govuk_frontend_toolkit 4.16.1 → 4.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f4ddc81957a656a0c17f892dfd132fc43ab5340
-  data.tar.gz: 3cea126b4db1d8bbf4738b4c0761a1caad2993d0
+  metadata.gz: 814dd64f724ed55761b47722aac9ba2a35904b99
+  data.tar.gz: c06eca3d6fee3ac3ef3bd036ddd2183e23854037
 SHA512:
-  metadata.gz: 1faf61dffef40648e7ff3950fc82c72cfc90809ae94cc21171620a42b628c0bb9f5f67580cd21e48c11e3d2927bb3da612921dbc67033f11ad47c71c895089c5
-  data.tar.gz: 130f686cd01660d1935c9356cba616803c6adba0011bb85c1a0fc2744de4671493ec7f27c2f7f57c618b0b2babb9eb08f532a3f10744073e76862e2ec515c7c7
+  metadata.gz: e858e46f18e4f819a793f64ef6b490153a906d4ce39903be37a740aa72cbecf9831bfee32819258d88c65ec9408687623d257bb4bd72bf30e9775428858da5be
+  data.tar.gz: d2f9dff826f282602071b32f40873fd642e8fb72513e862d61ae82863c05ffbbfbf650969233d35bcccf6cc4be9640a87f35a40b0c6977d1c5ca85428e96de41

data/app/assets/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 4.17.0
+
+- SelectionButtons will add a class to the label with the type of the child input ([PR #317](https://github.com/alphagov/govuk_frontend_toolkit/pull/317))
+
 # 4.16.1
 
 - Fix anchor-buttons.js to trigger a native click event, also rename to shimLinksWithButtonRole.js to explain what it does

data/app/assets/README.md

@@ -141,6 +141,7 @@ In production:
   * [Primary links](/docs/javascript.md#primary-links)
   * [Stick at top when scrolling](/docs/javascript.md#stick-at-top-when-scrolling)
   * [Selection buttons](/docs/javascript.md#selection-buttons)
+  * [Shim links with button role](/docs/javascript.md#shim-links-with-button-role)
 * [Analytics](/docs/analytics.md)
   * [Create an analytics tracker](/docs/analytics.md#create-an-analytics-tracker)
   * [Virtual pageviews](/docs/analytics.md#virtual-pageviews)

data/app/assets/VERSION.txt

@@ -1 +1 @@
-4.16.1
+4.17.0

data/app/assets/javascripts/govuk/selection-buttons.js

@@ -8,6 +8,8 @@
 
     this.selectedClass = 'selected';
     this.focusedClass = 'focused';
+    this.radioClass = 'selection-button-radio';
+    this.checkboxClass = 'selection-button-checkbox';
     if (opts !== undefined) {
       $.each(opts, function (optionName, optionObj) {
         this[optionName] = optionObj;
@@ -33,6 +35,8 @@
     $elms.each(function (idx, elm) {
       var $elm = $(elm);
 
+      var labelClass = $elm.attr('type') === 'radio' ? this.radioClass : this.checkboxClass;
+      $elm.parent('label').addClass(labelClass);
       if ($elm.is(':checked')) {
         this.markSelected($elm);
       }

data/app/assets/spec/unit/selection-button.spec.js

@@ -337,7 +337,14 @@ describe("selection-buttons", function () {
       });
 
       describe("At the point it is called", function () {
-        it("Should do nothing if no radios are checked", function () {
+        it("Should mark radios with the selection-button-radio class", function () {
+          buttonsInstance = new GOVUK.SelectionButtons("label.selectable input[type='radio']");
+          expect($radioLabels.eq(0).hasClass('selection-button-radio')).toBe(true);
+          expect($radioLabels.eq(1).hasClass('selection-button-radio')).toBe(true);
+          expect($radioLabels.eq(2).hasClass('selection-button-radio')).toBe(true);
+        });
+
+        it("Should not add a selected class if no radios are checked", function () {
           buttonsInstance = new GOVUK.SelectionButtons("label.selectable input[type='radio']");
           expect($radioLabels.eq(0).hasClass('selected')).toBe(false);
           expect($radioLabels.eq(1).hasClass('selected')).toBe(false);
@@ -411,7 +418,14 @@ describe("selection-buttons", function () {
       });
 
       describe("At the point it is called", function () {
-        it("Should do nothing if no checkboxes are checked", function () {
+        it("Should mark checkboxes with the selection-button-checkbox class", function () {
+          buttonsInstance = new GOVUK.SelectionButtons("label.selectable input[type='checkbox']");
+          expect($checkboxLabels.eq(0).hasClass('selection-button-checkbox')).toBe(true);
+          expect($checkboxLabels.eq(1).hasClass('selection-button-checkbox')).toBe(true);
+          expect($checkboxLabels.eq(2).hasClass('selection-button-checkbox')).toBe(true);
+        });
+
+        it("Should not add a selected class if no checkboxes are checked", function () {
           buttonsInstance = new GOVUK.SelectionButtons("label.selectable input[type='checkbox']");
           expect($checkboxLabels.eq(0).hasClass('selected')).toBe(false);
           expect($checkboxLabels.eq(1).hasClass('selected')).toBe(false);

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_frontend_toolkit
 version: !ruby/object:Gem::Version
-  version: 4.16.1
+  version: 4.17.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-19 00:00:00.000000000 Z
+date: 2016-09-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails