govuk_frontend_toolkit 3.3.0 → 3.3.1

Sign up to get free protection for your applications and to get access to all the features.
@@ -1,3 +1,7 @@
1
+ # 3.3.1
2
+
3
+ - Fix: Make the error colour a darker red for greater contrast and to meet WCAG 2.0 AAAA
4
+
1
5
  # 3.3.0
2
6
 
3
7
  - Add: Analytics - pageview tracking for a print attempt
@@ -1 +1 @@
1
- 3.3.0
1
+ 3.3.1
@@ -104,8 +104,24 @@
104
104
 
105
105
  // https://developers.google.com/analytics/devguides/collection/gajs/gaTrackingCustomVariables
106
106
  GoogleAnalyticsClassicTracker.prototype.setCustomVariable = function(index, value, name, scope) {
107
+ var PAGE_LEVEL_SCOPE = 3;
108
+ scope = scope || PAGE_LEVEL_SCOPE;
109
+
110
+ if (typeof index !== "number") {
111
+ index = parseInt(index, 10);
112
+ }
113
+
114
+ if (typeof scope !== "number") {
115
+ scope = parseInt(scope, 10);
116
+ }
117
+
107
118
  _gaq.push(['_setCustomVar', index, name, String(value), scope]);
108
119
  };
109
120
 
121
+ // Match tracker and universal API
122
+ GoogleAnalyticsClassicTracker.prototype.setDimension = function(index, value, name, scope) {
123
+ this.setCustomVariable(index, value, name, scope);
124
+ }
125
+
110
126
  GOVUK.GoogleAnalyticsClassicTracker = GoogleAnalyticsClassicTracker;
111
127
  })();
@@ -42,17 +42,6 @@
42
42
  Check this for your app before using this
43
43
  */
44
44
  Tracker.prototype.setDimension = function(index, value, name, scope) {
45
- var PAGE_LEVEL_SCOPE = 3;
46
- scope = scope || PAGE_LEVEL_SCOPE;
47
-
48
- if (typeof index !== "number") {
49
- index = parseInt(index, 10);
50
- }
51
-
52
- if (typeof scope !== "number") {
53
- scope = parseInt(scope, 10);
54
- }
55
-
56
45
  this.universal.setDimension(index, value);
57
46
  this.classic.setCustomVariable(index, value, name, scope);
58
47
  };
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: govuk_frontend_toolkit
3
3
  version: !ruby/object:Gem::Version
4
- version: 3.3.0
4
+ version: 3.3.1
5
5
  prerelease:
6
6
  platform: ruby
7
7
  authors:
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2015-03-16 00:00:00.000000000 Z
12
+ date: 2015-04-14 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: rails
@@ -288,7 +288,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
288
288
  version: '0'
289
289
  segments:
290
290
  - 0
291
- hash: 841556332065995635
291
+ hash: 3001671793728050183
292
292
  required_rubygems_version: !ruby/object:Gem::Requirement
293
293
  none: false
294
294
  requirements:
@@ -297,7 +297,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
297
297
  version: '0'
298
298
  segments:
299
299
  - 0
300
- hash: 841556332065995635
300
+ hash: 3001671793728050183
301
301
  requirements: []
302
302
  rubyforge_project:
303
303
  rubygems_version: 1.8.23