govuk_elements_rails 3.1.0 → 3.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c11c3760410ddee2a303ad32a80c8538ad6d354
-  data.tar.gz: 853ddbed025168693a3af55e7c97c59989e3aeab
+  metadata.gz: 1fe448dff48a121e14b22cae56969c1ddf6a9608
+  data.tar.gz: d0c986e531c847009d9c26e278c0b6b2c3820d5d
 SHA512:
-  metadata.gz: cb6f9bea9029e360e7fe77b6750f76c02d0d3ca8b2ba7bf1e94ef4c69ac15a8509499a1c7f8880ae737e3360fe3104cdb7c7c92087c561083602b09ab8d9e071
-  data.tar.gz: c8f62df813a18975d9f3a5805edb9769afccfe92eae7d67647472573b74474bce471a4bbfbb67cc92392bd0cab17f7a52cd578ddb87d5053f6cb565cdbab5e7e
+  metadata.gz: 8949b9bff5367d93db1385a3899e36218ba9cc7f56aa2e948d4acf6bb273018e29eb0ae58444c105ebc2c6aca760565e49ef543078d933eb514a6b93b49a8552
+  data.tar.gz: 23906c51650e39fa1ed82cd7f0f8dcda267460789f6360019093abde781a8e32e59eef2a0770ffc43d885b6172933f35ec293a617e75efa6ac361df383210479

data/README.md

@@ -183,7 +183,7 @@ To add a javascript file to gem, create new symlink to `govuk_elements` file, li
 ```sh
 cd vendor/assets/javascripts/
 ls -l
-ln -s ../../../govuk_elements/public/javascripts/vendor/details.polyfill.js .
+ln -s ../../../govuk_elements/assets/javascripts/govuk/details.polyfill.js .
 ls -l
 cd ../../..
 git add vendor/javascripts/details.polyfill.js
@@ -200,11 +200,6 @@ rake gem
 If you're happy all's ok, you can create a branch and commit:
 
 ```sh
-cd govuk_elements
-tag_sha=`git rev-parse HEAD`
-echo $tag_sha
-cd ..
-
 branch_name="update-$latest_tag"
 echo $branch_name
 git branch $branch_name
@@ -216,7 +211,7 @@ git add govuk_elements
 
 commit_msg="Upgrade to govuk_elements $latest_tag"
 commit_msg2="See govuk_elements $latest_tag changelog for details:"
-commit_msg3="https://github.com/alphagov/govuk_elements/blob/$tag_sha/CHANGELOG.md"
+commit_msg3="https://github.com/alphagov/govuk_elements/blob/$latest_tag/packages/govuk-elements-sass/CHANGELOG.md"
 
 echo $commit_msg
 echo $commit_msg2

data/vendor/assets/stylesheets/elements/_elements-typography.scss

@@ -201,10 +201,12 @@ p,
   &:link,
   &:visited,
   &:hover,
+  a#{&}:focus,
   &:active {
     color: $black;
   }
 
+
   text-decoration: none;
   border-bottom: 1px solid $black;
 
@@ -234,7 +236,6 @@ p,
   }
 
 }
-
 // Code styles
 .code {
   color: $text-colour;

data/vendor/assets/stylesheets/elements/_layout.scss

@@ -14,8 +14,10 @@
   @include media(desktop) {
     padding-bottom: $gutter * 3;
   }
-  // Pressing enter when focus is on the skiplink sets focus on the #content area
-  // Remove the blue outline
+
+  // DEPRECATED: Tabindex on #content
+  // https://github.com/alphagov/govuk_elements/pull/534
+  // We no longer recommend using tabindex on #content
   outline: none;
 }
 

data/vendor/assets/stylesheets/elements/_tables.scss

@@ -15,7 +15,7 @@ table {
     border-bottom: 1px solid $border-colour;
   }
 
-  th {
+  thead th {
     font-weight: 700;
   }
 

data/vendor/assets/stylesheets/elements/forms/_form-multiple-choice.scss

@@ -88,6 +88,7 @@
     border: solid;
     border-width: 0 0 5px 5px;
     background: transparent;
+    border-top-color: transparent;
     width: 17px;
     height: 7px;
     position: absolute;
@@ -116,8 +117,13 @@
   }
 
   // Disabled state
+  input:disabled {
+    cursor: default;
+  }
+
   input:disabled + label {
     @include opacity(0.5);
+    cursor: default;
   }
 
   &:last-child,

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_elements_rails
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.2
 platform: ruby
 authors:
-- Rob McKinnon
-- Government Digital Service
+- GOV.UK Design System Team (Government Digital Service)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-13 00:00:00.000000000 Z
+date: 2017-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -54,10 +53,10 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 6.0.2
 description: |-
-  A gem wrapper around govuk_elements v3.1.0
-   that pulls stylesheet and javascript files into a Rails app. Changelog: https://github.com/alphagov/govuk_elements/blob/7a860c7274fd83484ba42eefe1575e72aefaf55d
+  A gem wrapper around govuk_elements v3.1.2
+   that pulls stylesheet and javascript files into a Rails app. Changelog: https://github.com/alphagov/govuk_elements/blob/85644af5e31e9a28be3c8325978c258334a47764
   /CHANGELOG.md
-email: robin.whittleton@digital.cabinet-office.gov.uk
+email: design-system-developers@digital.cabinet-office.gov.uk
 executables: []
 extensions: []
 extra_rdoc_files:
@@ -67,7 +66,6 @@ files:
 - README.md
 - lib/govuk_elements_rails.rb
 - lib/govuk_elements_rails/engine.rb
-- vendor/assets/javascripts/details.polyfill.js
 - vendor/assets/stylesheets/_govuk-elements.scss
 - vendor/assets/stylesheets/elements/_breadcrumbs.scss
 - vendor/assets/stylesheets/elements/_buttons.scss
@@ -110,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.10
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: A gem wrapper around http://github.com/alphagov/govuk_elements that pulls

data/vendor/assets/javascripts/details.polyfill.js

@@ -1,217 +0,0 @@
-// <details> polyfill
-// http://caniuse.com/#feat=details
-
-// FF Support for HTML5's <details> and <summary>
-// https://bugzilla.mozilla.org/show_bug.cgi?id=591737
-
-// http://www.sitepoint.com/fixing-the-details-element/
-
-;(function () {
-  'use strict'
-
-  var NATIVE_DETAILS = typeof document.createElement('details').open === 'boolean'
-  var KEY_ENTER = 13
-  var KEY_SPACE = 32
-
-  // Add event construct for modern browsers or IE
-  // which fires the callback with a pre-converted target reference
-  function addEvent (node, type, callback) {
-    if (node.addEventListener) {
-      node.addEventListener(type, function (e) {
-        callback(e, e.target)
-      }, false)
-    } else if (node.attachEvent) {
-      node.attachEvent('on' + type, function (e) {
-        callback(e, e.srcElement)
-      })
-    }
-  }
-
-  // Cross-browser character code / key pressed
-  function charCode (e) {
-    return (typeof e.which === 'number') ? e.which : e.keyCode
-  }
-
-  // Cross-browser preventing default action
-  function preventDefault (e) {
-    if (e.preventDefault) {
-      e.preventDefault()
-    } else {
-      e.returnValue = false
-    }
-  }
-
-  // Handle cross-modal click events
-  function addClickEvent (node, callback) {
-    addEvent(node, 'keypress', function (e, target) {
-      // When the key gets pressed - check if it is enter or space
-      if (charCode(e) === KEY_ENTER || charCode(e) === KEY_SPACE) {
-        if (target.nodeName.toLowerCase() === 'summary') {
-          // Prevent space from scrolling the page
-          // and enter from submitting a form
-          preventDefault(e)
-          // Click to let the click event do all the necessary action
-          if (target.click) {
-            target.click()
-          } else {
-            // except Safari 5.1 and under don't support .click() here
-            callback(e, target)
-          }
-        }
-      }
-    })
-
-    // Prevent keyup to prevent clicking twice in Firefox when using space key
-    addEvent(node, 'keyup', function (e, target) {
-      if (charCode(e) === KEY_SPACE) {
-        if (target.nodeName === 'SUMMARY') {
-          preventDefault(e)
-        }
-      }
-    })
-
-    addEvent(node, 'click', function (e, target) {
-      callback(e, target)
-    })
-  }
-
-  // Get the nearest ancestor element of a node that matches a given tag name
-  function getAncestor (node, match) {
-    do {
-      if (!node || node.nodeName.toLowerCase() === match) {
-        break
-      }
-      node = node.parentNode
-    } while (node)
-
-    return node
-  }
-
-  // Create a started flag so we can prevent the initialisation
-  // function firing from both DOMContentLoaded and window.onload
-  var started = false
-
-  // Initialisation function
-  function addDetailsPolyfill (list) {
-    // If this has already happened, just return
-    // else set the flag so it doesn't happen again
-    if (started) {
-      return
-    }
-    started = true
-
-    // Get the collection of details elements, but if that's empty
-    // then we don't need to bother with the rest of the scripting
-    if ((list = document.getElementsByTagName('details')).length === 0) {
-      return
-    }
-
-    // else iterate through them to apply their initial state
-    var n = list.length
-    var i = 0
-    for (i; i < n; i++) {
-      var details = list[i]
-
-      // Save shortcuts to the inner summary and content elements
-      details.__summary = details.getElementsByTagName('summary').item(0)
-      details.__content = details.getElementsByTagName('div').item(0)
-
-      // If the content doesn't have an ID, assign it one now
-      // which we'll need for the summary's aria-controls assignment
-      if (!details.__content.id) {
-        details.__content.id = 'details-content-' + i
-      }
-
-      // Add ARIA role="group" to details
-      details.setAttribute('role', 'group')
-
-      // Add role=button to summary
-      details.__summary.setAttribute('role', 'button')
-
-      // Add aria-controls
-      details.__summary.setAttribute('aria-controls', details.__content.id)
-
-      // Set tabIndex so the summary is keyboard accessible for non-native elements
-      // http://www.saliences.com/browserBugs/tabIndex.html
-      if (!NATIVE_DETAILS) {
-        details.__summary.tabIndex = 0
-      }
-
-      // Detect initial open state
-      var openAttr = details.getAttribute('open') !== null
-      if (openAttr === true) {
-        details.__summary.setAttribute('aria-expanded', 'true')
-        details.__content.setAttribute('aria-hidden', 'false')
-      } else {
-        details.__summary.setAttribute('aria-expanded', 'false')
-        details.__content.setAttribute('aria-hidden', 'true')
-        if (!NATIVE_DETAILS) {
-          details.__content.style.display = 'none'
-        }
-      }
-
-      // Create a circular reference from the summary back to its
-      // parent details element, for convenience in the click handler
-      details.__summary.__details = details
-
-      // If this is not a native implementation, create an arrow
-      // inside the summary
-      if (!NATIVE_DETAILS) {
-        var twisty = document.createElement('i')
-
-        if (openAttr === true) {
-          twisty.className = 'arrow arrow-open'
-          twisty.appendChild(document.createTextNode('\u25bc'))
-        } else {
-          twisty.className = 'arrow arrow-closed'
-          twisty.appendChild(document.createTextNode('\u25ba'))
-        }
-
-        details.__summary.__twisty = details.__summary.insertBefore(twisty, details.__summary.firstChild)
-        details.__summary.__twisty.setAttribute('aria-hidden', 'true')
-      }
-    }
-
-    // Define a statechange function that updates aria-expanded and style.display
-    // Also update the arrow position
-    function statechange (summary) {
-      var expanded = summary.__details.__summary.getAttribute('aria-expanded') === 'true'
-      var hidden = summary.__details.__content.getAttribute('aria-hidden') === 'true'
-
-      summary.__details.__summary.setAttribute('aria-expanded', (expanded ? 'false' : 'true'))
-      summary.__details.__content.setAttribute('aria-hidden', (hidden ? 'false' : 'true'))
-
-      if (!NATIVE_DETAILS) {
-        summary.__details.__content.style.display = (expanded ? 'none' : '')
-
-        var hasOpenAttr = summary.__details.getAttribute('open') !== null
-        if (!hasOpenAttr) {
-          summary.__details.setAttribute('open', 'open')
-        } else {
-          summary.__details.removeAttribute('open')
-        }
-      }
-
-      if (summary.__twisty) {
-        summary.__twisty.firstChild.nodeValue = (expanded ? '\u25ba' : '\u25bc')
-        summary.__twisty.setAttribute('class', (expanded ? 'arrow arrow-closed' : 'arrow arrow-open'))
-      }
-
-      return true
-    }
-
-    // Bind a click event to handle summary elements
-    addClickEvent(document, function (e, summary) {
-      if (!(summary = getAncestor(summary, 'summary'))) {
-        return true
-      }
-      return statechange(summary)
-    })
-  }
-
-  // Bind two load events for modern and older browsers
-  // If the first one fires it will set a flag to block the second one
-  // but if it's not supported then the second one will fire
-  addEvent(document, 'DOMContentLoaded', addDetailsPolyfill)
-  addEvent(window, 'load', addDetailsPolyfill)
-})()