govuk_content_models 29.1.0 → 29.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a121fff0d81773c3acfd3666904c3b81770213fa
-  data.tar.gz: 10b3f0778399eb518163df1cffd4b70e84572b61
+  metadata.gz: 50dc520a74843e9a3ccd9b5a0427b966711f30b5
+  data.tar.gz: 8ba0639769f9c134d133ff996e9d2d41d4d0ed77
 SHA512:
-  metadata.gz: c54a371b42da309fce13c72b3be6085b5e90005aa93d92b8c7d33d3d176cbc1fae047d4556a0b06bad938efe4fb6dfca5ce5b090e8489350b9a538de00efedb8
-  data.tar.gz: ac2f04839f067d3801fb17691df3293d9c1a2ddf6a3c0296571e2c30fe97b23b7a678bd9183eeb69c317549edda3f0355d1e82f2097d1a66fbd5b2beabf7d7f1
+  metadata.gz: 1360728473419a672030754f02164c27f17fb790ef0acf0a1abcac89bb659680e778c6c32ecd894d5e219c65a774fe33e322d499dafd337b39e5b08b96d51ca5
+  data.tar.gz: 7651c6ef9eef44d07dabe3ebe997179f1aa20b89d6e26b5d785a89d66e0343c1c22b8f2d699f4d57fd62740fad031cdd60c5f9f2aa7d4dccdb5184ada39f3c7c

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 # CHANGELOG
 
+## 29.1.1
+
+- Bugfix: update question options slugs when their labels are updated
+
 ## 29.1.0
+
 - Allow detailed guide slugs to start with /guidance
 
 ## 29.0.1

data/app/models/simple_smart_answer_edition/node/option.rb

@@ -17,13 +17,13 @@ class SimpleSmartAnswerEdition < Edition
       validates :label, :next_node, presence: true
       validates :slug, :format => {:with => /\A[a-z0-9-]+\z/}
 
-      before_validation :populate_slug_if_blank
+      before_validation :populate_slug
 
       private
 
-      def populate_slug_if_blank
-        if self.slug.blank? and self.label.present?
-          self.slug = ActiveSupport::Inflector.parameterize(self.label)
+      def populate_slug
+        if label.present? && !slug_changed?
+          self.slug = ActiveSupport::Inflector.parameterize(label)
         end
       end
     end

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "29.1.0"
+  VERSION = "29.1.1"
 end

data/test/models/simple_smart_answer_option_test.rb

@@ -66,6 +66,13 @@ class SimpleSmartAnswerOptionTest < ActiveSupport::TestCase
         assert_equal "yes", @option.slug
       end
 
+      should "keep the slug up to date if the label changes" do
+        @option = @node.options.create(@atts.merge(slug: "most-likely"))
+        @option.label = "Most of the times"
+        assert @option.valid?
+        assert_equal "most-of-the-times", @option.slug
+      end
+
       should "not overwrite a given slug" do
         @option = @node.options.build(@atts.merge(:slug => "fooey"))
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 29.1.0
+  version: 29.1.1
 platform: ruby
 authors:
 - Paul Battley