govuk_content_models 10.2.1 → 10.2.2

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 10.2.2
+
+-  Prevent a Mongo error when tag_ids are set to nil 
+
 ## 10.2.0
 
 * Adding a nil check around `need_ids` field in validations and using the correct gem version number to reflect the new feature that got added in 10.1.1.

data/app/traits/taggable.rb

@@ -59,8 +59,12 @@ module Taggable
     # as documented on http://mongoid.org/en/mongoid/docs/documents.html
     tags
 
+    # Make sure that 'values' is an array. This stops the method blowing up
+    # if nil is provided.
+    values_as_array = Array(values)
+
     # This will raise a Tag::MissingTags exception unless all the tags exist
-    new_tags = Tag.by_tag_ids!(values, tag_type)
+    new_tags = Tag.by_tag_ids!(values_as_array, tag_type)
 
     @tags.reject! { |t| t.tag_type == tag_type }
     @tags += new_tags

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "10.2.1"
+  VERSION = "10.2.2"
 end

data/test/traits/taggable_test.rb

@@ -111,4 +111,16 @@ class TaggableTest < ActiveSupport::TestCase
 
     assert_equal ['bacon'], @item.keyword_ids
   end
+
+  test "can set tags of type to be nil" do
+    @item.section_ids = nil
+    @item.save!
+
+    assert_equal [], @item.section_ids
+
+    @item.sections = nil
+    @item.save!
+
+    assert_equal [], @item.section_ids
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 10.2.1
+  version: 10.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-15 00:00:00.000000000 Z
+date: 2014-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bson_ext
@@ -465,7 +465,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2178874985606860121
+      hash: -333607112453720263
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -474,7 +474,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 2178874985606860121
+      hash: -333607112453720263
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23