govuk_content_models 10.1.2 → 10.2.0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 10.2.0
+
+* Adding a nil check around `need_ids` field in validations and using the correct gem version number to reflect the new feature that got added in 10.1.1.
+
 ## 10.1.2
 
 * Use `\A\z` anchors instead of `^$` in need ID validation regex

data/app/models/artefact.rb

@@ -377,10 +377,13 @@ class Artefact
   end
 
   def filter_out_empty_need_ids
+    return if need_ids.blank?
     need_ids.reject!(&:blank?)
   end
 
   def format_of_new_need_ids
+    return if need_ids.blank?
+
     # http://api.rubyonrails.org/classes/ActiveModel/Dirty.html
     new_need_ids = need_ids_was.blank? ? need_ids : need_ids - need_ids_was
     errors.add(:need_ids, "must be six-digit integers") if new_need_ids.any? {|need_id| need_id !~ /\A\d{6}\z/ }

data/lib/govuk_content_models/version.rb

@@ -1,4 +1,4 @@
 module GovukContentModels
   # Changing this causes Jenkins to tag and release the gem into the wild
-  VERSION = "10.1.2"
+  VERSION = "10.2.0"
 end

data/test/models/artefact_test.rb

@@ -97,6 +97,13 @@ class ArtefactTest < ActiveSupport::TestCase
       assert_empty FactoryGirl.build(:artefact).need_ids
     end
 
+    should "do validations if nil" do
+      artefact = FactoryGirl.create(:artefact, need_ids: ["100001"])
+      artefact.need_ids = nil
+
+      assert_nothing_raised { artefact.valid? }
+    end
+
     should "filter out empty strings" do
       artefact = FactoryGirl.create(:artefact, need_ids: ["", "100002"])
       assert_equal ["100002"], artefact.reload.need_ids

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_content_models
 version: !ruby/object:Gem::Version
-  version: 10.1.2
+  version: 10.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2014-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bson_ext
@@ -465,7 +465,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2514232089714122932
+      hash: 1908367784692454141
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -474,7 +474,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2514232089714122932
+      hash: 1908367784692454141
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23