govuk_app_config 1.3.2 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 629e8bd24b9422af13b87da654890af10134751f9d8b74e5afdf4eada6a70978
-  data.tar.gz: ea026c299d154655ccec7e6e1d2925e044e2457fc2c55e21d511635a442cee70
+  metadata.gz: c76ebb58fe371660b4d6c10d3e001dc3e823ee9506fd4826823502ceb43e2fc7
+  data.tar.gz: 6cd6793d9c8e59f28922fba0f0c95b01597d542187548ef1f1d4a66c329ab6f9
 SHA512:
-  metadata.gz: 19f52425763d71a8dc15f0429f67333e3ceda68092535371c5530efeb1dbc5ed73a829e916af6e2f8200543b73bb9f1c4c5ea39e1c4b24f46d920c3906752ab0
-  data.tar.gz: d3b1cf2e316962ee61ce2eefae6652bae6726d8378dd58d90bc03eccf146ca10bc7e417fe8e9de7fb4cf884e2419ea79e7d8601e61ed4b1906a481a318f6cc83
+  metadata.gz: aa53f7780b90d526f16c29f07b82b251d41fa2fd0e2ce39bd2cc90800b4a007dc19976658a0eeb230cac7585bf49393e2f51636a1a868e321d8faa62932e196c
+  data.tar.gz: 39ae20eede2e1e8ca4d598dfe84d94822ca1487758f1e012fb2f77a5c416804ca036f33ee045358f6f7e0c9def5ce9b2defc479c0c70d0b0c46d23b41b96517d

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.4.0
+
+* Don't log intermittent errors from `gds-api-adapters` in Sentry, count them
+  in Graphite instead
+
 # 1.3.2
 
 * Update instructions to suggest that GovukUnicorn should be required directly

data/Jenkinsfile

@@ -1,6 +1,7 @@
 #!/usr/bin/env groovy
 
+library("govuk")
+
 node {
-  def govuk = load '/var/lib/jenkins/groovy_scripts/govuk_jenkinslib.groovy'
   govuk.buildProject()
 }

data/lib/govuk_app_config/configure.rb

@@ -5,14 +5,18 @@ end
 GovukError.configure do |config|
   # We're misusing the `should_capture` block here to hook into raven until
   # there's a better way: https://github.com/getsentry/raven-ruby/pull/750
-  config.should_capture = Proc.new {
+  config.should_capture = Proc.new { |e|
     GovukStatsd.increment("errors_occurred")
 
     # For backwards compatibility
     GovukStatsd.increment("errbit.errors_occurred")
 
-    # Return true so that we don't accidentally skip the error
-    true
+    if e.class.ancestors.any? { |c| c.name =~ /^GdsApi::(HTTPIntermittent|TimedOutException)/ }
+      GovukStatsd.increment("gds_api_adapters.errors.#{e.class.name.demodulize.underscore}")
+      false
+    else
+      true
+    end
   }
 
   config.excluded_exceptions = [

data/lib/govuk_app_config/version.rb

@@ -1,3 +1,3 @@
 module GovukAppConfig
-  VERSION = "1.3.2"
+  VERSION = "1.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_app_config
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.4.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-28 00:00:00.000000000 Z
+date: 2018-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: statsd-ruby