govuk_admin_template 1.1.7 → 1.2.0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.2.0
+
+* Remove selectable table javascript module
+
 # 1.1.7
 
 * Fix display of `lead` styles when using `text-muted` class

data/JAVASCRIPT.md

@@ -102,5 +102,4 @@ auto_show_modal.js | `AutoShowModal` | `auto-show-modal` | Initialise a Bootstra
 auto_track_event.js | `AutoTrackEvent` | `auto-track-event` | Use data attributes to track events in Google Analytics on page load
 filterable_table.js | `FilterableTable` | `filterable-table` | Filter the contents of a table, showing only matching rows
 fixed_table_header.js | `FixedTableHeader` | `fixed-table-header` | Fix the `<thead>` portion of a table when scrolling offscreen
-selectable_table.js | `SelectableTable` | `selectable-table` | Select rows in a table and perform an action on them
 toggle.js | `Toggle` | `toggle` | A simple toggle

data/app/assets/stylesheets/govuk_admin_template/_tables.css.scss

@@ -26,53 +26,3 @@ thead .table-header-secondary td {
     box-shadow: 0 3px 10px -5px rgba(0, 0, 0, 0.3);
   }
 }
-
-/* Selectable rows
-   ==========================================================================
-   Fill table cell with label to make the whole cell clickable.
-   This is achieved with a bit of a hack, the label is set to a height always
-   guaranteed to be larger than the cell height, and the cell has its overflow
-   hidden.
-*/
-
-.selectable-row {
-  padding: 0 !important;
-  overflow: hidden;
-  width: 40px;
-
-  tbody & {
-    background-color: #ccc;
-  }
-
-  label {
-    height: 300px;
-    width: 100%;
-    margin-bottom: 0;
-    position: absolute;
-    text-align: center;
-  }
-
-  input {
-    margin-top: 12px;
-    cursor: pointer;
-  }
-}
-
-.selectable-row-helper {
-  border-bottom: 1px dotted #999;
-  cursor: help;
-}
-
-/* Slightly different spacing for table headers */
-.table-header-secondary .selectable-row {
-  vertical-align: top;
-
-  input {
-    margin-top: 18px;
-  }
-}
-
-.selected-row td,
-.table-hover .selected-row:hover td {
-  background-color: #fffbcc; /* yellow highlight */
-}

data/app/views/govuk_admin_template/style_guide/index.html.erb

@@ -185,8 +185,6 @@
 <div class="row">
   <div class="col-md-6 lead">
     <p>When using a table with two layers of headings, usually for interacting with table content, <code>table-header</code> and <code>table-header-secondary</code> classes are used.</p>
-
-    <p>The second example shows a table with selectable rows. Selected rows highlight in yellow. The checkbox in the header selects all rows.</p>
   </div>
   <div class="col-md-6">
     <table class="table table-bordered table-hover">
@@ -207,47 +205,6 @@
         </tr>
       </tbody>
     </table>
-
-    <table class="table table-bordered" data-module="selectable-table">
-      <thead>
-        <tr class="table-header">
-          <th></th>
-          <th>Primary header</th>
-        </tr>
-        <tr class="table-header-secondary">
-          <th class="selectable-row">
-            <div class="relative">
-              <label>
-                <input type="checkbox" class="js-toggle-all" />
-              </label>
-            </div>
-          </th>
-          <th><a href="<%= @normal_link_href %>" class="btn btn-default">Action</a></th>
-        </tr>
-      </thead>
-    <tbody>
-      <tr class="selected-row">
-        <td class="selectable-row">
-          <div class="relative">
-            <label>
-              <input type="checkbox" checked="checked" class="js-toggle-row" />
-            </label>
-          </div>
-        </td>
-        <td>Selected row</td>
-      </tr>
-      <tr>
-        <td class="selectable-row">
-          <div class="relative">
-            <label>
-              <input type="checkbox" class="js-toggle-row" />
-            </label>
-          </div>
-        </td>
-        <td>Typical row</td>
-      </tr>
-    </tbody>
-    </table>
   </div>
 </div>
 <div class="row">

data/lib/govuk_admin_template/version.rb

@@ -1,3 +1,3 @@
 module GovukAdminTemplate
-  VERSION = "1.1.7"
+  VERSION = "1.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_admin_template
 version: !ruby/object:Gem::Version
-  version: 1.1.7
+  version: 1.2.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-06 00:00:00.000000000 Z
+date: 2014-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -170,7 +170,6 @@ files:
 - app/assets/javascripts/govuk-admin-template/vendor/html5.js
 - app/assets/javascripts/govuk-admin-template/vendor/respond.min.js
 - app/assets/javascripts/govuk-admin-template/govuk-admin.js
-- app/assets/javascripts/govuk-admin-template/modules/selectable_table.js
 - app/assets/javascripts/govuk-admin-template/modules/filterable_table.js
 - app/assets/javascripts/govuk-admin-template/modules/fixed_table_header.js
 - app/assets/javascripts/govuk-admin-template/modules/auto_track_event.js
@@ -209,7 +208,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 3294391031137274422
+      hash: -4369990551354532832
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23.2

data/app/assets/javascripts/govuk-admin-template/modules/selectable_table.js

@@ -1,154 +0,0 @@
-(function(Modules) {
-  "use strict";
-
-  Modules.SelectableTable = function() {
-
-    var that = this;
-
-    that.start = function(element) {
-
-      var tableRows = element.find('tbody tr'),
-          SELECTED_ROW_CLASS = 'selected-row',
-          RECENTLY_CHANGED_CLASS = 'js-most-recently-changed';
-
-      element.on('click', '.js-toggle-row',  toggleRow);
-      element.on('click', '.js-toggle-all',  toggleAllRows);
-      element.on('click', '.js-submit-form', submitForm);
-
-      element.on('ajax:success', 'form', createModal);
-      element.on('ajax:error',   'form', handleModalError);
-      element.on('ajax:complete','form', resetSubmitButtons);
-
-      onLoadMarkSelectedRowsWithClass();
-      updateHeaderToggleState();
-
-      function onLoadMarkSelectedRowsWithClass() {
-
-        var selectedRows = tableRows.find('.js-toggle-row:checked').parents('tr');
-        selectedRows.addClass(SELECTED_ROW_CLASS);
-
-      }
-
-      function toggleRow(event) {
-
-        var row = $(event.target).parents('tr');
-
-        event.shiftKey ? shiftToggleRow(row) : row.toggleClass(SELECTED_ROW_CLASS);
-
-        markRowAsRecentlyChanged(row);
-        updateHeaderToggleState();
-      }
-
-      function updateHeaderToggleState() {
-
-        var selectedRowsCount = tableRows.filter('.' + SELECTED_ROW_CLASS).length,
-            inputHeader = element.find('.js-toggle-all');
-
-        if (selectedRowsCount > 0 && selectedRowsCount < tableRows.length) {
-          inputHeader.prop('indeterminate', true);
-          inputHeader.prop('checked', false);
-          resetSubmitButtons();
-        } else if (selectedRowsCount === 0) {
-          inputHeader.prop('checked', false);
-          inputHeader.prop('indeterminate', false);
-          disableSubmitButtons();
-        } else {
-          inputHeader.prop('checked', true);
-          inputHeader.prop('indeterminate', false);
-          resetSubmitButtons();
-        }
-
-      }
-
-      function markRowAsRecentlyChanged(row) {
-        tableRows.removeClass(RECENTLY_CHANGED_CLASS);
-        row.addClass(RECENTLY_CHANGED_CLASS);
-      }
-
-      function shiftToggleRow(targetRow) {
-
-        var targetIndex = tableRows.index(targetRow),
-            targetState = targetRow.is('.' + SELECTED_ROW_CLASS),
-            mostRecentlyChanged = tableRows.filter('.' + RECENTLY_CHANGED_CLASS),
-            mostRecentlyChangedIndex = tableRows.index(mostRecentlyChanged),
-            rows, range;
-
-        // If we don't have a most recently changed, only toggle the current row
-        if (mostRecentlyChangedIndex < 0) {
-          mostRecentlyChangedIndex = targetIndex;
-        }
-
-        range = mostRecentlyChangedIndex < targetIndex ? [mostRecentlyChangedIndex, targetIndex + 1] : [targetIndex, mostRecentlyChangedIndex + 1];
-        rows = tableRows.slice.apply(tableRows, range);
-        toggleRows(rows, ! targetState);
-
-      }
-
-      function toggleAllRows(event) {
-
-        var rows = element.find('tbody tr');
-
-        // If everything selected
-        if (tableRows.length == element.find('.' + SELECTED_ROW_CLASS).length) {
-          toggleRows(rows, false);
-        } else {
-          toggleRows(rows, true);
-        }
-
-        updateHeaderToggleState();
-      }
-
-      function toggleRows(rows, select) {
-        if (select) {
-          rows.addClass(SELECTED_ROW_CLASS)
-        } else {
-          rows.removeClass(SELECTED_ROW_CLASS)
-        }
-        rows.find('input').prop('checked', select);
-      }
-
-      function submitForm(event) {
-        var target = $(event.target),
-            type = target.data('type');
-
-        if (target.is('.disabled')) {
-          event.preventDefault();
-          return;
-        }
-
-        disableSubmitButtons();
-        target.button('loading');
-
-        element.find('input[type="radio"][value="' + type + '"]').prop('checked', true);
-        element.find('form').submit();
-        event.preventDefault();
-      }
-
-      function createModal(event, html, status) {
-        var modal = $(html);
-
-        $('body').append(modal);
-
-        modal.modal('show').on('hidden.bs.modal', function () {
-          modal.remove();
-        });
-
-        GOVUKAdmin.start(modal);
-      }
-
-      function handleModalError(xhr, status, error) {
-        alert('There was a problem loading this. Please try again.');
-      }
-
-      function resetSubmitButtons() {
-        element.find('.js-submit-form').removeClass('disabled').button('reset');
-        element.find('.js-submit-container').addClass('buttons-enabled');
-      }
-
-      function disableSubmitButtons() {
-        element.find('.js-submit-form').addClass('disabled');
-        element.find('.js-submit-container').removeClass('buttons-enabled');
-      }
-    }
-  };
-})(window.GOVUKAdmin.Modules);