govspeak 6.5.1 → 6.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d1153c71bd7cd224750aa162c1ea63c89a902309cd08238a888d07a60f079d89
-  data.tar.gz: a7efca4529a1c6017224a77965e45994d30eba3a3e05f6d209dadff85a516cd9
+  metadata.gz: eaa4aea2a5ad557426d34d0d17ef75ae5d538862cc293ad6d6403a663797667f
+  data.tar.gz: 3950f3fdd4bc77f5b00ceb5bede0ffca988f2c910739ee0906fa49431be95ae0
 SHA512:
-  metadata.gz: 33209bc51e340ccc5a2a0dc3b43f887eddbd464b687232fb4a17c6c34ae0a3097321f7f51da3ba17762e6ad1307424204872c3374dfa99eeb0100992641f4911
-  data.tar.gz: ab00d13be257f7730b4b7c2a858a9a9eba3802148dfc851f60fdf91eb65acdb80510a5c67a1e599f2cedbf945502cf29d6567526d695872118025ebb384318f9
+  metadata.gz: 90a7401f005a80646a8390723c04b4e2754d39b42559189d70aab1c1214223b62e805f6cb640b4c1acc3dd37401fe059849884af56f533295fa4b24af760f7f8
+  data.tar.gz: 18f85c38c237de6fc51b62b15c69b7bf236e0957c218e8ee246ba7fd572102231b129f6728461b5b9e57f2884107a0c419327e8ce522e8c70fe38fd3c4b1f066

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 6.5.2
+
+* Allow `data` attributes on `div` tags (PR#173)
+
 ## 6.5.1
 * Change unicode testing characters after external gem change
 * Move from govuk-lint to rubocop-govuk

data/lib/govspeak/html_sanitizer.rb

@@ -55,6 +55,7 @@ class Govspeak::HtmlSanitizer
       attributes: {
         :all => Sanitize::Config::RELAXED[:attributes][:all] + %w[role aria-label],
         "a"  => Sanitize::Config::RELAXED[:attributes]["a"] + [:data],
+        "div" => [:data],
         "th"  => Sanitize::Config::RELAXED[:attributes]["th"] + %w[style],
         "td"  => Sanitize::Config::RELAXED[:attributes]["td"] + %w[style],
         "govspeak-embed-attachment" => %w[content-id],

data/lib/govspeak/version.rb

@@ -1,3 +1,3 @@
 module Govspeak
-  VERSION = "6.5.1".freeze
+  VERSION = "6.5.2".freeze
 end

data/lib/kramdown/parser/govuk.rb

@@ -35,11 +35,11 @@ module Kramdown
             unless host.nil? || @document_domains.compact.include?(host)
               element.attr["rel"] = "external"
             end
-          # rubocop:disable Lint/HandleExceptions
+          # rubocop:disable Lint/SuppressedException
           rescue Addressable::URI::InvalidURIError
             # it's safe to ignore these very *specific* exceptions
           end
-          # rubocop:enable Lint/HandleExceptions
+          # rubocop:enable Lint/SuppressedException
         end
         super
       end

data/test/html_sanitizer_test.rb

@@ -44,6 +44,15 @@ class HtmlSanitizerTest < Minitest::Test
     )
   end
 
+  test "allow data attributes on divs" do
+    html = "<div data-module='toggle' data-ecommerce-path='/' data-track-category='someDiv'>Test Div</div>"
+
+    assert_equal(
+      "<div data-module=\"toggle\" data-ecommerce-path=\"/\" data-track-category=\"someDiv\">Test Div</div>",
+      Govspeak::HtmlSanitizer.new(html).sanitize,
+    )
+  end
+
   test "allows images on whitelisted domains" do
     html = "<img src='http://allowed.com/image.jgp'>"
     sanitized_html = Govspeak::HtmlSanitizer.new(html, allowed_image_hosts: ["allowed.com"]).sanitize

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govspeak
 version: !ruby/object:Gem::Version
-  version: 6.5.1
+  version: 6.5.2
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-19 00:00:00.000000000 Z
+date: 2019-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -210,14 +210,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -365,23 +365,23 @@ signing_key:
 specification_version: 4
 summary: Markup language for single domain
 test_files:
-- test/govspeak_attachments_inline_test.rb
-- test/govspeak_attachment_test.rb
-- test/govspeak_attachment_link_test.rb
-- test/govspeak_images_test.rb
+- test/govspeak_link_extractor_test.rb
+- test/govspeak_structured_headers_test.rb
+- test/govspeak_images_bang_test.rb
+- test/govspeak_button_test.rb
 - test/govspeak_table_with_headers_test.rb
+- test/govspeak_extract_contact_content_ids_test.rb
+- test/blockquote_extra_quote_remover_test.rb
+- test/govspeak_test_helper.rb
 - test/govspeak_link_test.rb
-- test/govspeak_images_bang_test.rb
-- test/govspeak_link_extractor_test.rb
+- test/govspeak_images_test.rb
+- test/govspeak_attachment_link_test.rb
 - test/govspeak_contacts_test.rb
 - test/test_helper.rb
+- test/html_validator_test.rb
+- test/html_sanitizer_test.rb
+- test/govspeak_attachments_inline_test.rb
 - test/govspeak_test.rb
+- test/govspeak_attachment_test.rb
 - test/govspeak_attachments_image_test.rb
-- test/html_validator_test.rb
-- test/govspeak_structured_headers_test.rb
-- test/govspeak_extract_contact_content_ids_test.rb
-- test/blockquote_extra_quote_remover_test.rb
 - test/presenters/h_card_presenter_test.rb
-- test/govspeak_button_test.rb
-- test/govspeak_test_helper.rb
-- test/html_sanitizer_test.rb