govspeak 6.4.0 → 6.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fbff4078955867159e914ac1dd26310ab9295a0618a58529b42b64c7e55399fd
-  data.tar.gz: ce83e999fab5cec2919c21b4561cf06a26c42056dde7c1740b04ca7b1df9d1df
+  metadata.gz: 691092344fa56f8643bda4f29f8f0a18344515254b042fb15771375489395015
+  data.tar.gz: 529021924ad18fccfabda572204e59b33867578e548816ab093e2d51b30e059f
 SHA512:
-  metadata.gz: 1972d6f7430d74f570dd23e9e529e581460fb02b535c834abada9c1c14b4d59914ddfeedec8c6209e6992a303c44211c0759fd9592ab5e9be42b776824d5efcb
-  data.tar.gz: 139c744c3c51456f6ceac2b75f1cba186cdca54cf518b06b36768bd675560e00f9c95306228b076adadd6f08c6c2ad505447df42e5cce52095fc874bc4eeff21
+  metadata.gz: a870b551730a2a07f5a85bdb06df18b56018f3a700d21469d8c1804fe51d044ae7beb5455a8d1e332f44e003ed2d6231eb9f36fd72b0578de19cc408973074f0
+  data.tar.gz: d0b4ca4cf824216c139094d33fdd1a9ddf98800db9aa94b077b454cfce35e98713b1b6e850c63817242f5cc3e381aaa9633062d1b01c3a7450ec6a64876632ee

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 6.5.0
+
+* Allow data attributes on links
+
 ## 6.4.0
 
  * Add table heading syntax that allows a table cell outside of `thead` to be marked as a table heading with a scope of row. (PR#161)

data/lib/govspeak/html_sanitizer.rb

@@ -48,21 +48,13 @@ class Govspeak::HtmlSanitizer
     Sanitize.clean(@dirty_html, Sanitize::Config.merge(sanitize_config, transformers: transformers))
   end
 
-  def button_sanitize_config
-    %w[
-      data-module
-      data-tracking-code
-      data-tracking-name
-    ]
-  end
-
   def sanitize_config
     Sanitize::Config.merge(
       Sanitize::Config::RELAXED,
       elements: Sanitize::Config::RELAXED[:elements] + %w[govspeak-embed-attachment govspeak-embed-attachment-link],
       attributes: {
         :all => Sanitize::Config::RELAXED[:attributes][:all] + %w[role aria-label],
-        "a"  => Sanitize::Config::RELAXED[:attributes]["a"] + button_sanitize_config,
+        "a"  => Sanitize::Config::RELAXED[:attributes]["a"] + [:data],
         "th"  => Sanitize::Config::RELAXED[:attributes]["th"] + %w[style],
         "td"  => Sanitize::Config::RELAXED[:attributes]["td"] + %w[style],
         "govspeak-embed-attachment" => %w[content-id],

data/lib/govspeak/version.rb

@@ -1,3 +1,3 @@
 module Govspeak
-  VERSION = "6.4.0".freeze
+  VERSION = "6.5.0".freeze
 end

data/test/html_sanitizer_test.rb

@@ -35,6 +35,15 @@ class HtmlSanitizerTest < Minitest::Test
     )
   end
 
+  test "allow data attributes on links" do
+    html = "<a href='/' data-module='track-click' data-ecommerce-path='/' data-track-category='linkClicked'>Test Link</a>"
+
+    assert_equal(
+      "<a href=\"/\" data-module=\"track-click\" data-ecommerce-path=\"/\" data-track-category=\"linkClicked\">Test Link</a>",
+      Govspeak::HtmlSanitizer.new(html).sanitize
+    )
+  end
+
   test "allows images on whitelisted domains" do
     html = "<img src='http://allowed.com/image.jgp'>"
     sanitized_html = Govspeak::HtmlSanitizer.new(html, allowed_image_hosts: ['allowed.com']).sanitize

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govspeak
 version: !ruby/object:Gem::Version
-  version: 6.4.0
+  version: 6.5.0
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-22 00:00:00.000000000 Z
+date: 2019-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview
@@ -359,23 +359,23 @@ signing_key:
 specification_version: 4
 summary: Markup language for single domain
 test_files:
-- test/govspeak_attachments_inline_test.rb
-- test/govspeak_attachment_test.rb
 - test/govspeak_attachment_link_test.rb
-- test/govspeak_images_test.rb
-- test/govspeak_table_with_headers_test.rb
-- test/govspeak_link_test.rb
-- test/govspeak_images_bang_test.rb
-- test/govspeak_link_extractor_test.rb
-- test/govspeak_contacts_test.rb
 - test/test_helper.rb
+- test/govspeak_button_test.rb
 - test/govspeak_test.rb
-- test/govspeak_attachments_image_test.rb
 - test/html_validator_test.rb
-- test/govspeak_structured_headers_test.rb
-- test/govspeak_extract_contact_content_ids_test.rb
-- test/blockquote_extra_quote_remover_test.rb
-- test/presenters/h_card_presenter_test.rb
-- test/govspeak_button_test.rb
+- test/govspeak_attachment_test.rb
+- test/govspeak_contacts_test.rb
 - test/govspeak_test_helper.rb
+- test/blockquote_extra_quote_remover_test.rb
+- test/govspeak_table_with_headers_test.rb
+- test/govspeak_attachments_image_test.rb
 - test/html_sanitizer_test.rb
+- test/govspeak_link_test.rb
+- test/govspeak_extract_contact_content_ids_test.rb
+- test/govspeak_structured_headers_test.rb
+- test/govspeak_images_test.rb
+- test/presenters/h_card_presenter_test.rb
+- test/govspeak_images_bang_test.rb
+- test/govspeak_link_extractor_test.rb
+- test/govspeak_attachments_inline_test.rb