govspeak 10.1.0 → 10.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d9ca524477e38e4b0b37849295da93aaf71e8701f6eaf280da50fcf89ccbde01
-  data.tar.gz: 637af4d5351f4cb1a18435b8ee5e615403cbc663981bd8d6e9d67cd4f5a86607
+  metadata.gz: 244ad3768386af3b3e111493610fd0dd3b3ae892a1661da85be36d1c2d135f94
+  data.tar.gz: 915d3141f07e1578263645cdba00d39c02f9987ea15133a50bd6bf09b37d0f32
 SHA512:
-  metadata.gz: 1e69a7260c483ee4b9dff69a1be6dd733163f8bfc12777b55acbaea1e014b3ffd1c6ec0104ec4fc55141db551405b83f8980e57d912bb0f32cb6ab5ae64418a5
-  data.tar.gz: a71a0f62fe42ec52ea7123d1e1aad7f2d7fa54fcd45315250e74b42b4cf8fe322a34d1380a4402f5ed69cfab62474203bf5e220bbe41a7fffa65753bbd1828d8
+  metadata.gz: b493113cc87018ba77ec5238a160758492056b86b5d10e26fa5e9cd95374197769dcdddcf7fb2965bb0b0ca80fde42af7f0daa3435f66483c4a03f7c94123b57
+  data.tar.gz: c2880fc10ca8248e274054dde5a741a375e32a58e0ae20b96a8e98f94109d438d1e0d8dd37eaf9c0937fe4139b758999bd1960ff5ea041a5f6ee4de25a36d899

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 10.2.0
+
+* Revert 'Add GA4 indexes to attachments that render a details component' ([#389](https://github.com/alphagov/govspeak/pull/389))
+
 ## 10.1.0
 
 * Allow acronyms/abbreviations in steps ([#387](https://github.com/alphagov/govspeak/pull/387)).

data/lib/govspeak/post_processor.rb

@@ -57,11 +57,6 @@ module Govspeak
     end
 
     extension("embed attachment HTML") do |document|
-      # Attachments with details components need indexes set for GA4 tracking purposes
-      details_attachments = govspeak_document.attachments.select { |attachment| attachment[:alternative_format_contact_email] }
-      details_attachments_size = details_attachments.size
-      details_attachment_index = 0
-
       document.css("govspeak-embed-attachment").map do |el|
         attachment = govspeak_document.attachments.detect { |a| a[:id] == el["id"] }
 
@@ -70,17 +65,11 @@ module Govspeak
           next
         end
 
-        if attachment[:alternative_format_contact_email]
-          details_attachment_index += 1
-          details_ga4_attributes = { index_section: details_attachment_index, index_section_count: details_attachments_size }
-        end
-
         attachment_html = GovukPublishingComponents.render(
           "govuk_publishing_components/components/attachment",
           attachment:,
           margin_bottom: 6,
           locale: govspeak_document.locale,
-          details_ga4_attributes:,
         )
         el.swap(attachment_html)
       end

data/lib/govspeak/version.rb

@@ -1,3 +1,3 @@
 module Govspeak
-  VERSION = "10.1.0".freeze
+  VERSION = "10.2.0".freeze
 end

data/test/govspeak_attachment_test.rb

@@ -52,32 +52,4 @@ class GovspeakAttachmentTest < Minitest::Test
     assert html_has_selector?(rendered, "section.gem-c-attachment")
     assert_match(/<p>some more text<\/p>/, rendered)
   end
-
-  test "renders attachments with details elements with the correct GA4 index" do
-    attachments = []
-
-    (1..3).each do |index|
-      attachments << {
-        id: "attachment#{index}.ods",
-        url: "http://example.com/attachment#{index}",
-        title: "Attachment Title #{index}",
-        alternative_format_contact_email: "example@gov.uk",
-      }
-    end
-
-    # Insert an attachment without a details element, to ensure our code to increment the index ignores these
-    attachments.insert(1, {
-      id: "attachment.pdf",
-      url: "http://example.com/attachment.pdf",
-      title: "Attachment Title",
-    })
-
-    rendered = render_govspeak("[Attachment:attachment1.ods]\n[Attachment:attachment.pdf]\n[Attachment:attachment2.ods]\n[Attachment:attachment3.ods]", attachments)
-    node = Nokogiri::HTML(rendered)
-    node.css(".gem-c-details").each_with_index.map do |details, index|
-      ga4_event = JSON.parse(details.attribute("data-ga4-event"))
-      assert_equal ga4_event["index_section"], index + 1
-      assert_equal ga4_event["index_section_count"], 3
-    end
-  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: govspeak
 version: !ruby/object:Gem::Version
-  version: 10.1.0
+  version: 10.2.0
 platform: ruby
 authors:
 - GOV.UK Dev
 bindir: bin
 cert_chain: []
-date: 2025-03-05 00:00:00.000000000 Z
+date: 2025-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionview