governor_comments 0.2.5 → 0.2.6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ./
   specs:
-    governor_comments (0.2.5)
+    governor_comments (0.2.6)
       governor (>= 0.5.0)
       rails (~> 3.0.5)
 

data/VERSION

@@ -1 +1 @@
-0.2.5
+0.2.6

data/app/controllers/governor/comments_controller.rb

@@ -3,6 +3,7 @@ module Governor
     include Governor::Controllers::Helpers
     
     before_filter :init_resource
+    before_filter :validate_params, :only => [:create]
     before_filter :authorize_commenter!, :except => [:new, :create]
     before_filter :get_comment, :only => [:edit, :update, :destroy, :mark_spam, :not_spam]
     
@@ -76,5 +77,11 @@ module Governor
         redirect_to root_path unless governor_authorized?(:edit, resource)
       end
     end
+    
+    def validate_params
+      unless params.has_key?(:comment)
+        render :text => 'Please include the comment.', :status => :bad_request
+      end
+    end
   end
 end

data/governor_comments.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{governor_comments}
-  s.version = "0.2.5"
+  s.version = "0.2.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Liam Morley"]
-  s.date = %q{2011-05-18}
+  s.date = %q{2011-06-20}
   s.description = %q{Comments plugin for the Rails 3-based Governor blogging system.}
   s.email = %q{liam@carpeliam.com}
   s.extra_rdoc_files = [
@@ -52,6 +52,7 @@ Gem::Specification.new do |s|
     "spec/controllers/governor/comments_controller_spec.rb",
     "spec/governor_comments_spec.rb",
     "spec/models/article_spec.rb",
+    "spec/models/comment_spec.rb",
     "spec/rails_app/.gitignore",
     "spec/rails_app/Gemfile",
     "spec/rails_app/Gemfile.lock",
@@ -120,6 +121,7 @@ Gem::Specification.new do |s|
     "spec/controllers/governor/comments_controller_spec.rb",
     "spec/governor_comments_spec.rb",
     "spec/models/article_spec.rb",
+    "spec/models/comment_spec.rb",
     "spec/rails_app/app/controllers/application_controller.rb",
     "spec/rails_app/app/controllers/home_controller.rb",
     "spec/rails_app/app/helpers/application_helper.rb",

data/lib/governor_comments/comment.rb

@@ -16,6 +16,7 @@ module GovernorComments
       
       base.validates_presence_of :content
       base.validates_presence_of :commenter
+      base.validates_associated :commenter
     end
     
     def mark_spam

data/spec/controllers/governor/comments_controller_spec.rb

@@ -19,7 +19,10 @@ module Governor
         assigns[:article].should == @article
       end
       
-      it "looks up returning guests by email"
+      it "handles bad input from nasty spammers" do
+        post :create, :governor_mapping => :articles, :article_id => @article.id
+        response.response_code.should == 400
+      end
     end
     
     context "#mark_spam" do

data/spec/models/comment_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe Comment do
+  before do
+    @bad_guest = Guest.new
+    @bad_guest.should be_invalid
+    @good_guest = Guest.new(:name => 'name', :email => 'email@address.com')
+    @good_guest.should be_valid
+  end
+  it "is invalid if the commenter is invalid" do
+    Comment.new(:content => 'some content', :commenter => @bad_guest).should be_invalid
+    Comment.new(:content => 'some content', :commenter => @good_guest).should be_valid
+  end
+end

data/spec/rails_app/Gemfile

@@ -9,7 +9,7 @@ gem 'sqlite3'
 
 gem 'devise'
 gem 'rakismet'
-gem 'governor', :git => 'git://github.com/carpeliam/governor.git'
+gem 'governor'
 gem 'governor_comments', :path => '../..'
 
 gem 'dynamic_form'

data/spec/rails_app/Gemfile.lock

@@ -1,14 +1,7 @@
-GIT
-  remote: git://github.com/carpeliam/governor.git
-  revision: c1867661afb7659c2bdfa6aee5afda6d2a93c8a3
-  specs:
-    governor (0.5.7)
-      rails (>= 3.0.5)
-
 PATH
   remote: ../..
   specs:
-    governor_comments (0.2.5)
+    governor_comments (0.2.6)
       governor (>= 0.5.0)
       rails (~> 3.0.5)
 
@@ -51,6 +44,8 @@ GEM
     dynamic_form (1.1.3)
     erubis (2.6.6)
       abstract (>= 1.0.0)
+    governor (0.5.7)
+      rails (>= 3.0.5)
     i18n (0.5.0)
     mail (2.2.19)
       activesupport (>= 2.3.6)
@@ -94,7 +89,7 @@ PLATFORMS
 DEPENDENCIES
   devise
   dynamic_form
-  governor!
+  governor
   governor_comments!
   rails (= 3.0.5)
   rakismet

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: governor_comments
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: false
   segments: 
   - 0
   - 2
-  - 5
-  version: 0.2.5
+  - 6
+  version: 0.2.6
 platform: ruby
 authors: 
 - Liam Morley
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-18 00:00:00 -04:00
+date: 2011-06-20 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -284,6 +284,7 @@ files:
 - spec/controllers/governor/comments_controller_spec.rb
 - spec/governor_comments_spec.rb
 - spec/models/article_spec.rb
+- spec/models/comment_spec.rb
 - spec/rails_app/.gitignore
 - spec/rails_app/Gemfile
 - spec/rails_app/Gemfile.lock
@@ -380,6 +381,7 @@ test_files:
 - spec/controllers/governor/comments_controller_spec.rb
 - spec/governor_comments_spec.rb
 - spec/models/article_spec.rb
+- spec/models/comment_spec.rb
 - spec/rails_app/app/controllers/application_controller.rb
 - spec/rails_app/app/controllers/home_controller.rb
 - spec/rails_app/app/helpers/application_helper.rb