governor_background 0.2.0 → 0.2.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ./
   specs:
-    governor_background (0.2.0)
+    governor_background (0.2.1)
       governor
 
 GEM

data/VERSION

@@ -1 +1 @@
-0.2.0
+0.2.1

data/governor_background.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{governor_background}
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Liam Morley"]
-  s.date = %q{2011-05-12}
+  s.date = %q{2011-05-13}
   s.description = %q{A middle-tier plugin for the Rails 3-based Governor blogging system, allowing you to tie in additional services that might want to perform blog-related services in the background.}
   s.email = %q{liam@carpeliam.com}
   s.extra_rdoc_files = [

data/lib/governor_background.rb

@@ -12,7 +12,7 @@ background = Governor::Plugin.new('background')
 background.register_model_callback do |base|
   module InstanceMethods
     private
-    def run_in_background(method, arguments=[])
+    def run_in_background(method, *arguments)
       GovernorBackground::Handler.run_in_background self, method, arguments
     end
   end

data/lib/governor_background/handler.rb

@@ -1,7 +1,7 @@
 module GovernorBackground
   class Handler
     class << self
-      def run_in_background(object, method, arguments=[])
+      def run_in_background(object, method, *arguments)
         job = if delayed_job?
           Delayed::Job.new(object, method, ::Delayed::Job.enqueue(Delayed::Performer.new(object, method, arguments)))
         elsif resque?

data/lib/governor_background/resque/performer.rb

@@ -3,7 +3,7 @@ module GovernorBackground
     class Performer
       @queue = :governor
 
-      def self.perform(resource, id, method_name, arguments=[])
+      def self.perform(resource, id, method_name, *arguments)
         article = Governor.resources[resource].to.find(id)
         if arguments.blank?
           article.send(method_name)

data/spec/governor_background/handler_spec.rb

@@ -42,5 +42,12 @@ module GovernorBackground
       id = JobManager.jobs.first.id
       Resque::PerformerWithState.should have_queued(id, {:resource => :articles, :id => @article.id, :method_name => :post, :arguments => []}).in(:governor)
     end
+    
+    it "can accept any number of arguments" do
+      Handler.use_resque = true
+      Handler.run_in_background(@article, :post, 1, 2, 3)
+      id = JobManager.jobs.first.id
+      Resque::PerformerWithState.should have_queued(id, {:resource => :articles, :id => @article.id, :method_name => :post, :arguments => [1, 2, 3]}).in(:governor)
+    end
   end
 end

data/spec/governor_background/resque/performer_spec.rb

@@ -6,12 +6,17 @@ module GovernorBackground
       before do
         ResqueSpec.reset!
         @article = Factory(:article, :author => Factory(:user))
-        ::Resque.enqueue(Performer, :articles, @article.id, :post)
       end
   
       it "adds article.post to the :governor queue" do
+        ::Resque.enqueue(Performer, :articles, @article.id, :post)
         Performer.should have_queued(:articles, @article.id, :post).in(:governor)
       end
+      
+      it "accepts any number of arguments" do
+        ::Resque.enqueue(Performer, :articles, @article.id, :post, 1, 2, 3)
+        Performer.should have_queued(:articles, @article.id, :post, 1, 2, 3).in(:governor)
+      end
     end
   end
 end

data/spec/governor_background_spec.rb

@@ -1,7 +1,9 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe GovernorBackground do
-  it "adds #run_in_background to Article" do
-    Article.private_instance_methods.include? 'run_in_background'
+  it "passes arguments to the handler" do
+    @article = Factory(:article, :author => Factory(:user))
+    GovernorBackground::Handler.expects(:run_in_background).with(@article, :some_method, [1, 2, 3])
+    @article.send(:run_in_background, :some_method, 1, 2, 3)
   end
 end

data/spec/rails_app/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../..
   specs:
-    governor_background (0.2.0)
+    governor_background (0.2.1)
       governor
 
 GEM

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: governor_background
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - Liam Morley
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-12 00:00:00 -04:00
+date: 2011-05-13 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency