govdelivery-tms 0.9.3 → 0.9.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Zjc4MDEyNGFmZjllYzk4ZTc4MGE4ZTY0NmY0MThiNjM1OTQ2ZTIyZg==
+    OGU2YjhiZjAxYTBmOWZjNGRiOGEzYmJmM2JiYmFhNjVkY2U4NGJmYw==
   data.tar.gz: !binary |-
-    NGMxYjBiNDNjN2RlODIzYTJiYTRiZmE0ZWIxNDg4OTAwZmUzYzg3Yw==
+    Y2EzNjAyZDA5MWRiZmYyYzBmMzkyZWYyYzc5NDQ1MjMwZjY1NmM5NA==
 SHA512:
   metadata.gz: !binary |-
-    ZjA1Yjk5MmQyNTZmZTZkMmM2YjVmMDNmYmYxMDY5MWRiNTFmZjk0MTg0MzNh
-    NjViZjYxNTc3MzI5OTJjYWE2NjIzZmUwMjA5MTI4MWQ1OGI5ZTM5Yzg1ODRh
-    ZTZhYjIxMTJhZjc0MjViODkwY2ZiMTZlYzNmMmY3MTU5NjE5MjE=
+    M2ZhODFhYmQxZTZkMmI1MmU3NzA3OGNlNzFkMDlkMmQ1MTYwOWViMWNkYWRh
+    Yzg5ZDI4Y2I5ZDZlZGE1OTQyYWZkNjAxNmJkOWFmYTU1NWNjMzIxYTM1ZmUx
+    ZmI0MTA2MTMwNGIxZWI2YzlkYjQ2YzBlYWI0YjFhMGQ0MDk5NmU=
   data.tar.gz: !binary |-
-    MDg1NDNkMmJmMzUzODdhY2YzM2YyMTZjNmUwMGZkM2E4ZTEyMWE2YThmMjMz
-    NWZmYjZlMjI1MjlmZTFmZDFlM2Y1ZWFmNTQ2OWU3MWIwYzI5MGE1NGNmNmM0
-    MjUxNDdmMGI1MTNmZTlhYjc5ZmJkMTM5MWZjODlmY2QwZTk5MDI=
+    MmJmNzk5ZjRiNWI1OTJiNjIyYTFmMDY0MTgyZmFhZmQ1ZWQxNzA4YmZmMmU5
+    ZjZmMWUzMDUwZTJhMGY3NGQzNjE3ZTAzZjVhNmNlMGRkNGU0NDU5MTBlODUw
+    NTM0ZDE0ZDU4ZDFkODZhNWE0MzEyYmVmMWY3NTA3NzEwMzQ2ZWE=

data/lib/govdelivery/tms/instance_resource.rb

@@ -44,6 +44,17 @@ module GovDelivery::TMS::InstanceResource
       @readonly_attributes
     end
 
+    ##
+    # Nullable attributes are sent as null in the request
+    #
+    def nullable_attributes(*attrs)
+      @nullable_attributes ||= []
+      if attrs.any?
+        @nullable_attributes.map!(&:to_sym).concat(attrs).uniq! if attrs.any?
+      end
+      @nullable_attributes
+    end
+
     ##
     # For collections that are represented as attributes (i.e. inline, no href)
     #
@@ -166,7 +177,9 @@ module GovDelivery::TMS::InstanceResource
         json_hash[:_links]       ||= {}
         json_hash[:_links][attr] = @links[attr]
       end
-      json_hash.reject { |_, value| value.nil? }
+      json_hash.reject do |key, value|
+        value.nil? && !self.class.nullable_attributes.include?(key)
+      end
     end
 
     protected

data/lib/govdelivery/tms/resource/email_template.rb

@@ -18,5 +18,7 @@ module GovDelivery::TMS #:nodoc:
     readonly_attributes :id, :created_at
 
     collection_attribute :from_address, 'FromAddress'
+
+    nullable_attributes :message_type_code
   end
 end

data/lib/govdelivery/tms/version.rb

@@ -1,5 +1,5 @@
 module GovDelivery
   module TMS #:nodoc:
-    VERSION = '0.9.3'
+    VERSION = '0.9.4'.freeze
   end
 end

data/spec/instance_resource_spec.rb

@@ -35,6 +35,14 @@ describe GovDelivery::TMS::InstanceResource do
       expect(@instance_resource.to_json).to eq({blah: {recipients: [], opened: [], clicked: [], sent: [], failed: []}})
     end
 
+    it 'should ignore nils in to_json unless an attribute in nullable_attributes' do
+      @instance_resource.class.nullable_attributes :bar
+      @instance_resource.bar = nil
+      expect(@instance_resource.to_json).to eq({blah: {recipients: [], opened: [], clicked: [], sent: [], failed: []},
+                                                bar: nil})
+      @instance_resource.class.instance_variable_set :@nullable_attributes, []
+    end
+
     it 'should not GET on initialization' do
       expect(client).not_to receive(:get)
       Foo.new(client, 'https://example.com/foos/1')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govdelivery-tms
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 0.9.4
 platform: ruby
 authors:
 - GovDelivery