govdelivery-tms 0.8.9 → 0.8.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: beaa9bf643b1ed8a2db0bebfcc0c303e1a9eec63
-  data.tar.gz: fa153c967d58070a3ee1cdc9a1d0777b8f7f2990
+  metadata.gz: 628273a3b62f2225d9cee7f37734a94c7fc03da2
+  data.tar.gz: f085b0197b197519a0e60c330072a821038f3335
 SHA512:
-  metadata.gz: 30130e14bba971fd996209ea4918212be4bfcfea986a322ad68dc9c4d3ab246be61ea6dd78b6531e7fbc813563aa392125d083b27ef217e75c3582bf11f8818a
-  data.tar.gz: 179a63f71c4ad59a988d59b0ad1675d9fcc37cf2afa03084ef361fa16de91c45eb5ab6f5ffa32bc048325f2bedfc025422f159537849100ce86e25946178fcbe
+  metadata.gz: 9e1c2de8489ec577db76e9b6a5c0bbe920c4d2a7310b76e8edaabaf7849ae72605219ffae9162095f5309aff91903c527762dd8126bc1bf094ea7bc118198491
+  data.tar.gz: 6e24bd50c6902f8236aa828f266c9b0e13ee2f6ee46608f3fdfab0dc915948f25d751aee4c2a6e311386615ea25d2484a4d6eed285b548475122e6715655a78a

data/lib/govdelivery/tms/client.rb

@@ -90,8 +90,8 @@ class GovDelivery::TMS::Client
   private
 
   def setup_logging(debug)
-    logger = Logger.new(STDOUT)
-    logger.level = debug ? Logger::DEBUG : Logger::INFO
-    logger
+    Logger.new(STDOUT).tap do |logger|
+      logger.level = debug ? Logger::DEBUG : Logger::INFO
+    end
   end
 end

data/lib/govdelivery/tms/util/hal_link_parser.rb

@@ -30,7 +30,7 @@ module GovDelivery::TMS::Util
             subresources[rel] = klass.new(client, href)
             setup_subresource(link)
           else
-            logger.info("Don't know what to do with link rel '#{rel}' for class #{self.class}!") if self.respond_to?(:logger)
+            logger.info("Don't know what to do with link rel '#{rel}' for class #{self.class}!") if self.respond_to?(:logger) && logger
           end
 
         end
@@ -38,7 +38,11 @@ module GovDelivery::TMS::Util
     end
 
     def relation_class(rel)
-      ::GovDelivery::TMS.const_get(classify(rel)) rescue nil
+      ::GovDelivery::TMS.const_get(classify(rel)).tap do |klass|
+        return nil unless klass.name =~ /GovDelivery::TMS/
+      end
+    rescue NameError
+      nil
     end
 
     def setup_subresource(link)

data/lib/govdelivery/tms/version.rb

@@ -1,5 +1,5 @@
 module GovDelivery
   module TMS #:nodoc:
-    VERSION = '0.8.9'
+    VERSION = '0.8.10'
   end
 end

data/spec/client_spec.rb

@@ -1,8 +1,30 @@
 require 'spec_helper'
 describe GovDelivery::TMS::Client do
+  let(:links) {
+    [{'self' => '/'},
+     {'horse' => '/horses/new'},
+     {'rabbits' => '/rabbits'}]
+  }
+  context 'a client with a missing rel' do
+    before do
+      response        = double('response', status: 200,
+                               body:               {
+                                 'sid'    => 'abcd12345',
+                                 '_links' => (links + [{'missing' => '/fail'}])})
+      @raw_connection = double('raw_connection', get: response)
+      @connection     = allow(GovDelivery::TMS::Connection).to receive(:new).and_return(double('connection', connection: @raw_connection))
+    end
+    it 'should not blow up or create a relation' do
+      @client         = GovDelivery::TMS::Client.new('auth_token', api_root: 'null_url')
+      expect{@client.missing}.to raise_error(NoMethodError)
+    end
+  end
   context 'creating a new client' do
     before do
-      response = double('response', status: 200, body: {'sid' => 'abcd12345', '_links' => [{ 'self' => '/' }, { 'horse' => '/horses/new' }, { 'rabbits' => '/rabbits' }] })
+      response = double('response', status: 200,
+                        body:               {
+                          'sid'    => 'abcd12345',
+                          '_links' => links})
       @raw_connection = double('raw_connection', get: response)
       @connection = allow(GovDelivery::TMS::Connection).to receive(:new).and_return(double('connection', connection: @raw_connection))
       @client = GovDelivery::TMS::Client.new('auth_token', api_root: 'null_url')

data/spec/spec_helper.rb

@@ -6,6 +6,10 @@ class GovDelivery::TMS::Horse
   end
 end
 
+module Missing
+  # this is for testing missing relations that expose strange const_get behavior
+end
+
 class GovDelivery::TMS::Rabbits
   def initialize(_client, _href)
   end

metadata

@@ -1,57 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: govdelivery-tms
 version: !ruby/object:Gem::Version
-  version: 0.8.9
+  version: 0.8.10
 platform: ruby
 authors:
 - GovDelivery
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2015-06-11 00:00:00.000000000 Z
+date: 2015-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: activesupport
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: faraday
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: faraday
   prerelease: false
   type: :runtime
-- !ruby/object:Gem::Dependency
-  name: faraday_middleware
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+  name: faraday_middleware
   prerelease: false
   type: :runtime
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: "A reference implementation, written in Ruby,\n                     to\
   \ interact with GovDelivery's TMS API. The client is\n                     compatible\
   \ with Ruby 1.9 and 2.0. "
@@ -74,7 +74,6 @@ files:
 - lib/govdelivery/tms/instance_resource.rb
 - lib/govdelivery/tms/link_header.rb
 - lib/govdelivery/tms/logger.rb
-- lib/govdelivery/tms/version.rb
 - lib/govdelivery/tms/mail/delivery_method.rb
 - lib/govdelivery/tms/resource/collections.rb
 - lib/govdelivery/tms/resource/command.rb
@@ -93,6 +92,7 @@ files:
 - lib/govdelivery/tms/resource/webhook.rb
 - lib/govdelivery/tms/util/core_ext.rb
 - lib/govdelivery/tms/util/hal_link_parser.rb
+- lib/govdelivery/tms/version.rb
 - spec/client_spec.rb
 - spec/command_types_spec.rb
 - spec/email_message_spec.rb
@@ -127,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.1.9
+rubygems_version: 2.4.8
 signing_key:
 specification_version: 4
 summary: A ruby client to interact with the GovDelivery TMS REST API.