gouteur 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 001d0213cebc3a146615388dff657d573cc671395e2e8d62995e11b3b3a84f6e
-  data.tar.gz: 45ed7d535d16effa0c9ad2bd6044e973257d08a111e606beb6b65dd2e7483b83
+  metadata.gz: 174d0cdcc37fbca2d808a91be97a17feb70140ef403de6f95f91b0ce74e8beda
+  data.tar.gz: 6f886d8d85c43065b821371a916e44414580a5e5ead255d811916942d9387b70
 SHA512:
-  metadata.gz: 2664a0c872fbd8da4b638841454904ae43015652c10e3d2fabbd52f7c5f15fb2f5541eb677954952228e48153ca4ef6f6d85cac5ca3b7ca5abbbac07c11a67a2
-  data.tar.gz: 1befe751c803a11255163d29ef64b37ce143381c11b197c9826ee1f020e249bace18fb597a318840293c7b2d72fac78e3a42b86a99be059db7d8eb5628270a02
+  metadata.gz: 7806e1a42dacd49fa222c7eb9c73f21373786540c7a8d2c06ae8bba06dfb71a5d98e8e81ff6bfcda063da86b91d377c7a2b01ab2a5ee4e6bf0fdeac638a472b6
+  data.tar.gz: 84c3649159b02083c7ac31d94e14657a04807cc05f99f41cea3ea35939106394e88337118ce2c72a384fa6ec0c41f83d3c92bf3ccd9ff980c6fcdde9b4e9b571

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [1.0.1] - 2021-03-09
+
+### Fixed
+
+- Fixed error when a task failed with the old code
+
 ## [1.0.0] - 2021-02-08
 
 - Initial release

data/README.md

@@ -17,7 +17,7 @@ When you release a new version of your gem, these projects might break.
 
 [Semantic versioning](https://semver.org) obviously helps. People make mistakes, though. The boundary between public and private APIs can also be fuzzy, particularly in an open language like Ruby.
 
-Thus, when you update your gem, you might feel as if you should check whether things that depend on it will keep working.
+Thus, when you update your gem, you might feel as if you should check whether things that depend on it will keep working before you release the new version.
 
 Gouteur automates this step.
 

data/lib/gouteur/checker.rb

@@ -22,9 +22,7 @@ module Gouteur
       run_tasks(adapted: false)
 
       create_adapted_gemfile
-      install_adapted_bundle or return [
-        true, Message.skipped_incompatible(repo: repo)
-      ]
+      install_adapted_bundle or return handle_incompatible_semver
 
       run_tasks(adapted: true)
 
@@ -52,7 +50,8 @@ module Gouteur
 
     def run_task(task, adapted: false)
       puts("Running `#{task}` with #{adapted ? :new : :old} `#{Host.name}`...")
-      result = repo.bundle.exec(task, env: adapted ? adaptation_env : {})
+      env = adapted ? adaptation_env : {}
+      result = repo.bundle.exec(task, env: env)
       result.success? or raise Error, Message.send(
         adapted ? :broken_after_update : :broken,
         repo: repo, task: task, output: result.stdout, error: result.stderr
@@ -89,28 +88,32 @@ module Gouteur
       "#{repo.bundle.gemfile_path}.gouteur"
     end
 
-    BUNDLER_INCOMPATIBLE_VERSION_CODE = 6
-    BUNDLER_GEM_NOT_FOUND_CODE        = 7 # includes some incompatibility cases
-
     def install_adapted_bundle
       result = repo.bundle.install(env: adaptation_env)
-
       if result.success?
         true
-      elsif result.exitstatus == BUNDLER_INCOMPATIBLE_VERSION_CODE ||
-            result.exitstatus == BUNDLER_GEM_NOT_FOUND_CODE &&
-            result.stderr =~ /following version/
-        if repo.locked?
-          raise Error,
-                Message.incompatible_failure(repo: repo, error: result.stderr)
-        else
-          false
-        end
+      elsif indicates_incompatible_semver?(result)
+        false
       else
         raise Error, result.full_error
       end
     end
 
+    BUNDLER_INCOMPATIBLE_VERSION_CODE = 6
+    BUNDLER_GEM_NOT_FOUND_CODE = 7 # includes some incompatibility cases
+
+    def indicates_incompatible_semver?(result)
+      result.exitstatus == BUNDLER_INCOMPATIBLE_VERSION_CODE ||
+        result.exitstatus == BUNDLER_GEM_NOT_FOUND_CODE &&
+          result.stderr =~ /following version/
+    end
+
+    def handle_incompatible_semver
+      raise Error, Message.incompatible_failure(repo: repo) if repo.locked?
+
+      [true, Message.skipped_incompatible(repo: repo)]
+    end
+
     def adaptation_env
       {
         'BUNDLE_GEMFILE' => adapted_gemfile_path,

data/lib/gouteur/message.rb

@@ -14,7 +14,7 @@ module Gouteur
 
     def success(repo:)
       <<~MSG
-        👨‍🍳 Délicieux!
+        👨‍🍳 #{random_word_for_tasty.capitalize}!
 
         Your changes to `#{Host.name}` are fine for `#{repo}`. All tasks succeeded.
       MSG
@@ -44,20 +44,21 @@ module Gouteur
       MSG
     end
 
-    def broken(repo:, task:, error:)
+    def broken(repo:, task:, output:, error:)
       <<~MSG
         👨‍🍳 Zut alors!
 
         Task `#{task}` failed for `#{repo}` even before inserting the new code of `#{Host.name}`.
 
         This likely means the task is broken or does not exist.
+        #{original_output_part(output)}
         #{original_error_part(error)}
       MSG
     end
 
     def broken_after_update(repo:, task:, output:, error:)
       <<~MSG
-        👨‍🍳 Répugnant!
+        👨‍🍳 #{random_word_for_disgusting.capitalize}!
 
         Task `#{task}` failed for `#{repo}` after inserting the new code of `#{Host.name}`.
 
@@ -77,14 +78,13 @@ module Gouteur
       MSG
     end
 
-    def incompatible_failure(repo:, error:)
+    def incompatible_failure(repo:)
       <<~MSG
         👨‍🍳 Zut alors!
 
         The new version number of `#{Host.name}` is incompatible with the version requirements specified by `#{repo}`.
 
         Incompatible version numbers can be allowed by removing the `locked` flag. This will make gouteur SKIP the tasks in this case.
-        #{original_error_part(error)}
       MSG
     end
 
@@ -101,5 +101,13 @@ module Gouteur
     def strip(string)
       string.to_s.gsub(/\A\s+|\s+\z/, '')
     end
+
+    def random_word_for_tasty
+      %w[délectable délicieux savoureux succulent].sample
+    end
+
+    def random_word_for_disgusting
+      %w[dégoûtant immangeable répugnant].sample
+    end
   end
 end

data/lib/gouteur/version.rb

@@ -1,3 +1,3 @@
 module Gouteur
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.0.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gouteur
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Janosch Müller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-22 00:00:00.000000000 Z
+date: 2021-03-09 00:00:00.000000000 Z
 dependencies: []
 description: Run tests of dependent gems against your changes.
 email: