gopay 0.1.1 → 0.2

data/config/config.yml

@@ -1,7 +1,7 @@
 urls:
   test:
-    full_integration: https://testgw.gopay.cz/gw/pay-full-v2
-    wsdl: https://testgw.gopay.cz/axis/EPaymentServiceV2?wsdl
+    full_integration: http://testgw.gopay.cz/gw/pay-full-v2
+    wsdl: http://testgw.gopay.cz/axis/EPaymentServiceV2?wsdl
     base_integration: https://testgw.gopay.cz/gw/pay-base-v2
     get_account_statement_url: https://testgw.gopay.cz/gw/services/get-account-statement
   production:

data/lib/gopay/crypt.rb

@@ -16,12 +16,12 @@ module GoPay
       des.encrypt
       des.key = GoPay.configuration.secure_key
       result = des.update(string)
-      result.unpack("H*").to_s
+      result.unpack("H*")[0]
     end
 
     def decrypt(encrypted_data, padding_off = false)
       encrypted_data = bin2hex(encrypted_data)
-      des = OpenSSL::Cipher::Cipher.new("des-ede3")
+      des = OpenSSL::Cipher.new("des-ede3")
       des.decrypt
       des.padding = 0 if padding_off
       des.key = GoPay.configuration.secure_key
@@ -30,7 +30,7 @@ module GoPay
     end
 
     def bin2hex(bin)
-      bin.scan(/../).map { | tuple | tuple.hex.chr }.to_s
+      bin.scan(/../).map { |tuple| tuple.hex }.pack 'c*'
     end
   end
 

data/lib/gopay/models/base_payment.rb

@@ -30,8 +30,10 @@ module GoPay
         soap.body = {"paymentCommand" => payment_command_hash}
       end
       self.response = soap_response.to_hash[:create_payment_response][:create_payment_return]
-      self.payment_session_id = response[:payment_session_id]
       valid_response?(response, GoPay::STATUSES[:created])
+      valid = valid_response?(response, GoPay::STATUSES[:created])
+      self.payment_session_id = response[:payment_session_id] if valid
+      valid
     end
 
     def load(validated_status = nil)
@@ -111,9 +113,10 @@ module GoPay
     end
 
     def valid_identity?(params, padding_off = false)
-      params['targetGoId'] == target_goid.to_s &&
-          params['orderNumber'] == order_number.to_s &&
-          GoPay::Crypt.sha1(concat_payment_identity(params)) == GoPay::Crypt.decrypt(params['encryptedSignature'], padding_off)
+      raise 'invalid targetGoId' unless params['targetGoId'] == target_goid.to_s
+      raise 'invalid orderNumber' unless params['orderNumber'] == order_number.to_s
+      raise 'invalid encryptedSignature' unless GoPay::Crypt.sha1(concat_payment_identity(params)) == GoPay::Crypt.decrypt(params['encryptedSignature'], padding_off)
+      true
     end
 
     def concat_payment_identity(params)

data/lib/gopay/version.rb

@@ -1,3 +1,3 @@
 module GoPay
-  VERSION = "0.1.1"
+  VERSION = "0.2"
 end

data/test/config_test.rb

@@ -7,7 +7,7 @@ class ConfigTest < Test::Unit::TestCase
 
     should "load both config and country_codes yml files" do
       assert_equal "Česká Republika", GoPay.configuration.country_codes["CZE"]
-      assert_equal "https://testgw.gopay.cz/gw/pay-full-v2", GoPay.configuration.urls["full_integration"]
+      assert_equal "http://testgw.gopay.cz/gw/pay-full-v2", GoPay.configuration.urls["full_integration"]
     end
 
   end

data/test/test_helper.rb

@@ -3,7 +3,12 @@ $: << File.join(File.expand_path(File.dirname(__FILE__)), "../lib")
 require "rubygems"
 require 'test/unit'
 require "shoulda"
-require 'mocha'
+
+if RUBY_VERSION > "1.9"
+  require 'mocha/setup'
+else
+  require 'mocha'
+end
 
 require "gopay"
 require "awesome_print"
@@ -14,3 +19,5 @@ end
 
 # create your own test.yml (see test.example.yml)
 GoPay.configure_from_yaml(File.join(File.dirname(__FILE__), "test.yml"))
+
+HTTPI.log = false # silences warning like HTTPI executes HTTP POST using the net_http adapter

metadata

@@ -1,74 +1,73 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: gopay
-version: !ruby/object:Gem::Version 
-  hash: 25
+version: !ruby/object:Gem::Version
+  version: '0.2'
   prerelease: 
-  segments: 
-  - 0
-  - 1
-  - 1
-  version: 0.1.1
 platform: ruby
-authors: 
+authors:
 - papricek
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2012-09-23 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-11-21 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: savon
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: shoulda
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: shoulda
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: mocha
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: mocha
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
-description: GoPay is a library making it easy to access GoPay http://www.gopay.cz paygate from Ruby. It offers some basic wrapper around soap calls in the form of AR-like models. Its autoconfigurable from Rails.
-email: 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+description: GoPay is a library making it easy to access GoPay http://www.gopay.cz
+  paygate from Ruby. It offers some basic wrapper around soap calls in the form of
+  AR-like models. Its autoconfigurable from Rails.
+email:
 - patrikjira@gmail.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .rvmrc
 - Gemfile
@@ -92,38 +91,29 @@ files:
 - test/test_helper.rb
 homepage: http://gopay.defactory.net
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: gopay
 rubygems_version: 1.8.21
 signing_key: 
 specification_version: 3
 summary: A little gem making integration of GoPay easy
-test_files: 
+test_files:
 - test/config_test.rb
 - test/crypt_test.rb
 - test/models_test.rb