googlevoice47 0.1.9 → 0.1.10

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    googlevoice47 (0.1.8)
+    googlevoice47 (0.1.9)
       htmlentities
       mechanize
 
@@ -9,15 +9,20 @@ GEM
   remote: http://rubygems.org/
   specs:
     diff-lcs (1.1.3)
-    htmlentities (4.3.0)
-    mechanize (2.0.1)
-      net-http-digest_auth (>= 1.1.1, ~> 1.1)
-      net-http-persistent (~> 1.8)
+    domain_name (0.5.2)
+      unf (~> 0.0.3)
+    htmlentities (4.3.1)
+    mechanize (2.1.1)
+      domain_name (~> 0.5, >= 0.5.1)
+      net-http-digest_auth (~> 1.1, >= 1.1.1)
+      net-http-persistent (~> 2.4, >= 2.4.1)
       nokogiri (~> 1.4)
-      webrobots (>= 0.0.9, ~> 0.0)
-    net-http-digest_auth (1.1.1)
-    net-http-persistent (1.9)
+      ntlm-http (~> 0.1, >= 0.1.1)
+      webrobots (~> 0.0, >= 0.0.9)
+    net-http-digest_auth (1.2)
+    net-http-persistent (2.4.1)
     nokogiri (1.5.0)
+    ntlm-http (0.1.1)
     rake (0.9.2)
     rspec (2.6.0)
       rspec-core (~> 2.6.0)
@@ -27,8 +32,10 @@ GEM
     rspec-expectations (2.6.0)
       diff-lcs (~> 1.1.2)
     rspec-mocks (2.6.0)
-    webrobots (0.0.11)
-      nokogiri (>= 1.4.4)
+    unf (0.0.4)
+      unf_ext
+    unf_ext (0.0.4)
+    webrobots (0.0.13)
 
 PLATFORMS
   ruby

data/lib/googlevoice47/version.rb

@@ -1,3 +1,3 @@
 module GoogleVoice
-  VERSION = "0.1.9"
+  VERSION = "0.1.10"
 end

data/lib/googlevoice47.rb

@@ -17,23 +17,16 @@ module GoogleVoice
     
     class InvalidLoginException < Exception; end
     class InvalidPhoneNumberException < Exception; end
-  
-    # Create a basic Mechanize agent, initial our objects, and
-    # create our dynamic <function>_xml methods
+
     def initialize(email, password)
       @agent = Mechanize.new
       @coder = HTMLEntities.new
       @email = email if !email.nil?
       @password = password if !password.nil?
-      
-      # The methods created with this are used to fetch various
-      # XML data from Google for call-related history data.
+
       init_xml_methods()
     end
-  
-    # Login to a Google Account to use the Google Voice services
-    # Most of the calls require a special authentication token called
-    # _rnr_se that can be scraped from the page once logged in. 
+
     def login()
       login_page = @agent.get("https://www.google.com/accounts/ServiceLogin?service=grandcentral")
       login_page.forms.first.field_with(:name=>"Email").value = @email
@@ -44,49 +37,35 @@ module GoogleVoice
       raise InvalidLoginException, "Cannot login to Google Voice with #{@email}" unless dialing_form
       @rnr_se = dialing_form.field_with(:name => '_rnr_se').value
     end
-  
-    # Make sure we have a valid Mechanize agent and we obtained the _rnr_se 
-    # authentication token after logging in. Those are the two keys to 
-    # determining if we are successfully logged in or not.
+
     def logged_in?
         (@agent !=nil) && (@rnr_se != nil)
     end
   
-    # Send a text message to remote_number
     def sms(remote_number, text_message)
       login unless logged_in?
-      #remote_number = validate_number(remote_number)
+      remote_number = validate_number(remote_number)
       text_message = @coder.encode(text_message)
       @agent.post('https://www.google.com/voice/sms/send/', :id => '', :phoneNumber => remote_number, :text => text_message, "_rnr_se" => @rnr_se)
     end
-  
-    # Place a call to remote_number, and ring back forwarding_number which
-    # should be set up on the currently logged in Google Voice account
+
     def call(remote_number, forwarding_number)
       login unless logged_in?
-      #remote_number = validate_number(remote_number)
+      remote_number = validate_number(remote_number)
       forwarding_number = validate_number(forwarding_number)
       @agent.post('https://www.google.com/voice/call/connect/', :outgoingNumber => remote_number, :forwardingNumber => forwarding_number, :phoneType => 2, :subscriberNumber => 'undefined', :remember => '0', "_rnr_se" => @rnr_se)
     end
     
-    # Cancel the call in progress for this account. It does NOT hang up
-    # a call that has been answered, only one that has been placed but 
-    # not completed yet.
     def cancel()
       login unless logged_in?
       @agent.post('https://www.google.com/voice/call/cancel/', :outgoingNumber => 'undefined', :forwardingNumber => 'undefined', :cancelType => 'C2C', "_rnr_se" => @rnr_se)      
     end
 
-      
-    # International numbers can vary in length as opposed to the standard US 10 digit number
-    # So we can't effectively validate based on length. Instead, let's make sure we have at 
-    # least 4 digits and at most 15 since E.164 recommends at most 15 digits minus country code
-    # for the phone number (http://en.wikipedia.org/wiki/E.164)
-    #def validate_number(phone_number)
-    #  phone_number = phone_number.gsub(/\D/,'')
-    #  raise InvalidPhoneNumberException, "Invalid Phone Number #{phone_number}" if phone_number.length < 4 || phone_number.length > 15
-    #  return phone_number
-    #end
+    def validate_number(phone_number)
+      phone_number = phone_number.gsub(/\D/,'')
+      raise InvalidPhoneNumberException, "Invalid Phone Number #{phone_number}" if phone_number.length < 4 || phone_number.length > 15
+      return phone_number
+    end
 
     private
 
@@ -95,12 +74,7 @@ module GoogleVoice
       login unless logged_in?
       return @agent.get(url).body
     end
-  
-    # Google provides XML data for various call histories all with the same
-    # URL pattern in a getful manner. So here we're just dynamically creating
-    # methods to fetch that data in a DRY-manner. Yes, define_method is slow, 
-    # but we're already making web calls which drags performance down anyway 
-    # so it shouldn't matter in the long run.
+
     def init_xml_methods()
       (class << self; self; end).class_eval do
         %w{ unread inbox starred all spam trash voicemail sms trash recorded placed received missed }.each do |method|
@@ -108,7 +82,4 @@ module GoogleVoice
             get_xml_document("https://www.google.com/voice/inbox/recent/#{method}")
           end
         end      
-      end    
-    end
-  end
-end
+      end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: googlevoice47
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.1.10
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &78387520 !ruby/object:Gem::Requirement
+  requirement: &73845350 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *78387520
+  version_requirements: *73845350
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &78386310 !ruby/object:Gem::Requirement
+  requirement: &73844930 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *78386310
+  version_requirements: *73844930
 - !ruby/object:Gem::Dependency
   name: mechanize
-  requirement: &78385310 !ruby/object:Gem::Requirement
+  requirement: &73844470 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *78385310
+  version_requirements: *73844470
 - !ruby/object:Gem::Dependency
   name: htmlentities
-  requirement: &78383010 !ruby/object:Gem::Requirement
+  requirement: &73844150 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +54,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *78383010
+  version_requirements: *73844150
 description: Uses Mechanize to screen-scrape Google Voice since there is no public
   API
 email: