googleauth 0.6.4 → 0.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc8d4e98f777414cf7bbe922d89f8c7965aa47c2451bb257553293525d194f9c
-  data.tar.gz: 740529bdc238f8e43ae4375930f5945ab1b0e48670a58849506da63076255cfa
+  metadata.gz: 42b70d4d7a7f9a7f6260501866ff9568c0617c96930ecc5476af975c65b2927b
+  data.tar.gz: 8a4abb1767b3f2fb1257cc9dbbcf2bd47e0337c580ee01ddcbeb9cda9830b729
 SHA512:
-  metadata.gz: 6d197b21416e10d28db7c20b1a92455e810c78d566297e1fdda6c836edeab9ea4fb5d7b918ed9e06969e4335d620ae9a1dae569da6a9beb20366ab4715aed57c
-  data.tar.gz: 9f104ab9b08cf3568d668018173551142bd081fdfdc0b20f86490e4c60d41c01cf06ee85ea9478a924dc11e73f87dfeaf9668b1c230252465d72336c0dfc12e7
+  metadata.gz: 791422083e1cb0b97785d9dff1c7bff9d26d6d36154c29717e48a999611c7c6920b771f1e3febe8b4ce0479122aa3f6bdd22a421f3d19622ff21dec66971e725
+  data.tar.gz: f3da1e7b835fa67c9bc346ac69fbfdcf448ea756dae0a142be16a195e05b0c3884bbf947fa847bcb5f8d4d754db3a12b240f019288d79affa9654f272aa0e3ac

data/.travis.yml

@@ -1,11 +1,12 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4
-  - 2.3
-  - 2.2
+  - 2.5.1
+  - 2.4.4
+  - 2.3.7
+  - 2.2.10
+  - 2.1.10
   - 2.0.0
-  - 2.1
   - 1.9.3
   - rbx-2
   - jruby-9.1.9.0

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.6.5 (2018/08/16)
+
+* Fix incorrect http verb when revoking credentials.
+* Warn on EOL ruby versions.
+
 ## 0.6.4 (2018/08/03)
 
 * Resolve issue where DefaultCredentials constant was undefined.

data/README.md

@@ -10,7 +10,6 @@
 [![Gem Version](https://badge.fury.io/rb/googleauth.svg)](http://badge.fury.io/rb/googleauth)
 [![Build Status](https://secure.travis-ci.org/google/google-auth-library-ruby.svg)](http://travis-ci.org/google/google-auth-library-ruby)
 [![Coverage Status](https://coveralls.io/repos/google/google-auth-library-ruby/badge.svg)](https://coveralls.io/r/google/google-auth-library-ruby)
-[![Dependency Status](https://gemnasium.com/google/google-auth-library-ruby.svg)](https://gemnasium.com/google/google-auth-library-ruby)
 
 ## Description
 
@@ -163,6 +162,17 @@ access and refresh tokens. Two storage implementations are included:
 Custom storage implementations can also be used. See
 [token_store.rb](lib/googleauth/token_store.rb) for additional details.
 
+## Supported Ruby Versions
+
+This library is currently supported on Ruby 1.9+.
+
+However, Ruby 2.4 or later is strongly recommended, as earlier releases have
+reached or are nearing end-of-life. After March 31, 2019, Google will provide
+official support only for Ruby versions that are considered current and
+supported by Ruby Core (that is, Ruby versions that are either in normal
+maintenance or in security maintenance).
+See https://www.ruby-lang.org/en/downloads/branches/ for further details.
+
 ## License
 
 This library is licensed under Apache 2.0. Full license text is

data/lib/googleauth.rb

@@ -33,3 +33,75 @@ require 'googleauth/credentials'
 require 'googleauth/default_credentials'
 require 'googleauth/user_authorizer'
 require 'googleauth/web_user_authorizer'
+
+module Google
+  # Module Auth provides classes that provide Google-specific authorization
+  # used to access Google APIs.
+  module Auth
+    # rubocop:disable MethodDefParentheses
+
+    # On March 31, 2019, set supported version to 2.4 and recommended to 2.6.
+    # Thereafter, follow the MRI support schedule: supported means non-EOL,
+    # and recommended means in normal (rather than security) maintenance.
+    # See https://www.ruby-lang.org/en/downloads/branches/
+    ##
+    # Minimum "supported" Ruby version (non-EOL)
+    # @private
+    #
+    SUPPORTED_VERSION_THRESHOLD = '1.9'.freeze
+    ##
+    # Minimum "recommended" Ruby version (normal maintenance)
+    # @private
+    #
+    RECOMMENDED_VERSION_THRESHOLD = '2.4'.freeze
+    ##
+    # Check Ruby version and emit a warning if it is old
+    # @private
+    #
+    def self.warn_on_old_ruby_version
+      return if ENV['GOOGLE_CLOUD_SUPPRESS_RUBY_WARNINGS']
+      cur_version = Gem::Version.new RUBY_VERSION
+      if cur_version < Gem::Version.new(SUPPORTED_VERSION_THRESHOLD)
+        warn_unsupported_ruby cur_version, RECOMMENDED_VERSION_THRESHOLD
+      elsif cur_version < Gem::Version.new(RECOMMENDED_VERSION_THRESHOLD)
+        warn_nonrecommended_ruby cur_version, RECOMMENDED_VERSION_THRESHOLD
+      end
+    rescue ArgumentError
+      warn 'Unable to determine current Ruby version.'
+    end
+
+    ##
+    # Print a warning for an EOL version of Ruby
+    # @private
+    #
+    def self.warn_unsupported_ruby cur_version, recommended_version
+      warn "WARNING: You are running Ruby #{cur_version}, which has reached" \
+        ' end-of-life and is no longer supported by Ruby Core.'
+      warn 'The Google Cloud API clients work best on supported versions of' \
+        ' Ruby. It is strongly recommended that you upgrade to Ruby' \
+        " #{recommended_version} or later."
+      warn 'See https://www.ruby-lang.org/en/downloads/branches/ for more' \
+        ' info on the Ruby maintenance schedule.'
+      warn 'To suppress this message, set the' \
+        ' GOOGLE_CLOUD_SUPPRESS_RUBY_WARNINGS environment variable.'
+    end
+
+    ##
+    # Print a warning for a supported but nearing EOL version of Ruby
+    # @private
+    #
+    def self.warn_nonrecommended_ruby cur_version, recommended_version
+      warn "WARNING: You are running Ruby #{cur_version}, which is nearing" \
+        ' end-of-life.'
+      warn 'The Google Cloud API clients work best on supported versions of' \
+        " Ruby. Consider upgrading to Ruby #{recommended_version} or later."
+      warn 'See https://www.ruby-lang.org/en/downloads/branches/ for more' \
+        ' info on the Ruby maintenance schedule.'
+      warn 'To suppress this message, set the' \
+        ' GOOGLE_CLOUD_SUPPRESS_RUBY_WARNINGS environment variable.'
+    end
+    # rubocop:enable MethodDefParentheses
+  end
+end
+
+Google::Auth.warn_on_old_ruby_version

data/lib/googleauth/user_refresh.rb

@@ -94,7 +94,7 @@ module Google
         c = options[:connection] || Faraday.default_connection
 
         retry_with_error do
-          resp = c.get(REVOKE_TOKEN_URI, token: refresh_token || access_token)
+          resp = c.post(REVOKE_TOKEN_URI, token: refresh_token || access_token)
           case resp.status
           when 200
             self.access_token = nil

data/lib/googleauth/version.rb

@@ -31,6 +31,6 @@ module Google
   # Module Auth provides classes that provide Google-specific authorization
   # used to access Google APIs.
   module Auth
-    VERSION = '0.6.4'.freeze
+    VERSION = '0.6.5'.freeze
   end
 end

data/spec/googleauth/user_authorizer_spec.rb

@@ -299,17 +299,17 @@ describe Google::Auth::UserAuthorizer do
 
     before(:example) do
       token_store.store('user1', token_json)
-      stub_request(
-        :get, 'https://oauth2.googleapis.com/revoke?token=refreshtoken'
-      )
+      stub_request(:post, 'https://oauth2.googleapis.com/revoke')
+        .with(body: hash_including('token' => 'refreshtoken'))
         .to_return(status: 200)
     end
 
     it 'should revoke the grant' do
       authorizer.revoke_authorization('user1')
       expect(a_request(
-               :get, 'https://oauth2.googleapis.com/revoke?token=refreshtoken'
-      ))
+               :post, 'https://oauth2.googleapis.com/revoke'
+             ).with(body: hash_including('token' => 'refreshtoken'))
+      )
         .to have_been_made
     end
 

data/spec/googleauth/user_refresh_spec.rb

@@ -246,8 +246,8 @@ describe Google::Auth::UserRefreshCredentials do
 
   describe 'when revoking a refresh token' do
     let(:stub) do
-      stub_request(:get, 'https://oauth2.googleapis.com/revoke' \
-                         '?token=refreshtoken')
+      stub_request(:post, 'https://oauth2.googleapis.com/revoke')
+        .with(body: hash_including('token' => 'refreshtoken'))
         .to_return(status: 200,
                    headers: { 'Content-Type' => 'application/json' })
     end
@@ -262,8 +262,8 @@ describe Google::Auth::UserRefreshCredentials do
 
   describe 'when revoking an access token' do
     let(:stub) do
-      stub_request(:get, 'https://oauth2.googleapis.com/revoke' \
-                         '?token=accesstoken')
+      stub_request(:post, 'https://oauth2.googleapis.com/revoke')
+        .with(body: hash_including('token' => 'accesstoken'))
         .to_return(status: 200,
                    headers: { 'Content-Type' => 'application/json' })
     end
@@ -280,8 +280,8 @@ describe Google::Auth::UserRefreshCredentials do
 
   describe 'when revoking an invalid token' do
     let(:stub) do
-      stub_request(:get, 'https://oauth2.googleapis.com/revoke' \
-                         '?token=refreshtoken')
+      stub_request(:post, 'https://oauth2.googleapis.com/revoke')
+        .with(body: hash_including('token' => 'refreshtoken'))
         .to_return(status: 400,
                    headers: { 'Content-Type' => 'application/json' })
     end
@@ -296,14 +296,14 @@ describe Google::Auth::UserRefreshCredentials do
 
   describe 'when errors occurred with request' do
     it 'should fail with Signet::AuthorizationError if request times out' do
-      allow_any_instance_of(Faraday::Connection).to receive(:get)
+      allow_any_instance_of(Faraday::Connection).to receive(:post)
         .and_raise(Faraday::TimeoutError)
       expect { @client.revoke! }
         .to raise_error Signet::AuthorizationError
     end
 
     it 'should fail with Signet::AuthorizationError if request fails' do
-      allow_any_instance_of(Faraday::Connection).to receive(:get)
+      allow_any_instance_of(Faraday::Connection).to receive(:post)
         .and_raise(Faraday::ConnectionFailed, nil)
       expect { @client.revoke! }
         .to raise_error Signet::AuthorizationError

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: googleauth
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.5
 platform: ruby
 authors:
 - Tim Emiola
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-06 00:00:00.000000000 Z
+date: 2018-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday