googleauth 0.15.0 → 0.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b15478e865e5cfea5a21aaf18b55e6f7839c0c6a81fd127a249d414ce7f62589
-  data.tar.gz: 0a5ea3ff83f4706367b710ac200ef1936f042f8c124174c0ab5857aa435e940c
+  metadata.gz: 81e35a1b1c577067dfb5e6199a557139c4bbac47e9ab88ec65711264ac45df05
+  data.tar.gz: 8192491002f8082665a22d894f8d65485df79da746d6ec5b3a0719a65026fcaf
 SHA512:
-  metadata.gz: a096b40f4f8559d1263e9f7fd8d28742ee63199dfc5ae77c486602f14bb9f03ed1331b86e64a0afe32bcafef38bb9e26140226615ac546817e1bc8d4c96812ba
-  data.tar.gz: fefa616d20dbfb6b11b71e7869d08e470b919cce6ea991d91930f5036f2945fb652cbb6dfe83f50e93c626c953ba4d9b82483b28891abc97bbb8f4fae863013c
+  metadata.gz: 0d0b9a2b9fcd2f2805167acb8f51814077ba41643237af1005155103e1a87854f0a2c348522a93f9b7d112bd5de9fe96d6d93e608a890e1db88ea69fa8cfa4fc
+  data.tar.gz: 19b5c3c31d48427040f03865cfb6298d94eb1bed6f57a5a62a3179db1ebdf3a036742cfc8ff2af156e9ff691b4baadc6201a8678bbe23cbbdf4e08153d54414c

data/.github/workflows/release.yml

@@ -1,15 +1,18 @@
 on:
   schedule:
-    - cron: '29 9 * * 1'
+    - cron: '29 9 * * *'
   workflow_dispatch:
 
 name: release
 jobs:
   release-please:
+    env:
+      ENABLE_RELEASE_PLEASE: ${{ secrets.ENABLE_RELEASE_PLEASE }}
     runs-on: ubuntu-latest
     steps:
       - name: ReleasePlease
         id: release-please
+        if: ${{ env.ENABLE_RELEASE_PLEASE || github.event_name == 'workflow_dispatch' }}
         uses: GoogleCloudPlatform/release-please-action@v2
         with:
           command: release-pr

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Release History
 
+## [0.15.1](https://www.github.com/googleapis/google-auth-library-ruby/compare/v0.15.0...v0.15.1) (2021-02-08)
+
+
+### Bug Fixes
+
+* Fix crash when using a client credential without any paths or env_vars set ([#296](https://www.github.com/googleapis/google-auth-library-ruby/issues/296)) ([c971c1a](https://www.github.com/googleapis/google-auth-library-ruby/commit/c971c1ad2d7730c0f5b389d533a972be32fbaf49))
+
 ## [0.15.0](https://www.github.com/googleapis/google-auth-library-ruby/compare/v0.14.0...v0.15.0) (2021-01-26)
 
 

data/lib/googleauth/credentials.rb

@@ -103,7 +103,6 @@ module Google
       # Set the default token credential URI to be used when none is provided during initialization.
       #
       # @param [String] new_token_credential_uri
-      # @return [String]
       #
       def self.token_credential_uri= new_token_credential_uri
         @token_credential_uri = new_token_credential_uri
@@ -125,7 +124,6 @@ module Google
       # Sets the default target audience ID to be used when none is provided during initialization.
       #
       # @param [String] new_audience
-      # @return [String]
       #
       def self.audience= new_audience
         @audience = new_audience
@@ -140,7 +138,7 @@ module Google
       # If {#scope} is set, this credential will produce access tokens.
       # If {#target_audience} is set, this credential will produce ID tokens.
       #
-      # @return [String, Array<String>]
+      # @return [String, Array<String>, nil]
       #
       def self.scope
         lookup_auth_param :scope do
@@ -156,8 +154,7 @@ module Google
       # If {#scope} is set, this credential will produce access tokens.
       # If {#target_audience} is set, this credential will produce ID tokens.
       #
-      # @param [String, Array<String>] new_scope
-      # @return [String, Array<String>]
+      # @param [String, Array<String>, nil] new_scope
       #
       def self.scope= new_scope
         new_scope = Array new_scope unless new_scope.nil?
@@ -172,7 +169,7 @@ module Google
       # If {#scope} is set, this credential will produce access tokens.
       # If {#target_audience} is set, this credential will produce ID tokens.
       #
-      # @return [String]
+      # @return [String, nil]
       #
       def self.target_audience
         lookup_auth_param :target_audience
@@ -186,7 +183,7 @@ module Google
       # If {#scope} is set, this credential will produce access tokens.
       # If {#target_audience} is set, this credential will produce ID tokens.
       #
-      # @param [String] new_target_audience
+      # @param [String, nil] new_target_audience
       #
       def self.target_audience= new_target_audience
         @target_audience = new_target_audience
@@ -195,11 +192,20 @@ module Google
       ##
       # The environment variables to search for credentials. Values can either be a file path to the
       # credentials file, or the JSON contents of the credentials file.
+      # The env_vars will never be nil. If there are no vars, the empty array is returned.
       #
       # @return [Array<String>]
       #
       def self.env_vars
-        lookup_auth_param :env_vars do
+        env_vars_internal || []
+      end
+
+      ##
+      # @private
+      # Internal recursive lookup for env_vars.
+      #
+      def self.env_vars_internal
+        lookup_auth_param :env_vars, :env_vars_internal do
           # Pull values when PATH_ENV_VARS or JSON_ENV_VARS constants exists.
           path_env_vars = lookup_local_constant :PATH_ENV_VARS
           json_env_vars = lookup_local_constant :JSON_ENV_VARS
@@ -209,9 +215,10 @@ module Google
 
       ##
       # Sets the environment variables to search for credentials.
+      # Setting to `nil` "unsets" the value, and defaults to the superclass
+      # (or to the empty array if there is no superclass).
       #
-      # @param [Array<String>] new_env_vars
-      # @return [Array<String>]
+      # @param [String, Array<String>, nil] new_env_vars
       #
       def self.env_vars= new_env_vars
         new_env_vars = Array new_env_vars unless new_env_vars.nil?
@@ -220,11 +227,20 @@ module Google
 
       ##
       # The file paths to search for credentials files.
+      # The paths will never be nil. If there are no paths, the empty array is returned.
       #
       # @return [Array<String>]
       #
       def self.paths
-        lookup_auth_param :paths do
+        paths_internal || []
+      end
+
+      ##
+      # @private
+      # Internal recursive lookup for paths.
+      #
+      def self.paths_internal
+        lookup_auth_param :paths, :paths_internal do
           # Pull in values if the DEFAULT_PATHS constant exists.
           vals = lookup_local_constant :DEFAULT_PATHS
           vals ? Array(vals).flatten.uniq : nil
@@ -233,9 +249,10 @@ module Google
 
       ##
       # Set the file paths to search for credentials files.
+      # Setting to `nil` "unsets" the value, and defaults to the superclass
+      # (or to the empty array if there is no superclass).
       #
-      # @param [Array<String>] new_paths
-      # @return [Array<String>]
+      # @param [String, Array<String>, nil] new_paths
       #
       def self.paths= new_paths
         new_paths = Array new_paths unless new_paths.nil?
@@ -252,14 +269,15 @@ module Google
       # Otherwise, calls the superclass method if present.
       # Returns nil if all steps fail.
       #
-      # @param [Symbol] The parameter name
+      # @param name [Symbol] The parameter name
+      # @param method_name [Symbol] The lookup method name, if different
       # @return [Object] The value
       #
-      def self.lookup_auth_param name
+      def self.lookup_auth_param name, method_name = name
         val = instance_variable_get "@#{name}".to_sym
         val = yield if val.nil? && block_given?
         return val unless val.nil?
-        return superclass.send name if superclass.respond_to? name
+        return superclass.send method_name if superclass.respond_to? method_name
         nil
       end
 

data/lib/googleauth/version.rb

@@ -31,6 +31,6 @@ module Google
   # Module Auth provides classes that provide Google-specific authorization
   # used to access Google APIs.
   module Auth
-    VERSION = "0.15.0".freeze
+    VERSION = "0.15.1".freeze
   end
 end

data/spec/googleauth/credentials_spec.rb

@@ -82,6 +82,11 @@ describe Google::Auth::Credentials, :private do
     Google::Auth::Credentials.new default_keyfile_hash, scope: "http://example.com/scope"
   end
 
+  it "uses empty paths and env_vars by default" do
+    expect(Google::Auth::Credentials.paths).to eq([])
+    expect(Google::Auth::Credentials.env_vars).to eq([])
+  end
+
   describe "using CONSTANTS" do
     it "can be subclassed to pass in other env paths" do
       test_path_env_val = "/unknown/path/to/file.txt".freeze

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: googleauth
 version: !ruby/object:Gem::Version
-  version: 0.15.0
+  version: 0.15.1
 platform: ruby
 authors:
 - Tim Emiola
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-01-26 00:00:00.000000000 Z
+date: 2021-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday