google_suggest 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cda7a8c51269519a0b274daf814125cc62438dc749a969b1287befa05481282a
-  data.tar.gz: a3d5628a8ac383e32ecaa008b594e56491ba07905b799d25061ceabd3b062713
+  metadata.gz: 6a3e9bdc9fbba9c974aaef9edc750bf7e25ada054f4b4d61bce93f024092abda
+  data.tar.gz: 33ddf30287efc93bf8a52ae5e1d3db696203d88a6b2baea9a16d3d5abf13d783
 SHA512:
-  metadata.gz: 1595d5acf65ae8e05c1367dee6cd8702093e0f6de4e5d6703edd73ad9b01278a1b5e9b157e2596fb4ff72ce02b665093476fed827ede375f94e1122b57e15a89
-  data.tar.gz: cbf6177ab3bfd89da79ffd9ba50e380609b50ef48f514229073b36b51fbff91f6bf149671b4e847867424918d1d912090456a767887543199e54767972a0ae37
+  metadata.gz: 597d07a3b8abc51b26c02e16c7e14ba13a515e2a81f5358a782b2f8e5fcdc11310ef0d6b9ded2670c531e2831a47c161ab805a38ead317cdf05b86055160846e
+  data.tar.gz: b88ec7c3f0d8f42b3439a840d49b952a8824a2852277e45b00537c9a3d38c5b30de4f6e7ac491fa58d90b238cf8a560bcf7bbcbcdb361fcd40bf4af261119107

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # ChangeLog
 
-## (Next Release)
+## GoogleSuggest 1.0.3
+
+* BugFix: Failed to parse Suggest API response since encoding issue. [#29](https://github.com/satoryu/google_suggest/pull/29)
+
+## GoogleSuggest 1.0.2
 
 * Drop ruby 2.3 from supported ruby versions. [#25](https://github.com/satoryu/google_suggest/pull/25)
 * Made `Region` module since it has never been instantiated. [#26](https://github.com/satoryu/google_suggest/pull/26)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    google_suggest (1.0.2)
+    google_suggest (1.0.3)
 
 GEM
   remote: https://rubygems.org/

data/lib/google_suggest.rb

@@ -64,13 +64,10 @@ class GoogleSuggest
   end
 
   def parse(doc)
+    doc = doc.encode('UTF-8', 'Shift_JIS') unless doc.valid_encoding?
     xml = REXML::Document.new(doc)
-    suggestions = REXML::XPath.match(xml, '/toplevel/CompleteSuggestion/suggestion').each_with_object([]) do |suggest, res|
-      data = suggest.attribute('data').value
-      if data && !data.valid_encoding?
-        data.force_encoding('Shift_JIS').encode!('UTF-8')
-      end
-      res << data
+    suggestions = REXML::XPath.match(xml, '/toplevel/CompleteSuggestion/suggestion').map do |suggest|
+      suggest.attribute('data').value
     end
 
     suggestions

data/lib/google_suggest/version.rb

@@ -1,3 +1,3 @@
 class GoogleSuggest
-  VERSION = '1.0.2'.freeze
+  VERSION = '1.0.3'.freeze
 end

data/spec/google_suggest_spec.rb

@@ -99,7 +99,7 @@ describe GoogleSuggest do
     end
   end
 
-  describe '#suggest_from' do
+  describe '#suggest_for' do
     before :all do
       GoogleSuggest.configure do |c|
         c.home_language = 'us'

data/spec/sample_ja.xml

@@ -1 +1 @@
-<?xml version="1.0"?><toplevel><CompleteSuggestion><suggestion data="グーグル"/><num_queries int="13000000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルマップ"/><num_queries int="293000000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルアース"/><num_queries int="183000000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルクローム"/><num_queries int="782000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルカレンダー"/><num_queries int="9830000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグル翻訳"/><num_queries int="5140000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルショッピング"/><num_queries int="21900000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルスカラー"/><num_queries int="91600"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルメール"/><num_queries int="62700000"/></CompleteSuggestion><CompleteSuggestion><suggestion data="グーグルドキュメント"/><num_queries int="2260000"/></CompleteSuggestion></toplevel>
+<?xml version="1.0"?><toplevel><CompleteSuggestion><suggestion data="�O�[�O���}�b�v"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O��"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���|��"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���A�[�X"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���h���C�u"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���t�H�g"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���J�����_�["/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���A�J�E���g"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���A�i���e�B�N�X"/></CompleteSuggestion><CompleteSuggestion><suggestion data="�O�[�O���t�H�[��"/></CompleteSuggestion></toplevel>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google_suggest
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Tatsuya Sato
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-01 00:00:00.000000000 Z
+date: 2019-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake