google_sign_in 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e7270439ab30f7671a23b2284ca7db4d384a5f96
-  data.tar.gz: 51c1f1f402dbf464def14b68fd181e177b846fdd
+SHA256:
+  metadata.gz: 97c5ef43841bbc4901283ef218bd5bafcd321fbca2cbe51b991dce9c3943a656
+  data.tar.gz: f644ef5388eda41ae7181c68c53ce10843f8b862946305075023d3c79a91c0cd
 SHA512:
-  metadata.gz: e81ae78ed6bd5ef42ff7e81df6b09a9847ca183443a9a2e55688eea31af5d436391f85b18d46f58a4198555c212e6ef5df5469d24c195152e074c88b8948dda3
-  data.tar.gz: 5c2974784dff4008339b849c4e8f9655ddf76dda8c9ff7025f53240f90069bd29b8f7e2d35d8c5b137ceaf00522889e972717e68ccd0dfe0363fd97ca435ecc4
+  metadata.gz: 7a8116d55e09e785113aa8591a2ea3827f45bbe566413b323f3d8712a43dc84a7e21f1c0987c06b4ef5199a5ebf569d9237674ac949011e63aaad527bf725c2a
+  data.tar.gz: e4e034189b5e8307d5454a2a59a7e5c50e8ebf33813163f9eb241e9f9e4ede44e3f31364cf912a4e2992f156df4ac99de75a401a7ed8112cfbce4d7b89157215

data/README.md

@@ -73,10 +73,12 @@ the decoding of the Google ID Token using the google-id-token library. Interroga
 for profile details is particularly helpful when you use Google for signup, as you can get the name, email
 address, avatar url, and locale through it.
 
-## Outstanding work
+## Compatibility with Turbolinks
 
-- Proper testing. Need to generate a test client_id/google id token combo that we can use to test with.
-- Not much more. I'm seeking to keep this simple, just for signin/signup, not general Google integration.
+Google's JavaScript doesn't play nice with Turbolinks. We've routed around the damage by adding a [Turbolinks
+meta tag](https://github.com/turbolinks/turbolinks/blob/master/README.md#ensuring-specific-pages-trigger-a-full-reload)
+on whatever page `google_sign_in` is called to always do a full reload for that page. Note that this
+auto-compatibility feature requires Turbolinks 5.1+.
 
 ## License
 

data/google_sign_in.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = 'google_sign_in'
-  s.version  = '0.1.3'
+  s.version  = '0.1.4'
   s.authors  = 'David Heinemeier Hansson'
   s.email    = 'david@basecamp.com'
   s.summary  = 'Sign in (or up) with Google for Rails applications'

data/lib/google_sign_in/helper.rb

@@ -5,7 +5,8 @@ module GoogleSignIn
     def google_sign_in(**form_options, &block)
       content_for :head,
         google_sign_in_javacript_include_tag +
-        google_sign_in_client_id_meta_tag
+        google_sign_in_client_id_meta_tag +
+        turbolinks_reload_meta_tag
 
       google_sign_in_javascript_tag +
       google_sign_in_hidden_form_tag(**form_options) +
@@ -16,14 +17,17 @@ module GoogleSignIn
       def google_sign_in_javacript_include_tag
         javascript_include_tag "https://apis.google.com/js/api.js", async: true, defer: true,
           onload: "this.onload=function(){};setupGoogleSignIn()",
-          onreadystatechange: "if (this.readyState === 'complete') this.onload()",
-          data: { turbolinks_track: :reload, force_turbolinks_reload: Time.now.to_i }
+          onreadystatechange: "if (this.readyState === 'complete') this.onload()"
       end
 
       def google_sign_in_client_id_meta_tag
         tag.meta name: "google-signin-client_id", content: GoogleSignIn::Identity.client_id
       end
 
+      def turbolinks_reload_meta_tag
+        tag.meta name: "turbolinks-visit-control", content: "reload"
+      end
+
       def google_sign_in_hidden_form_tag(**options)
         options.reverse_merge!(html: { style: "display: none" })
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google_sign_in
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-21 00:00:00.000000000 Z
+date: 2018-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -90,7 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Sign in (or up) with Google for Rails applications