google_sign_in 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0b1d9fd3259a66f7304ba5130515d1cfda99211a
-  data.tar.gz: 3d0d4a66f812fe29aa70981e6331d9d1c0fbcebe
+  metadata.gz: e7270439ab30f7671a23b2284ca7db4d384a5f96
+  data.tar.gz: 51c1f1f402dbf464def14b68fd181e177b846fdd
 SHA512:
-  metadata.gz: 3911369b014ca6aeb902f89fd14406a99e053d2184560cd0392af98df174e1753e47bf01b73c92e34ffa22e443756d5e0479b295cedce8dbe41c4533658707d4
-  data.tar.gz: fca8d21ba6b78465353764be25ea8d2b5f2d8c4814813b785ec09684508be9ad11a5ac7149065d4d89da9fa693ad08b0e3cdc6d970ffa9acacde3d4dc5089bdc
+  metadata.gz: e81ae78ed6bd5ef42ff7e81df6b09a9847ca183443a9a2e55688eea31af5d436391f85b18d46f58a4198555c212e6ef5df5469d24c195152e074c88b8948dda3
+  data.tar.gz: 5c2974784dff4008339b849c4e8f9655ddf76dda8c9ff7025f53240f90069bd29b8f7e2d35d8c5b137ceaf00522889e972717e68ccd0dfe0363fd97ca435ecc4

data/Gemfile.lock

@@ -1,27 +1,25 @@
 PATH
   remote: .
   specs:
-    google_sign_in (0.1)
+    google_sign_in (0.1.2)
       activesupport (>= 5.1)
-      google-id-token (>= 1.3.1)
+      google-id-token (>= 1.4.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.1.1)
+    activesupport (5.1.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-    byebug (9.0.6)
+    byebug (9.1.0)
     concurrent-ruby (1.0.5)
-    google-id-token (1.3.1)
-      jwt
-      multi_json
-    i18n (0.8.1)
-    jwt (1.5.6)
-    minitest (5.10.2)
-    multi_json (1.12.1)
+    google-id-token (1.4.0)
+      jwt (>= 1)
+    i18n (0.8.6)
+    jwt (2.0.0)
+    minitest (5.10.3)
     rake (12.0.0)
     thread_safe (0.3.6)
     tzinfo (1.2.3)
@@ -37,4 +35,4 @@ DEPENDENCIES
   rake
 
 BUNDLED WITH
-   1.15.0
+   1.15.4

data/README.md

@@ -10,7 +10,7 @@ tutorial on how to setup a client id](https://developers.google.com/identity/sig
 Once you have your client id, create a `config/initializers/google_sign_in_client_id.rb` file with this:
 `GoogleSignIn::Identity.client_id = <THAT CLIENT ID YOU GOT FROM GOOGLE>`
 
-Now you can use the sign-in integration on your signup or sigin screen. 
+Now you can use the sign-in integration on your signup or signin screen.
 
 ## Example
 
@@ -73,19 +73,9 @@ the decoding of the Google ID Token using the google-id-token library. Interroga
 for profile details is particularly helpful when you use Google for signup, as you can get the name, email
 address, avatar url, and locale through it.
 
-## Unreleased gem caveat
-
-The gem google-id-token is currently behind its GitHub repository on the release schedule. The latest release
-is version 1.3.1 from 2015. So for now, you should depend on the github version in your app's Gemfile:
-
-```ruby
-gem 'google-id-token', github: 'google/google-id-token'
-```
-
 ## Outstanding work
 
 - Proper testing. Need to generate a test client_id/google id token combo that we can use to test with.
-- Cajole Google to release a new version of the google-id-token so caveat can be removed.
 - Not much more. I'm seeking to keep this simple, just for signin/signup, not general Google integration.
 
 ## License

data/google_sign_in.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name     = 'google_sign_in'
-  s.version  = '0.1.2'
+  s.version  = '0.1.3'
   s.authors  = 'David Heinemeier Hansson'
   s.email    = 'david@basecamp.com'
   s.summary  = 'Sign in (or up) with Google for Rails applications'
@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 1.9.3'
 
   s.add_dependency 'activesupport', '>= 5.1'
-  s.add_dependency 'google-id-token', '>= 1.3.1'
+  s.add_dependency 'google-id-token', '>= 1.4.0'
 
   s.add_development_dependency 'bundler', '~> 1.15'
 

data/lib/google_sign_in/helper.rb

@@ -2,13 +2,13 @@ require 'google_sign_in/identity'
 
 module GoogleSignIn
   module Helper
-    def google_sign_in(url:, &block)
+    def google_sign_in(**form_options, &block)
       content_for :head,
         google_sign_in_javacript_include_tag +
         google_sign_in_client_id_meta_tag
 
       google_sign_in_javascript_tag +
-      google_sign_in_hidden_form_tag(url: url) +
+      google_sign_in_hidden_form_tag(**form_options) +
       google_sign_in_click_handler(&block)
     end
 
@@ -24,8 +24,10 @@ module GoogleSignIn
         tag.meta name: "google-signin-client_id", content: GoogleSignIn::Identity.client_id
       end
 
-      def google_sign_in_hidden_form_tag(url:)
-        form_with url: url, html: { style: "display: none" } do |form|
+      def google_sign_in_hidden_form_tag(**options)
+        options.reverse_merge!(html: { style: "display: none" })
+
+        form_with(**options) do |form|
           form.hidden_field(:google_id_token, id: "google_sign_in_token") + form.submit(id: "google_sign_in_submit")
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google_sign_in
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-31 00:00:00.000000000 Z
+date: 2017-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.3.1
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -90,7 +90,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Sign in (or up) with Google for Rails applications