google_places 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8439d196c5b207a51f79c1c53b4a8fd91439ce54
-  data.tar.gz: 1392714187eb2667d7ecc157e494c04785270140
+  metadata.gz: a7c7601aa9e3d41a1d901e95f3d6d8ff3537196b
+  data.tar.gz: 513249ec18cfb927b8cf8d48c8656a187168fbb5
 SHA512:
-  metadata.gz: 42af9c2cb49adc5c1cba215d780926ef9b718f32c4c9a3ed70e861e1ca0a0ce6619a7f890dd718286c04f7459b5deccc2ced819ac340c85c50693df8998b5511
-  data.tar.gz: 9c9b957daec2c8dc210cbb9f5945377cde979bc9e16a1ef6c765c31e4bd0a5251c1a14ffd0ffbd6bf9b0d63057b246c69fb019efa22b1b8a4ea0e9cbe31f0891
+  metadata.gz: 0d7104e3321af46c15e18a1f54159ea7b54154db044fd54e1772ba7e341b85d9fa565d16dfa55e5e452c77e0056ce3a2d5f422955608f5a1cc72bdb7dc639502
+  data.tar.gz: c85de97b1526db8d96c84b97a79a4ab3f60ad893b7987f6ce4cbb6a35a2d5c9cbc86287bf65fdefd0f3ca479891bdc8198454c282dc703e380d33694e31eb1b9

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 1.1.0
+
+- Include the profile_photo_url attribute for the GooglePlaces::Review object
+- Gracefully handle HTTP 500 errors from the Google API
+
 ## 1.0.0
 
 - Upgraded httparty 0.14.0 -> 0.15.6

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    google_places (1.0.0)
+    google_places (1.1.0)
       httparty (>= 0.13.1)
 
 GEM

data/google_places.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path('../lib', __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = 'google_places'
-  s.version     = '1.0.0'
+  s.version     = '1.1.0'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ['Marcel de Graaf']
   s.email       = ['mail@marceldegraaf.net']

data/lib/google_places/error.rb

@@ -34,4 +34,12 @@ module GooglePlaces
 
   class NotFoundError < HTTParty::ResponseError
   end
+
+  # Thrown when the server returns any 5xx error
+  #
+  # This can be the case when:
+  # - There is a network problem between this gem and Google's API servers
+  # - Google's API is broken
+  class APIConnectionError < HTTParty::ResponseError
+  end
 end

data/lib/google_places/request.rb

@@ -347,7 +347,8 @@ module GooglePlaces
     # @raise [NotFoundError] when server response object includes 'NOT_FOUND'
     # @return [String] the response from the server as JSON
     def parsed_response
-      return @response.headers["location"] if @response.code >= 300 and @response.code < 400
+      return @response.headers["location"] if @response.code >= 300 && @response.code < 400
+      raise APIConnectionError.new(@response) if @response.code >= 500 && @response.code < 600
       case @response.parsed_response['status']
       when 'OK', 'ZERO_RESULTS'
         @response.parsed_response
@@ -363,6 +364,5 @@ module GooglePlaces
         raise NotFoundError.new(@response)
       end
     end
-
   end
 end

data/lib/google_places/review.rb

@@ -1,14 +1,15 @@
 module GooglePlaces
   class Review
-    attr_accessor :rating, :type, :author_name, :author_url, :text, :time
+    attr_accessor :rating, :type, :author_name, :author_url, :text, :time, :profile_photo_url
 
-    def initialize(rating, type, author_name, author_url, text, time)
-      @rating       = rating
-      @type         = type
-      @author_name  = author_name
-      @author_url   = author_url
-      @text         = text
-      @time         = time
+    def initialize(rating, type, author_name, author_url, text, time, profile_photo_url)
+      @rating            = rating
+      @type              = type
+      @author_name       = author_name
+      @author_url        = author_url
+      @text              = text
+      @time              = time
+      @profile_photo_url = profile_photo_url
     end
   end
 end

data/lib/google_places/spot.rb

@@ -467,7 +467,8 @@ module GooglePlaces
               r['author_name'],
               r['author_url'],
               r['text'],
-              r['time'].to_i
+              r['time'].to_i,
+              r['profile_photo_url']
           )
         }
       else []

data/spec/google_places/request_spec.rb

@@ -291,4 +291,16 @@ describe GooglePlaces::Request do
     end
   end
 
+  context 'with an HTTP 502 response', vcr: { cassette_name: 'http_502' } do
+    it 'correctly handles the exception' do
+      stub_const("GooglePlaces::Request::DETAILS_URL", 'http://httpstat.us/502')
+
+      expect(lambda {
+        GooglePlaces::Request.spot(
+          :reference => @reference,
+          :key => api_key
+        )
+      }).to raise_error GooglePlaces::APIConnectionError
+    end
+  end
 end

data/spec/vcr_cassettes/http_502.yml

@@ -0,0 +1,46 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: http://httpstat.us/502?key=AIzaSyAKeN0XMV5LqJmqBrZZ1K8qMipFW7-Eybg&reference=CnRsAAAASc4grenwL0h3X5VPNp5fkDNfqbjt3iQtWIPlKS-3ms9GbnCxR_FLHO0B0ZKCgJSg19qymkeHagjQFB4aUL87yhp4mhFTc17DopK1oiYDaeGthztSjERic8TmFNe-6zOpKSdiZWKE6xlQvcbSiWIJchIQOEYZqunSSZqNDoBSs77bWRoUJcMMVANtSlhy0llKI0MI6VcC7DU
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 502
+      message: Bad Gateway
+    headers:
+      Cache-Control:
+      - private
+      Content-Length:
+      - '15'
+      Content-Type:
+      - text/plain; charset=utf-8
+      Server:
+      - Microsoft-IIS/8.0
+      X-Aspnetmvc-Version:
+      - '5.1'
+      Access-Control-Allow-Origin:
+      - "*"
+      X-Aspnet-Version:
+      - 4.0.30319
+      X-Powered-By:
+      - ASP.NET
+      Set-Cookie:
+      - ARRAffinity=5f087fd6a40a6d05f0b0eb568d99070a0e7b27a443c43c64047aae88fa2e0bea;Path=/;HttpOnly;Domain=httpstat.us
+      Date:
+      - Tue, 07 Nov 2017 10:30:02 GMT
+    body:
+      encoding: UTF-8
+      string: 502 Bad Gateway
+    http_version: 
+  recorded_at: Tue, 07 Nov 2017 10:30:03 GMT
+recorded_with: VCR 2.9.3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google_places
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Marcel de Graaf
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-17 00:00:00.000000000 Z
+date: 2018-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -119,6 +119,7 @@ files:
 - spec/google_places/spot_spec.rb
 - spec/spec_helper.rb
 - spec/vcr_cassettes/GooglePlaces_Spot/List_spots_options/should_not_set_radius_to_nil_if_rankby_is_set_to_prominence.yml
+- spec/vcr_cassettes/http_502.yml
 - spec/vcr_cassettes/list_predictions.yml
 - spec/vcr_cassettes/list_spots.yml
 - spec/vcr_cassettes/list_spots_by_radar.yml
@@ -168,6 +169,7 @@ test_files:
 - spec/google_places/spot_spec.rb
 - spec/spec_helper.rb
 - spec/vcr_cassettes/GooglePlaces_Spot/List_spots_options/should_not_set_radius_to_nil_if_rankby_is_set_to_prominence.yml
+- spec/vcr_cassettes/http_502.yml
 - spec/vcr_cassettes/list_predictions.yml
 - spec/vcr_cassettes/list_spots.yml
 - spec/vcr_cassettes/list_spots_by_radar.yml