google_maps_geocoder 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c568a9b578691865efa5fb3e960924c1d26eb1c6f041f6586897b56fb789ffd
-  data.tar.gz: 88b05d3af710f1de4fda1377769f69d8f9b0d65a993ec4890dc5ee24998f2d7f
+  metadata.gz: a1b75a6d688d7ae2c78598419106c233c97b4e3d3670de878f91cdba8c12d920
+  data.tar.gz: 3df70e06f88e78962ca11daf667c2e03057de045883534d8c80eb52cc4119edd
 SHA512:
-  metadata.gz: 688f7c22172faa20e5108120a680130a30accbf78a2597e0b2f4af2886e45af917d4c3358f115d7af9a073fea6f01e3e0e3e9cbc7172810ada348ca33597ffa6
-  data.tar.gz: 206170d5705a87acd41d58a00e230962437d0369fc08ca7b29bb8e26eee09789a71b6ca21eb77dd20302338ed96e052dc271faeaa98090a58d4c4ee063f4ffc0
+  metadata.gz: 204f47f4a4b6ee052e21c2f8fb16664dfb0cd7ea69e65b52522842cd0514d68c452209ca17e0a639c7f1acdb2bf817346a700eee6a3667457cd7ab4c047379e9
+  data.tar.gz: e2d04e07a9d445f9795a7226be2327b0a29921923ca1471b8cdfa74b1436aca4db9a68315198d3dd228c87c62148e1eeb4d5983197bc8bfbff135dd6be4abd19

data/.github/FUNDING.yml

@@ -0,0 +1,14 @@
+# These are supported funding model platforms
+
+github: ivanoblomov
+patreon: # Replace with a single Patreon username
+open_collective: # Replace with a single Open Collective username
+ko_fi: # Replace with a single Ko-fi username
+tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
+community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
+liberapay: # Replace with a single Liberapay username
+issuehunt: # Replace with a single IssueHunt username
+lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
+polar: # Replace with a single Polar username
+buy_me_a_coffee: oblomov
+custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']

data/.rubocop.yml

@@ -0,0 +1,7 @@
+require:
+  - rubocop-performance
+  - rubocop-rake
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable

data/Gemfile

@@ -5,10 +5,11 @@ gemspec
 
 gem 'inch', '~> 0.8'
 gem 'pry', '~> 0.14.1'
-gem 'rake', ['>= 12.3.3', '~> 13.0']
+gem 'rake', '~> 13'
 gem 'rspec', '~> 3'
-gem 'rubocop', '< 1.63'
-gem 'rubocop-rake', '~> 0'
-gem 'rubocop-rspec', '~> 2'
+gem 'rubocop', '< 1.68'
+gem 'rubocop-performance', require: false
+gem 'rubocop-rake', require: false
+gem 'rubocop-rspec', require: false
 gem 'simplecov', '~> 0.18'
 gem 'simplecov-lcov', '~> 0.8'

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2011-2022 Roderick Monje
+Copyright (c) 2011-2024 Roderick Monje
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -108,10 +108,6 @@ Complete RDoc documentation is available at [RubyDoc.info](https://www.rubydoc.i
 
 ## [Contributing to GoogleMapsGeocoder](.github/CONTRIBUTING.md)
 
-## Cheers!
-
-<a href="https://www.buymeacoffee.com/oblomov" target="_blank"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-green.png" alt="Buy Me A Coffee" height="41" width="174" ></a>
-
 ## Copyright
 
 Copyright © 2011-2024 Roderick Monje. See [LICENSE.txt](LICENSE.txt) for further details.

data/SECURITY.md

@@ -6,8 +6,8 @@
 
 | Version | Supported          |
 | ------- | ------------------ |
-| 1.0.0   | :white_check_mark: |
-| < 1.0.0 | :x:                |
+| 1.0.1   | :white_check_mark: |
+| < 1.0.1 | :x:                |
 
 ## Reporting a Vulnerability
 

data/google_maps_geocoder.gemspec

@@ -6,18 +6,19 @@ Gem::Specification.new do |s|
   s.version = GoogleMapsGeocoder::VERSION.dup
   s.licenses = ['MIT']
   s.summary = 'A simple PORO wrapper for geocoding with Google Maps.'
-  s.description = 'Geocode a location without worrying about parsing Google '\
-                  "Maps' response. GoogleMapsGeocoder wraps it in a plain-old "\
+  s.description = 'Geocode a location without worrying about parsing Google ' \
+                  "Maps' response. GoogleMapsGeocoder wraps it in a plain-old " \
                   'Ruby object.'
   s.homepage = 'https://github.com/FoveaCentral/google_maps_geocoder'
   s.authors = ['Roderick Monje']
   s.cert_chain = ['certs/ivanoblomov.pem']
   s.email = 'rod@foveacentral.com'
-  s.signing_key = File.expand_path('~/.ssh/gem-private_key.pem') if $PROGRAM_NAME =~ /gem\z/
+  s.signing_key = File.expand_path('~/.ssh/gem-private_key.pem') if $PROGRAM_NAME.end_with?('gem')
 
-  s.add_runtime_dependency 'rack', '>= 2.1.4', '< 3.1.0'
+  s.add_dependency 'rack', '>= 2.1.4', '< 3.2.0'
 
   s.files = `git ls-files`.split "\n"
   s.require_paths = ['lib']
   s.required_ruby_version = '>= 3.0'
+  s.metadata['rubygems_mfa_required'] = 'true'
 end

data/lib/google_maps_geocoder/google_maps_geocoder.rb

@@ -128,15 +128,15 @@ class GoogleMapsGeocoder
       if (message = @json['error_message'])
         Logger.new($stderr).error(message)
       end
-      super @json
+      super(@json)
     end
   end
 
   private
 
   def google_maps_request(address)
-    "#{GOOGLE_MAPS_API}?address=#{Rack::Utils.escape address}"\
-    "&key=#{ENV['GOOGLE_MAPS_API_KEY']}"
+    "#{GOOGLE_MAPS_API}?address=#{Rack::Utils.escape address}" \
+      "&key=#{ENV.fetch('GOOGLE_MAPS_API_KEY', nil)}"
   end
 
   def google_maps_response(address)
@@ -181,8 +181,8 @@ class GoogleMapsGeocoder
   end
 
   def parse_formatted_street_address
-    "#{parse_address_component_type('street_number')} "\
-    "#{parse_address_component_type('route')}"
+    "#{parse_address_component_type('street_number')} " \
+      "#{parse_address_component_type('route')}"
   end
 
   def parse_lat
@@ -207,7 +207,7 @@ class GoogleMapsGeocoder
 
   def set_attributes_from_json
     ALL_ADDRESS_SEGMENTS.each do |segment|
-      instance_variable_set :"@#{segment}", send("parse_#{segment}")
+      instance_variable_set :"@#{segment}", send(:"parse_#{segment}")
     end
   end
 end

data/lib/google_maps_geocoder/version.rb

@@ -3,5 +3,5 @@
 # A simple PORO wrapper for geocoding with Google Maps.
 class GoogleMapsGeocoder
   # This gem's version.
-  VERSION = '1.0.0' unless defined?(GoogleMapsGeocoder::VERSION)
+  VERSION = '1.0.1' unless defined?(GoogleMapsGeocoder::VERSION)
 end

data/spec/lib/google_maps_geocoder_spec.rb

@@ -6,68 +6,113 @@ require "#{File.dirname(__FILE__)}/../spec_helper"
 # rubocop:disable Metrics/BlockLength
 RSpec.describe GoogleMapsGeocoder do
   describe '#new' do
-    context 'with "White House"' do
-      subject(:geocoder) do
-        GoogleMapsGeocoder.new('White House')
-      rescue SocketError
-        pending 'waiting for a network connection'
-      rescue GoogleMapsGeocoder::GeocodingError => e
-        raise if e.json['status'] == 'REQUEST_DENIED'
+    context 'when API key is valid' do
+      # rubocop:disable RSpec/NestedGroups
+      context 'with "White House"' do
+        subject(:geocoder) do
+          described_class.new('White House')
+        rescue SocketError
+          pending 'waiting for a network connection'
+        rescue GoogleMapsGeocoder::GeocodingError => e
+          raise if e.json['status'] == 'REQUEST_DENIED'
 
-        pending 'waiting for query limit to pass'
-      end
+          pending 'waiting for query limit to pass'
+        end
 
-      it { should be_partial_match }
-      it { should_not be_exact_match }
+        it { is_expected.to be_partial_match }
+        it { is_expected.not_to be_exact_match }
 
-      context 'address' do
-        it do
-          expect(geocoder.formatted_street_address)
-            .to eq '1600 Pennsylvania Avenue Northwest'
+        describe '#formatted_street_address' do
+          it { expect(geocoder.formatted_street_address).to eq '1600 Pennsylvania Avenue Northwest' }
         end
-        it { expect(geocoder.city).to eq 'Washington' }
-        it { expect(geocoder.state_long_name).to eq 'District of Columbia' }
-        it { expect(geocoder.state_short_name).to eq 'DC' }
-        it { expect(geocoder.postal_code).to eq '20500' }
-        it { expect(geocoder.country_short_name).to eq 'US' }
-        it { expect(geocoder.country_long_name).to eq 'United States' }
-        it do
-          expect(geocoder.formatted_address)
-            .to match(/1600 Pennsylvania Avenue NW, Washington, DC 20500, USA/)
+
+        describe '#city' do
+          it { expect(geocoder.city).to eq 'Washington' }
         end
-      end
 
-      context 'coordinates' do
-        it { expect(geocoder.lat).to be_within(0.005).of(38.8976633) }
-        it { expect(geocoder.lng).to be_within(0.005).of(-77.0365739) }
-      end
+        describe '#state_long_name' do
+          it { expect(geocoder.state_long_name).to eq 'District of Columbia' }
+        end
+
+        describe '#state_short_name' do
+          it { expect(geocoder.state_short_name).to eq 'DC' }
+        end
+
+        describe '#postal_code' do
+          it { expect(geocoder.postal_code).to eq '20500' }
+        end
+
+        describe '#country_short_name' do
+          it { expect(geocoder.country_short_name).to eq 'US' }
+        end
+
+        describe '#country_long_name' do
+          it { expect(geocoder.country_long_name).to eq 'United States' }
+        end
+
+        describe '#formatted_address' do
+          it { expect(geocoder.formatted_address).to match(/1600 Pennsylvania Avenue NW, Washington, DC 20500, USA/) }
+        end
+
+        describe '#lat' do
+          it { expect(geocoder.lat).to be_within(0.005).of(38.8976633) }
+        end
 
-      context 'Geocoder API' do
-        it { expect(geocoder.address).to eq subject.formatted_address }
-        it { expect(geocoder.coordinates).to eq [subject.lat, subject.lng] }
-        it { expect(geocoder.country).to eq subject.country_long_name }
-        it { expect(geocoder.country_code).to eq subject.country_short_name }
-        it { expect(geocoder.latitude).to eq subject.lat }
-        it { expect(geocoder.longitude).to eq subject.lng }
-        it { expect(geocoder.state).to eq subject.state_long_name }
-        it { expect(geocoder.state_code).to eq subject.state_short_name }
+        describe '#lng' do
+          it { expect(geocoder.lng).to be_within(0.005).of(-77.0365739) }
+        end
+
+        context 'when using Geocoder API' do
+          describe '#address' do
+            it { expect(geocoder.address).to eq geocoder.formatted_address }
+          end
+
+          describe '#coordinates' do
+            it { expect(geocoder.coordinates).to eq [geocoder.lat, geocoder.lng] }
+          end
+
+          describe '#country' do
+            it { expect(geocoder.country).to eq geocoder.country_long_name }
+          end
+
+          describe '#country_code' do
+            it { expect(geocoder.country_code).to eq geocoder.country_short_name }
+          end
+
+          describe '#latitude' do
+            it { expect(geocoder.latitude).to eq geocoder.lat }
+          end
+
+          describe '#longitude' do
+            it { expect(geocoder.longitude).to eq geocoder.lng }
+          end
+
+          describe '#state' do
+            it { expect(geocoder.state).to eq geocoder.state_long_name }
+          end
+
+          describe '#state_code' do
+            it { expect(geocoder.state_code).to eq geocoder.state_short_name }
+          end
+        end
       end
+      # rubocop:enable RSpec/NestedGroups
     end
 
     context 'when API key is invalid' do
+      subject(:geocoder) do
+        described_class.new('nowhere that comes to mind')
+      rescue SocketError
+        pending 'waiting for a network connection'
+      end
+
       around do |example|
-        original_key = ENV['GOOGLE_MAPS_API_KEY']
+        original_key = ENV.fetch('GOOGLE_MAPS_API_KEY', nil)
         ENV['GOOGLE_MAPS_API_KEY'] = 'invalid_key'
         example.run
         ENV['GOOGLE_MAPS_API_KEY'] = original_key
       end
 
-      subject(:geocoder) do
-        GoogleMapsGeocoder.new('nowhere that comes to mind')
-      rescue SocketError
-        pending 'waiting for a network connection'
-      end
-
       it { expect { geocoder }.to raise_error GoogleMapsGeocoder::GeocodingError }
     end
   end

data/spec/spec_helper.rb

@@ -16,12 +16,12 @@ $LOAD_PATH.unshift(File.dirname(__FILE__))
 require 'google_maps_geocoder/google_maps_geocoder'
 # silence output
 RSpec.configure do |config|
-  config.before(:example) do
+  config.before do
     quiet_logger = Logger.new(IO::NULL)
     allow(Logger).to receive(:new).and_return(quiet_logger)
   end
 
-  config.after(:example) do
+  config.after do
     allow(Logger).to receive(:new).and_call_original
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google_maps_geocoder
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Roderick Monje
@@ -35,7 +35,7 @@ cert_chain:
   UNicoJ8NJMgduyTPvZBJtvUPddQr1yAL66/l+CFewbGb/1DbqfSvA2atfUobhDrG
   zYKOF/ofPEZhX7sqLK5GzDW4x1QDHAgr1YIdttVxhHADOxF4EVSJCHH0RGw=
   -----END CERTIFICATE-----
-date: 2024-03-29 00:00:00.000000000 Z
+date: 2024-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -46,7 +46,7 @@ dependencies:
         version: 2.1.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -56,7 +56,7 @@ dependencies:
         version: 2.1.4
     - - "<"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.2.0
 description: Geocode a location without worrying about parsing Google Maps' response.
   GoogleMapsGeocoder wraps it in a plain-old Ruby object.
 email: rod@foveacentral.com
@@ -66,6 +66,7 @@ extra_rdoc_files: []
 files:
 - ".document"
 - ".github/CONTRIBUTING.md"
+- ".github/FUNDING.yml"
 - ".github/ISSUE_TEMPLATE/bug-report.md"
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/ISSUE_TEMPLATE/task.md"
@@ -73,6 +74,7 @@ files:
 - ".github/dependabot.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
+- ".rubocop.yml"
 - ".simplecov"
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -89,7 +91,8 @@ files:
 homepage: https://github.com/FoveaCentral/google_maps_geocoder
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []
 require_paths: