google_maps 0.3.0 → 0.3.1

data/VERSION

@@ -1 +1,2 @@
-0.3.0
+0.3.1
+

data/google_maps.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "google_maps"
-  s.version = "0.3.0"
+  s.version = "0.3.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Tushar Ranka"]
-  s.date = "2012-05-30"
+  s.date = "2013-05-22"
   s.description = "General Purpose Library to interact with Google Maps v3 api. Geocoder. "
   s.email = "tusharranka@gmail.com"
   s.extra_rdoc_files = [
@@ -37,7 +37,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/appfolio/geocode"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.12"
+  s.rubygems_version = "1.8.25"
   s.summary = "Gem to interact with Google Maps v3 API"
 
   if s.respond_to? :specification_version then

data/lib/google_maps/geocoder/location.rb

@@ -30,12 +30,11 @@ module GoogleMaps
       ]
 
       ACCURATE_TYPES      = [ "street_address", "premise", "subpremise" ]
-      
-      
 
-      attr_accessor :formatted_address, :location_type, :latitude, :longitude, :types
+      attr_accessor :formatted_address, :location_type, :latitude, :longitude, :types, :address_components
 
       def initialize(json)
+        self.address_components = json['address_components']
         self.formatted_address = json['formatted_address']
         if geometry_json = json['geometry']
           self.location_type = ActiveSupport::StringInquirer.new(geometry_json['location_type'].downcase)
@@ -45,15 +44,38 @@ module GoogleMaps
             self.longitude = BigDecimal(geometry_json['location']['lng'].to_s)
           end
         end
-
-        self.types         = json['types']
+        self.types = json['types']
       end
 
-
       def street_address?
         (ACCURATE_TYPES & self.types).present?
       end
 
+      def method_missing(method_sym, *args, &block)
+        if TYPES.include?(method_sym.to_s)
+          define_address_component_accessor_for_type(method_sym)
+          send(method_sym, args.first)
+        else
+          super
+        end
+      end
+
+      def respond_to?(method_sym, include_private = false)
+        TYPES.include?(method_sym.to_s) || super
+      end
+
+    private
+
+      def define_address_component_accessor_for_type(type_symbol)
+        class_eval %Q{
+          def #{type_symbol}(arg=nil)
+            component = address_components.select { |ac| ac['types'].include?('#{type_symbol.to_s}') }.first
+            return nil if component.blank?
+            (arg.to_s == 'short') ? component['short_name'] : component['long_name']
+          end
+        }
+      end
+
     end
   end
 end

data/test/google_maps/geocoder_test.rb

@@ -44,6 +44,63 @@ class GoogleMaps::GeocoderTest < ActiveSupport::TestCase
     assert manhattan_ny.location_type.approximate?
     assert_equal ["sublocality", "political"], manhattan_ny.types
   end
+
+  def test_all_encompassing_json
+    GoogleMaps::Geocoder.expects(:url).with(:address => "80 Leonard Street, New York, NY 10013", :ssl => false, :sensor => false).returns(:url)
+
+    RestClient.expects(:get).with(:url).returns(all_encompassing_json)
+    results = GoogleMaps::Geocoder.locate!("80 Leonard Street, New York, NY 10013")
+
+    assert results.status.ok?
+
+    result = results.first
+    assert_equal "80", result.street_number
+    assert_equal "Leonard Street", result.route
+    assert_equal "Lower Manhattan", result.neighborhood
+    assert_equal "Manhattan", result.sublocality
+    assert_equal "New York", result.locality
+    assert_equal "New York", result.administrative_area_level_1
+    assert_equal "New York", result.administrative_area_level_2
+    assert_equal "New York", result.administrative_area_level_3
+    assert_equal "United States", result.country
+    assert_equal "10013", result.postal_code
+    assert_equal "Premise Long", result.premise
+    assert_equal "Subpremise Long", result.subpremise
+    assert_equal "Pretty Mountain Long", result.natural_feature
+    assert_equal "La Guardia", result.airport
+    assert_equal "Central Park", result.park
+    assert_equal "Statue of Liberty", result.point_of_interest
+    assert_equal "272510 Long", result.post_box
+    assert_equal "13.5", result.floor
+    assert_equal nil, result.room
+
+    assert_equal "80", result.street_number(:short)
+    assert_equal "Leonard St", result.route(:short)
+    assert_equal "Lower Manhattan", result.neighborhood(:short)
+    assert_equal "Manhattan", result.sublocality(:short)
+    assert_equal "New York", result.locality(:short)
+    assert_equal "NY", result.administrative_area_level_1(:short)
+    assert_equal "New York", result.administrative_area_level_2(:short)
+    assert_equal "New York", result.administrative_area_level_3(:short)
+    assert_equal "US", result.country(:short)
+    assert_equal "10013", result.postal_code(:short)
+    assert_equal "Premise Short", result.premise(:short)
+    assert_equal "Subpremise Short", result.subpremise(:short)
+    assert_equal "Pretty Mountain Short", result.natural_feature(:short)
+    assert_equal "La Guardia", result.airport(:short)
+    assert_equal "Central Park", result.park(:short)
+    assert_equal "Statue of Liberty", result.point_of_interest(:short)
+    assert_equal "272510 Short", result.post_box(:short)
+    assert_equal "13.5", result.floor(:short)
+    assert_equal nil, result.room(:short)
+
+    assert result.respond_to?(:street_number)
+    assert result.respond_to?(:street_address?)
+
+    assert_raise NoMethodError do
+      result.this_field_is_not_present_in_address_components
+    end
+  end
   
   def test_locate__error
     error = StandardError.new("there was an error doing that")

data/test/test_helper.rb

@@ -34,4 +34,8 @@ class ActiveSupport::TestCase
     "{\n   \"results\" : [\n      {\n         \"address_components\" : [\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"New York\",\n               \"types\" : [ \"locality\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"New York\",\n               \"types\" : [ \"administrative_area_level_2\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"NY\",\n               \"types\" : [ \"administrative_area_level_1\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"United States\",\n               \"short_name\" : \"US\",\n               \"types\" : [ \"country\", \"political\" ]\n            }\n         ],\n         \"formatted_address\" : \"New York, NY, USA\",\n         \"geometry\" : {\n            \"bounds\" : {\n               \"northeast\" : {\n                  \"lat\" : 40.91524130,\n                  \"lng\" : -73.7002720\n               },\n               \"southwest\" : {\n                  \"lat\" : 40.4959080,\n                  \"lng\" : -74.25908790\n               }\n            },\n            \"location\" : {\n               \"lat\" : 40.71435280,\n               \"lng\" : -74.00597309999999\n            },\n            \"location_type\" : \"APPROXIMATE\",\n            \"viewport\" : {\n               \"northeast\" : {\n                  \"lat\" : 40.84953420,\n                  \"lng\" : -73.74985430\n               },\n               \"southwest\" : {\n                  \"lat\" : 40.57889640,\n                  \"lng\" : -74.26209190\n               }\n            }\n         },\n         \"types\" : [ \"locality\", \"political\" ]\n      },\n      {\n         \"address_components\" : [\n            {\n               \"long_name\" : \"Manhattan\",\n               \"short_name\" : \"Manhattan\",\n               \"types\" : [ \"sublocality\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"New York\",\n               \"types\" : [ \"locality\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"New York\",\n               \"types\" : [ \"administrative_area_level_2\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"NY\",\n               \"types\" : [ \"administrative_area_level_1\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"United States\",\n               \"short_name\" : \"US\",\n               \"types\" : [ \"country\", \"political\" ]\n            }\n         ],\n         \"formatted_address\" : \"Manhattan, New York, NY, USA\",\n         \"geometry\" : {\n            \"bounds\" : {\n               \"northeast\" : {\n                  \"lat\" : 40.8822140,\n                  \"lng\" : -73.9070\n               },\n               \"southwest\" : {\n                  \"lat\" : 40.67954790,\n                  \"lng\" : -74.0472850\n               }\n            },\n            \"location\" : {\n               \"lat\" : 40.78343450,\n               \"lng\" : -73.96624950\n            },\n            \"location_type\" : \"APPROXIMATE\",\n            \"viewport\" : {\n               \"northeast\" : {\n                  \"lat\" : 40.8200450,\n                  \"lng\" : -73.90331300000001\n               },\n               \"southwest\" : {\n                  \"lat\" : 40.6980780,\n                  \"lng\" : -74.03514899999999\n               }\n            }\n         },\n         \"types\" : [ \"sublocality\", \"political\" ]\n      }\n   ],\n   \"status\" : \"OK\"\n}\n"
   end
 
+  def all_encompassing_json
+    "{\n   \"results\" : [\n      {\n         \"address_components\" : [\n            {\n               \"long_name\" : \"80\",\n               \"short_name\" : \"80\",\n               \"types\" : [ \"street_number\" ]\n            },\n            {\n               \"long_name\" : \"Leonard Street\",\n               \"short_name\" : \"Leonard St\",\n               \"types\" : [ \"route\" ]\n            },\n            {\n               \"long_name\" : \"Lower Manhattan\",\n               \"short_name\" : \"Lower Manhattan\",\n               \"types\" : [ \"neighborhood\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"Manhattan\",\n               \"short_name\" : \"Manhattan\",\n               \"types\" : [ \"sublocality\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"New York\",\n               \"types\" : [ \"locality\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"New York\",\n               \"types\" : [ \"administrative_area_level_3\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"New York\",\n               \"types\" : [ \"administrative_area_level_2\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"New York\",\n               \"short_name\" : \"NY\",\n               \"types\" : [ \"administrative_area_level_1\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"United States\",\n               \"short_name\" : \"US\",\n               \"types\" : [ \"country\", \"political\" ]\n            },\n            {\n               \"long_name\" : \"10013\",\n               \"short_name\" : \"10013\",\n               \"types\" : [ \"postal_code\" ]\n            },\n            {\n               \"long_name\" : \"Premise Long\",\n               \"short_name\" : \"Premise Short\",\n               \"types\" : [ \"premise\" ]\n            },\n            {\n               \"long_name\" : \"Subpremise Long\",\n               \"short_name\" : \"Subpremise Short\",\n               \"types\" : [ \"subpremise\" ]\n            },\n            {\n               \"long_name\" : \"Pretty Mountain Long\",\n               \"short_name\" : \"Pretty Mountain Short\",\n               \"types\" : [ \"natural_feature\" ]\n            },\n            {\n               \"long_name\" : \"La Guardia\",\n               \"short_name\" : \"La Guardia\",\n               \"types\" : [ \"airport\" ]\n            },\n            {\n               \"long_name\" : \"Central Park\",\n               \"short_name\" : \"Central Park\",\n               \"types\" : [ \"park\" ]\n            },\n            {\n               \"long_name\" : \"Statue of Liberty\",\n               \"short_name\" : \"Statue of Liberty\",\n               \"types\" : [ \"point_of_interest\" ]\n            },\n            {\n               \"long_name\" : \"272510 Long\",\n               \"short_name\" : \"272510 Short\",\n               \"types\" : [ \"post_box\" ]\n            },\n            {\n               \"long_name\" : \"13.5\",\n               \"short_name\" : \"13.5\",\n               \"types\" : [ \"floor\" ]\n            }\n         ],\n         \"formatted_address\" : \"80 Leonard Street, New York, NY 10013, USA\",\n         \"geometry\" : {\n            \"location\" : {\n               \"lat\" : 40.71729149999999,\n               \"lng\" : -74.00512060\n            },\n            \"location_type\" : \"ROOFTOP\",\n            \"viewport\" : {\n               \"northeast\" : {\n                  \"lat\" : 40.71864048029149,\n                  \"lng\" : -74.00377161970849\n               },\n               \"southwest\" : {\n                  \"lat\" : 40.71594251970850,\n                  \"lng\" : -74.00646958029149\n               }\n            }\n         },\n         \"postcode_localities\" : [],\n         \"types\" : [ \"street_address\" ]\n      }\n   ],\n   \"status\" : \"OK\"\n}\n"
+  end
+
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: google_maps
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: 
   segments: 
   - 0
   - 3
-  - 0
-  version: 0.3.0
+  - 1
+  version: 0.3.1
 platform: ruby
 authors: 
 - Tushar Ranka
@@ -15,10 +15,9 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-05-30 00:00:00 Z
+date: 2013-05-22 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  type: :runtime
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -28,11 +27,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  type: :runtime
   version_requirements: *id001
   name: rest-client
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  type: :runtime
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -42,11 +41,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  type: :runtime
   version_requirements: *id002
   name: activesupport
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  type: :development
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -58,11 +57,11 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
+  type: :development
   version_requirements: *id003
   name: bundler
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  type: :development
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -74,11 +73,11 @@ dependencies:
         - 8
         - 3
         version: 1.8.3
+  type: :development
   version_requirements: *id004
   name: jeweler
   prerelease: false
 - !ruby/object:Gem::Dependency 
-  type: :development
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -88,6 +87,7 @@ dependencies:
         segments: 
         - 0
         version: "0"
+  type: :development
   version_requirements: *id005
   name: mocha
   prerelease: false
@@ -146,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.12
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Gem to interact with Google Maps v3 API