google_finance_currency_converter 0.3.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 44fc65187b8b654f07f0946df6d6f3a5a8857783
-  data.tar.gz: 9b3daaeff75df2e81e0a9b295bfc0809d5b9b2b0
+  metadata.gz: ac20fa38292a74d3a96c645c6f16a94155401d16
+  data.tar.gz: d0db8141c56830069f4e4693fdc2fa87926a5963
 SHA512:
-  metadata.gz: b45001163f59ad9874922be89ef50f53ca99bede5e85ee4bd43fb78e44c8fac04b3663978cc92546f7a7d59c699ef34f21b57e2cb458a2f971a16175ce2cbd2a
-  data.tar.gz: 0a30c78d8fbcdf855538b15cb6484b2ec620994b6f29bd85ead28c0f92ababe3495a2144bd53484695d71f67bc739941606fdab52e25f1845bcc20de633cfb96
+  metadata.gz: a26ea4268ab608f2e655589115d662a312b520c268827007018e31f4b52209ef3c64ffa0b73b74fa38fb755c1167e5d1f60f9ace7567973712d4b7def68884d8
+  data.tar.gz: b61f875941ba99fa7e79c0317b2e5519c673fc2cb5db778560f607fd993946f2d98aa522b57f14de3d66e7ca651238e0cbcae1569bb2a6d1e6815db4f7ca8491

data/README.rdoc

@@ -1,6 +1,6 @@
 = google_finance_currency_converter
 
-GoogleFinanceCurrencyConverter.new(:from => 'GBP', :to => 'BRL').rate # 2.784
+GoogleFinanceCurrencyConverter.new(:from => 'GBP', :to => 'BRL', :amount => 1).result # 2.784
 
 == Contributing to google_finance_currency_converter
  

data/VERSION

@@ -1 +1 @@
-0.3.1
+1.0.0

data/google_finance_currency_converter.gemspec

@@ -2,14 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
+# stub: google_finance_currency_converter 1.0.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "google_finance_currency_converter"
-  s.version = "0.3.1"
+  s.version = "1.0.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
   s.authors = ["Pedro Menezes"]
-  s.date = "2013-08-01"
+  s.date = "2014-05-19"
   s.description = "a wrapper for google finance currency converter"
   s.email = "pedrojudo@gmail.com"
   s.extra_rdoc_files = [
@@ -34,8 +36,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/pedromenezes/google_finance_currency_converter"
   s.licenses = ["MIT"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = "2.0.5"
+  s.rubygems_version = "2.2.2"
   s.summary = "a wrapper for google finance currency converter"
 
   if s.respond_to? :specification_version then

data/lib/google_finance_currency_converter.rb

@@ -4,21 +4,24 @@ class GoogleFinanceCurrencyConverter
   def initialize(params={})
     @from = params[:from]
     @to = params[:to]
+    @amount = params[:amount]
+    @amount = 1 if @amount == nil
     raise "Same code" if @from == @to
   end
 
-  def rate
+  def result
+    return 0 if @amount == 0
     parse_response(request)
   end
 
   private
     def request
-      open("http://www.google.com/finance/converter?a=1&from=#{@from}&to=#{@to}").read
+      open("http://www.google.com/finance/converter?a=#{@amount}&from=#{@from}&to=#{@to}").read
     end
 
     def parse_response(response)
-      rate = response.scan(/<span class=bld>([^.]+(?:\.(?:\d+))?)/)
-      raise "Rate not found" if rate.empty?
-      rate[0][0].to_f
+      scanned_result = response.scan(/<span class=bld>([^.]+(?:\.(?:\d+))?)/)
+      raise "Result not found" if scanned_result.empty?
+      scanned_result[0][0].to_f
     end
 end

data/spec/google_finance_currency_converter_spec.rb

@@ -2,35 +2,40 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe GoogleFinanceCurrencyConverter do
   describe "conversion" do
-    it "should work with currency that returns an integer" do
-      stub_converted_val_response(2)
+    it "should work with valid values" do
+      stub_converted_response_value(:amount_to_convert => 2, :response_value => 4.784)
 
-      converter = GoogleFinanceCurrencyConverter.new(:from => 'GBP', :to => 'BRL')
-      converter.rate.should == 2
+      converter = GoogleFinanceCurrencyConverter.new(:from => 'GBP', :to => 'BRL', :amount => 2)
+      converter.result.should == 4.784
+    end
+
+    it "should return 0 when user wants to convert 0" do
+      converter = GoogleFinanceCurrencyConverter.new(:from => 'GBP', :to => 'BRL', :amount => 0)
+      converter.result.should == 0
     end
-    
-    it "should work with currency that returns a float" do
-      stub_converted_val_response(2.784)
+
+    it "should set amount to 1 when amount is nil" do
+      stub_converted_response_value(:amount_to_convert => 1, :response_value => 4.784)
 
       converter = GoogleFinanceCurrencyConverter.new(:from => 'GBP', :to => 'BRL')
-      converter.rate.should == 2.784
+      converter.result.should == 4.784
     end
   end
-  
+
   describe "raising error" do
     it "should raise 'Same code' if from and to codes are the same" do
       lambda {
-        converter = GoogleFinanceCurrencyConverter.new(:from => 'BRL', :to => 'BRL')
+        converter = GoogleFinanceCurrencyConverter.new(:from => 'BRL', :to => 'BRL', :amount => 1)
       }.should raise_error("Same code")
     end
-    
-    it "should raise 'Rate not found' if the conversion doesn't exist" do
+
+    it "should raise 'Result not found' if the conversion doesn't exist" do
       stub_error_response()
-      
-      converter = GoogleFinanceCurrencyConverter.new(:from => 'BRL', :to => 'ALL')
+
+      converter = GoogleFinanceCurrencyConverter.new(:from => 'BRL', :to => 'ALL', :amount => 1)
       lambda {
-        converter.rate
-      }.should raise_error("Rate not found")
+        converter.result
+      }.should raise_error("Result not found")
     end
   end
 end

data/spec/helper/response.html

@@ -210,7 +210,7 @@
 </select>
 </div>
 &nbsp;
-<div id=currency_converter_result>1 GBP = <span class=bld><converted_val> BRL</span>
+<div id=currency_converter_result><amount_to_convert> GBP = <span class=bld><response_value> BRL</span>
 <input type=submit value="Convert">
 </div>
 </form>

data/spec/spec_helper.rb

@@ -10,13 +10,19 @@ require 'google_finance_currency_converter'
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each {|f| require f}
 
 RSpec.configure do |config|
-  
+
 end
 
-def stub_converted_val_response(val)
+def stub_converted_response_value(params)
+  amount_to_convert = params[:amount_to_convert] or 0
+  response_value = params[:response_value] or 0
+
   File.open(File.expand_path(File.dirname(__FILE__) + '/helper/response.html'), 'r') do |f|
-    stub_request(:get, "http://www.google.com/finance/converter?a=1&from=GBP&to=BRL").
-        to_return(:body => f.read.gsub("<converted_val>", val.to_s))
+    stub_request(:get, "http://www.google.com/finance/converter?a=#{amount_to_convert}&from=GBP&to=BRL").
+        to_return(
+          :body => f.read.gsub("<amount_to_convert>", amount_to_convert.to_s)
+                         .gsub("<response_value>", response_value.to_s)
+        )
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google_finance_currency_converter
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Pedro Menezes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-01 00:00:00.000000000 Z
+date: 2014-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -108,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: a wrapper for google finance currency converter