google_distance_matrix 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 38cca78e153cdfc6eca4ccb53116f4d5224872342179ce20bc9869961e0abffe
-  data.tar.gz: 12f845ae5fad59d60bd6f9796da24c4ce736ab7766cf1fd95e9cfe315d1660ba
+  metadata.gz: 9d95262e2f29c248bbf1d42d16d95b9148ef0d16354a4e4dc8e4f5af23364980
+  data.tar.gz: 8911ea692148753e4325908ae0c3b6dffa2c08fbcef4b0585afe5d4f2e45f10d
 SHA512:
-  metadata.gz: b4dd69ed7bf22b3c8ee1c8443aa63f486bbfe4139f4dfc3aea7671018ff01a4997253837812c92d552047132e6fb0e2c5cb348f980a969bbe2f6dc943212d959
-  data.tar.gz: b25399a083d05f99b7345cd1ba167701e00b79265302131bcbea76608419210d7d094238134d86e31e1dfbc83590d0686143eac7ae5909eb3f690b9d136e9832
+  metadata.gz: 9149df909c7604f327b4d342d34e3df99c5898e109a434ef30a123e848cd5591ab01d51d921460907ba53b3a31deccd5ad484fe89e7027aafdbb7a3309eb7ac8
+  data.tar.gz: c8c1054b9060e0ecec7648313931f1d3349ec24cd74ce2f0ffec14cc893c7eda47654cd6df2422b1b162d51c57d1e92222f568d4c9ba25a0d67ff554b9f1aaa5

data/CHANGELOG.md

@@ -1,5 +1,7 @@
 ## v.0.6.1 (to be released)
 
+* fix: when matrix places were built from hashes, passing hashes to route/s_for doesnt't work (by brauliomartinezlm)
+* fix: place comparison was not working with == (by brauliomartinezlm)
 
 ## v.0.6.0
 

data/lib/google_distance_matrix/place.rb

@@ -22,6 +22,7 @@ module GoogleDistanceMatrix
       if respond_to_needed_attributes? attributes_or_object
         extract_and_assign_attributes_from_object attributes_or_object
       elsif attributes_or_object.is_a? Hash
+        @extracted_attributes_from = attributes_or_object.with_indifferent_access
         assign_attributes attributes_or_object
       else
         raise ArgumentError, 'Must be either hash or object responding to lat, lng or address. '
@@ -36,12 +37,15 @@ module GoogleDistanceMatrix
     end
 
     def eql?(other)
+      return false unless other.is_a? self.class
+
       if address.present?
         address == other.address
       else
         lat_lng == other.lat_lng
       end
     end
+    alias == eql?
 
     def lat_lng?
       lat.present? && lng.present?

data/lib/google_distance_matrix/routes_finder.rb

@@ -142,6 +142,8 @@ module GoogleDistanceMatrix
       if object.is_a? Place
         object
       else
+        object = object.with_indifferent_access if object.is_a? Hash
+
         find_place_for_object(origins, object) ||
           find_place_for_object(destinations, object)
       end

data/lib/google_distance_matrix/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GoogleDistanceMatrix
-  VERSION = '0.6.0'
+  VERSION = '0.6.1'
 end

data/spec/lib/google_distance_matrix/place_spec.rb

@@ -95,4 +95,12 @@ describe GoogleDistanceMatrix::Place do
         .to_not be_eql described_class.new(lat: lat, lng: lng + 1)
     end
   end
+
+  describe '#==' do
+    it 'is considered equal when places are compared with ==' do
+      expect(described_class.new(address: address) ==
+             GoogleDistanceMatrix::Place.new(address: address))
+        .to be_truthy
+    end
+  end
 end

data/spec/lib/google_distance_matrix/routes_finder_spec.rb

@@ -3,7 +3,8 @@
 require 'spec_helper'
 
 describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
-  let(:origin_1) { GoogleDistanceMatrix::Place.new address: 'Karl Johans gate, Oslo' }
+  let(:origin_1_attributes) { { address: 'Karl Johans gate, Oslo' } }
+  let(:origin_1) { GoogleDistanceMatrix::Place.new origin_1_attributes }
   let(:origin_2) { GoogleDistanceMatrix::Place.new address: 'Askerveien 1, Asker' }
 
   let(:destination_1) { GoogleDistanceMatrix::Place.new address: 'Drammensveien 1, Oslo' }
@@ -70,6 +71,13 @@ describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
         expect(routes.map(&:origin).all? { |o| o == origin_1 }).to be true
       end
 
+      it 'still returns routes for origin if it has same address but different object_id' do
+        routes = subject.routes_for GoogleDistanceMatrix::Place.new origin_1_attributes
+
+        expect(routes.length).to eq 2
+        expect(routes.map(&:origin).all? { |o| o == origin_1 }).to be true
+      end
+
       it 'returns routes for given destination' do
         routes = subject.routes_for destination_2
 
@@ -83,6 +91,17 @@ describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
         expect(routes.length).to eq 2
         expect(routes.map(&:destination).all? { |d| d == destination_2 }).to be true
       end
+
+      context 'place built from hash' do
+        let(:destination_2_built_from) { { address: 'Skjellestadhagen, Heggedal' } }
+
+        it 'returns routes for given hash a place was built from' do
+          routes = subject.routes_for destination_2_built_from
+
+          expect(routes.length).to eq 2
+          expect(routes.map(&:destination).all? { |d| d == destination_2 }).to be true
+        end
+      end
     end
 
     describe '#routes_for!' do
@@ -104,6 +123,16 @@ describe GoogleDistanceMatrix::RoutesFinder, :request_recordings do
         expect(route.destination).to eq destination_2
       end
 
+      context 'place built from hash' do
+        let(:destination_2_built_from) { { address: 'Skjellestadhagen, Heggedal' } }
+
+        it 'returns route when you give it the hash the place was built from' do
+          route = subject.route_for(origin: origin_1, destination: destination_2_built_from)
+          expect(route.origin).to eq origin_1
+          expect(route.destination).to eq destination_2
+        end
+      end
+
       it 'fails with argument error if origin is missing' do
         expect { subject.route_for destination: destination_2 }.to raise_error ArgumentError
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google_distance_matrix
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Thorbjørn Hermansen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-19 00:00:00.000000000 Z
+date: 2019-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel