google_currency_convert 0.0.1 → 0.0.2

data/README.md

@@ -0,0 +1,47 @@
+# google currency convert
+currency convert by google finance [API](https://www.google.com/finance/converter)
+
+###Install
+
+```
+gem install google_currency_convert
+```
+
+###get currency code and country info
+
+```
+GoogleCurrencyConvert.currency_info
+
+=> ["AED United Arab Emirates Dirham (AED)", "AFN Afghan Afghani (AFN)", "ALL Albanian Lek (ALL)", "AMD Armenian Dram (AMD)", "ANG Netherlands Antillean Guilder (ANG)", "AOA Angolan Kwanza (AOA)", "ARS Argentine Peso (ARS)", "AUD Australian Dollar (A$)", "AWG Aruban Florin (AWG)", "AZN Azerbaijani Manat (AZN)", "BAM Bosnia-Herzegovina Convertible Mark (BAM)", "BBD Barbadian Dollar (BBD)", "BDT Bangladeshi Taka (BDT)",....]
+
+```
+You can get the currency code by country name. For example:
+
+```
+GoogleCurrencyConvert.currency_info.select { |i| i.include?("Jap")}
+
+=> ["JPY Japanese Yen (¥)"]
+```
+###only get currency codes
+
+```
+GoogleCurrencyConvert.currency_codes
+
+=> ["AED", "AFN", "ALL", "AMD", "ANG", "AOA", "ARS", "AUD", "AWG", "AZN", "BAM", "BBD", "BDT", "BGN", "BHD", "BIF", "BMD", "BND", "BOB", "BRL", "BSD", "BTC", "BTN", "BWP", "BYR", "BZD", "CAD", "CDF", "CHF", "CLF", "CLP", "CNH", "CNY", "COP", "CRC", "CUP", "CVE", "CZK", "DEM", "DJF", "DKK", "DOP", "DZD", "EGP", "ERN", "ETB", "EUR", "FIM", "FJD", "FKP", "FRF", "GBP", "GEL", "GHS", "GIP", "GMD", "GNF", "GTQ", "GYD", "HKD", "HNL", "HRK", "HTG", "HUF", "IDR", "IEP", "ILS", "INR", "IQD", "IRR", "ISK", "ITL", "JMD", "JOD", "JPY", "KES", "KGS", "KHR", "KMF", "KPW", "KRW", "KWD", "KYD", "KZT", "LAK", "LBP", "LKR", "LRD", "LSL", "LTL", "LVL", "LYD", "MAD", "MDL", "MGA", "MKD", "MMK", "MNT", "MOP", "MRO", "MUR", "MVR", "MWK", "MXN", "MYR", "MZN", "NAD", "NGN", "NIO", "NOK", "NPR", "NZD", "OMR", "PAB", "PEN", "PGK", "PHP", "PKG", "PKR", "PLN", "PYG", "QAR", "RON", "RSD", "RUB", "RWF", "SAR", "SBD", "SCR", "SDG", "SEK", "SGD", "SHP", "SLL", "SOS", "SRD", "STD", "SVC", "SYP", "SZL", "THB", "TJS", "TMT", "TND", "TOP", "TRY", "TTD", "TWD", "TZS", "UAH", "UGX", "USD", "UYU", "UZS", "VEF", "VND", "VUV", "WST", "XAF", "XCD", "XDR", "XOF", "XPF", "YER", "ZAR", "ZMK", "ZMW", "ZWL"]
+```
+
+###currency convert
+
+The amount parameter has the default value, so if don't pass the amount, you will get the
+currency rate.
+
+```
+GoogleCurrencyConvert.currency_convert(from_currency, to_currency, amount = 1)
+```
+
+Convert US Dollar to Chinese Yuan, for example:
+
+```
+GoogleCurrencyConvert.currency_convert("USD", "CNY")
+=> 6.2092
+```

data/lib/google_currency_convert.rb

@@ -8,8 +8,8 @@ class GoogleCurrencyConvert
 			@info = []
 			file_path = File.expand_path("curr_code.csv", File.dirname(__FILE__))
 			IO.readlines(file_path).each { |line| @info << line.strip }
-	    end
-	    @info
+	  end
+	  @info
 	end
 
 	def self.currency_codes
@@ -17,21 +17,21 @@ class GoogleCurrencyConvert
 		@info.map { |i| i.split(' ')[0] }
 	end
 
-	def self.currency_convert(from, to, amount)
+	def self.currency_convert(from, to, amount = 1)
 		if not currency_codes.include?(from) or not currency_codes.include?(to)
 			return "Error: cannot support such currency code"
 		end
 
 		return "Error: amount must be a positive integer" if amount <= 0 or amount.class != Fixnum
 
-	    host = "www.google.com"
-	    http = Net::HTTP.new(host, 80)
-	    url = "/finance/converter?a=#{amount}&from=#{from}&to=#{to}"
-	    response = http.get(url)
+    host = "www.google.com"
+    http = Net::HTTP.new(host, 80)
+    url = "/finance/converter?a=#{amount}&from=#{from}&to=#{to}"
+    response = http.get(url)
 
-	    doc = Nokogiri::HTML(response.body)
-	    result = doc.css('div#currency_converter_result').first.text
-	    result.split(' ')[3].to_f
+    doc = Nokogiri::HTML(response.body)
+    result = doc.css('div#currency_converter_result').first.text
+    result.split(' ')[3].to_f
 	end
 
-end
+end

data/test/google_currency_convert_spec.rb

@@ -0,0 +1,29 @@
+require_relative '../lib/google_currency_convert.rb'
+
+RSpec.describe GoogleCurrencyConvert do
+	it "currency info is a non-empty array" do
+		expect(GoogleCurrencyConvert.currency_info.size).to be > 0
+	end
+
+	it "currency codes a non-empty array" do
+		expect(GoogleCurrencyConvert.currency_codes.size).to be > 0
+	end
+
+	it "return error if the currency code is invalid" do
+		err_message = "Error: cannot support such currency code"
+		expect(GoogleCurrencyConvert.currency_convert("ABCD", "AED", 1)).to eq(err_message)
+		expect(GoogleCurrencyConvert.currency_convert("AED", "ABCD", 1)).to eq(err_message)
+	end
+
+	it "return error if the currency amount is not a positive integer" do
+		err_message = "Error: amount must be a positive integer"
+		expect(GoogleCurrencyConvert.currency_convert("AFN", "AED", 0)).to eq(err_message)
+		expect(GoogleCurrencyConvert.currency_convert("AFN", "AED", -1)).to eq(err_message)
+	end
+
+	it "get a float if the code and maount are right" do
+		expect(GoogleCurrencyConvert.currency_convert("AFN", "AED")).to be > 0.0
+		expect(GoogleCurrencyConvert.currency_convert("AFN", "AED", 100)).to be > 0.0
+	end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google_currency_convert
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -19,6 +19,8 @@ extra_rdoc_files: []
 files:
 - lib/google_currency_convert.rb
 - lib/curr_code.csv
+- test/google_currency_convert_spec.rb
+- README.md
 homepage: http://rubygems.org/gems/google_currency_convert
 licenses:
 - MIT