google_currency 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 15465e69da6f84b9957b6cd166fa5623f8ddbf64
-  data.tar.gz: 5dccac4429dc84a2ae1615d6cb43a45120f4445c
+  metadata.gz: 1b57390ef56dd1b049e7b5d9fd8a3ed893791779
+  data.tar.gz: 38469aad714942d2fb16afa1b933a2d31e6940b0
 SHA512:
-  metadata.gz: c1b9bdf4d77d9e35b67d45b34f5c330dfad9c8737e9e078425b998cb8960569e1cdc7179d50d0d94d608e35e80266fa92bdd9bb8c4d6c48c2e4ec8928d0d17fa
-  data.tar.gz: 39b45cf9d40d71e436a0d2444cf68b748567743a2a74355a5af4f4a8bf773ead3bccd46ebe44597e458307a88945ead011f535808a682d364d43cff33be24192
+  metadata.gz: 8207d9c3712b4e58da9080e9dcf1b1bf43620d615205435ebd36b2895824f99a155a52b3889bafa4729ee275d7e9c17d96728f65110ceeccc88de0188d805cf1
+  data.tar.gz: ed516c931481812b71dad0290ef1a657742eb743c2ff46699ec210a4c644e9dd3e23c4b8aba96a702269d6a893a5382139264b6af3e48c2dca66efc40e98c183

data/AUTHORS

@@ -8,3 +8,4 @@ Lars Pind
 Shane Emmons
 sowenjub
 yinquanteo
+Tarang Patel

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+3.3.0
+=====
+
+- Update Money gem dep
+
+3.2.1
+=====
+- Increase precision of rates by using inverse reciprocals for certain currencyes
+
 3.0.0
 =====
 

data/README.md

@@ -24,7 +24,8 @@ Usage
     money = Money.new(1_00, "USD") # amount is in cents
     money.exchange_to(:EUR)
 
-    # or install the 'monetize' gem
+    # or install and use the 'monetize' gem
+    require 'monetize'
     money = 1.to_money(:USD)
     money.exchange_to(:EUR)
 
@@ -36,7 +37,25 @@ An `UnknownCurrency` will be thrown if `#exchange_to` is called with a
 
 A `GoogleCurrencyFetchError` will be thrown if there is an unknown issue with the Google Finance Converter API.
 
+Caveats
+-------
+
+This gem uses [Google Finance Converter](https://www.google.com/finance/converter) under the hood.
+
+Exchange rates are,
+
+1. Based on 1 unit of the original currency.
+1. Have a precision of 4 decimal places.
+
+What this means is that if the JPY to USD exchange rate is 0.0083660,
+Google will report the JPY to USD exchange rate as 0.0084.
+As a result, a larger JPY to USD conversion such as 10000 JPY to USD would yield 84 USD instead of 83.66 USD.
+
+Consequently, this means that small exchange rates will be imprecise.
+For example, if the IDR to USD exchange rate were 0.00007761, Google will report it as 0.0001.
+This means 100000 IDR would exchange to 10 USD instead of 7.76 USD.
+
 Copyright
 ---------
 
-Copyright (c) 2011 Shane Emmons. See {file:LICENSE} for details.
+Copyright (c) 2011 Shane Emmons. See [LICENSE](LICENSE) for details.

data/google_currency.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name        = "google_currency"
-  s.version     = "3.2.0"
+  s.version     = "3.3.0"
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Shane Emmons"]
   s.email       = ["semmons99@gmail.com"]
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency "yard", ">= 0.5.8"
   s.add_development_dependency "ffi"
 
-  s.add_dependency "money", "~> 6.5.0"
+  s.add_dependency "money", "~> 6.7"
 
   s.files =  Dir.glob("{lib,spec}/**/*")
   s.files += %w(LICENSE README.md CHANGELOG.md AUTHORS)

data/lib/money/bank/google_currency.rb

@@ -1,4 +1,5 @@
 require 'money'
+require 'money/rates_store/rate_removal_support'
 require 'open-uri'
 
 class Money
@@ -14,6 +15,7 @@ class Money
       SERVICE_HOST = "www.google.com"
       SERVICE_PATH = "/finance/converter"
 
+
       # @return [Hash] Stores the currently known rates.
       attr_reader :rates
 
@@ -43,6 +45,11 @@ class Money
         end
       end
 
+      def initialize(*)
+        super
+        @store.extend Money::RatesStore::RateRemovalSupport
+      end
+
       ##
       # Clears all rates stored in @rates
       #
@@ -53,9 +60,7 @@ class Money
       #   @bank.get_rate(:USD, :EUR)  #=> 0.776337241
       #   @bank.flush_rates           #=> {}
       def flush_rates
-        @mutex.synchronize{
-          @rates = {}
-        }
+        store.clear_rates
       end
 
       ##
@@ -73,10 +78,7 @@ class Money
       #   @bank.get_rate(:USD, :EUR)    #=> 0.776337241
       #   @bank.flush_rate(:USD, :EUR)  #=> 0.776337241
       def flush_rate(from, to)
-        key = rate_key_for(from, to)
-        @mutex.synchronize{
-          @rates.delete(key)
-        }
+        store.remove_rate(from, to)
       end
 
       ##
@@ -94,10 +96,7 @@ class Money
       #   @bank.get_rate(:USD, :EUR)  #=> 0.776337241
       def get_rate(from, to)
         expire_rates
-
-        @mutex.synchronize{
-          @rates[rate_key_for(from, to)] ||= fetch_rate(from, to)
-        }
+        store.get_rate(from, to) || store.add_rate(from, to, fetch_rate(from, to))
       end
 
       ##
@@ -124,9 +123,18 @@ class Money
       #
       # @return [BigDecimal] The requested rate.
       def fetch_rate(from, to)
+
         from, to = Currency.wrap(from), Currency.wrap(to)
+
         data = build_uri(from, to).read
-        extract_rate(data)
+        rate = extract_rate(data);
+
+        if (rate < 0.1)
+          rate = 1/extract_rate(build_uri(to, from).read)
+        end
+
+        rate
+
       end
 
       ##

data/lib/money/rates_store/rate_removal_support.rb

@@ -0,0 +1,27 @@
+module Money::RatesStore
+  module RateRemovalSupport
+    # Remove a conversion rate and returns it. Uses +Mutex+ to synchronize data access.
+    #
+    # @param [String] currency_iso_from Currency to exchange from.
+    # @param [String] currency_iso_to Currency to exchange to.
+    #
+    # @return [Numeric]
+    #
+    # @example
+    #   store = Money::RatesStore::Memory.new
+    #   store.remove_rate("USD", "CAD")
+    #   store.remove_rate("CAD", "USD")
+    def remove_rate(currency_iso_from, currency_iso_to)
+      transaction { index.delete rate_key_for(currency_iso_from, currency_iso_to) }
+    end
+
+    # Clears all conversion rates. Uses +Mutex+ to synchronize data access.
+    #
+    # @example
+    #   store = Money::RatesStore::Memory.new
+    #   store.clear_rates
+    def clear_rates
+      transaction { @index = {} }
+    end
+  end
+end

data/spec/google_currency_with_json_spec.rb

@@ -46,7 +46,7 @@ describe "GoogleCurrency" do
 
     it "should store the rate for faster retreival" do
       @bank.get_rate('USD', 'EUR')
-      expect(@bank.rates).to include('USD_TO_EUR')
+      expect(@bank.store.instance_variable_get("@index")).to include('USD_TO_EUR')
     end
 
     context "handles" do
@@ -80,7 +80,7 @@ describe "GoogleCurrency" do
     it "should empty @rates" do
       @bank.get_rate('USD', 'EUR')
       @bank.flush_rates
-      expect(@bank.rates).to eq({})
+      expect(@bank.store.instance_variable_get("@index")).to eq({})
     end
   end
 
@@ -89,8 +89,8 @@ describe "GoogleCurrency" do
       @bank.get_rate('USD', 'EUR')
       @bank.get_rate('USD', 'JPY')
       @bank.flush_rate('USD', 'EUR')
-      expect(@bank.rates).to include('USD_TO_JPY')
-      expect(@bank.rates).to_not include('USD_TO_EUR')
+      expect(@bank.store.instance_variable_get("@index")).to include('USD_TO_JPY')
+      expect(@bank.store.instance_variable_get("@index")).to_not include('USD_TO_EUR')
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: google_currency
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Shane Emmons
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-02 00:00:00.000000000 Z
+date: 2016-01-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.5.0
+        version: '6.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 6.5.0
+        version: '6.7'
 description: GoogleCurrency extends Money::Bank::Base and gives you access to the
   current Google Currency exchange rates.
 email:
@@ -82,6 +82,7 @@ files:
 - Rakefile
 - google_currency.gemspec
 - lib/money/bank/google_currency.rb
+- lib/money/rates_store/rate_removal_support.rb
 - spec/google_currency_with_json_spec.rb
 - spec/rates/error.html
 - spec/rates/sgd_to_usd.html
@@ -107,7 +108,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Access the Google Currency exchange rate data.