google_books 0.2.0 → 0.2.1

data/.gitignore

@@ -3,4 +3,5 @@ pkg/*
 .bundle
 spec/fixtures/cassette_library/*.yml
 .idea/*
-.DS_Store
+.DS_Store
+.rbx

data/CHANGELOG.md

@@ -37,3 +37,10 @@ v0.2.0
       *   Standardized publisher names in a similar fashion to the [google-book gem](https://rubygems.org/gems/google-book)
 *   Bug Fixes
       *   The publishedDate field in the Google Books API are strings in the format of YYYY-MM-DD. Sometimes it's just YYYY and other times it's YYYY-MM.  Previously the `published_date` attribute was a Date type, now it is a string and you can convert the date however you want in your applications.
+v0.2.1
+------
+*   Bug Fixes
+      *   Removed call to blank? in the `normalize_publisher` method of the Book class
+*   Other
+      *   Added specific versions for required gems
+      *   Fixed VCR cassette problem between Ruby 1.8.7 and 1.9.2 (Run the tests using 1.8.7 first and then 1.9.2 to reuse the same cassette)

data/Gemfile.lock

@@ -2,27 +2,31 @@ PATH
   remote: .
   specs:
     google_books (0.2.0)
-      hashie
-      httparty
+      hashie (~> 1.1.0)
+      httparty (~> 0.8.1)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    ZenTest (4.6.0)
+    ZenTest (4.6.2)
     addressable (2.2.6)
     archive-tar-minitar (0.5.2)
     autotest (4.4.6)
       ZenTest (>= 4.4.1)
     columnize (0.3.4)
-    crack (0.1.8)
-    diff-lcs (1.1.2)
+    crack (0.3.1)
+    diff-lcs (1.1.3)
     hashie (1.1.0)
-    httparty (0.7.8)
-      crack (= 0.1.8)
+    httparty (0.8.1)
+      multi_json
+      multi_xml
     linecache (0.46)
       rbx-require-relative (> 0.0.4)
     linecache19 (0.5.12)
       ruby_core_source (>= 0.1.4)
+    multi_json (1.0.3)
+    multi_xml (0.4.1)
+    rake (0.8.7)
     rbx-require-relative (0.0.5)
     rspec (2.6.0)
       rspec-core (~> 2.6.0)
@@ -47,8 +51,8 @@ GEM
       ruby-debug-base19 (>= 0.11.19)
     ruby_core_source (0.1.5)
       archive-tar-minitar (>= 0.5.2)
-    vcr (1.10.3)
-    webmock (1.6.4)
+    vcr (1.11.3)
+    webmock (1.7.6)
       addressable (~> 2.2, > 2.2.5)
       crack (>= 0.1.7)
 
@@ -56,10 +60,11 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  autotest
+  autotest (~> 4.4.6)
   google_books!
-  rspec
+  rake (~> 0.8.7)
+  rspec (~> 2.6.0)
   ruby-debug
   ruby-debug19
-  vcr
-  webmock
+  vcr (~> 1.11.3)
+  webmock (~> 1.7.6)

data/google_books.gemspec

@@ -12,13 +12,14 @@ Gem::Specification.new do |s|
   s.summary     = %q{A Ruby wrapper around the Google Books API}
   s.description = %q{A Ruby wrapper that allows you to query the Google Books API. This project was inspired by google-book, see the README for more information}
   
-  s.add_dependency('httparty')
-  s.add_dependency('hashie')
+  s.add_dependency('httparty', '~> 0.8.1')
+  s.add_dependency('hashie', '~> 1.1.0')
   
-  s.add_development_dependency('autotest')
-  s.add_development_dependency('rspec')
-  s.add_development_dependency('webmock')
-  s.add_development_dependency('vcr')
+  s.add_development_dependency('rake', '~> 0.8.7')
+  s.add_development_dependency('autotest', '~> 4.4.6')
+  s.add_development_dependency('rspec', '~> 2.6.0')
+  s.add_development_dependency('webmock', '~> 1.7.6')
+  s.add_development_dependency('vcr', '~> 1.11.3')
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/lib/google_books/api/book.rb

@@ -40,7 +40,7 @@ module GoogleBooks
       end
       
       def normalize_publisher(name)
-        return name if name.blank?
+        return name if (name.nil? || name.empty?)
         
         name.
           gsub(/[ ,]+Inc.?$/i, ' Inc.').

data/lib/google_books/version.rb

@@ -1,3 +1,3 @@
 module GoogleBooks
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/spec/google_books/api/book_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../spec_helper'
+require 'spec_helper'
 
 module GoogleBooks
   module API
@@ -89,6 +89,12 @@ module GoogleBooks
           book = Book.new(item)
           book.publisher.should eq "Publisher University Press"
         end
+        
+        it "should handle strings with apostrophes" do
+          item['volumeInfo']['publisher'] = "O'Reilly Media, Inc."
+          book = Book.new(item)
+          book.publisher.should eq "O'Reilly Media Inc."
+        end
       end
       
       describe "published_date" do

data/spec/google_books/api/response_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../../spec_helper'
+require 'spec_helper'
 
 module GoogleBooks
   module API
@@ -15,6 +15,11 @@ module GoogleBooks
         response.first.should be_a Book
       end
       
+      it "should correctly parse O'Reilly Media Inc" do
+        response = API.search('Douglas Crockford')
+        book = response.first
+        book.publisher.should eq "O'Reilly Media Inc."
+      end
     end
   end
 end

data/spec/google_books/api_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
   
 module GoogleBooks
   describe API do
@@ -27,7 +27,10 @@ module GoogleBooks
       
       it "should join parameters" do
         API.search('damien white', :count => 20, :page => 2)
-        API.send(:query).should include 'startIndex=2&maxResults=20'
+        API.send(:query).should include 'startIndex=2'
+        API.send(:query).should include 'maxResults=20'
+        API.send(:query).should include 'q=damien+white'
+        API.send(:query).count('&').should eq 2 
       end
       
       it "should return the proper number results based on the count passed in" do

data/spec/support/vcr.rb

@@ -1,7 +1,11 @@
 require 'vcr'
+require 'yaml'
+YAML::ENGINE.yamler = 'syck' if defined?(YAML::ENGINE)
+
+cassette_dir = File.dirname(__FILE__) + '/../fixtures/cassette_library'
 
 VCR.config do |c|
-  c.cassette_library_dir = File.dirname(__FILE__) + '/../fixtures/cassette_library'
+  c.cassette_library_dir = cassette_dir
   c.default_cassette_options = { :record => :new_episodes }
   c.stub_with :webmock
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google_books
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,74 +9,85 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-29 00:00:00.000000000Z
+date: 2011-10-18 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &70187585301000 !ruby/object:Gem::Requirement
+  requirement: &70335070032720 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.8.1
   type: :runtime
   prerelease: false
-  version_requirements: *70187585301000
+  version_requirements: *70335070032720
 - !ruby/object:Gem::Dependency
   name: hashie
-  requirement: &70187585300580 !ruby/object:Gem::Requirement
+  requirement: &70335070032220 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *70187585300580
+  version_requirements: *70335070032220
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &70335070031760 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.8.7
+  type: :development
+  prerelease: false
+  version_requirements: *70335070031760
 - !ruby/object:Gem::Dependency
   name: autotest
-  requirement: &70187585300160 !ruby/object:Gem::Requirement
+  requirement: &70335070031300 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 4.4.6
   type: :development
   prerelease: false
-  version_requirements: *70187585300160
+  version_requirements: *70335070031300
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70187585299740 !ruby/object:Gem::Requirement
+  requirement: &70335070030840 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.6.0
   type: :development
   prerelease: false
-  version_requirements: *70187585299740
+  version_requirements: *70335070030840
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70187585299320 !ruby/object:Gem::Requirement
+  requirement: &70335070030380 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.7.6
   type: :development
   prerelease: false
-  version_requirements: *70187585299320
+  version_requirements: *70335070030380
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &70187585298900 !ruby/object:Gem::Requirement
+  requirement: &70335070029920 !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ! '>='
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.11.3
   type: :development
   prerelease: false
-  version_requirements: *70187585298900
+  version_requirements: *70335070029920
 description: A Ruby wrapper that allows you to query the Google Books API. This project
   was inspired by google-book, see the README for more information
 email: