google_analytics_mailer 0.1.1 → 0.1.2

data/Changelog.md

@@ -1,3 +1,7 @@
+## 0.1.2, released 2013-09-26
+
+* Removed blank params from generated urls
+
 ## 0.1.1, released 2013-08-23
 
 * Added license to gemspec

data/lib/google_analytics_mailer/url_for.rb

@@ -14,6 +14,8 @@ module GoogleAnalyticsMailer # :nodoc:
       params_to_add = controller.computed_analytics_params.with_indifferent_access
       # temporary override coming from with_google_analytics_params method
       params_to_add.merge!(@_override_ga_params) if @_override_ga_params.try(:any?)
+      # remove empty GA params
+      params_to_add.delete_if { |_, v| v.blank? }
       # if there are no parameters return super value
       if params_to_add.empty?
         super(original_url)

data/lib/google_analytics_mailer/version.rb

@@ -1,3 +1,3 @@
 module GoogleAnalyticsMailer
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/lib/url_for_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+# Mock helper used to test module methods
+# @see http://stackoverflow.com/questions/5944278/overriding-method-by-another-defined-in-module
+class MockHelper
+  # No op implementation of url_for
+  def url_for(url)
+    url
+  end
+
+  # Used by implementation
+  def controller
+    self
+  end
+
+  def computed_analytics_params
+    {}.with_indifferent_access
+  end
+end
+
+describe GoogleAnalyticsMailer::UrlFor do
+
+  let(:dummy_class) { Class.new(MockHelper) { include GoogleAnalyticsMailer::UrlFor } }
+  let(:subject) { dummy_class.new }
+
+  describe '#url_for' do
+
+    it 'should not include blank GA params' do
+      subject.stub(computed_analytics_params: {utm_campaign: nil})
+      subject.url_for('http://www.example.com').should_not include 'utm_campaign'
+    end
+
+    it 'should uri encode GA parameter values' do
+      subject.stub(computed_analytics_params: {utm_campaign: 'Foo Bar'})
+      subject.url_for('http://www.example.com').should include 'utm_campaign=Foo%20Bar'
+    end
+
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google_analytics_mailer
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-23 00:00:00.000000000 Z
+date: 2013-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -132,6 +132,7 @@ files:
 - lib/google_analytics_mailer/url_for.rb
 - lib/google_analytics_mailer/version.rb
 - spec/lib/google_analytics_mailer_spec.rb
+- spec/lib/url_for_spec.rb
 - spec/spec_helper.rb
 - spec/support/views/user_mailer/welcome.html.erb
 - spec/support/views/user_mailer/welcome2.html.erb
@@ -164,6 +165,7 @@ summary: This gem provides automatic Google Analytics tagged links in ActionMail
   generated emails
 test_files:
 - spec/lib/google_analytics_mailer_spec.rb
+- spec/lib/url_for_spec.rb
 - spec/spec_helper.rb
 - spec/support/views/user_mailer/welcome.html.erb
 - spec/support/views/user_mailer/welcome2.html.erb