google4r-checkout 1.1.4 → 1.1.5

data/CHANGES

@@ -1,5 +1,9 @@
 =google4r-checkout Changelog
 
+== 1.1.5 (2012-08-01)
+
+* Raise a more informative exception for non-XML notifications, contributed by James Martin
+
 == 1.1.4 (2012-07-31)
 
 * Carrier shipping adjustment support, contributed by Ben Hutton

data/lib/google4r/checkout/notifications.rb

@@ -101,6 +101,9 @@ module Google4R #:nodoc:
     #    # ...
     #  end
     class NotificationHandler
+      class NonXmlNotification
+      end
+
       # The Frontend object that created this NotificationHandler
       attr_accessor :frontend
       
@@ -117,7 +120,7 @@ module Google4R #:nodoc:
       # TODO: Add parsing of other notifications here (merchant calculation and the like) when they have been implemented.
       #++
       def handle(xml_str)
-        root = REXML::Document.new(xml_str).root
+        root = REXML::Document.new(xml_str).root || NonXmlNotification
         
         case root.name
         when 'new-order-notification' then

data/test/unit/notification_handler_test.rb

@@ -83,6 +83,11 @@ class Google4R::Checkout::NotificationHandlerTest < Test::Unit::TestCase
       [
         '<unknown-notification />'
       ]
+
+    @non_xmls = 
+      [
+        'some-key-value=pair'
+      ]
   end
   
   def test_handler_gets_initialized_correctly
@@ -110,4 +115,10 @@ class Google4R::Checkout::NotificationHandlerTest < Test::Unit::TestCase
       assert_raises(UnknownNotificationType) { @notification_handler.handle(xml_str) }
     end
   end
+
+  def test_raises_exception_on_non_xml_notifications
+    @non_xmls.each do |str|
+      assert_raises(UnknownNotificationType) { @notification_handler.handle(str) }
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google4r-checkout
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
   prerelease: 
 platform: ruby
 authors:
@@ -15,10 +15,11 @@ authors:
 - Larry Salibra
 - Paul Schreiber
 - Ben Hutton
+- James Martin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-31 00:00:00.000000000 Z
+date: 2012-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: money