google-pubsub-enhancer 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 598dded4b468b690d2bb999edcb90fd5268f168b
-  data.tar.gz: 0c51990f11c382f61b0930cc9fabaaaa303668fe
+  metadata.gz: 5e20918fd98bff1967fb4de0a621430e08266923
+  data.tar.gz: 4fc8547079c2d2a6681349de1b172f5709d299b2
 SHA512:
-  metadata.gz: 9c924edc41dfb127cc14fa542c1e28ad6234d5ab8548fb15037abd0ccb3416239fe7c5b7eebb8626eee6fb63df6eb30d799930f5e92b14432bebeda110e8fa8b
-  data.tar.gz: 12a13974b8f4604ec7fe0c3d26a1f31612171be11cb5603cf2118115dab6b1babee62581c934ba46dfd1c8873d6713bffbd1ba7f0cb3a2a7b4b5bce96805a65f
+  metadata.gz: 9b2098a5da5eec707e25fe853c47c2c993bd3d86e2439b181507eba546e92294297eb18b7df2883e7cece5bc6d7f630c0fb2b875e196bb9111add9c73add918a
+  data.tar.gz: fd6108cfd7bcb53c4f45224b13b53a2d118289e477f8b35d76435449c4a8bd35a1ada97e6a58ab3d908594bbacedf6cd73b1fd5d9da0c32504ecb4ed8fcc8c5c

data/.gitignore

@@ -9,3 +9,4 @@
 /tmp/
 /tags
 /spike
+.ruby-version

data/google-pubsub-enhancer.gemspec

@@ -6,8 +6,8 @@ require 'google_pubsub_enhancer/version'
 Gem::Specification.new do |spec|
   spec.name          = "google-pubsub-enhancer"
   spec.version       = GooglePubsubEnhancer::VERSION
-  spec.authors       = ["bejczib"]
-  spec.email         = ["bejczi.balint@gmail.com"]
+  spec.authors       = ["bejczib","karoly_bujtor"]
+  spec.email         = ["bejczi.balint@gmail.com","bujtor.karoly@gmail.com"]
 
   spec.summary       = %q{Enhancement for a pipeline built with Google PubSub Services }
   spec.homepage      = "http://github.com/bejczib/google-pubsub-enhancer"

data/lib/google_pubsub_enhancer/spec.rb

@@ -6,7 +6,7 @@ module GooglePubsubEnhancer::Spec
       let(:publisher) { double "publisher"}
       let(:subscription) { double 'subscription'}
       before do
-        allow(ENV).to receive(:[]).with("PUBSUB_KEYFILE_JSON").and_return(JSON.dump({project_id: 'cica'}))
+        ENV['PUBSUB_KEYFILE_JSON'] = JSON.dump(project_id: 'cica')
         allow(Google::Cloud::Pubsub).to receive(:new).and_return(pubsub)
         allow(pubsub).to receive(:publish).and_yield(publisher)
         allow(pubsub).to receive(:subscription).and_return subscription
@@ -14,6 +14,10 @@ module GooglePubsubEnhancer::Spec
         allow(publisher).to receive(:publish)
         allow(subscription).to receive(:acknowledge)
       end
+
+      after do
+        ENV.delete 'PUBSUB_KEYFILE_JSON'
+      end
     end
   end
 

data/lib/google_pubsub_enhancer/version.rb

@@ -1,3 +1,3 @@
 class GooglePubsubEnhancer
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

data/lib/google_pubsub_enhancer.rb

@@ -19,7 +19,7 @@ class GooglePubsubEnhancer
       key = ::Google::Cloud::Pubsub::Credentials::JSON_ENV_VARS.find { |n| !ENV[n].nil? }
       @pubsub_config ||= JSON.parse(ENV[key])
     rescue => ex
-      raise Exception, 'Environment not setted properly'
+      raise Exception, "Environment not setted properly"
     end
   end
 
@@ -45,15 +45,17 @@ class GooglePubsubEnhancer
       break if opts[:shutdown].call || received_messages == nil
       next if received_messages.empty?
       @logger.debug{"#{received_messages.length} messages received"}
-      @stack.call({received_messages: received_messages})
-      subscription.acknowledge(received_messages)
+      env = {received_messages: received_messages, nacked_messages: []}
+      @stack.call(env)
+      p env
+      subscription.acknowledge(env[:received_messages] - env[:nacked_messages])
     end
   end
 
   def create_subscription(subscription_short_name)
     Google::Cloud::Pubsub.new.subscription(self.class.name_by('subscriptions', subscription_short_name))
   rescue => ex
-    raise Exception, 'Environment not setted properly'
+    raise Exception, 'Problem with subscription. Check spelling or permissions!'
   end
 
   def configurate_options(opts)

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: google-pubsub-enhancer
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - bejczib
+- karoly_bujtor
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-03-01 00:00:00.000000000 Z
+date: 2017-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -83,6 +84,7 @@ dependencies:
 description: 
 email:
 - bejczi.balint@gmail.com
+- bujtor.karoly@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []