google-geocode 1.0.0 → 1.1.0

data/Rakefile

@@ -8,7 +8,7 @@ $VERBOSE = nil
 
 spec = Gem::Specification.new do |s|
   s.name = 'google-geocode'
-  s.version = '1.0.0'
+  s.version = '1.1.0'
   s.summary = 'Google Geocoder API Library'
   s.description = 'Map addresses to latitude and longitude with Google\'s Geocoder.'
   s.author = 'Eric Hodel'

data/lib/google_geocode.rb

@@ -64,11 +64,19 @@ class GoogleGeocode
 
     status = obj.elements['/kml/Response/Status/code'].text.to_i
     case status
-    when 200 # ignore, ok
-    when 602
-      raise AddressError, 'invalid address'
-    when 610
+    when 200 then # ignore, ok
+    when 500 then
+      raise Error, 'server error'
+    when 601 then
+      raise AddressError, 'missing address'
+    when 602 then
+      raise AddressError, 'unknown address'
+    when 603 then
+      raise AddressError, 'unavailable address'
+    when 610 then
       raise KeyError, 'invalid key'
+    when 620 then
+      raise KeyError, 'too many queries'
     else
       raise Error, "unknown error #{status}"
     end

data/test/test_google_geocode.rb

@@ -44,7 +44,59 @@ class TestGoogleGeocode < Test::Unit::TestCase
     flunk 'Error expected'
   end
 
-  def test_locate_bad_address
+  def test_locate_missing_address
+    URI::HTTP.responses << <<-EOF.strip
+<?xml version="1.0" encoding="UTF-8"?><kml xmlns="http://earth.google.com/kml/2.0"><Response><name>1600</name><Status><code>601</code><request>geocode</request></Status></Response></kml>
+    EOF
+
+    @gg.locate 'x'
+
+  rescue GoogleGeocode::AddressError => e
+    assert_equal 'missing address', e.message
+  else
+    flunk 'Error expected'
+  end
+
+  def test_locate_server_error
+    URI::HTTP.responses << <<-EOF.strip
+<?xml version='1.0' encoding='UTF-8'?><kml xmlns='http://earth.google.com/kml/2.0'><Response><name>1600 Amphitheater Pkwy, Mountain View, CA</name><Status><code>500</code><request>geocode</request></Status></Response></kml>
+    EOF
+
+    @gg.locate 'x'
+
+  rescue GoogleGeocode::Error => e
+    assert_equal 'server error', e.message
+  else
+    flunk 'Error expected'
+  end
+
+  def test_locate_too_many_queries
+    URI::HTTP.responses << <<-EOF.strip
+<?xml version='1.0' encoding='UTF-8'?><kml xmlns='http://earth.google.com/kml/2.0'><Response><name>1600 Amphitheater Pkwy, Mountain View, CA</name><Status><code>620</code><request>geocode</request></Status></Response></kml>
+    EOF
+
+    @gg.locate 'x'
+
+  rescue GoogleGeocode::KeyError => e
+    assert_equal 'too many queries', e.message
+  else
+    flunk 'Error expected'
+  end
+
+  def test_locate_unavailable_address
+    URI::HTTP.responses << <<-EOF.strip
+<?xml version="1.0" encoding="UTF-8"?><kml xmlns="http://earth.google.com/kml/2.0"><Response><name>42-44 Hanway Street, London</name><Status><code>603</code><request>geocode</request></Status></Response></kml>
+    EOF
+
+    @gg.locate 'x'
+
+  rescue GoogleGeocode::AddressError => e
+    assert_equal 'unavailable address', e.message
+  else
+    flunk 'Error expected'
+  end
+
+  def test_locate_unknown_address
     URI::HTTP.responses << <<-EOF.strip
 <?xml version="1.0" encoding="UTF-8"?><kml xmlns="http://earth.google.com/kml/2.0"><Response><name>1600</name><Status><code>602</code><request>geocode</request></Status></Response></kml>
     EOF
@@ -52,7 +104,7 @@ class TestGoogleGeocode < Test::Unit::TestCase
     @gg.locate 'x'
 
   rescue GoogleGeocode::AddressError => e
-    assert_equal 'invalid address', e.message
+    assert_equal 'unknown address', e.message
   else
     flunk 'Error expected'
   end

metadata

@@ -3,7 +3,7 @@ rubygems_version: 0.8.11.15
 specification_version: 1
 name: google-geocode
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.1.0
 date: 2006-06-12 00:00:00 -07:00
 summary: Google Geocoder API Library
 require_paths: