google-cloud-pubsub 0.33.1 → 0.33.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e04bfd015838726c4fdd745c2a4fa04d22a7bbe7a79a255fcc19987697769fd8
-  data.tar.gz: ab43471a308ba83145be50db01082b3a77b39f3b61b79384b37cd46f21c2dcfb
+  metadata.gz: e93469ccb43f93262792fbcc7c58a076930f3655dc39c059ad2f323305cea78d
+  data.tar.gz: f026ce8b7ca6054fc98c9904a0d4a400fc92f7076cb7c57b575b51f3646101c5
 SHA512:
-  metadata.gz: ed5543bd1d0556486877c6ac13762c1baeb69e791272473d204a511c40451d381a9ebf82ce0bc819cd7fa68b3176c7886857b02a87bba170d24bb56d8e0689ea
-  data.tar.gz: d89498904abfcc1e1f1ffd1425b6e5c847a82ddf170b0e2d497fcbe7f238112d8567540a7bf2294329a26ed778cf58df6fef9d805678bc7c2e7ff4ff3224dad4
+  metadata.gz: 552944e31e98a88fcdeff590ffca5b9a10bfe0150f74feb9c907b92b3597776e64bde50e29115072523f9df8acea495caad3ae61e964095bb8b44dfa9fafe968
+  data.tar.gz: 19a1d398e0255684aa3c8c4269d857cee51c25be4c7e6828741fad86c040ce5de5994a7cc7565644c8610c1939bcbb98ab036349b54db693b843896531135ab9

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+### 0.33.2 / 2018-10-29
+
+* Rename delay methods to modify_ack_deadline
+  * Rename modify_ack_deadling aliases to delay
+  * This maintains backwards compatibility
+
 ### 0.33.1 / 2018-10-03
 
 * Update connection configuration.

data/OVERVIEW.md

@@ -257,7 +257,8 @@ A message must be acknowledged after it is pulled, or Pub/Sub will mark the
 message for redelivery. The message acknowledgement deadline can delayed if more
 time is needed. This will allow more time to process the message before the
 message is marked for redelivery. (See
-{Google::Cloud::Pubsub::ReceivedMessage#delay! ReceivedMessage#delay!})
+{Google::Cloud::Pubsub::ReceivedMessage#modify_ack_deadline!
+ReceivedMessage#modify_ack_deadline!})
 
 ```ruby
 require "google/cloud/pubsub"
@@ -269,7 +270,7 @@ subscriber = sub.listen do |received_message|
   puts received_message.message.data
 
   # Delay for 2 minutes
-  received_message.delay! 120
+  received_message.modify_ack_deadline! 120
 end
 
 # Start background threads that will call the block passed to listen.
@@ -302,7 +303,8 @@ subscriber.stop.wait!
 ```
 
 Multiple messages can be delayed or made available for immediate redelivery:
-(See {Google::Cloud::Pubsub::Subscription#delay Subscription#delay})
+(See {Google::Cloud::Pubsub::Subscription#modify_ack_deadline
+Subscription#modify_ack_deadline})
 
 ```ruby
 require "google/cloud/pubsub"
@@ -311,7 +313,7 @@ pubsub = Google::Cloud::Pubsub.new
 
 sub = pubsub.subscription "my-topic-sub"
 received_messages = sub.pull
-sub.delay 120, received_messages
+sub.modify_ack_deadline 120, received_messages
 ```
 
 ## Creating a snapshot and using seek

data/lib/google/cloud/pubsub/async_publisher.rb

@@ -189,6 +189,8 @@ module Google
 
         protected
 
+        # rubocop:disable Naming/MemoizedInstanceVariableName
+
         def init_resources!
           @first_published_at   ||= Time.now
           @publish_thread_pool  ||= Concurrent::FixedThreadPool.new \
@@ -198,6 +200,8 @@ module Google
           @thread ||= Thread.new { run_background }
         end
 
+        # rubocop:enable Naming/MemoizedInstanceVariableName
+
         def run_background
           synchronize do
             until @stopped

data/lib/google/cloud/pubsub/received_message.rb

@@ -147,7 +147,7 @@ module Google
         #     puts received_message.message.data
         #
         #     # Delay for 2 minutes
-        #     received_message.delay! 120
+        #     received_message.modify_ack_deadline! 120
         #   end
         #
         #   # Start background threads that will call block passed to listen.
@@ -156,11 +156,11 @@ module Google
         #   # Shut down the subscriber when ready to stop receiving messages.
         #   subscriber.stop.wait!
         #
-        def delay! new_deadline
+        def modify_ack_deadline! new_deadline
           ensure_subscription!
-          subscription.delay new_deadline, ack_id
+          subscription.modify_ack_deadline new_deadline, ack_id
         end
-        alias modify_ack_deadline! delay!
+        alias delay! modify_ack_deadline!
 
         ##
         # Resets the acknowledge deadline for the message without acknowledging

data/lib/google/cloud/pubsub/subscriber.rb

@@ -57,7 +57,8 @@ module Google
       #   handle the received messages. Default is 8.
       # @attr_reader [Integer] push_threads The number of threads to handle
       #   acknowledgement ({ReceivedMessage#ack!}) and delay messages
-      #   ({ReceivedMessage#nack!}, {ReceivedMessage#delay!}). Default is 4.
+      #   ({ReceivedMessage#nack!}, {ReceivedMessage#modify_ack_deadline!}).
+      #   Default is 4.
       #
       class Subscriber
         include MonitorMixin

data/lib/google/cloud/pubsub/subscriber/async_stream_pusher.rb

@@ -68,7 +68,7 @@ module Google
             nil
           end
 
-          def delay deadline, ack_ids
+          def modify_ack_deadline deadline, ack_ids
             return true if ack_ids.empty?
 
             synchronize do
@@ -93,6 +93,7 @@ module Google
 
             nil
           end
+          alias delay modify_ack_deadline
 
           def start
             synchronize do

data/lib/google/cloud/pubsub/subscriber/async_unary_pusher.rb

@@ -68,7 +68,7 @@ module Google
             nil
           end
 
-          def delay deadline, ack_ids
+          def modify_ack_deadline deadline, ack_ids
             return true if ack_ids.empty?
 
             synchronize do
@@ -93,6 +93,7 @@ module Google
 
             nil
           end
+          alias delay modify_ack_deadline
 
           def start
             synchronize do

data/lib/google/cloud/pubsub/subscriber/enumerator_queue.rb

@@ -13,8 +13,6 @@
 # limitations under the License.
 
 
-require "thread"
-
 module Google
   module Cloud
     module Pubsub

data/lib/google/cloud/pubsub/subscriber/stream.rb

@@ -144,7 +144,7 @@ module Google
 
           ##
           # @private
-          def delay deadline, *messages
+          def modify_ack_deadline deadline, *messages
             mod_ack_ids = coerce_ack_ids messages
             return true if mod_ack_ids.empty?
 
@@ -157,6 +157,7 @@ module Google
 
             true
           end
+          alias delay modify_ack_deadline
 
           def async_pusher
             synchronize { @async_pusher }

data/lib/google/cloud/pubsub/subscription.rb

@@ -491,15 +491,15 @@ module Google
         #
         #   sub = pubsub.subscription "my-topic-sub"
         #   received_messages = sub.pull
-        #   sub.delay 120, received_messages
+        #   sub.modify_ack_deadline 120, received_messages
         #
-        def delay new_deadline, *messages
+        def modify_ack_deadline new_deadline, *messages
           ack_ids = coerce_ack_ids messages
           ensure_service!
           service.modify_ack_deadline name, ack_ids, new_deadline
           true
         end
-        alias modify_ack_deadline delay
+        alias delay modify_ack_deadline
 
         ##
         # Creates a new {Snapshot} from the subscription. The created snapshot

data/lib/google/cloud/pubsub/version.rb

@@ -16,7 +16,7 @@
 module Google
   module Cloud
     module Pubsub
-      VERSION = "0.33.1".freeze
+      VERSION = "0.33.2".freeze
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-cloud-pubsub
 version: !ruby/object:Gem::Version
-  version: 0.33.1
+  version: 0.33.2
 platform: ruby
 authors:
 - Mike Moore
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-03 00:00:00.000000000 Z
+date: 2018-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-cloud-core
@@ -157,14 +157,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.50.0
+        version: 0.59.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.50.0
+        version: 0.59.2
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement