google-cloud-bigquery 1.18.1 → 1.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5906552349d5601779e5fc80cbc4dbcb054ecbc810885fa6db0ec617e2253a2a
-  data.tar.gz: 3e077eaf5f351d697058b97a89cc2fccc0c8a9f2af6f8d8263f2ea5ae7f738da
+  metadata.gz: 65c8bae8c365c4fde7d54e75abe9c15aa4eba702b2e6300371843bc97bbc27f7
+  data.tar.gz: 5457cacd3331a717f63b0d71b907aa5e68702256118cd41d16f90be672f187e4
 SHA512:
-  metadata.gz: 3c031b1150418cb31a835b9996c6ce31322ffc5b3cbefd05520283ffb11695967c920ec051ab53f726e8968f9c343fd1839b355bc23483145556f5c401ab1c4e
-  data.tar.gz: da68f76f39a126cc17069a7e071721771321faeade8ee916b3cf33a580c5fccb775a463ea2e8046be803b4ca984a84833b3c21589082dc0f6aacf101e85a5fb5
+  metadata.gz: b7f0438c001bccc0854ecf13b81909c056635a50489d074c8d91beb13ba3f5e00826663b20371ef7b0669a6cfcb3ee058da8eefc6ffcfd410e9da18d1dd82167
+  data.tar.gz: 05f8d06e52e06625655730e0c31ae57a8b6bec5c771809d73814413db90122477b143d494d0e8236f43782766673a0f0230b48480f9ce0cddb125b55065cc68a

data/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Release History
 
+### 1.19.0 / 2020-02-11
+
+#### Features
+
+* Add Routine
+  * Add Dataset#create_routine
+  * Add Argument
+  * Update StandardSql classes to expose public initializer
+  * Add Data#ddl_target_routine and QueryJob#ddl_target_routine
+* Allow row inserts to skip insert_id generation
+  * Streaming inserts using an insert_id are not able to be inserted as fast as inserts without an insert_id
+  * Add the ability for users to skip insert_id generation in order to speed up the inserts
+  * The default behavior continues to generate insert_id values for each row inserted
+  * Add yield documentation for Dataset#insert
+
 ### 1.18.1 / 2019-12-18
 
 #### Bug Fixes

data/lib/google/cloud/bigquery/argument.rb

@@ -0,0 +1,197 @@
+# Copyright 2020 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+
+require "google/cloud/bigquery/standard_sql"
+
+module Google
+  module Cloud
+    module Bigquery
+      ##
+      # # Argument
+      #
+      # Input/output argument of a function or a stored procedure. See {Routine}.
+      #
+      # @example
+      #   require "google/cloud/bigquery"
+      #
+      #   bigquery = Google::Cloud::Bigquery.new
+      #   dataset = bigquery.dataset "my_dataset"
+      #   routine = dataset.create_routine "my_routine" do |r|
+      #     r.routine_type = "SCALAR_FUNCTION"
+      #     r.language = :SQL
+      #     r.body = "(SELECT SUM(IF(elem.name = \"foo\",elem.val,null)) FROM UNNEST(arr) AS elem)"
+      #     r.arguments = [
+      #       Google::Cloud::Bigquery::Argument.new(
+      #         name: "arr",
+      #         argument_kind: "FIXED_TYPE",
+      #         data_type: Google::Cloud::Bigquery::StandardSql::DataType.new(
+      #           type_kind: "ARRAY",
+      #           array_element_type: Google::Cloud::Bigquery::StandardSql::DataType.new(
+      #             type_kind: "STRUCT",
+      #             struct_type: Google::Cloud::Bigquery::StandardSql::StructType.new(
+      #               fields: [
+      #                 Google::Cloud::Bigquery::StandardSql::Field.new(
+      #                   name: "name",
+      #                   type: Google::Cloud::Bigquery::StandardSql::DataType.new(type_kind: "STRING")
+      #                 ),
+      #                 Google::Cloud::Bigquery::StandardSql::Field.new(
+      #                   name: "val",
+      #                   type: Google::Cloud::Bigquery::StandardSql::DataType.new(type_kind: "INT64")
+      #                 )
+      #               ]
+      #             )
+      #           )
+      #         )
+      #       )
+      #     ]
+      #   end
+      #
+      class Argument
+        ##
+        # Creates a new, immutable Argument object.
+        #
+        # @overload initialize(data_type, kind, mode, name)
+        #   @param [StandardSql::DataType, String] data_type The data type of the argument. Required unless
+        #     {#argument_kind} is `ANY_TYPE`.
+        #   @param [String] argument_kind The kind of argument. Optional. Defaults to `FIXED_TYPE`.
+        #
+        #     * `FIXED_TYPE` - The argument is a variable with fully specified type, which can be a struct or an array,
+        #       but not a table.
+        #     * `ANY_TYPE` - The argument is any type, including struct or array, but not a table.
+        #
+        #     To be added: `FIXED_TABLE`, `ANY_TABLE`.
+        #   @param [String] mode Specifies whether the argument is input or output. Optional. Can be set for procedures
+        #     only.
+        #
+        #     * IN - The argument is input-only.
+        #     * OUT - The argument is output-only.
+        #     * INOUT - The argument is both an input and an output.
+        #   @param [String] name The name of the argument. Optional. Can be absent for a function return argument.
+        #
+        def initialize **kwargs
+          kwargs[:data_type] = StandardSql::DataType.gapi_from_string_or_data_type kwargs[:data_type]
+          @gapi = Google::Apis::BigqueryV2::Argument.new(**kwargs)
+        end
+
+        ##
+        # The data type of the argument. Required unless {#argument_kind} is `ANY_TYPE`.
+        #
+        # @return [StandardSql::DataType] The data type.
+        #
+        def data_type
+          StandardSql::DataType.from_gapi @gapi.data_type
+        end
+
+        ##
+        # The kind of argument. Optional. Defaults to `FIXED_TYPE`.
+        #
+        # * `FIXED_TYPE` - The argument is a variable with fully specified type, which can be a struct or an array, but
+        #   not a table.
+        # * `ANY_TYPE` - The argument is any type, including struct or array, but not a table.
+        #
+        # To be added: `FIXED_TABLE`, `ANY_TABLE`.
+        #
+        # @return [String] The upper case kind of argument.
+        #
+        def argument_kind
+          @gapi.argument_kind
+        end
+
+        ##
+        # Checks if the value of {#argument_kind} is `FIXED_TYPE`. The default is `true`.
+        #
+        # @return [Boolean] `true` when `FIXED_TYPE`, `false` otherwise.
+        #
+        def fixed_type?
+          return true if @gapi.argument_kind.nil?
+          @gapi.argument_kind == "FIXED_TYPE"
+        end
+
+        ##
+        # Checks if the value of {#argument_kind} is `ANY_TYPE`. The default is `false`.
+        #
+        # @return [Boolean] `true` when `ANY_TYPE`, `false` otherwise.
+        #
+        def any_type?
+          @gapi.argument_kind == "ANY_TYPE"
+        end
+
+        ##
+        # Specifies whether the argument is input or output. Optional. Can be set for procedures only.
+        #
+        # * IN - The argument is input-only.
+        # * OUT - The argument is output-only.
+        # * INOUT - The argument is both an input and an output.
+        #
+        # @return [String] The upper case input/output mode of the argument.
+        #
+        def mode
+          @gapi.mode
+        end
+
+        ##
+        # Checks if the value of {#mode} is `IN`. Can be set for procedures only. The default is `false`.
+        #
+        # @return [Boolean] `true` when `IN`, `false` otherwise.
+        #
+        def in?
+          @gapi.mode == "IN"
+        end
+
+        ##
+        # Checks if the value of {#mode} is `OUT`. Can be set for procedures only. The default is `false`.
+        #
+        # @return [Boolean] `true` when `OUT`, `false` otherwise.
+        #
+        def out?
+          @gapi.mode == "OUT"
+        end
+
+        ##
+        # Checks if the value of {#mode} is `INOUT`. Can be set for procedures only. The default is `false`.
+        #
+        # @return [Boolean] `true` when `INOUT`, `false` otherwise.
+        #
+        def inout?
+          @gapi.mode == "INOUT"
+        end
+
+        ##
+        #
+        # The name of the argument. Optional. Can be absent for a function return argument.
+        #
+        # @return [String] The name of the argument.
+        #
+        def name
+          @gapi.name
+        end
+
+        ##
+        # @private
+        def to_gapi
+          @gapi
+        end
+
+        ##
+        # @private New Argument from a Google API Client object.
+        def self.from_gapi gapi
+          new.tap do |a|
+            a.instance_variable_set :@gapi, gapi
+          end
+        end
+      end
+    end
+  end
+end

data/lib/google/cloud/bigquery/copy_job.rb

@@ -152,7 +152,7 @@ module Google
           #
           # @return [Google::Cloud::Bigquery::CopyJob::Updater] A job
           #   configuration object for setting copy options.
-          def self.from_options service, source, target, options = {}
+          def self.from_options service, source, target, options
             job_ref = service.job_ref_from options[:job_id], options[:prefix]
             copy_cfg = Google::Apis::BigqueryV2::JobConfigurationTableCopy.new(
               source_table:      source,
@@ -284,6 +284,23 @@ module Google
             @gapi.configuration.update! labels: value
           end
 
+          def cancel
+            raise "not implemented in #{self.class}"
+          end
+
+          def rerun!
+            raise "not implemented in #{self.class}"
+          end
+
+          def reload!
+            raise "not implemented in #{self.class}"
+          end
+          alias refresh! reload!
+
+          def wait_until_done!
+            raise "not implemented in #{self.class}"
+          end
+
           ##
           # @private Returns the Google API client library version of this job.
           #

data/lib/google/cloud/bigquery/data.rb

@@ -316,6 +316,21 @@ module Google
           job_gapi&.statistics&.query&.ddl_operation_performed
         end
 
+        ##
+        # The DDL target routine, in reference state. (See {Routine#reference?}.)
+        # Present only for `CREATE/DROP FUNCTION/PROCEDURE` queries. (See
+        # {#statement_type}.)
+        #
+        # @return [Google::Cloud::Bigquery::Routine, nil] The DDL target routine, in
+        #   reference state.
+        #
+        def ddl_target_routine
+          ensure_service!
+          routine = job_gapi&.statistics&.query&.ddl_target_routine
+          return nil if routine.nil?
+          Google::Cloud::Bigquery::Routine.new_reference_from_gapi routine, service
+        end
+
         ##
         # The DDL target table, in reference state. (See {Table#reference?}.)
         # Present only for `CREATE/DROP TABLE/VIEW` queries. (See

data/lib/google/cloud/bigquery/dataset.rb

@@ -18,6 +18,7 @@ require "google/cloud/errors"
 require "google/cloud/bigquery/service"
 require "google/cloud/bigquery/table"
 require "google/cloud/bigquery/model"
+require "google/cloud/bigquery/routine"
 require "google/cloud/bigquery/external"
 require "google/cloud/bigquery/dataset/list"
 require "google/cloud/bigquery/dataset/access"
@@ -731,8 +732,7 @@ module Google
         #
         def tables token: nil, max: nil
           ensure_service!
-          options = { token: token, max: max }
-          gapi = service.list_tables dataset_id, options
+          gapi = service.list_tables dataset_id, token: token, max: max
           Table::List.from_gapi gapi, service, dataset_id, max
         end
 
@@ -817,6 +817,174 @@ module Google
           Model::List.from_gapi gapi, service, dataset_id, max
         end
 
+        ##
+        # Creates a new routine. The following attributes may be set in the yielded block:
+        # {Routine::Updater#routine_type=}, {Routine::Updater#language=}, {Routine::Updater#arguments=},
+        # {Routine::Updater#return_type=}, {Routine::Updater#imported_libraries=}, {Routine::Updater#body=}, and
+        # {Routine::Updater#description=}.
+        #
+        # @param [String] routine_id The ID of the routine. The ID must contain only
+        #   letters (a-z, A-Z), numbers (0-9), or underscores (_). The maximum length
+        #   is 256 characters.
+        # @yield [routine] A block for setting properties on the routine.
+        # @yieldparam [Google::Cloud::Bigquery::Routine::Updater] routine An updater to set additional properties on the
+        #   routine.
+        #
+        # @return [Google::Cloud::Bigquery::Routine] A new routine object.
+        #
+        # @example
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #   dataset = bigquery.dataset "my_dataset"
+        #
+        #   routine = dataset.create_routine "my_routine" do |r|
+        #     r.routine_type = "SCALAR_FUNCTION"
+        #     r.language = "SQL"
+        #     r.arguments = [
+        #       Google::Cloud::Bigquery::Argument.new(name: "x", data_type: "INT64")
+        #     ]
+        #     r.body = "x * 3"
+        #     r.description = "My routine description"
+        #   end
+        #
+        #   puts routine.routine_id
+        #
+        # @example Extended example:
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #   dataset = bigquery.dataset "my_dataset"
+        #   routine = dataset.create_routine "my_routine" do |r|
+        #     r.routine_type = "SCALAR_FUNCTION"
+        #     r.language = :SQL
+        #     r.body = "(SELECT SUM(IF(elem.name = \"foo\",elem.val,null)) FROM UNNEST(arr) AS elem)"
+        #     r.arguments = [
+        #       Google::Cloud::Bigquery::Argument.new(
+        #         name: "arr",
+        #         argument_kind: "FIXED_TYPE",
+        #         data_type: Google::Cloud::Bigquery::StandardSql::DataType.new(
+        #           type_kind: "ARRAY",
+        #           array_element_type: Google::Cloud::Bigquery::StandardSql::DataType.new(
+        #             type_kind: "STRUCT",
+        #             struct_type: Google::Cloud::Bigquery::StandardSql::StructType.new(
+        #               fields: [
+        #                 Google::Cloud::Bigquery::StandardSql::Field.new(
+        #                   name: "name",
+        #                   type: Google::Cloud::Bigquery::StandardSql::DataType.new(type_kind: "STRING")
+        #                 ),
+        #                 Google::Cloud::Bigquery::StandardSql::Field.new(
+        #                   name: "val",
+        #                   type: Google::Cloud::Bigquery::StandardSql::DataType.new(type_kind: "INT64")
+        #                 )
+        #               ]
+        #             )
+        #           )
+        #         )
+        #       )
+        #     ]
+        #   end
+        #
+        # @!group Routine
+        #
+        def create_routine routine_id
+          ensure_service!
+          new_tb = Google::Apis::BigqueryV2::Routine.new(
+            routine_reference: Google::Apis::BigqueryV2::RoutineReference.new(
+              project_id: project_id, dataset_id: dataset_id, routine_id: routine_id
+            )
+          )
+          updater = Routine::Updater.new new_tb
+
+          yield updater if block_given?
+
+          gapi = service.insert_routine dataset_id, updater.to_gapi
+          Routine.from_gapi gapi, service
+        end
+
+        ##
+        # Retrieves an existing routine by ID.
+        #
+        # @param [String] routine_id The ID of a routine.
+        # @param [Boolean] skip_lookup Optionally create just a local reference
+        #   object without verifying that the resource exists on the BigQuery
+        #   service. Calls made on this object will raise errors if the resource
+        #   does not exist. Default is `false`. Optional.
+        #
+        # @return [Google::Cloud::Bigquery::Routine, nil] Returns `nil` if the
+        #   routine does not exist.
+        #
+        # @example
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #   dataset = bigquery.dataset "my_dataset"
+        #
+        #   routine = dataset.routine "my_routine"
+        #   puts routine.routine_id
+        #
+        # @example Avoid retrieving the routine resource with `skip_lookup`:
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #
+        #   dataset = bigquery.dataset "my_dataset"
+        #
+        #   routine = dataset.routine "my_routine", skip_lookup: true
+        #
+        # @!group Routine
+        #
+        def routine routine_id, skip_lookup: nil
+          ensure_service!
+          return Routine.new_reference project_id, dataset_id, routine_id, service if skip_lookup
+          gapi = service.get_routine dataset_id, routine_id
+          Routine.from_gapi gapi, service
+        rescue Google::Cloud::NotFoundError
+          nil
+        end
+
+        ##
+        # Retrieves the list of routines belonging to the dataset.
+        #
+        # @param [String] token A previously-returned page token representing
+        #   part of the larger set of results to view.
+        # @param [Integer] max Maximum number of routines to return.
+        # @param [String] filter If set, then only the routines matching this filter are returned. The current supported
+        #   form is `routineType:`, with a {Routine#routine_type} enum value. Example: `routineType:SCALAR_FUNCTION`.
+        #
+        # @return [Array<Google::Cloud::Bigquery::Routine>] An array of routines
+        #   (See {Google::Cloud::Bigquery::Routine::List})
+        #
+        # @example
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #   dataset = bigquery.dataset "my_dataset"
+        #
+        #   routines = dataset.routines
+        #   routines.each do |routine|
+        #     puts routine.routine_id
+        #   end
+        #
+        # @example Retrieve all routines: (See {Routine::List#all})
+        #   require "google/cloud/bigquery"
+        #
+        #   bigquery = Google::Cloud::Bigquery.new
+        #   dataset = bigquery.dataset "my_dataset"
+        #
+        #   routines = dataset.routines
+        #   routines.all do |routine|
+        #     puts routine.routine_id
+        #   end
+        #
+        # @!group Routine
+        #
+        def routines token: nil, max: nil, filter: nil
+          ensure_service!
+          gapi = service.list_routines dataset_id, token: token, max: max, filter: filter
+          Routine::List.from_gapi gapi, service, dataset_id, max, filter: filter
+        end
+
         ##
         # Queries data by creating a [query
         # job](https://cloud.google.com/bigquery/docs/query-overview#query_jobs).
@@ -1073,7 +1241,7 @@ module Google
         #
         #   job.wait_until_done!
         #   if !job.failed?
-        #     table_ref = job.ddl_target_table
+        #     table_ref = job.ddl_target_table # Or ddl_target_routine for CREATE/DROP FUNCTION/PROCEDURE
         #   end
         #
         # @example Execute a DML statement:
@@ -1321,7 +1489,7 @@ module Google
         #
         #   data = bigquery.query "CREATE TABLE my_table (x INT64)"
         #
-        #   table_ref = data.ddl_target_table
+        #   table_ref = data.ddl_target_table # Or ddl_target_routine for CREATE/DROP FUNCTION/PROCEDURE
         #
         # @example Execute a DML statement:
         #   require "google/cloud/bigquery"
@@ -1942,7 +2110,7 @@ module Google
         #   dataset = bigquery.dataset "my_dataset", skip_lookup: true
         #   dataset.exists? # true
         #
-        def exists? force: nil
+        def exists? force: false
           return gapi_exists? if force
           # If we have a memoized value, return it
           return @exists unless @exists.nil?
@@ -2052,7 +2220,7 @@ module Google
         end
 
         ##
-        # @private New lazy Dataset object without making an HTTP request.
+        # @private New lazy Dataset object without making an HTTP request, for use with the skip_lookup option.
         def self.new_reference project_id, dataset_id, service
           raise ArgumentError, "dataset_id is required" unless dataset_id
           new.tap do |b|
@@ -2083,12 +2251,13 @@ module Google
         # @param [String] table_id The ID of the destination table.
         # @param [Hash, Array<Hash>] rows A hash object or array of hash objects
         #   containing the data. Required.
-        # @param [Array<String>] insert_ids A unique ID for each row. BigQuery
-        #   uses this property to detect duplicate insertion requests on a
-        #   best-effort basis. For more information, see [data
-        #   consistency](https://cloud.google.com/bigquery/streaming-data-into-bigquery#dataconsistency).
-        #   Optional. If not provided, the client library will assign a UUID to
-        #   each row before the request is sent.
+        # @param [Array<String|Symbol>, Symbol] insert_ids A unique ID for each row. BigQuery uses this property to
+        #   detect duplicate insertion requests on a best-effort basis. For more information, see [data
+        #   consistency](https://cloud.google.com/bigquery/streaming-data-into-bigquery#dataconsistency). Optional. If
+        #   not provided, the client library will assign a UUID to each row before the request is sent.
+        #
+        #  The value `:skip` can be provided to skip the generation of IDs for all rows, or to skip the generation of an
+        #  ID for a specific row in the array.
         # @param [Boolean] skip_invalid Insert all valid rows of a request, even
         #   if invalid rows exist. The default value is `false`, which causes
         #   the entire request to fail if any invalid rows exist.
@@ -2099,6 +2268,12 @@ module Google
         #   a new table with the given `table_id`, if no table is found for
         #   `table_id`. The default value is false.
         #
+        # @yield [table] a block for setting the table
+        # @yieldparam [Google::Cloud::Bigquery::Table::Updater] table An updater
+        #   to set additional properties on the table in the API request to
+        #   create it. Only used when `autocreate` is set and the table does not
+        #   already exist.
+        #
         # @return [Google::Cloud::Bigquery::InsertResponse] An insert response
         #   object.
         #
@@ -2144,32 +2319,19 @@ module Google
         #
         # @!group Data
         #
-        def insert table_id, rows, insert_ids: nil, skip_invalid: nil, ignore_unknown: nil, autocreate: nil
+        def insert table_id, rows, insert_ids: nil, skip_invalid: nil, ignore_unknown: nil, autocreate: nil, &block
           rows = [rows] if rows.is_a? Hash
+          raise ArgumentError, "No rows provided" if rows.empty?
+
+          insert_ids = Array.new(rows.count) { :skip } if insert_ids == :skip
           insert_ids = Array insert_ids
           if insert_ids.count.positive? && insert_ids.count != rows.count
             raise ArgumentError, "insert_ids must be the same size as rows"
           end
 
           if autocreate
-            begin
-              insert_data table_id, rows,
-                          skip_invalid: skip_invalid, ignore_unknown: ignore_unknown, insert_ids: insert_ids
-            rescue Google::Cloud::NotFoundError
-              sleep rand(1..60)
-              begin
-                create_table table_id do |tbl_updater|
-                  yield tbl_updater if block_given?
-                end
-              # rubocop:disable Lint/HandleExceptions
-              rescue Google::Cloud::AlreadyExistsError
-              end
-              # rubocop:enable Lint/HandleExceptions
-
-              sleep 60
-              insert table_id, rows, skip_invalid: skip_invalid, ignore_unknown: ignore_unknown, autocreate: true,
-                                     insert_ids: insert_ids
-            end
+            insert_data_with_autocreate table_id, rows, skip_invalid: skip_invalid, ignore_unknown: ignore_unknown,
+                                                        insert_ids: insert_ids, &block
           else
             insert_data table_id, rows, skip_invalid: skip_invalid, ignore_unknown: ignore_unknown,
                                         insert_ids: insert_ids
@@ -2239,15 +2401,30 @@ module Google
 
         protected
 
-        def insert_data table_id, rows, skip_invalid: nil, ignore_unknown: nil,
-                        insert_ids: nil
+        def insert_data_with_autocreate table_id, rows, skip_invalid: nil, ignore_unknown: nil, insert_ids: nil
+          insert_data table_id, rows, skip_invalid: skip_invalid, ignore_unknown: ignore_unknown, insert_ids: insert_ids
+        rescue Google::Cloud::NotFoundError
+          sleep rand(1..60)
+          begin
+            create_table table_id do |tbl_updater|
+              yield tbl_updater if block_given?
+            end
+          # rubocop:disable Lint/HandleExceptions
+          rescue Google::Cloud::AlreadyExistsError
+          end
+          # rubocop:enable Lint/HandleExceptions
+
+          sleep 60
+          retry
+        end
+
+        def insert_data table_id, rows, skip_invalid: nil, ignore_unknown: nil, insert_ids: nil
           rows = [rows] if rows.is_a? Hash
           raise ArgumentError, "No rows provided" if rows.empty?
           ensure_service!
-          options = { skip_invalid:   skip_invalid,
-                      ignore_unknown: ignore_unknown,
-                      insert_ids:     insert_ids }
-          gapi = service.insert_tabledata dataset_id, table_id, rows, options
+          gapi = service.insert_tabledata dataset_id, table_id, rows, skip_invalid:   skip_invalid,
+                                                                      ignore_unknown: ignore_unknown,
+                                                                      insert_ids:     insert_ids
           InsertResponse.from_gapi rows, gapi
         end
 
@@ -2444,14 +2621,14 @@ module Google
         end
 
         ##
-        # Yielded to a block to accumulate changes for a patch request.
+        # Yielded to a block to accumulate changes for a create request. See {Project#create_dataset}.
         class Updater < Dataset
           ##
-          # A list of attributes that were updated.
+          # @private A list of attributes that were updated.
           attr_reader :updates
 
           ##
-          # Create an Updater object.
+          # @private Create an Updater object.
           def initialize gapi
             @updates = []
             @gapi = gapi
@@ -2468,8 +2645,109 @@ module Google
             @access
           end
 
+          # rubocop:disable Style/MethodDefParentheses
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def delete(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def create_table(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def create_view(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def table(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def tables(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def model(*)
+            raise "not implemented in #{self.class}"
+          end
+
           ##
-          # Make sure any access changes are saved
+          # @raise [RuntimeError] not implemented
+          def models(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def create_routine(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def routine(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def routines(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def query_job(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def query(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def external(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def load_job(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def load(*)
+            raise "not implemented in #{self.class}"
+          end
+
+          ##
+          # @raise [RuntimeError] not implemented
+          def reload!
+            raise "not implemented in #{self.class}"
+          end
+          alias refresh! reload!
+
+          # rubocop:enable Style/MethodDefParentheses
+
+          ##
+          # @private Make sure any access changes are saved
           def check_for_mutated_access!
             return if @access.nil?
             return unless @access.changed?
@@ -2477,6 +2755,8 @@ module Google
             patch_gapi! :access
           end
 
+          ##
+          # @private
           def to_gapi
             check_for_mutated_access!
             @gapi