google-ads-common 0.9.6 → 0.9.7

data/ChangeLog

@@ -1,3 +1,6 @@
+0.9.7:
+  - Removed deprecated ClientLogin support.
+
 0.9.6:
   - Support for 'choice' types in API requests.
 

data/lib/ads_common/api.rb

@@ -24,7 +24,6 @@ require 'logger'
 require 'ads_common/config'
 require 'ads_common/errors'
 require 'ads_common/utils'
-require 'ads_common/auth/client_login_handler'
 require 'ads_common/auth/oauth2_handler'
 require 'ads_common/auth/oauth2_jwt_handler'
 
@@ -192,16 +191,6 @@ module AdsCommon
     def create_auth_handler()
       auth_method = @config.read('authentication.method', :OAUTH2)
       return case auth_method
-        when :CLIENTLOGIN
-          @logger.warn("ClientLogin authentication method is now deprecated" +
-              " and will be removed in the future. Consider migration to" +
-              " OAuth2. See 'https://developers.google.com/accounts/docs/" +
-              "AuthForInstalledApps' for more details.")
-          AdsCommon::Auth::ClientLoginHandler.new(
-              @config,
-              api_config.client_login_config(:AUTH_SERVER),
-              api_config.client_login_config(:LOGIN_SERVICE_NAME)
-          )
         when :OAUTH
           raise AdsCommon::Errors::Error,
               'OAuth authorization method is deprecated, use OAuth2 instead.'

data/lib/ads_common/version.rb

@@ -21,6 +21,6 @@
 
 module AdsCommon
   module ApiConfig
-    CLIENT_LIB_VERSION = '0.9.6'
+    CLIENT_LIB_VERSION = '0.9.7'
   end
 end

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-common
 version: !ruby/object:Gem::Version
-  version: 0.9.6
+  version: 0.9.7
+  prerelease: 
 platform: ruby
 authors:
 - Sergio Gomes
@@ -9,11 +10,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-09 00:00:00.000000000 Z
+date: 2015-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -21,6 +23,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -28,6 +31,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: httpi
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -35,6 +39,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -42,6 +47,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: signet
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -49,6 +55,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -60,70 +67,69 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- COPYING
-- ChangeLog
-- README.md
 - lib/ads_common/api.rb
-- lib/ads_common/api_config.rb
-- lib/ads_common/auth/base_handler.rb
+- lib/ads_common/version.rb
+- lib/ads_common/errors.rb
 - lib/ads_common/auth/client_login_handler.rb
+- lib/ads_common/auth/base_handler.rb
 - lib/ads_common/auth/oauth2_handler.rb
 - lib/ads_common/auth/oauth2_jwt_handler.rb
-- lib/ads_common/build/savon_abstract_generator.rb
-- lib/ads_common/build/savon_generator.rb
+- lib/ads_common/credential_handler.rb
+- lib/ads_common/api_config.rb
+- lib/ads_common/utils.rb
+- lib/ads_common/build/savon_service_generator.rb
 - lib/ads_common/build/savon_registry.rb
 - lib/ads_common/build/savon_registry_generator.rb
-- lib/ads_common/build/savon_service_generator.rb
+- lib/ads_common/build/savon_abstract_generator.rb
+- lib/ads_common/build/savon_generator.rb
 - lib/ads_common/config.rb
-- lib/ads_common/credential_handler.rb
-- lib/ads_common/errors.rb
-- lib/ads_common/http.rb
 - lib/ads_common/parameters_validator.rb
-- lib/ads_common/results_extractor.rb
 - lib/ads_common/savon_headers/base_header_handler.rb
 - lib/ads_common/savon_headers/oauth_header_handler.rb
+- lib/ads_common/results_extractor.rb
+- lib/ads_common/http.rb
 - lib/ads_common/savon_service.rb
-- lib/ads_common/utils.rb
-- lib/ads_common/version.rb
-- test/coverage.rb
 - test/suite_unittests.rb
-- test/test_client_login_handler.rb
+- test/coverage.rb
+- test/test_results_extractor.rb
 - test/test_config.rb
-- test/test_config.yml
+- test/test_utils.rb
 - test/test_credential_handler.rb
-- test/test_parameters_validator.rb
-- test/test_results_extractor.rb
 - test/test_savon_service.rb
-- test/test_utils.rb
+- test/test_config.yml
+- test/test_parameters_validator.rb
+- COPYING
+- README.md
+- ChangeLog
 homepage: http://code.google.com/p/google-api-ads-ruby/
 licenses:
 - Apache-2.0
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: google-ads-common
-rubygems_version: 2.2.2
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Common code for Google Ads APIs
 test_files:
+- test/test_results_extractor.rb
+- test/test_config.rb
 - test/test_utils.rb
 - test/test_credential_handler.rb
-- test/test_parameters_validator.rb
-- test/test_client_login_handler.rb
-- test/test_results_extractor.rb
 - test/test_savon_service.rb
-- test/test_config.rb
+- test/test_parameters_validator.rb

checksums.yaml

@@ -1,15 +0,0 @@
----
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    Y2VjOTE1ODA4OGQzOGY2NmU4MDczOWE4OTYwMzUwMDgzNTg3YzU0OQ==
-  data.tar.gz: !binary |-
-    MzFiODExZTFhOTQ3OGI5NzU3NWFmYzRiYzZmOWRkOGFjYjhkM2U0NQ==
-SHA512:
-  metadata.gz: !binary |-
-    ZWE4MDc2MTQzNjEyMDRhNzE2ZjhkZTI0ODhjM2Y3ZDIzMDAyMjIyZmYyNThi
-    Y2JjODZjNjQ3ZmNkZGZjZDA0Mjk1YWUzMTZlNTVjMDBhZDNjNTAwOWQwZWY3
-    M2EwOTRiMzdhYzk5MDQ1M2JlOWFmOGMxODgwOWJhY2EyZDUzYTc=
-  data.tar.gz: !binary |-
-    ZWM4MmQxYTE0ODNjNTIzNDdjOTRjZTkzYTNhOGFiOWQ1N2ViNTdjNjkzOTQx
-    NDU0ZDIzNDJiZjcxM2FjZjg4ODI3OTFlY2I2MDFhMGRjZmM3MTIxNWRlZDQ4
-    NTUzMThkYWU1MmU1N2U5YWFkZDQxNTc2MWI4NzRlNDMxYzkxNTA=

data/test/test_client_login_handler.rb

@@ -1,131 +0,0 @@
-#!/usr/bin/env ruby
-# Encoding: utf-8
-#
-# Author:: api.dklimkin@gmail.com (Danial Klimkin)
-#
-# Copyright:: Copyright 2012, Google Inc. All Rights Reserved.
-#
-# License:: Licensed under the Apache License, Version 2.0 (the "License");
-#           you may not use this file except in compliance with the License.
-#           You may obtain a copy of the License at
-#
-#           http://www.apache.org/licenses/LICENSE-2.0
-#
-#           Unless required by applicable law or agreed to in writing, software
-#           distributed under the License is distributed on an "AS IS" BASIS,
-#           WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-#           implied.
-#           See the License for the specific language governing permissions and
-#           limitations under the License.
-#
-# Tests client login handler methods.
-
-require 'test/unit'
-
-require 'ads_common/config'
-require 'ads_common/auth/client_login_handler'
-
-module AdsCommon
-  module Auth
-    class ClientLoginHandler
-
-      public :parse_token_text
-      public :handle_login_error
-      public :validate_credentials
-      public :create_token_from_string
-    end
-  end
-end
-
-
-# Stub class for HTTP response.
-class ResponseStub
-
-  attr_reader :code
-  attr_reader :body
-
-  def initialize(code, body)
-    @code, @body = code, body
-  end
-end
-
-class TestClientLoginHandler < Test::Unit::TestCase
-
-  def setup()
-    config = AdsCommon::Config.new({})
-    @handler = AdsCommon::Auth::ClientLoginHandler.new(
-        config, 'http://www.google.com', 'adwords')
-  end
-
-  def test_handle_login_error_captcha()
-    assert_raises (AdsCommon::Errors::CaptchaRequiredError) do
-      response = ResponseStub.new(403, '')
-      results = {
-          'Error' => 'CaptchaRequired',
-          'CaptchaUrl' => '/account/test-captcha'
-      }
-      @handler.handle_login_error({}, response, results)
-    end
-  end
-
-  def test_handle_login_error_other()
-    assert_raises(AdsCommon::Errors::AuthError) do
-      response = ResponseStub.new(403, 'Body')
-      results = {'Error' => 'SomeError', 'Info' => 'SomeInfo'}
-      @handler.handle_login_error({}, response, results)
-    end
-  end
-
-  def test_parse_token_text_simple()
-    error_str = "BadAuthentication"
-    text = "Error=%s\n" % error_str
-    result = @handler.parse_token_text(text)
-    assert_equal(error_str, result['Error'])
-    assert_equal(['Error'], result.keys)
-  end
-
-  def test_parse_token_text_captcha()
-    captcha_token = "3u6_27iOel71j525g2tg252ge6t35g345XJtRuHYEYiTyAxsMPz2222442"
-    captcha_url = "Captcha?ctoken=3u245245rgfwrg5g2fw5x3xGqQBrk_AoXXJtRuHY%3a-V"
-    error_str = "CaptchaRequired"
-    url_str = "https://www.google.com/accounts/ErrorMsg?Email=example%40goog" +
-        "le.com&service=adwords&id=cr&timeStmp=1327400499&secTok=.AG5fkgtw45" +
-        "25gfref25gttrefwwrPeB8Xw%3D%3D"
-    text = "CaptchaToken=%s\nCaptchaUrl=%s\nError=%s\nUrl=%s\n" %
-        [captcha_token, captcha_url, error_str, url_str]
-    result = @handler.parse_token_text(text)
-    assert_equal(captcha_token, result['CaptchaToken'])
-    assert_equal(captcha_url, result['CaptchaUrl'])
-    assert_equal(error_str, result['Error'])
-    assert_equal(url_str, result['Url'])
-    assert_equal(['CaptchaToken', 'CaptchaUrl', 'Error', 'Url'],
-        result.keys.sort)
-  end
-
-  def test_validate_credentials_valid()
-    credentials1 = {:email => 'email@example.com', :password => 'qwerty'}
-    credentials2 = {:auth_token => 'QazSWXEDEDCE434234'}
-    assert_nothing_raised do
-      @handler.validate_credentials(credentials1)
-    end
-    assert_nothing_raised do
-      @handler.validate_credentials(credentials2)
-    end
-  end
-
-  def test_validate_credentials_invalid()
-    credentials1 = {:email => 'email@example.com'}
-    credentials2 = {:password => 'qwerty'}
-    assert_raises(AdsCommon::Errors::AuthError) do
-      @handler.validate_credentials(credentials1)
-    end
-    assert_raises(AdsCommon::Errors::AuthError) do
-      @handler.validate_credentials(credentials2)
-    end
-  end
-
-  def test_create_token_from_string()
-    test_text = 'fooBar'
-    assert_equal(test_text, @handler.create_token_from_string(test_text))
-  end
-end