google-ads-common 0.12.5 → 0.12.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2db986ad1bd370703b2924e95f491c684118272d
-  data.tar.gz: 9a7073d4830e50f02fb50f72858ba37947d609b0
+  metadata.gz: a4310819d97635131655a65b5d98849c18ec76cb
+  data.tar.gz: 63c393bcacd43a3c34763f12c8ec939499dac628
 SHA512:
-  metadata.gz: 761e14fe7e3534f325fee15aac89063fc3679b2be21715e7419e9ec124cfac2440080a0ef8d8744860ae80b16159aab5c226ebe2a9336495261cd5631782615d
-  data.tar.gz: 9f71f9c5d76eb075788f295edd25b549f1d0afc9eb45fc3483d9f4e10efc2e3410c847fb2aa233405451bb64944e379b8a2122130d7df70a280a9e6c1049234c
+  metadata.gz: dfc0517f0ad20ba3a4a2e39a7cb11ad711364c67def32b6833adbc873fbad27e994cd96c1b99005589c53cec604c4d28671e540a398a894c387a266c382c2800
+  data.tar.gz: 3ac22c22c57f716fa0e5dd822668d24e5c42c03f3cd6e5030650f88d701f2fea3a326f8adf4afd447dded0655c5ccd0280cba4f078b0296c95d76d7241b565b2

data/ChangeLog

@@ -1,3 +1,12 @@
+0.12.6:
+  - Added support for config param :oauth2_prompt and removed support for
+    :oauth2_approval_prompt, and updated URI parameter name. The expected value
+    for this parameter has changed along with this naming change. For example,
+    instead of using "force" you should use "consent".
+    For more information, see here:
+    https://developers.google.com/identity/protocols/OAuth2UserAgent#formingtheurl
+  - Fixed issue #7.
+
 0.12.5:
   - Fixed issue #75.
 

data/README.md

@@ -24,6 +24,11 @@ The following gem libraries are required:
  - httpclient
  - signet
 
+Note: If you're using a version of Ruby lower than 2.2.2, you will need to
+manually install a previous version of Rack, a dependency of our HTTP library.
+You can do this with:
+
+    $ gem install rack -v 1.6.4
 
 # Docs for Developers
 

data/lib/ads_common/auth/oauth2_handler.rb

@@ -211,7 +211,7 @@ module AdsCommon
           if verification_code.nil? || verification_code.empty?
             uri_options = {
               :access_type => credentials[:oauth2_access_type],
-              :approval_prompt => credentials[:oauth2_approval_prompt]
+              :prompt => credentials[:oauth2_prompt]
             }.reject {|k, v| v.nil?}
             oauth_url = client.authorization_uri(uri_options)
             raise AdsCommon::Errors::OAuth2VerificationRequired.new(oauth_url)

data/lib/ads_common/config.rb

@@ -52,8 +52,8 @@ module AdsCommon
     def set(property_path, value)
       if property_path
         last_node = @config
-        last_name = property_path.split('.').inject(nil) do |last_name, section|
-          last_node = last_node[last_name] ||= {} unless last_name.nil?
+        last_name = property_path.split('.').inject(nil) do |name, section|
+          last_node = last_node[name] ||= {} unless name.nil?
           section.to_sym
         end
         last_node[last_name] = value
@@ -83,11 +83,11 @@ module AdsCommon
           @config = new_config
         else
           raise AdsCommon::Errors::Error,
-              "Incorrect configuration file: %s" % filename
+              "Incorrect configuration file: '%s'" % filename
         end
       rescue TypeError => e
         raise AdsCommon::Errors::Error,
-            "Error parsing configuration file: %s" % filename
+            "Error parsing configuration file: '%s' (%s)" % [filename, e]
       end
       return nil
     end

data/lib/ads_common/credential_handler.rb

@@ -49,7 +49,7 @@ module AdsCommon
       end
 
       # Find removed properties.
-      diff = @credentials.inject(diff) do |result, (key, value)|
+      diff = @credentials.inject(diff) do |result, (key, _)|
         result << [key, nil] unless new_credentials.include?(key)
         result
       end

data/lib/ads_common/results_extractor.rb

@@ -62,7 +62,7 @@ module AdsCommon
     # Normalizes output starting with root output node.
     def normalize_output(output_data, method_definition)
       fields = method_definition[:output][:fields]
-      result = normalize_fields(output_data, fields)
+      return normalize_fields(output_data, fields)
     end
 
     # Normalizes all fields for the given data based on the fields list
@@ -102,9 +102,9 @@ module AdsCommon
       result = data
       # Convert a specific structure to a handy hash if detected.
       if check_key_value_struct(result)
-        result = convert_key_value_to_hash(result).inject({}) do |result, (k,v)|
-          result[k] = normalize_output_field(v, field_def)
-          result
+        result = convert_key_value_to_hash(result).inject({}) do |s, (k,v)|
+          s[k] = normalize_output_field(v, field_def)
+          s
         end
       else
         result = data.map {|item| normalize_output_field(item, field_def)}

data/lib/ads_common/savon_service.rb

@@ -109,7 +109,7 @@ module AdsCommon
       original_action_name = action if original_action_name.nil?
       response = @client.request(original_action_name) do |soap, wsdl, http|
         soap.body = args
-        header_handler.prepare_request(http, soap)
+        @header_handler.prepare_request(http, soap)
         soap.namespaces.merge!(extra_namespaces) unless extra_namespaces.nil?
         return soap.to_xml if xml_only
       end

data/lib/ads_common/version.rb

@@ -19,6 +19,6 @@
 
 module AdsCommon
   module ApiConfig
-    CLIENT_LIB_VERSION = '0.12.5'
+    CLIENT_LIB_VERSION = '0.12.6'
   end
 end

data/test/test_config.rb

@@ -63,7 +63,7 @@ class TestConfig < Test::Unit::TestCase
   # Test initializer with an incorrect existing file.
   def test_initialize_filename_incorrect
     assert_raises (AdsCommon::Errors::Error) do
-      config = AdsCommon::Config.new('/dev/null')
+      AdsCommon::Config.new('/dev/null')
     end
   end
 

data/test/test_env.rb

@@ -35,4 +35,9 @@ class TestEnv < Test::Unit::TestCase
     puts "\nUsing OpenSSL %s with %d methods.\n" %
         [OpenSSL::OPENSSL_VERSION, OpenSSL::SSL::SSLContext::METHODS.count]
   end
+
+  # Output rake version to the tests log.
+  def test_rake_version
+    puts "\nRunning with rake %s.\n" % Rake::VERSION if defined?(Rake)
+  end
 end

data/test/test_oauth2_handler.rb

@@ -69,7 +69,7 @@ class TestOAuth < Test::Unit::TestCase
 
     # Make sure that we are still able to refresh the token.
     assert_nothing_raised do
-      token = handler.refresh_token!();
+      handler.refresh_token!();
     end
   end
 

data/test/test_results_extractor.rb

@@ -82,8 +82,7 @@ class TestResultsExtractor < Test::Unit::TestCase
   end
 
   def test_normalize_item_long()
-    result1 = @extractor.normalize_item(2147483648,
-        {:type => 'long'})
+    result1 = @extractor.normalize_item(2147483648, {:type => 'long'})
     assert_kind_of(Integer, result1)
     assert_equal(2147483648, result1, 'bad conversion')
 
@@ -102,26 +101,21 @@ class TestResultsExtractor < Test::Unit::TestCase
     result3 = @extractor.normalize_item('true', {:type => 'boolean'})
     assert_kind_of(TrueClass, result3)
 
-    result4 = @extractor.normalize_item('false',
-        {:type => 'boolean'})
+    result4 = @extractor.normalize_item('false', {:type => 'boolean'})
     assert_kind_of(FalseClass, result4)
 
-    result5 = @extractor.normalize_item('True',
-        {:type => 'boolean'})
-    assert_kind_of(TrueClass, result3)
+    result5 = @extractor.normalize_item('True', {:type => 'boolean'})
+    assert_kind_of(TrueClass, result5)
 
-    result6 = @extractor.normalize_item('False',
-        {:type => 'boolean'})
-    assert_kind_of(FalseClass, result4)
+    result6 = @extractor.normalize_item('False', {:type => 'boolean'})
+    assert_kind_of(FalseClass, result6)
   end
 
   def test_normalize_item_object()
-    result1 = @extractor.normalize_item({:a => 'b'},
-        {:type => 'StubClass'})
+    result1 = @extractor.normalize_item({:a => 'b'}, {:type => 'StubClass'})
     assert_equal('b', result1[:a], 'object corrupted')
 
-    result2 = @extractor.normalize_item(@extractor,
-        {:type => 'SavonService'})
+    result2 = @extractor.normalize_item(@extractor, {:type => 'SavonService'})
     assert_equal(@extractor.hash, result2.hash, 'object corrupted')
   end
 

data/test/test_savon_service.rb

@@ -20,10 +20,6 @@
 
 require 'test/unit'
 
-# Work around jruby <= 1.7.8 issue with OpenSSL definition.
-require 'openssl'
-OpenSSL::SSL::SSLContext::METHODS = []
-
 require 'ads_common/config'
 require 'ads_common/savon_service'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-common
 version: !ruby/object:Gem::Version
-  version: 0.12.5
+  version: 0.12.6
 platform: ruby
 authors:
 - Sergio Gomes
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-20 00:00:00.000000000 Z
+date: 2016-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-ads-savon
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.0.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.0.2
 - !ruby/object:Gem::Dependency
   name: httpi
   requirement: !ruby/object:Gem::Requirement