google-ads-common 0.12.3 → 0.12.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8d34659b849a7c7d8c74e8c55ec41687e20b6f27
-  data.tar.gz: b0166a1ea29fec1b996d2dcd1b7d7c56e3e7088e
+  metadata.gz: 3f6a5db7dfd14b7bf4d37bdbc437877bc0c62e00
+  data.tar.gz: 4f6a32a4c035bc75da84395ebf93f074eb262b34
 SHA512:
-  metadata.gz: 8cf1179914225735a33c703ae6457fee953007e9b264c039027bd7c54d5ddde6df99cde904d2c3a8987efda61f4270cbb0773942a7779c1071c458e5e4fe2bd8
-  data.tar.gz: 63934b55ddbc67f57356779acacfe7a2cdf4e9b90a9cd4ee447a3b8eeb44e2419fe36e28a182db9df75a34a8493e1218414a82eeb51fcd8ae7835a1258746830
+  metadata.gz: af9f3aed5785a4c41c5608b286b7e9eb949085866815357f90d59cdb8319c9ccba0748c7ca44888f37342cb4919197b8cf417f5b7a40d15d41f60cab52e2377e
+  data.tar.gz: 412ac052f5c5730a06bbe08b63f8ba3837df2059312f2625a3a3d5e03592223d43bc928ba679c36deacb69e8539cef9e7efbc1e9b6a65498cade2110a5a05ac8

data/ChangeLog

@@ -1,8 +1,11 @@
-0.12.3
+0.12.4:
+  - Started enforcing minumum Ruby runtime version via gemspec.
+
+0.12.3:
   - Fix discrepancy in version between Github and RubyGems due to failure to
     push to Github.
 
-0.12.2
+0.12.2:
   - Fix permissions for Ads Common gem.
 
 0.12.1:

data/lib/ads_common/auth/oauth2_service_account_handler.rb

@@ -115,13 +115,13 @@ module AdsCommon
         end
 
         if credentials[:oauth2_key].nil? && credentials[:oauth2_keyfile].nil?
-          raise AdsCommon::Errors::AuthError,
-              'Either key or key file must be provided for OAuth2 service account.'
+          raise AdsCommon::Errors::AuthError, 'Either key or key file must ' +
+              'be provided for OAuth2 service account.'
         end
 
         if credentials[:oauth2_key] && credentials[:oauth2_keyfile]
-          raise AdsCommon::Errors::AuthError,
-              'Both service account key and key file provided, only one can be used.'
+          raise AdsCommon::Errors::AuthError, 'Both service account key and ' +
+              'key file provided, only one can be used.'
         end
 
         p12 = true
@@ -152,8 +152,8 @@ module AdsCommon
 
         if credentials[:oauth2_key] &&
             !credentials[:oauth2_key].kind_of?(OpenSSL::PKey::RSA)
-          raise AdsCommon::Errors::AuthError,
-              'OAuth2 service account key provided must be of type OpenSSL::PKey::RSA.'
+          raise AdsCommon::Errors::AuthError, 'OAuth2 service account key ' +
+              'provided must be of type OpenSSL::PKey::RSA.'
         end
       end
 

data/lib/ads_common/env_check.rb

@@ -19,18 +19,11 @@
 
 require 'ads_common/errors'
 
-MIN_RUBY_VERSION = Gem::Version.new('2.0')
 MIN_RUBY_RECOMMENDED_VERSION = Gem::Version.new('2.1')
 
-if Gem::Version.new(RUBY_VERSION.dup()) < MIN_RUBY_VERSION
-  raise AdsCommon::Errors::VersionError,
-      'Unsupported Ruby version %s. Upgrade to version %s or later' %
-      [RUBY_VERSION, MIN_RUBY_RECOMMENDED_VERSION]
-end
-
 # Checks current ruby version to make sure it's supported.
 def check_version(logger)
-  if Gem::Version.new(RUBY_VERSION) < MIN_RUBY_RECOMMENDED_VERSION
+  if Gem::Version.new(RUBY_VERSION.dup()) < MIN_RUBY_RECOMMENDED_VERSION
     logger.warn(
         ('You are using a deprecated version of Ruby (%s). ' +
         'Consider upgrading to a fully supported version %s or later') %

data/lib/ads_common/version.rb

@@ -19,6 +19,6 @@
 
 module AdsCommon
   module ApiConfig
-    CLIENT_LIB_VERSION = '0.12.3'
+    CLIENT_LIB_VERSION = '0.12.4'
   end
 end

data/test/test_credential_handler.rb

@@ -89,7 +89,7 @@ class TestCredentialHandler < Test::Unit::TestCase
   end
 
   def test_auth_handler_callback_once()
-    mock = MiniTest::Mock.new()
+    mock = Minitest::Mock.new()
     mock.expect(:property_changed,  nil, [:foo, 'bar'])
     @handler.set_auth_handler(mock)
     @handler.set_credential(:foo, 'bar')
@@ -101,21 +101,21 @@ class TestCredentialHandler < Test::Unit::TestCase
 
     credentials[:foo] = 'bar'
     credentials[:baz] = 42
-    mock1 = MiniTest::Mock.new()
+    mock1 = Minitest::Mock.new()
     mock1.expect(:property_changed, nil, [:baz, 42])
     @handler.set_auth_handler(mock1)
     @handler.credentials = credentials
     assert(mock1.verify)
 
     credentials.delete(:baz)
-    mock2 = MiniTest::Mock.new()
+    mock2 = Minitest::Mock.new()
     mock2.expect(:property_changed, nil, [:baz, nil])
     @handler.set_auth_handler(mock2)
     @handler.credentials = credentials
     assert(mock2.verify)
 
     credentials[:foo] = nil
-    mock3 = MiniTest::Mock.new()
+    mock3 = Minitest::Mock.new()
     mock3.expect(:property_changed, nil, [:foo, nil])
     mock3.expect(:property_changed, nil, [:baz, nil])
     @handler.set_auth_handler(mock3)

data/test/test_oauth2_handler.rb

@@ -65,7 +65,7 @@ class TestOAuth < Test::Unit::TestCase
     handler.setup_client()
     assert_not_nil(handler.client)
     handler.client.issued_at = Time.now.to_s
-    assert_equal(String, handler.client.issued_at.class)
+    assert_equal(Time, handler.client.issued_at.class)
 
     # Make sure that we are still able to refresh the token.
     assert_nothing_raised do

data/test/test_oauth2_service_account_handler.rb

@@ -34,13 +34,13 @@ end
 class TestOAuthServiceAccount < Test::Unit::TestCase
   def test_file_extension_check()
     assert_nothing_raised do
-      validate_credentials(["test", ".json"])
+      validate_credentials(['test', '.json'])
     end
     assert_nothing_raised do
-      validate_credentials(["test", ".p12"])
+      validate_credentials(['test', '.p12'])
     end
-    assert_raise do
-      validate_credentials(["test", ".other"])
+    assert_raises(AdsCommon::Errors::AuthError) do
+      validate_credentials(['test', '.other'])
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-common
 version: !ruby/object:Gem::Version
-  version: 0.12.3
+  version: 0.12.4
 platform: ruby
 authors:
 - Sergio Gomes
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-23 00:00:00.000000000 Z
+date: 2016-08-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-ads-savon
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.1
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: httpi
   requirement: !ruby/object:Gem::Requirement
@@ -138,7 +138,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -146,17 +146,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: google-ads-common
-rubygems_version: 2.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Common code for Google Ads APIs
 test_files:
-- test/test_env.rb
-- test/test_results_extractor.rb
+- test/test_savon_service.rb
 - test/test_config.rb
-- test/test_utils.rb
+- test/test_oauth2_service_account_handler.rb
 - test/test_credential_handler.rb
-- test/test_oauth2_handler.rb
-- test/test_savon_service.rb
+- test/test_utils.rb
 - test/test_parameters_validator.rb
-- test/test_oauth2_service_account_handler.rb
+- test/test_oauth2_handler.rb
+- test/test_env.rb
+- test/test_results_extractor.rb