goog_currency 0.0.4 → 0.0.5

data/.travis.yml

@@ -2,5 +2,6 @@ language: ruby
 rvm:
   - "1.9.2"
   - "1.9.3"
+  - "2.0.0"
 # uncomment this line if your project needs to run something other than `rake`:
 script: bundle exec rspec spec

data/README.md

@@ -30,6 +30,16 @@ Throws GoogCurrency::Exception in case of any error.
 
 Throws GoogCurrency::NoMethodException if conversion method syntax is invalid.
 
+## Ruby versions support
+
+Supports Ruby 1.9.2 and 2.0.0
+
+Ruby 1.8.7, has encoding issues.
+
+## TODO
+
+Fix for Ruby 1.8.7
+
 ## Contributing
 
 1. Fork it

data/goog_currency.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |gem|
   gem.email         = ["girish.sonawane@gmail.com"]
   gem.description   = %q{Ruby Gem for currency conversion using Google API}
   gem.summary       = %q{Simple Ruby interface to Google Currency API}
-  gem.add_runtime_dependency 'rest-client', '~> 1.6.7'
+  gem.add_runtime_dependency 'rest-client'
   gem.add_runtime_dependency 'json'
   
   gem.add_development_dependency "rspec", "~> 2.12.0"

data/lib/goog_currency.rb

@@ -1,39 +1,36 @@
 require "goog_currency/version"
 require 'rest_client'
 require 'json'
-require 'iconv' 
+
 module GoogCurrency
   def self.method_missing(meth, *args)
     from, to = meth.to_s.split("_to_")
-    
+
     if from.nil? or to.nil?
       raise NoMethodException, "GoogCurrency accepts methods in 'usd_to_inr' or 'gbp_to_usd' format"
     end
-    
+
     response = RestClient.get("http://www.google.com/ig/calculator?hl=en&q=#{args.first}#{from.upcase}=?#{to.upcase}").body
-    
+
     # response is not valid json
+    # Remove unicode character used as thousands separator by the Google API
+    encoding_options = {
+      :invalid           => :replace,  # Replace invalid byte sequences
+      :undef             => :replace,  # Replace anything not defined in ASCII
+      :replace           => ''        # Use a blank for those replacements
+      #:universal_newline => true       # Always break lines with \n
+    }
+    response = response.encode(Encoding.find('ASCII'), encoding_options)
     response.gsub!(/(lhs|rhs|error|icc)/, '"\1"')
     response_hash = JSON.parse(response)
 
     if response_hash['error'].nil? or response_hash['error'] == ''
-      #
-      # Remove unicode character used as thousands separator by the Google API
-      # Thanks to Nathan Long, http://stackoverflow.com/a/9420531
-      #
-      #encoding_options = {
-          #:invalid           => :replace,  # Replace invalid byte sequences
-          #:undef             => :replace,  # Replace anything not defined in ASCII
-          #:replace           => '',        # Use a blank for those replacements
-          #:universal_newline => true       # Always break lines with \n
-        #}
-        #response_hash['rhs'].encode(Encoding.find('ASCII'), encoding_options).to_f
-      Iconv.conv('ASCII//IGNORE', 'UTF8', response_hash['rhs']).to_f
+      response_hash['rhs'].to_f
     else
       raise Exception, "An error occurred: #{response_hash['error']}"
     end
   end
-  
+
   class Exception < StandardError; end
   class NoMethodException < StandardError; end
 end

data/lib/goog_currency/version.rb

@@ -1,3 +1,3 @@
 module GoogCurrency
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/goog_currency_spec.rb

@@ -10,7 +10,7 @@ VALID
 valid100_response =<<-VALID_100
 {lhs: "100 U.S. dollar",rhs: "5\u0080483.6587 Indian rupees",error: "",icc: true}
 VALID_100
-
+ 
 invalid_response =<<-INVALID
 {lhs: "",rhs: "",error: "4",icc: false}
 INVALID
@@ -34,6 +34,12 @@ describe "GoogCurrency" do
       usd = GoogCurrency.usd_to_inr(100)
       usd.should == 5483.6587
     end
+
+    it  "ignores new thousands separator correctly" do
+      # performs live api call, not possible to reproduce the string
+      # returned by the api
+      expect { GoogCurrency.usd_to_inr(100) }.to_not raise_error 
+    end
   end
 
   describe "invalid currencies" do
@@ -52,4 +58,4 @@ describe "GoogCurrency" do
     end
   end
 
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: goog_currency
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-29 00:00:00.000000000 Z
+date: 2013-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -17,15 +17,15 @@ dependencies:
   requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.6.7
+        version: '0'
   version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.6.7
+        version: '0'
   prerelease: false
 - !ruby/object:Gem::Dependency
   name: json
@@ -106,7 +106,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       segments:
       - 0
       version: '0'
-      hash: -1032122126172519155
+      hash: 3862151153092687607
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -115,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       segments:
       - 0
       version: '0'
-      hash: -1032122126172519155
+      hash: 3862151153092687607
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25