goog_currency 0.0.1 → 0.0.2

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2012 Girish S
+Copyright (c) 2013 Girish Sonawane
 
 MIT License
 

data/README.md

@@ -2,6 +2,8 @@
 
 A simple Ruby interface for currency conversion using Google API. Uses http://www.google.com/ig/calculator?hl=en&q=100USD=?INR
 
+Current version: 0.0.2
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -20,8 +22,9 @@ Or install it yourself as:
 
 Sample usage
 
-    usd = GoogCurrency.usd_to_inr(1)
-    gbp = GoogCurrency.usd_to_gbp(1)
+    rupees = GoogCurrency.usd_to_inr(1)
+    pounds = GoogCurrency.usd_to_gbp(1)
+    yen = GoogCurrency.gbp_to_jpy(1)
 
 Throws GoogCurrency::Exception in case of any error.
 
@@ -34,3 +37,9 @@ Throws GoogCurrency::NoMethodException if conversion method syntax is invalid.
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+## Licence
+MIT License
+
+Copyright (c) 2013 Girish Sonawane
+

data/goog_currency.gemspec

@@ -8,7 +8,7 @@ Gem::Specification.new do |gem|
   gem.version       = GoogCurrency::VERSION
   gem.authors       = ["Girish S"]
   gem.email         = ["girish.sonawane@gmail.com"]
-  gem.description   = %q{Gem for currency conversion using Google API}
+  gem.description   = %q{Ruby Gem for currency conversion using Google API}
   gem.summary       = %q{Simple Ruby interface to Google Currency API}
   gem.add_runtime_dependency 'rest-client', '~> 1.6.7'
   gem.add_runtime_dependency 'json', '~> 1.7.5'

data/lib/goog_currency.rb

@@ -7,7 +7,7 @@ module GoogCurrency
     from, to = meth.to_s.split("_to_")
     
     if from.nil? or to.nil?
-      raise GoogCurrency::NoMethodException, "GoogCurrency accepts methods in 'usd_to_inr' or 'gbp_to_usd' format"
+      raise NoMethodException, "GoogCurrency accepts methods in 'usd_to_inr' or 'gbp_to_usd' format"
     end
     
     response = RestClient.get("http://www.google.com/ig/calculator?hl=en&q=#{args.first}#{from.upcase}=?#{to.upcase}").body
@@ -17,9 +17,19 @@ module GoogCurrency
     response_hash = JSON.parse(response)
 
     if response_hash['error'].nil? or response_hash['error'] == ''
-      response_hash['rhs'].to_f
+      #
+      # Remove unicode character used as thousands separator by the Google API
+      # Thanks to Nathan Long, http://stackoverflow.com/a/9420531
+      #
+      encoding_options = {
+          :invalid           => :replace,  # Replace invalid byte sequences
+          :undef             => :replace,  # Replace anything not defined in ASCII
+          :replace           => '',        # Use a blank for those replacements
+          :universal_newline => true       # Always break lines with \n
+        }
+        response_hash['rhs'].encode(Encoding.find('ASCII'), encoding_options).to_f
     else
-      raise GoogCurrency::Exception, "An error occurred: #{response_hash['error']}"
+      raise Exception, "An error occurred: #{response_hash['error']}"
     end
   end
   

data/lib/goog_currency/version.rb

@@ -1,3 +1,3 @@
 module GoogCurrency
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/goog_currency_spec.rb

@@ -7,6 +7,10 @@ valid_response =<<-VALID
 {lhs: "1 U.S. dollar",rhs: "54.836587 Indian rupees",error: "",icc: true}
 VALID
 
+valid100_response =<<-VALID_100
+{lhs: "100 U.S. dollar",rhs: "5\u0080483.6587 Indian rupees",error: "",icc: true}
+VALID_100
+
 invalid_response =<<-INVALID
 {lhs: "",rhs: "",error: "4",icc: false}
 INVALID
@@ -21,6 +25,15 @@ describe "GoogCurrency" do
       usd = GoogCurrency.usd_to_inr(1)
       usd.should == 54.836587
     end
+
+    it  "ignores thousands separator correctly" do
+      FakeWeb.register_uri(:get,
+                           "http://www.google.com/ig/calculator?hl=en&q=100USD=?INR",
+                           :status => "200",
+                           :body => valid100_response)
+      usd = GoogCurrency.usd_to_inr(100)
+      usd.should == 5483.6587
+    end
   end
 
   describe "invalid currencies" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: goog_currency
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-07 00:00:00.000000000 Z
+date: 2013-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -75,7 +75,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.3.0
-description: Gem for currency conversion using Google API
+description: Ruby Gem for currency conversion using Google API
 email:
 - girish.sonawane@gmail.com
 executables: []