goodwill 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e719b975ab0646de6f53fe98886aec39e1854ee99801c825d7ac7301ffa13f40
-  data.tar.gz: 7e9bdce4e2ca7c0e7b621b40226073b11fea1f81e8809b13e62efe33fbee6c97
+  metadata.gz: 4067be1f98e0d4de75e6b2880f35d671d8d88b3d939aaa64b1e85c5448775759
+  data.tar.gz: e5eedc6e6208cbf1b9706349bf7485934c1b2c4d91f07a8d655775134dcf151c
 SHA512:
-  metadata.gz: b6d88107b867793646fccb768784e7831220614e3e2cd4cd25c33a37d7c7032cfa5cc06475c16b37d17351c851be3d4fb86975dd978b88288e32ca038b8c57c3
-  data.tar.gz: 56684c90f1313a7855054ba342d076d752405d9f387d43de2582b86f5f612e901d46167657d42453a2cf7c354b94e8d4e0817311487e4ef76bcdf33f426ab5b6
+  metadata.gz: a5351d1a764cf460f4e0850da86ae0f95da9608ead60742f25e42477d71bfbdf9a8fe2c78e7a28037060088b85c00f66db637dc0fa6ee193a51e7880a9f34dde
+  data.tar.gz: d1b3b90c793943446a2e0ac4b676b3785d2e4eb2d85ef997f59dbd8c030c170707b5049c06cc2867ddeb63f19077049c80a3fec22f1aa41f867e5ee2131dac0d

data/.travis.yml

@@ -1,9 +1,8 @@
 language: ruby
 rvm:
-- 2.2.0
-- 2.3.0
-- 2.4.0
 - 2.5.0
+- 2.6.0
+- 2.7.0
 before_install: gem install bundler
 script:
   - bundle exec rspec

data/lib/goodwill/account.rb

@@ -65,13 +65,14 @@ module Goodwill
       # -5 - bid less than minimum
       mechanize.get(BID_URL, params) do |page|
         res = JSON.parse(page.body)
-        if res['BidResult'] == 1
+        case res['BidResult']
+        when 1
           return true if res['BidResultMessage'].include?('Bid Received')
 
           return false if res['BidResultMessage'].include?('You have already been outbid.')
 
           raise Goodwill::BidError, res['BidResultMessage']
-        elsif res['BidResult'] == -5
+        when -5
           raise Goodwill::BidError, res['BidResultMessage']
         end
       end

data/lib/goodwill/auction.rb

@@ -15,17 +15,7 @@ module Goodwill
     include CSSPaths
     include URLPaths
 
-    attr_reader :item_page
-
-    attr_reader :bids
-    attr_reader :current
-    attr_reader :end
-    attr_reader :href
-    attr_reader :item
-    attr_reader :itemid
-    attr_reader :seller
-    attr_reader :shipping
-    attr_reader :type
+    attr_reader :item_page, :bids, :current, :end, :href, :item, :itemid, :seller, :shipping, :type
 
     def initialize(itemid, zipcode = '97222', state = 'OR', country = 'US')
       @itemid = itemid
@@ -70,6 +60,9 @@ module Goodwill
       params = "?ZipCode=#{zipcode}&Country=#{country}&ItemId=#{itemid}&Quantity=1&_=#{DateTime.now.strftime('%s')}"
       page = mechanize.get(SHIPPING_URL + params)
       page.search(SHIPPING_PATH).text.split(': ').last.tr('$', '').to_f
+    rescue StandardError
+      puts "Timeout (#{e}), retrying in 1 second..."
+      retry
     end
 
     def parse_end_time

data/lib/goodwill/biddingauction.rb

@@ -6,19 +6,10 @@ module Goodwill
   class BiddingAuction < Auction
     include URLPaths
 
-    attr_reader :bidding
-    attr_reader :winning
-    attr_reader :max
+    attr_reader :bidding, :winning, :max, :current, :end, :href, :item, :itemid, :seller, :shipping
 
     # TODO: why do i need this?
     attr_reader :bids
-    attr_reader :current
-    attr_reader :end
-    attr_reader :href
-    attr_reader :item
-    attr_reader :itemid
-    attr_reader :seller
-    attr_reader :shipping
 
     def initialize(itemid, mechanize)
       super(itemid)

data/lib/goodwill/cli.rb

@@ -7,6 +7,7 @@ module Goodwill
     class_option :verbose, type: :boolean
     class_option :username
     class_option :password
+    class_option :threads
 
     def initialize(*args)
       super
@@ -14,7 +15,8 @@ module Goodwill
 
       username = options[:username] || ask('Username:')
       password = options[:password] || ask('Password:') { |q| q.echo = false }
-      @account = Goodwill::Account.new(username, password)
+      threads = options[:threads].to_i || 10
+      @account = Goodwill::Account.new(username, password, threads)
     end
 
     desc 'auctions', "List all auctions you're currently bidding on"

data/lib/goodwill/mechanize.rb

@@ -17,14 +17,12 @@ module Goodwill
         @username ||= nil
       end
 
-      attr_writer :username
+      attr_writer :username, :password
 
       def password
         @password ||= nil
       end
 
-      attr_writer :password
-
       def logged_in?
         @logged_in ||= false
       end

data/lib/goodwill/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Goodwill
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: goodwill
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Brandon Burnett
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-06-08 00:00:00.000000000 Z
+date: 2020-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gem-release