gooddata 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e42a132c41968e4869171cd83833ddd435d003f0
-  data.tar.gz: 5f57d656cdac4d45901f36a621b57404e109f80e
+SHA256:
+  metadata.gz: 349861ea9b8d256231dd3e3bc41f2db25c8b757f066dad7cae3d113be9e5afcc
+  data.tar.gz: 6c470979756fa2584e6d7ae10b6de76160e3705f0ccd0c3de95405cbb1662de1
 SHA512:
-  metadata.gz: c5c2cceaded37c876c3dafcf0999027aed0f2aeb9a8dd8620b99ff913b5c03d5facdfd3af81e4002ff87ada7d9f1dcb25230e566711ebf17d145178a2d885059
-  data.tar.gz: cf6c751bffac63afc799a6ac24ee3698417ec247067ea6c72db8db3916dd2cefc83c6b9b99de62ad23003ae3c55c758aef8ace3d08f31083ba1c9946bf4a1c84
+  metadata.gz: 38e9044811de4851d3c988fdb6b87e093dbf40ae2fb947056f08107b614564f7cf9078f46465017a9c4554215194b1a7f69f029b8d86086163d2c9fc2174e359
+  data.tar.gz: d8574354704c95e2cf71623079f5b1eea5115e9bd889c61c321ca7e3c10504eac7883c77c7bfd2394d19505049cef9b840675eba0e7baf6192b66a469a376bc5

data/.editorconfig

@@ -1,12 +1,9 @@
 root = true
 
-[*]
+[*.rb]
 indent_style = space
 indent_size = 2
-end_of_line = lf
 charset = utf-8
+end_of_line = lf
 trim_trailing_whitespace = true
 insert_final_newline = true
-
-[*.{sh,markdown}]
-indent_size = 4

data/.gitignore

@@ -43,4 +43,4 @@ deprecations.txt
 .vscode/settings.json
 
 # test cache files
-./spec/cache/
+spec/cache/

data/.travis.yml

@@ -1,24 +1,44 @@
 language: ruby
 cache: bundler
 stages:
-- unit
+- name: unit
+  if: type IN (push, pull_request)
 - name: integration
-  if: type IN (api, cron)
+  if: type IN (api)
+- name: periodic
+  if: type IN (cron)
+- name: cleanup
+  if: type IN (cron)
 jobs:
   include:
+  # unit
   - stage: unit
     name: unit tests
     script: bundle exec rake test:unit
     rvm:
     - 2.3
-    - jruby-9.1.7
+    - 2.4
+    - 2.5
+    - jruby-9.1.5
+    - jruby-9.1.14
+    - jruby-1.7.19
   - stage: unit
     name: pronto code review
     script: |
       git remote add upstream https://github.com/gooddata/gooddata-ruby.git
       git fetch upstream master
       bundle exec pronto run -c upstream/master --exit-code
-  - stage: integration
+  - stage: unit
+    name: sdk vcr tests
+    script: VCR_RECORD_MODE=none bundle exec rake test:sdk
+    rvm: jruby-9.1.14
+  - stage: unit
+    name: sdk vcr tests (project)
+    script: VCR_RECORD_MODE=none bundle exec rake test:project
+    rvm: jruby-9.1.14
+  # integration
+  - &lcm-integration-tests
+    stage: integration
     name: lcm integration tests
     script: |
       bundle exec rake -f lcm.rake docker:build
@@ -26,11 +46,88 @@ jobs:
       bundle exec rake -f lcm.rake test:integration:docker
     rvm:
     - jruby-9.1.7
-  - stage: integration
+  - &sdk-integration-tests
+    stage: integration
     name: sdk integration tests
     script: bundle exec rake test:sdk
-    rvm: jruby-9.1.7
-  - stage: integration
+    rvm: 2.5
+    env: VCR_ON=false
+  - &sdk-integration-tests-project
+    stage: integration
     name: sdk integration tests (project)
     script: bundle exec rake test:project
-    rvm: jruby-9.1.7
+    env: VCR_ON=false
+    rvm: 2.5
+  # periodic
+  # staging 1
+  - <<: *lcm-integration-tests
+    stage: periodic
+    name: staging1 - lcm integration tests
+    env:
+    - GD_ENV=staging
+    - VCR_ON=false
+  - <<: *sdk-integration-tests
+    stage: periodic
+    name: staging1 - sdk integration tests
+    env:
+    - GD_ENV=staging
+    - VCR_ON=false
+  - <<: *sdk-integration-tests-project
+    stage: periodic
+    name: staging1 - sdk integration tests (project)
+    env:
+    - GD_ENV=staging
+    - VCR_ON=false
+  # staging 2
+  - <<: *lcm-integration-tests
+    stage: periodic
+    name: staging2 - lcm integration tests
+    env:
+    - GD_ENV=testing
+    - VCR_ON=false
+  - <<: *sdk-integration-tests
+    stage: periodic
+    name: staging2 - sdk integration tests
+    env:
+    - GD_ENV=testing
+    - VCR_ON=false
+  - <<: *sdk-integration-tests-project
+    stage: periodic
+    name: staging2 - sdk integration tests (project)
+    env:
+    - GD_ENV=testing
+    - VCR_ON=false
+  # staging 3
+  - <<: *lcm-integration-tests
+    stage: periodic
+    name: staging3 - lcm integration tests
+    env:
+    - GD_ENV=development
+    - VCR_ON=false
+  - <<: *sdk-integration-tests
+    stage: periodic
+    name: staging3 - sdk integration tests
+    env:
+    - GD_ENV=development
+    - VCR_ON=false
+  - <<: *sdk-integration-tests-project
+    stage: periodic
+    name: staging3 - sdk integration tests (project)
+    env:
+    - GD_ENV=development
+    - VCR_ON=false
+  - &cleanup
+    stage: cleanup
+    name: staging1 - test environment clean-up
+    script: bundle exec ruby bin/test_projects_cleanup.rb -f
+    env: GD_ENV=staging
+  - <<: *cleanup
+    name: staging2 - test environment clean-up
+    env: GD_ENV=testing
+  - <<: *cleanup
+    name: staging3 - test environment clean-up
+    env: GD_ENV=development
+notifications:
+  slack:
+    secure: TyYks8rEBJMouWRjRtHZJJm+BIajxgwsoSIpxidZmD5zRk5ssEkGVbuYIvjUN+if1NyM1bmWspTSVX+8g5IDmt9PgcujXVqCbPRvfK90r3obs8A5pHbDnKEue6inqYUjNoqa1D6PkWTS1dTb6xvy8WiAwMGqoFGHnlNs4WFF9N4=
+    on_pull_requests: false

data/CHANGELOG.md

@@ -1,4 +1,45 @@
 # GoodData Ruby SDK Changelog
+## 1.3.3
+ - Fix git-ignoring project cache
+ - Fix style in vcr configurer
+ - TMA-1205: Fix vcr configurer setup
+ - Describe releasing process more accurately
+ - Fix editorconfig
+ - TMA-1190: Add cleanup stage to travis.yml
+ - gemspec cleanup: transitive deps, email, authors
+ - TMA-1190: Add test env clean-up script
+ - TMA-1185: Record vcr cassettes
+ - TMA-1185: Fix vcr for project cache
+ - TMA-1182: UFB extended spec passing
+ - TRIVIAL: remove redundant suffix
+ - BUGFIX: TMA-1183 don't use make_tmpname
+ - TMA-1181: use correct exit code from lcm integ. docker-compose
+ - TMA-782: do not rely on spec extensions
+ - Revert "TMA-1181: do not use docker for lcm-integration-tests"
+ - TMA-1152: logout and delete users after spec
+ - FEATURE: TMA-1165 Create Help brick and make it default entry point in Docker image
+ - TMA-1181: passing userprov spec
+ - TRIVIAL: use the correct ruby version's for tests in travis
+ - TMA-1181: do not use docker for lcm-integration-tests
+ - Add pry-byebug to dev dependencies
+ - Fix standalone calls to rspec expect
+ - TMA-782: transfer component type process thru lcm
+ - FEATURE: TMA-1165 Remove unused info bricks
+ - Enable travis notifications in slack
+ - Update gooddata.gemspec
+ - TMA-1048 update ads driver dependency
+ - Run unit tests in supported rubies
+ - Run cron job on staging env 1/2/3
+ - FEATURE: TMA-1034 Add Docker label containing LCM bricks version
+ - SETI-2444 fix docker run on jenkins slaves
+ - TMA-1014: parallel do_not_touch logic in UFB
+ - TMA-905: do not print dynamic schedule param value if the param is set as secure
+ - BUGFIX: TMA-1153 Adjust LCM brick syslog to be able to log to Splunk
+ - TMA-1100 fix productized connector deployment
+ - TMA-1071: Record VCR cassettes
+ - TMA-1071: Reenable VCR
+ - Add pry-byebug to dev dependencies
+
 ## 1.3.2
  - Add rake task for changelog preview
  - added possibility to run tests on PI

data/Dockerfile

@@ -1,11 +1,14 @@
 FROM harbor.intgdc.com/tools/gdc-java-8-jre:b057b53
 
 ARG GIT_COMMIT=unspecified
+ARG BRICKS_VERSION=unspecified
+
 LABEL image_name="GDC LCM Bricks"
 LABEL maintainer="LCM <lcm@gooddata.com>"
 LABEL git_repository_url="https://github.com/gooddata/gooddata-ruby/"
 LABEL parent_image="harbor.intgdc.com/tools/gdc-java-8-jre:b057b53"
 LABEL git_commit=$GIT_COMMIT
+LABEL bricks_version=$BRICKS_VERSION
 
 # which is required by RVM
 RUN yum install -y curl which \
@@ -32,4 +35,4 @@ ADD ./gooddata.gemspec .
 
 RUN /bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle install"
 
-CMD [ "./bin/hello_world.sh" ]
+CMD [ "./bin/help.sh" ]

data/Dockerfile.ruby

@@ -2,7 +2,7 @@ FROM ruby:2.3-alpine
 
 MAINTAINER Tomas Korcak <korczis@gmail.com>
 
-RUN apk add --no-cache curl make gcc git g++ python linux-headers binutils-gold gnupg libstdc++ openssl cmake
+RUN apk add --no-cache curl make gcc git g++ python linux-headers binutils-gold gnupg libstdc++ openssl cmake curl-dev
 
 RUN ln -s /usr/bin/make /usr/bin/gmake
 

data/Jenkinsfile

@@ -9,7 +9,10 @@ def config = [
         'microservices': [
                 'lcm-bricks': [
                         'docker': [
-                                'dockerfile': './Dockerfile'
+                                'dockerfile': './Dockerfile',
+                                'arguments': [
+                                        'BRICKS_VERSION': { readFile('./VERSION').trim() }
+                                ]
                         ]
                 ]
         ]

data/RELEASING.md

@@ -7,7 +7,7 @@
 1. `bundle install`
 1. bump version in [lib/gooddata/version.rb](lib/gooddata/version.rb)
 1. `bundle exec rake version:bump`
-1. push to master
+1. create PR to upstream and have it merged
 1. `git push origin tags/{version}`
 1. `rake gem:release`
 1. `rvm use jruby && rm Gemfile.lock && bundle install`

data/VERSION

@@ -0,0 +1 @@
+3.5.0

data/bin/help.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+/bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb help_brick"

data/bin/run_brick.rb

@@ -9,7 +9,7 @@ BRICK_PARAM_PREFIX = 'BRICK_PARAM_'
 brick_type = !ARGV.empty? ? ARGV[0] : DEFAULT_BRICK
 
 syslog_node = ENV['NODE_NAME']
-log = RemoteSyslogLogger.new(syslog_node, 514, :program => brick_type)
+log = RemoteSyslogLogger.new(syslog_node, 514, :program => "ruby_#{brick_type}", :facility => 'local2')
 
 log.info "action=#{brick_type}_execution status=init"
 

data/bin/test_projects_cleanup.rb

@@ -0,0 +1,97 @@
+example = 'GD_ENV=testing GD_SPEC_PASSWORD=secret bundle exec ruby bin/test_projects_cleanup.rb'
+
+if ARGV.include?('-h')
+  puts 'Example:'
+  puts example
+  exit 0
+end
+
+require 'gooddata'
+require_relative '../spec/environment/environment'
+GoodData::Environment.load
+config = GoodData::Environment::ConnectionHelper::LCM_ENVIRONMENT
+secrets = GoodData::Environment::ConnectionHelper::SECRETS
+
+def delete_project_by_title(title, projects, days = 14, force = false)
+  dead_line = Time.now - days * 60 * 60 * 24
+  filtered_projects = projects.select do |p|
+    p.title.match(title) && p.created < dead_line
+  end
+  filtered_projects.each do |project|
+    if force
+      puts "Deleting: #{project.pid} - #{project.title} - #{project.created}"
+      project_add = project.add
+      project_add && project_add.output_stage && project_add.output_stage.delete
+      project.delete
+    else
+      puts "Would delete: #{project.pid} - #{project.title} - #{project.created}"
+    end
+  end
+  puts "#{filtered_projects.length} projects matching \"#{title}\" #{'would be ' unless force}deleted."
+end
+
+def delete_ads_by_title(title, client, days = 14, force = false)
+  warehouses = client.warehouses
+  return if warehouses.empty?
+
+  deleted = 0
+  warehouses.each do |warehouse|
+    warehouse_title = warehouse.title
+    next unless warehouse_title.match(title)
+
+    dead_line = Time.now - days * 60 * 60 * 24
+    created = Time.parse(warehouse.data["created"])
+    next if created > dead_line
+
+    begin
+      if force
+        puts "Deleting: #{warehouse_title} - #{created}"
+        warehouse.delete
+      else
+        puts "Would delete:  #{warehouse_title} - #{created}"
+      end
+      deleted += 1
+    rescue StandardError => e
+      puts "Failed to delete #{warehouse_title}: #{e}"
+    end
+  end
+  puts "#{deleted} ADS instances with title \"#{title}\" #{'would be ' unless force}deleted."
+end
+
+def clean_up!(client, force, days)
+  projects = client.projects
+  delete_project_by_title(/Insurance Demo Master/, projects, days, force)
+  delete_project_by_title(/Car Demo Master/, projects, days, force)
+  delete_project_by_title(/Insurance Demo Workspace/, projects, days, force)
+  delete_project_by_title(/Client With Conflicting LDM/, projects, days, force)
+  delete_project_by_title(/Development Project/, projects, days, force)
+  delete_project_by_title(/lcm-test-fixture/, projects, days, force)
+  delete_project_by_title(/Test MASTER project/, projects, days, force)
+  delete_project_by_title(/Test MINOR project/, projects, days, force)
+  delete_project_by_title(/^Test project$/, projects, days, force)
+  delete_project_by_title(/userprov-e2e-testing/, projects, days, force)
+  delete_ads_by_title(/Development ADS/, client, days, force)
+  delete_ads_by_title(/Production ADS/, client, days, force)
+end
+
+def init_client(username, password, server)
+  GoodData.connect(
+    username,
+    password,
+    server: server,
+    verify_ssl: false,
+    timeout: nil
+  )
+end
+
+username = config[:username]
+password = secrets[:password]
+dev_client = init_client(username, password, "https://#{config[:dev_server]}")
+prod_client = init_client(username, password, "https://#{config[:prod_server]}")
+
+force = ARGV.include?('-f')
+days = 14
+clean_up!(dev_client, force, days)
+clean_up!(prod_client, force, days)
+
+dev_client.disconnect

data/gooddata.gemspec

@@ -13,12 +13,15 @@ Gem::Specification.new do |s|
     'Pavel Kolesnikov',
     'Thomas Watson Steen',
     'Tomas Svarovsky',
-    'Tomas Korcak'
+    'Tomas Korcak',
+    'Jan Zdrahal',
+    'Petr Gadorek',
+    'Jakub Mahnert'
   ]
 
   s.summary = 'A convenient Ruby wrapper around the GoodData RESTful API'
   s.description = 'Use the GoodData::Client class to integrate GoodData into your own application or use the CLI to work with GoodData directly from the command line.'
-  s.email = 'pavel@gooddata.com'
+  s.email = 'lcm@gooddata.com'
   s.extra_rdoc_files = %w(LICENSE README.md)
 
   s.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
@@ -42,6 +45,8 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'yard-rspec', '~> 0.1'
   s.add_development_dependency 'ZenTest', '~> 4.11'
   s.add_development_dependency 'pry'
+  s.add_development_dependency 'pry-byebug', '~> 3.6' if RUBY_PLATFORM != 'java'
+
   s.add_development_dependency 'pronto', '~> 0.9.5' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'pronto-rubocop', '~> 0.9.0' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'pronto-reek', '~> 0.9.0' if RUBY_PLATFORM != 'java'
@@ -53,8 +58,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'docile', '~> 1.1'
   s.add_dependency 'erubis', '~> 2.7'
   s.add_dependency 'gli', '~> 2.15'
-  s.add_dependency 'gooddata_datawarehouse' if RUBY_PLATFORM == 'java'
-  s.add_dependency 'gooddata-dss-jdbc', '0.1.12' if RUBY_PLATFORM == 'java'
+  s.add_dependency 'gooddata_datawarehouse', '~> 0.0.9' if RUBY_PLATFORM == 'java'
   s.add_dependency 'highline', '= 2.0.0.pre.develop.14'
   s.add_dependency 'json_pure', '~> 1.8'
   s.add_dependency 'multi_json', '~> 1.12'

data/lcm.rake

@@ -92,12 +92,8 @@ namespace :test do
   namespace :integration do
     desc 'Run integration tests in Docker'
     task :docker do
-      system('docker-compose -f docker-compose.lcm.yml up --force-recreate --abort-on-container-exit appstore')
-
-      # TODO: use exit-code-from after update to docker-compose >= 1.12
-      # system('docker-compose up --exit-code-from appstore') ||
-      #   fail('Test execution failed')
-      system(check_exit_code) || fail('Test execution failed!')
+      system('docker-compose -f docker-compose.lcm.yml up --force-recreate --abort-on-container-exit --exit-code-from appstore appstore') ||
+        fail('Test execution failed!')
     end
   end
   namespace :load do

data/lib/gooddata/bricks/hello_world_brick.rb

@@ -14,7 +14,7 @@ module GoodData
       # @option [String] 'message' text to be returned in result, if nill - nothing is returned
       # :reek:UtilityFunction
       def call(params)
-        GoodData::LCM2.perform('hello_world', params)
+        GoodData::LCM2.perform('hello', params)
       end
     end
   end

data/lib/gooddata/bricks/help_brick.rb

@@ -0,0 +1,17 @@
+require_relative 'brick'
+
+module GoodData
+  module Bricks
+    # Simple brick used for printing help message about bricks
+    class HelpBrick < GoodData::Bricks::Brick
+      def version
+        '0.0.1'
+      end
+
+      # Help brick entry-point
+      def call(params)
+        GoodData::LCM2.perform('help', params)
+      end
+    end
+  end
+end

data/lib/gooddata/bricks/pipeline.rb

@@ -99,6 +99,17 @@ module GoodData
           ]
         )
       end
+
+      def self.help_brick_pipeline
+        prepare(
+          [
+            DecodeParamsMiddleware,
+            LoggerMiddleware,
+            BenchMiddleware,
+            HelpBrick
+          ]
+        )
+      end
     end
   end
 end

data/lib/gooddata/helpers/global_helpers.rb

@@ -231,7 +231,10 @@ module GoodData
       end
 
       def decrypt(database64, key)
-        return '' if key.nil? || key.empty?
+        if key.nil? || key.empty?
+          puts 'WARNING: No encryption key provided.'
+          return 'no_key_provided'
+        end
 
         data = Base64.decode64(database64)
 

data/lib/gooddata/lcm/actions/collect_dynamic_schedule_params.rb

@@ -26,6 +26,9 @@ module GoodData
 
         description 'Value Column'
         param :param_value_column, instance_of(Type::StringType), required: false
+
+        description 'Should the param be hidden?'
+        param :param_secure_column, instance_of(Type::StringType), required: false
       end
 
       class << self
@@ -36,6 +39,7 @@ module GoodData
           client_id_column = params.client_id_column || 'client_id'
           param_name_column = params.param_name_column || 'param_name'
           param_value_column = params.param_value_column || 'param_value'
+          param_secure_column = params.param_secure_column || 'param_secure'
           results = []
 
           input_source = params.dynamic_params.input_source
@@ -43,16 +47,18 @@ module GoodData
           input_data = without_check(PARAMS, params) do
             File.open(data_source.realize(params), 'r:UTF-8')
           end
-          GoodData.logger.debug("Input data: #{input_data.read}")
 
           schedule_params = {}
 
           CSV.foreach(input_data, :headers => true, :return_headers => false, encoding: 'utf-8') do |row|
-            GoodData.logger.debug("Processing row: #{row}")
-            results << row.to_hash
-
-            client_id = row[client_id_column] ? row[client_id_column] : :all_clients
-            schedule_name = row[schedule_title_column] ? row[schedule_title_column] : :all_schedules
+            is_param_secure = row[param_secure_column] == 'true'
+            safe_to_print_row = row.to_hash
+            safe_to_print_row[param_value_column] = '******' if is_param_secure
+            GoodData.logger.debug("Processing row: #{safe_to_print_row}")
+            results << safe_to_print_row
+
+            client_id = row[client_id_column] || :all_clients
+            schedule_name = row[schedule_title_column] || :all_schedules
 
             schedule_params[client_id] ||= {}
             schedule_params[client_id][schedule_name] ||= {}

data/lib/gooddata/lcm/actions/help.rb

@@ -0,0 +1,33 @@
+# Copyright (c) 2010-2018 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata/bricks/pipeline'
+
+require_relative 'base_action'
+
+module GoodData
+  module LCM2
+    # Action responsible for printing bricks help
+    class Help < BaseAction
+      DESCRIPTION = 'Print Help Message'
+
+      PARAMS = {}
+
+      class << self
+        BRICK_PIPELINE_SUFFIX = /_brick_pipeline$/
+
+        def create_help
+          GoodData::Bricks::Pipeline.methods
+            .grep(BRICK_PIPELINE_SUFFIX)
+            .map { |method| method.to_s.sub(BRICK_PIPELINE_SUFFIX, '') }
+            .map { |available_brick| { available_brick: available_brick } }
+        end
+
+        def call(_params)
+          { results: create_help }
+        end
+      end
+    end
+  end
+end

data/lib/gooddata/lcm/actions/synchronize_etls_in_segment.rb

@@ -19,10 +19,16 @@ module GoodData
         param :synchronize, array_of(instance_of(Type::SynchronizationInfoType)), required: true, generated: true
 
         description 'Schedule Additional Parameters'
-        param :additional_params, instance_of(Type::HashType), required: false
+        param :additional_params, instance_of(Type::HashType), required: false, deprecated: true, replacement: :schedule_additional_params
 
         description 'Schedule Additional Secure Parameters'
-        param :additional_hidden_params, instance_of(Type::HashType), required: false
+        param :additional_hidden_params, instance_of(Type::HashType), required: false, deprecated: true, replacement: :schedule_additional_hidden_params
+
+        description 'Schedule Additional Parameters'
+        param :schedule_additional_params, instance_of(Type::HashType), required: false
+
+        description 'Schedule Additional Secure Parameters'
+        param :schedule_additional_hidden_params, instance_of(Type::HashType), required: false
 
         description 'Schedule Parameters'
         param :schedule_params, instance_of(Type::HashType), required: false, default: {}
@@ -50,6 +56,10 @@ module GoodData
         def call(params)
           client = params.gdc_gd_client
           data_product = params.data_product
+
+          schedule_additional_params = params.schedule_additional_params || params.additional_params
+          schedule_additional_hidden_params = params.schedule_additional_hidden_params || params.additional_hidden_params
+
           synchronize_segments = params.synchronize.group_by do |info|
             info[:segment_id]
           end
@@ -125,14 +135,14 @@ module GoodData
                   end
                 end
 
-                schedule.update_params(params.additional_params) if params.additional_params
+                schedule.update_params(schedule_additional_params) if schedule_additional_params
 
                 schedule.update_params(params_for_all_schedules_in_all_projects) if params_for_all_schedules_in_all_projects
                 schedule.update_params(params_for_all_projects[schedule.name]) if params_for_all_projects[schedule.name]
                 schedule.update_params(params_for_all_schedules_in_this_client) if params_for_all_schedules_in_this_client
                 schedule.update_params(params_for_this_client[schedule.name]) if params_for_this_client[schedule.name]
 
-                schedule.update_hidden_params(params.additional_hidden_params) if params.additional_hidden_params
+                schedule.update_hidden_params(schedule_additional_hidden_params) if schedule_additional_hidden_params
                 schedule.enable
                 schedule.save
               end

data/lib/gooddata/lcm/actions/synchronize_processes.rb

@@ -24,8 +24,8 @@ module GoodData
         description 'Logger'
         param :gdc_logger, instance_of(Type::GdLogger), required: true
 
-        description 'Additional Hidden Parameters'
-        param :additional_hidden_params, instance_of(Type::HashType), required: false
+        description 'Additional Hidden Parameters of Processes'
+        param :process_additional_hidden_params, instance_of(Type::HashType), required: false
       end
 
       RESULT_HEADER = [
@@ -59,7 +59,8 @@ module GoodData
                 from,
                 to_project,
                 ads_output_stage_uri: info.ads_output_stage_uri,
-                ads_output_stage_prefix: info.ads_output_stage_prefix
+                ads_output_stage_prefix: info.ads_output_stage_prefix,
+                additional_hidden_params: params.process_additional_hidden_params
               )
 
               to_project.add.output_stage.client_id = client_id if client_id && to_project.add.output_stage

data/lib/gooddata/lcm/actions/synchronize_schedules.rb

@@ -22,10 +22,16 @@ module GoodData
         param :synchronize, array_of(instance_of(Type::SynchronizationInfoType)), required: true, generated: true
 
         description 'Schedule Additional Parameters'
-        param :additional_params, instance_of(Type::HashType), required: false
+        param :additional_params, instance_of(Type::HashType), required: false, deprecated: true, replacement: :schedule_additional_params
 
         description 'Schedule Additional Secure Parameters'
-        param :additional_hidden_params, instance_of(Type::HashType), required: false
+        param :additional_hidden_params, instance_of(Type::HashType), required: false, deprecated: true, replacement: :schedule_additional_hidden_params
+
+        description 'Schedule Additional Parameters'
+        param :schedule_additional_params, instance_of(Type::HashType), required: false
+
+        description 'Schedule Additional Secure Parameters'
+        param :schedule_additional_hidden_params, instance_of(Type::HashType), required: false
 
         description 'Logger'
         param :gdc_logger, instance_of(Type::GdLogger), required: true
@@ -47,6 +53,9 @@ module GoodData
           client = params.gdc_gd_client
           development_client = params.development_client
 
+          schedule_additional_params = params.schedule_additional_params || params.additional_params
+          schedule_additional_hidden_params = params.schedule_additional_hidden_params || params.additional_hidden_params
+
           params.synchronize.peach do |info|
             from_project = info.from
             to_projects = info.to
@@ -68,8 +77,8 @@ module GoodData
                 # s.update_params('GOODOT_CUSTOM_PROJECT_ID' => c.id)
                 # s.update_params('CLIENT_ID' => c.id)
                 # s.update_params('SEGMENT_ID' => segment.id)
-                schedule.update_params(params.additional_params || {})
-                schedule.update_hidden_params(params.additional_hidden_params || {})
+                schedule.update_params(schedule_additional_params || {})
+                schedule.update_hidden_params(schedule_additional_hidden_params || {})
                 schedule.disable
                 schedule.save
 

data/lib/gooddata/lcm/actions/synchronize_user_filters.rb

@@ -90,13 +90,16 @@ module GoodData
           client = params.gdc_gd_client
           domain_name = params.organization || params.domain
           fail "Either organisation or domain has to be specified in params" unless domain_name
+
           domain = client.domain(domain_name) if domain_name
           project = client.projects(params.gdc_project) || client.projects(params.gdc_project_id)
           fail "Either project or project_id has to be specified in params" unless project
+
           data_product = params.data_product
 
           config = params.filters_config
           fail 'User filters brick requires configuration how the filter should be setup. For this use the param "filters_config"' if config.blank?
+
           symbolized_config = GoodData::Helpers.deep_dup(config)
           symbolized_config = GoodData::Helpers.symbolize_keys(symbolized_config)
           symbolized_config[:labels] = symbolized_config[:labels].map { |l| GoodData::Helpers.symbolize_keys(l) }
@@ -133,6 +136,7 @@ module GoodData
             user_filters.group_by { |u| u[:pid] }.flat_map.pmap do |id, new_filters|
               users = users_by_project[id]
               fail "The #{multiple_projects_column} cannot be empty" if id.blank?
+
               if mode == 'sync_multiple_projects_based_on_custom_id'
                 current_project = domain.clients(id, data_product).project
               elsif mode == 'sync_multiple_projects_based_on_pid'
@@ -154,40 +158,34 @@ module GoodData
             user_filters.group_by { |u| u[multiple_projects_column] }.flat_map.pmap do |client_id, new_filters|
               users = users_by_project[client_id]
               fail "Client id cannot be empty" if client_id.blank?
+
               c = domain.clients(client_id, data_product)
               if params.segments && !segment_uris.include?(c.segment_uri)
-                puts "Client #{client_id} is outside segments_filter #{params.segments}"
+                params.gdc_logger.warn "Client #{client_id} is outside segments_filter #{params.segments}"
                 next
               end
               current_project = c.project
               fail "Client #{client_id} does not have project." unless current_project
+
               working_client_ids << client_id
               partial_results = sync_user_filters(current_project, new_filters, run_params.merge(users_brick_input: users), symbolized_config)
               results.concat(partial_results[:results])
             end
 
             unless run_params[:do_not_touch_filters_that_are_not_mentioned]
-              domain_clients.each do |c|
+              domain_clients.peach do |c|
                 next if working_client_ids.include?(c.client_id)
+
                 begin
                   current_project = c.project
-                rescue => e
-                  puts "Error when accessing project of client #{c.client_id}. Error: #{e}"
-                  next
-                end
-                unless current_project
-                  puts "Client #{c.client_id} has no project."
-                  next
-                end
-                if current_project.deleted?
-                  puts "Project #{current_project.pid} of client #{c.client_id} is deleted."
-                  next
-                end
+                  users = users_by_project[c.client_id]
+                  params.gdc_logger.info "Delete all filters in project #{current_project.pid} of client #{c.client_id}"
+                  current_results = sync_user_filters(current_project, [], run_params.merge(users_brick_input: users), symbolized_config)
 
-                puts "Delete all filters in project #{current_project.pid} of client #{c.client_id}"
-                users = users_by_project[c.client_id]
-                delete_results = current_project.add_data_permissions([], run_params.merge(users_brick_input: users))
-                results.concat(delete_results[:results])
+                  results.concat(current_results[:results])
+                rescue StandardError => e
+                  params.gdc_logger.error "Failed to clear filters of  #{c.client_id} due to: #{e.inspect}"
+                end
               end
             end
 

data/lib/gooddata/lcm/lcm2.rb

@@ -75,32 +75,15 @@ module GoodData
     end
 
     MODES = {
-      # Low Level Commands
-
-      actions: [
-        PrintActions
-      ],
 
       hello: [
         HelloWorld
       ],
 
-      modes: [
-        PrintModes
-      ],
-
-      info: [
-        PrintTypes,
-        PrintActions,
-        PrintModes
-      ],
-
-      types: [
-        PrintTypes
+      help: [
+        Help
       ],
 
-      ## Bricks
-
       release: [
         EnsureReleaseTable,
         CollectDataProduct,
@@ -170,11 +153,8 @@ module GoodData
 
       schedules_execution: [
         ExecuteSchedules
-      ],
-
-      hello_world: [
-        HelloWorld
       ]
+
     }
 
     MODE_NAMES = MODES.keys

data/lib/gooddata/models/domain.rb

@@ -365,7 +365,10 @@ Available values for setting language are: #{available_languages}."
     # use fuzzy_get_user.
     #
     # @param [String] name Name to look for
-    # @param [Array<GoodData::User>]user_list Optional cached list of users used for look-ups
+    # @param [Array<GoodData::User>] user_list
+    # Optional cached list of users used for look-ups.
+    # WARNING: If not specified, in the worst case the
+    # method gets all users from the domain!
     # @return [GoodDta::Membership] User
     def get_user(name, user_list = users)
       return member(name, user_list) if name.instance_of?(GoodData::Membership)

data/lib/gooddata/models/process.rb

@@ -187,8 +187,8 @@ module GoodData
       def deploy_component(data, options = { client: GoodData.client, project: GoodData.project })
         client, project = GoodData.get_client_and_project(options)
         data = { process: data } unless data[:process]
-        data[:process] = GoodData::Helpers.symbolize_keys(data[:process]).select { |k| [:type, :name, :component].include? k }
-        data[:process][:component] = GoodData::Helpers.symbolize_keys(data[:process][:component]).select { |k| [:name, :version].include? k }
+        data[:process] = GoodData::Helpers.symbolize_keys(data[:process]).select { |k| %i[type name component].include? k }
+        data[:process][:component] = GoodData::Helpers.symbolize_keys(data[:process][:component]).select { |k| %i[name version configLocation].include? k }
 
         # a feature flag is required to create component type processes
         client.post "/gdc/projects/#{project.pid}/projectFeatureFlags",

data/lib/gooddata/models/project.rb

@@ -262,6 +262,7 @@ module GoodData
       def transfer_processes(from_project, to_project, options = {})
         options = GoodData::Helpers.symbolize_keys(options)
         to_project_processes = to_project.processes
+        additional_hidden_params = options[:additional_hidden_params] || {}
         result = from_project.processes.uniq(&:name).map do |process|
           fail "The process name #{process.name} must be unique in transfered project #{to_project}" if to_project_processes.count { |p| p.name == process.name } > 1
           next if process.type == :dataload
@@ -272,7 +273,8 @@ module GoodData
                          GoodData::Process.deploy_from_appstore(process.path, name: process.name, client: to_project.client, project: to_project)
                        elsif process.component
                          to_process.delete if to_process
-                         GoodData::Process.deploy_component(GoodData::Helpers.symbolize_keys(process.to_hash), project: to_project, client: to_project.client)
+                         process_hash = GoodData::Helpers::DeepMergeableHash[GoodData::Helpers.symbolize_keys(process.to_hash)].deep_merge(additional_hidden_params)
+                         GoodData::Process.deploy_component(process_hash, project: to_project, client: to_project.client)
                        else
                          Dir.mktmpdir('etl_transfer') do |dir|
                            dir = Pathname(dir)

data/lib/gooddata/version.rb

@@ -6,7 +6,7 @@
 
 # GoodData Module
 module GoodData
-  VERSION = '1.3.2'
+  VERSION = '1.3.3'
 
   class << self
     # Version

metadata

@@ -1,17 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: gooddata
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - Pavel Kolesnikov
 - Thomas Watson Steen
 - Tomas Svarovsky
 - Tomas Korcak
+- Jan Zdrahal
+- Petr Gadorek
+- Jakub Mahnert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-05 00:00:00.000000000 Z
+date: 2018-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -209,6 +212,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.6'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.6'
 - !ruby/object:Gem::Dependency
   name: pronto
   requirement: !ruby/object:Gem::Requirement
@@ -539,15 +556,17 @@ dependencies:
         version: '0'
 description: Use the GoodData::Client class to integrate GoodData into your own application
   or use the CLI to work with GoodData directly from the command line.
-email: pavel@gooddata.com
+email: lcm@gooddata.com
 executables:
 - gitflow-init.sh
 - gooddata
 - hello_world.sh
+- help.sh
 - provisioning.sh
 - release.sh
 - rollout.sh
 - run_brick.rb
+- test_projects_cleanup.rb
 - user_filters.sh
 - users.sh
 extensions: []
@@ -581,14 +600,17 @@ files:
 - RELEASING.md
 - Rakefile
 - TODO.md
+- VERSION
 - authors.sh
 - bin/gitflow-init.sh
 - bin/gooddata
 - bin/hello_world.sh
+- bin/help.sh
 - bin/provisioning.sh
 - bin/release.sh
 - bin/rollout.sh
 - bin/run_brick.rb
+- bin/test_projects_cleanup.rb
 - bin/user_filters.sh
 - bin/users.sh
 - ci.rake
@@ -608,6 +630,7 @@ files:
 - lib/gooddata/bricks/brick.rb
 - lib/gooddata/bricks/bricks.rb
 - lib/gooddata/bricks/hello_world_brick.rb
+- lib/gooddata/bricks/help_brick.rb
 - lib/gooddata/bricks/middleware/aws_middleware.rb
 - lib/gooddata/bricks/middleware/base_middleware.rb
 - lib/gooddata/bricks/middleware/bench_middleware.rb
@@ -719,10 +742,8 @@ files:
 - lib/gooddata/lcm/actions/ensure_technical_users_project.rb
 - lib/gooddata/lcm/actions/execute_schedules.rb
 - lib/gooddata/lcm/actions/hello_world.rb
+- lib/gooddata/lcm/actions/help.rb
 - lib/gooddata/lcm/actions/import_object_collections.rb
-- lib/gooddata/lcm/actions/print_actions.rb
-- lib/gooddata/lcm/actions/print_modes.rb
-- lib/gooddata/lcm/actions/print_types.rb
 - lib/gooddata/lcm/actions/provision_clients.rb
 - lib/gooddata/lcm/actions/purge_clients.rb
 - lib/gooddata/lcm/actions/rename_existing_client_projects.rb
@@ -950,7 +971,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: A convenient Ruby wrapper around the GoodData RESTful API

data/lib/gooddata/lcm/actions/print_actions.rb

@@ -1,58 +0,0 @@
-# encoding: UTF-8
-#
-# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree.
-
-require_relative 'base_action'
-
-module GoodData
-  module LCM2
-    class PrintActions < BaseAction
-      DESCRIPTION = 'Print Information About Actions'
-
-      PARAMS = {
-      }
-
-      class << self
-        def call(params)
-          results = []
-
-          actions = GoodData::LCM2::BaseAction.descendants
-
-          actions.each do |action|
-            action_params = action.const_get(:PARAMS)
-            action_params_keys = action_params.keys
-            params = action_params_keys.map do |param|
-              param
-            end
-
-            types = action_params.map do |_k, param|
-              param[:type].class.short_name
-            end
-
-            required = action_params.map do |_k, param|
-              param[:opts][:required]
-            end
-
-            defaults = action_params.map do |_k, param|
-              param[:opts][:default]
-            end
-
-            results << {
-              name: action.short_name,
-              description: action.const_get(:DESCRIPTION),
-              params: params.join("\n"),
-              types: types.join("\n"),
-              required: required.join("\n"),
-              default: defaults.join("\n")
-            }
-          end
-
-          # Return results
-          results
-        end
-      end
-    end
-  end
-end

data/lib/gooddata/lcm/actions/print_modes.rb

@@ -1,69 +0,0 @@
-# encoding: UTF-8
-#
-# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree.
-
-require_relative 'base_action'
-
-module GoodData
-  module LCM2
-    class PrintModes < BaseAction
-      DESCRIPTION = 'Print Modes'
-
-      PARAMS = {
-      }
-
-      class << self
-        def call(params)
-          results = []
-          GoodData::LCM2::MODES.keys.each_with_index do |mode, index|
-            actions = GoodData::LCM2::MODES[mode]
-            action_names = actions.map do |k, _action|
-              params_length = k.const_get(:PARAMS).keys.length
-              k.short_name + ("\n" * (params_length > 1 ? params_length - 1 : 0))
-            end
-
-            params = actions.map do |action|
-              action.const_get(:PARAMS).map do |_k, param|
-                param[:name]
-              end
-            end
-
-            types = actions.map do |action|
-              action.const_get(:PARAMS).map do |_k, param|
-                param[:type]
-                # param[:type].class.short_name
-              end
-            end
-
-            required = actions.map do |action|
-              action.const_get(:PARAMS).map do |_k, param|
-                param[:opts][:required]
-              end
-            end
-
-            defaults = actions.map do |action|
-              action.const_get(:PARAMS).map do |_k, param|
-                param[:opts][:default]
-              end
-            end
-
-            results << {
-              '#' => index,
-              mode: mode,
-              actions: action_names.join("\n"),
-              params: params.join("\n"),
-              types: types.join("\n"),
-              required: required.join("\n"),
-              default: defaults.join("\n")
-            }
-          end
-
-          # Return results
-          results
-        end
-      end
-    end
-  end
-end

data/lib/gooddata/lcm/actions/print_types.rb

@@ -1,52 +0,0 @@
-# encoding: UTF-8
-#
-# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
-# This source code is licensed under the BSD-style license found in the
-# LICENSE file in the root directory of this source tree.
-
-require_relative 'base_action'
-
-module GoodData
-  module LCM2
-    class PrintTypes < BaseAction
-      DESCRIPTION = 'Print Information About Defined Types'
-
-      PARAMS = {
-      }
-
-      class << self
-        def call(_params)
-          results = []
-
-          GoodData::LCM2::Dsl::Dsl::TYPES.each_pair do |k, v|
-            vals = []
-            v.each_pair do |_name, val|
-              vals << val[:type]
-            end
-
-            required = []
-            v.each_pair do |_name, val|
-              required << val[:opts][:required]
-            end
-
-            defaults = []
-            v.each_pair do |_name, val|
-              defaults << val[:opts][:default]
-            end
-
-            results << {
-              class: k.short_name,
-              param: v.keys.join("\n"),
-              type: vals.join("\n"),
-              required: required.join("\n"),
-              default: defaults.join("\n")
-            }
-          end
-
-          # Return results
-          results
-        end
-      end
-    end
-  end
-end