gooddata 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2fd2c88fc8ba7bc3e6e6f9aec01c2647fbdc1944
-  data.tar.gz: fe5004fa1d35bdb6f52c08ce457da2c38ba2c0ac
+  metadata.gz: 78388b62f10692bc8416395774aad6f3d4020b39
+  data.tar.gz: 925461dba225f4b742734c96a423fec33fca818a
 SHA512:
-  metadata.gz: d8cddf4daefff255c001fa8187b36c3f49d6d50a0917be3d19518c0ac51cc7d19481358d1730f594b7dc07a147802e6588909a19710abe50704198c65727a56b
-  data.tar.gz: 3423a1d456ca6bf3f4c4e965e46f061515c60da85cf9f3d34a3b0b42febaa6760aa8b4771103e795d2bfea869c2527247196354b6997b157150eaada6a6beb5c
+  metadata.gz: 4c50cccdecccfd33eb03bbd40e9d129e413d2a02a3ba5ee96f4a0e76c16f4007747fa697e6065480875d283f5f5169b3d21ccd920ca0880049d50fbd27030baf
+  data.tar.gz: ec7eb3f19ed6cad1915eb30133305ea2c97f052d5dfd1bd8a6f9897ebbd069c565d68d250cf518ee35ac6450edf283e33cd76811e4fd59ba94670bcf8bcfd2c4

data/.dockerignore

@@ -0,0 +1,2 @@
+.git
+.gooddata

data/CHANGELOG.md

@@ -1,4 +1,52 @@
 # GoodData Ruby SDK Changelog
+## 1.3.1
+ - FEATURE: TMA-1030 Raise jruby version used in K8s docker image (#1284)
+ - Update README.md
+ - TRIVIAL: Correct dockerfile maintainer
+ - TMA-1033: show reason of filter composition failure (#1282)
+ - TMA-483 && TMA-963 Paralel ufb bug final fix
+ - TMA-963 && TMA-483: UFB and UB performance (#1234)
+ - TMA-1002 fixed broken tests
+ - no vcr (#1277)
+ - TMA-1005: Automate rotating credentials
+ - TMA-925: Optimize polling intervals
+ - Add info about running tests to CONTRIBUTING.md (#1262)
+ - Fix rubocop issue
+ - Add empty lines between licenses and modules
+ - SETI-2180 Updated base image namespace
+ - FEATURE: TMA-1030 Dockerize LCM bricks
+ - FEATURE: TMA-1030 Write brick outputs to files
+ - FEATURE: TMA-1030 Add Hello World brick
+ - REFACTOR: TMA-1030 Non functional changes
+ - BUGFIX: TMA-1040 Add nil result if action fails
+ - TEST: TMA-1040 Add tests for "perform" method in LCM2 module
+ - Require ActiveSupport where it's needed
+ - Revert Array refinement to Enumerable opening
+ - Revert class to reopening
+ - Use duplicable? from ActiveSupport
+ - Remove object.blank? as ActiveSupport already do it
+ - Revert Object to reopening
+ - Increase the scope of monkey patchs
+ - Fixes tests in CI
+ - Patch all places that use '.to_b' with all extensions that implements it
+ - Isolate Symbol monkeypatch in SymbolExtensions module
+ - Code :lipstick: Insert license header in files where it was missing
+ - Isolate String monkeypatch in StringExtensions module
+ - Add TrueExtensions and FalseExtensions in missing places
+ - Isolate Object monkeypatch in ObjectExtensions module
+ - Isolate Numeric monkeypatch in NumericExtensions module
+ - Isolate BigDecimal monkeypatch in BigDecimalExtensions module
+ - Adds Extensions to Globalhelper, it's the only one calls `duplicable?`
+ - Isolate Nil monkeypatch in NilExtensions module
+ - Isolate Integer monkeypatch in IntegerExtensions module
+ - Isolate Hash monkeypatch in HashExtensions module
+ - Isolate True/False monkey patchs in respectives modules
+ - Is a good practice to explicit the error in rescue block
+ - Isolate Enumerable monkey patch in EnumerableExtensions module
+ - Isolate Class monkeypatch in ClassExtensions module
+ - TMA-927: handle uppercase email inputs
+ - TMA-648 tests not deleting ads instances fixed
+
 ## 1.3.0
  - Add changelog for 1.2.1
  - Automate bumping version (#1243)

data/CONTRIBUTING.md

@@ -1,5 +1,24 @@
 # Contributing
 
+## Tests
+### Unit tests
+`bundle exec rake test:unit`
+### Integration tests
+Currently only GoodData employees can run integration tests for security reasons.
+
+`GD_SPEC_PASSWORD=*** bundle exec rake test:integration`
+
+[Integration tests](spec/integration) can be run against different GoodData [environments](spec/environment) or with 
+[VCR](https://relishapp.com/vcr/vcr/docs). 
+
+#### VCR test setup
+When adding new integration test, always set `:vcr` metadata. 
+```ruby
+describe 'New integration test', :vcr
+``` 
+The VCR `record` mode can be set via `VCR_RECORD_MODE` environment variable. Set it to `all` to make a new recording.
+Please check the recorded payloads for possible sensitive data before submitting to github.
+
 ## Static analysis
 We use [Pronto](https://github.com/prontolabs/pronto) to detect code smells using static analysis. Comments are automatically created on pull requests when code smells are found.
 
@@ -35,16 +54,4 @@ We use [Pronto](https://github.com/prontolabs/pronto) to detect code smells usin
    [license](/LICENSE).
 1. Use `GoodData.logger` for logging instead of `puts`.
 
-## Integration tests
-[Integration tests](spec/integration) can be run against different GoodData [environments](spec/environment) or with 
-[VCR](https://relishapp.com/vcr/vcr/docs). 
-
-### VCR test setup
-When adding new integration test, always set `:vcr` metadata. 
-```ruby
-describe 'New integration test', :vcr
-``` 
-The VCR `record` mode can be set via `VCR_RECORD_MODE` environment variable. Set it to `all` to make a new recording.
-Please check the recorded payloads for possible sensitive data before submitting to github.
-
 _Based on [GitLab's contribution guide](https://github.com/gitlabhq/gitlabhq/blob/master/CONTRIBUTING.md)._

data/Dockerfile

@@ -0,0 +1,37 @@
+FROM harbor.intgdc.com/tools/gdc-java-8-jre:b057b53
+
+MAINTAINER LCM <lcm@gooddata.com>
+
+LABEL image_name="GDC LCM Bricks"
+LABEL maintainer="LCM <lcm@gooddata.com>"
+LABEL git_repostiory_url="https://github.com/gooddata/gooddata-ruby/"
+LABEL parent_image="harbor.intgdc.com/tools/gdc-java-8-jre:b057b53"
+
+# which is required by RVM
+RUN yum install -y curl which \
+    && yum clean all \
+    && rm -rf /var/cache/yum
+
+RUN gpg --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 7D2BAF1CF37B13E2069D6956105BD0E739499BDB
+RUN curl -sSL https://get.rvm.io | bash -s stable --ruby=jruby-9.1.14
+
+# Switch to directory with sources
+WORKDIR /src
+
+# login shell is required by rvm
+RUN /bin/bash -l -c ". /usr/local/rvm/scripts/rvm && gem update --system \
+    && gem install bundler rake"
+
+ARG SOURCE_COMMIT
+ENV GOODDATA_RUBY_COMMIT=$SOURCE_COMMIT
+
+ADD ./bin ./bin
+ADD ./lib ./lib
+ADD ./Gemfile .
+ADD ./gooddata.gemspec .
+
+RUN /bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle install"
+
+ENTRYPOINT ["/bin/bash", "-l", "-c"]
+
+CMD [ ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb" ]

data/README.md

@@ -78,4 +78,4 @@ For full contributor info see [contributors page](https://github.com/gooddata/go
 
 ## Copyright
 
-Copyright (c) 2010 - 2015 GoodData Corporation and Thomas Watson Steen. See LICENSE for details.
+Copyright (c) 2010 - 2018 GoodData Corporation and Thomas Watson Steen. See [LICENSE](/LICENSE) for details.

data/Rakefile

@@ -5,10 +5,11 @@ require 'rubygems'
 require 'bundler/setup'
 require 'bundler/cli'
 require 'bundler/gem_tasks'
-
+require 'gooddata'
 require 'rake/testtask'
 require 'rspec/core/rake_task'
 
+require 'yaml'
 require 'yard'
 
 require 'rubocop/rake_task'
@@ -224,3 +225,18 @@ namespace :gitflow do
     system(file_path) || fail('Initializing git-flow failed!')
   end
 end
+
+namespace :password do
+  task :rotate, [:value, :encryption_key] do |_, args|
+    key = 'password'
+    value = args[:value]
+    encryption_key = args[:encryption_key]
+    encrypted_value = GoodData::Helpers.encrypt(value, encryption_key).strip
+    secrets_path = File.join(File.dirname(__FILE__), 'spec/environment/secrets.yaml')
+    secrets = YAML.load_file(secrets_path)
+    secrets.each_value do |env|
+      env[key].replace(encrypted_value) if env.key?(key)
+    end
+    File.write(secrets_path, secrets.to_yaml)
+  end
+end

data/bin/run_brick.rb

@@ -0,0 +1,31 @@
+#!/usr/bin/env ruby
+
+require 'remote_syslog_logger'
+require_relative '../lib/gooddata'
+
+DEFAULT_BRICK = 'hello_world_brick'
+
+brick_type = ENV['BRICK_TYPE'] || DEFAULT_BRICK
+
+syslog_node = ENV['NODE_NAME']
+log = RemoteSyslogLogger.new(syslog_node, 514, :program => brick_type)
+
+log.info "action=#{brick_type}_execution status=start"
+
+begin
+  brick_pipeline = GoodData::Bricks::Pipeline.send("#{brick_type}_pipeline")
+  params_json = ENV['BRICK_PARAMS_JSON']
+  params = params_json.nil? ? {} : JSON.parse(params_json)
+
+  params['gooddata_ruby_commit'] = ENV['GOODDATA_RUBY_COMMIT'] || '<unknown>'
+  params['log_directory'] = ENV['LOG_DIRECTORY'] || '/tmp/'
+
+  @brick_result = brick_pipeline.call(params)
+  log.info "action=#{brick_type}_execution status=finished"
+rescue NoMethodError => e
+  log.info "action=#{brick_type}_execution status=error Invalid brick type '#{brick_type}', #{e.message}"
+  raise e
+rescue => e
+  log.info "action=#{brick_type}_execution status=error #{e.message}"
+  raise e
+end

data/gooddata.gemspec

@@ -60,6 +60,7 @@ Gem::Specification.new do |s|
   s.add_dependency 'multi_json', '~> 1.12'
   s.add_dependency 'parseconfig', '~> 1.0'
   s.add_dependency 'pmap', '~> 1.1'
+  s.add_dependency 'remote_syslog_logger', '~> 1.0.3'
   s.add_dependency 'restforce', '~> 2.4'
   s.add_dependency 'rest-client', '~> 2.0'
   s.add_dependency 'rubyzip', '~> 1.2', '>= 1.2.1'

data/lib/gooddata/bricks/hello_world_brick.rb

@@ -0,0 +1,21 @@
+require_relative 'brick'
+
+module GoodData
+  module Bricks
+    # Simple brick used for testing and debug purposes
+    class HelloWorldBrick < GoodData::Bricks::Brick
+      def version
+        '0.0.1'
+      end
+
+      # HelloWorld brick entry-point
+      #
+      # @param [Hash] params Parameters
+      # @option [String] 'message' text to be returned in result, if nill - nothing is returned
+      # :reek:UtilityFunction
+      def call(params)
+        GoodData::LCM2.perform('hello_world', params)
+      end
+    end
+  end
+end

data/lib/gooddata/bricks/middleware/gooddata_middleware.rb

@@ -6,6 +6,18 @@
 
 require_relative 'base_middleware'
 
+require 'gooddata/extensions/true'
+require 'gooddata/extensions/false'
+require 'gooddata/extensions/integer'
+require 'gooddata/extensions/string'
+require 'gooddata/extensions/nil'
+
+using TrueExtensions
+using FalseExtensions
+using IntegerExtensions
+using StringExtensions
+using NilExtensions
+
 module GoodData
   module Bricks
     # Connects to platform and enriches parameters with GoodData::Client

data/lib/gooddata/bricks/middleware/logger_middleware.rb

@@ -6,6 +6,18 @@
 
 require 'logger'
 
+require 'gooddata/extensions/true'
+require 'gooddata/extensions/false'
+require 'gooddata/extensions/integer'
+require 'gooddata/extensions/string'
+require 'gooddata/extensions/nil'
+
+using TrueExtensions
+using FalseExtensions
+using IntegerExtensions
+using StringExtensions
+using NilExtensions
+
 require_relative 'base_middleware'
 
 module GoodData

data/lib/gooddata/bricks/pipeline.rb

@@ -9,6 +9,7 @@ require_relative 'user_filters_brick'
 require_relative 'release_brick'
 require_relative 'provisioning_brick'
 require_relative 'rollout_brick'
+require_relative 'hello_world_brick'
 
 module GoodData
   module Bricks
@@ -87,6 +88,17 @@ module GoodData
         RolloutBrick
         ])
       end
+
+      def self.hello_world_brick_pipeline
+        prepare(
+          [
+            DecodeParamsMiddleware,
+            LoggerMiddleware,
+            BenchMiddleware,
+            HelloWorldBrick
+          ]
+        )
+      end
     end
   end
 end

data/lib/gooddata/exceptions/filter_maqlization.rb

@@ -6,11 +6,5 @@
 
 module GoodData
   class FilterMaqlizationError < RuntimeError
-    attr_accessor :errors
-
-    def initialize(errs = [])
-      super('Filter MAQLization failed')
-      @errors = errs
-    end
   end
 end

data/lib/gooddata/extensions/class.rb

@@ -1,3 +1,7 @@
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
 class Class
   def short_name
     name.split('::').last

data/lib/gooddata/extensions/enumerable.rb

@@ -1,9 +1,6 @@
-# encoding: UTF-8
-#
 # Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
-
 module Enumerable
   def mapcat(initial = [], &block)
     reduce(initial) do |a, e|

data/lib/gooddata/extensions/extensions.rb

@@ -1,9 +1,6 @@
-# encoding: UTF-8
-#
 # Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
-
 base = Pathname(__FILE__).dirname.expand_path
 Dir.glob(base + '*.rb').each do |file|
   require_relative file

data/lib/gooddata/extensions/false.rb

@@ -1,23 +1,15 @@
-# encoding: UTF-8
-#
 # Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
-class FalseClass
-  # +false+ is not duplicable:
-  #
-  #   false.duplicable? # => false
-  #   false.dup         # => TypeError: can't dup FalseClass
-  def duplicable?
-    false
-  end
-
-  def to_b
-    false
-  end
+module FalseExtensions
+  refine FalseClass do
+    def to_b
+      false
+    end
 
-  def to_i
-    0
+    def to_i
+      0
+    end
   end
 end

data/lib/gooddata/extensions/hash.rb

@@ -1,48 +1,17 @@
-# encoding: UTF-8
-#
 # Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
-class Hash
-  # Return a hash that includes everything but the given keys. This is useful for
-  # limiting a set of parameters to everything but a few known toggles:
-  #
-  #   @person.update_attributes(params[:person].except(:admin))
-  #
-  # If the receiver responds to +convert_key+, the method is called on each of the
-  # arguments. This allows +except+ to play nice with hashes with indifferent access
-  # for instance:
-  #
-  #   {:a => 1}.with_indifferent_access.except(:a)  # => {}
-  #   {:a => 1}.with_indifferent_access.except("a") # => {}
-  #
-  def except(*keys)
-    dup.except!(*keys)
-  end
-
-  # Replaces the hash without the given keys.
-  def except!(*keys)
-    keys.each { |key| delete(key) }
-    self
-  end
-
-  def slice(*keys)
-    keys.map! { |key| convert_key(key) } if respond_to?(:convert_key, true)
-    keys.each_with_object(self.class.new) { |k, hash| hash[k] = self[k] if key?(k) }
-  end
-
-  def compact
-    select { |_, value| !value.nil? }
-  end
-
-  def deep_merge(hash)
-    hash = hash.to_hash
-    merge(hash) do |_key, old_val, new_val|
-      if old_val.is_a?(Hash) && new_val.is_a?(Hash)
-        old_val.deep_merge(new_val)
-      else
-        new_val
+module HashExtensions
+  refine Hash do
+    def deep_merge(hash)
+      hash = hash.to_hash
+      merge(hash) do |_key, old_val, new_val|
+        if old_val.is_a?(Hash) && new_val.is_a?(Hash)
+          old_val.deep_merge(new_val)
+        else
+          new_val
+        end
       end
     end
   end