gooddata 1.0.2-java → 1.1.0-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 1a64b525cdec4b089de164628c08eddb299f75875e156204215b530c110b45f2
-  data.tar.gz: 492d0cd232b7f3d999c5d255ae98c794dec372217f6d100c20e63389aa3788db
+SHA1:
+  metadata.gz: 6b6f4b4a04c7d9e3bc5b91238454502895c617d4
+  data.tar.gz: 47ad281d269a76cf4d254216eef35d68719611b1
 SHA512:
-  metadata.gz: 62fa97168460a21cbe452dec16fc00976d97aed011e287028255ac5cc53a9e8b3ca18506f8b0369fde45bcb9b6b532a953ad9fae6959592742583110edd723e8
-  data.tar.gz: 66a42280ad478127ea4da38033bf8d78421f9cc43b944e206053511c98dc6a21db2fd319809314e12e12b692c06828c09c387cfbc6c056ad02c3bcb8700f1b4d
+  metadata.gz: 69b134a11f9074c7c4899e9720707452b436880f8e35241b7b974059bc1dc319f0b4c7407e5fced4bd21321169bfd5ab79818d5ed4029ed58bce942fbbe77dca
+  data.tar.gz: 2e28148e264d290c1dc4c696e8242e3616857b6e12aaf3137a8196340b0a26640134fa656a7e5c7bbca6e58696bf7b87ea1b673d77e1cb4549ac7137d4303de7

data/.gitignore

@@ -16,6 +16,7 @@ tmtags
 
 ## IDEA
 .idea/
+*.iml
 
 ## PROJECT::GENERAL
 .bundle

data/CONTRIBUTING.md

@@ -35,4 +35,16 @@ We use [Pronto](https://github.com/prontolabs/pronto) to detect code smells usin
    [license](/LICENSE).
 1. Use `GoodData.logger` for logging instead of `puts`.
 
+## Integration tests
+[Integration tests](spec/integration) can be run against different GoodData [environments](spec/environment) or with 
+[VCR](https://relishapp.com/vcr/vcr/docs). 
+
+### VCR test setup
+When adding new integration test, always set `:vcr` metadata. 
+```ruby
+describe 'New integration test', :vcr
+``` 
+The VCR `record` mode can be set via `VCR_RECORD_MODE` environment variable. Set it to `all` to make a new recording.
+Please check the recorded payloads for possible sensitive data before submitting to github.
+
 _Based on [GitLab's contribution guide](https://github.com/gitlabhq/gitlabhq/blob/master/CONTRIBUTING.md)._

data/README.md

@@ -59,11 +59,14 @@ Pavel Kolesnikov [ <mailto:pavel@gooddata.com> / [@koles](http://twitter.com/kol
 
 **Actively developed and maintained by**
 
-- [Tomas Korcak](https://github.com/korczis) [ <mailto:korczis@gmail.com> / [@korczis](http://twitter.com/korczis) ]
-- [Tomas Svarovsky](https://github.com/fluke777) [ <mailto:svarovsky.tomas@gmail.com> / [@fluke777](http://twitter.com/fluke777) ]
+- [Jan Zdráhal](https://github.com/panjan) [ <mailto:jan.zdrahal@gooddata.com> ]
+- [Jakub Mahnert](https://github.com/kubamahnert) [ <mailto:jakub.mahnert@gooddata.com> ]
+- [Petr Gaďorek](https://github.com/Hahihula) [ <mailto:petr.gadorek@gooddata.com> ]
 
 **Contributors**
 
+- [Tomas Korcak](https://github.com/korczis) [ <mailto:korczis@gmail.com> / [@korczis](http://twitter.com/korczis) ]
+- [Tomas Svarovsky](https://github.com/fluke777) [ <mailto:svarovsky.tomas@gmail.com> / [@fluke777](http://twitter.com/fluke777) ]
 - [Patrick McConlogue](https://github.com/thnkr/)
 - [Petr Cvengros](https://github.com/cvengros)
 

data/Rakefile

@@ -7,7 +7,6 @@ require 'bundler/cli'
 require 'bundler/gem_tasks'
 
 require 'rake/testtask'
-require 'rake/notes/rake_task'
 require 'rspec/core/rake_task'
 
 require 'yard'

data/dev-gooddata-sso.pub.encrypted

@@ -0,0 +1,40 @@
+144HUJzbALmdmAyge1ALrX7bZf8WfFpI29oZoXiTgTi8IsFBpyWX/SbgBnZ8
+MpyX35kJZGK/3F2pkuba5GkhIw6IWSwa+n01EbIc7s5fZfUf+E7f69bMs7Y6
+VBMorf5LMcNAm6OtqNo59YxxanaG+fm5ZwCPnfxfqZj7CieBT8h37+szyJ0s
+h2ZVS+IyHZ6tWOkHH3sQdSUynDh4R6IuuGDwoaxJqGBg4068aLHGvZUze0ge
+6S1WSlcgWeeDtMEgTPiAb1Sq2sRKPnIScleKp6PxW83CLpFuRAzColoNIYcG
+wSp7y02bpi5N7XtWNg7QCatBr8O+9ChJ+2ndBDzFBXbetnwFN2UOTVRKjca7
+BD07+h5QXTAZj7L736/0Ti8O6wvyJEVNy2iCpUrjys10SHO0AJBIxr8Y2jd6
+L+wty3o3S3sL2Jb+yr3DeuINTsWBaSVYPvr7oYEXvFbBsXmq9r30XtKW6Et+
+3TCoOAETJu5XbQuDn9qwE3qvmRMfZBiKMaCCpgHJYWCOX6UE1600Yp/ctOvf
+runSTMpZ+cQvpH+38+W0WQCISmgHUPANRMcpdQzW6jQwZ1vd1/31AQKGUHya
+gHJlIoN+1vIH/AOgJQjcVbNNAnh9p1ylKVtLOB418MAVkZnDmFoa8BcLJRPT
+XxL98Iqp9AtEPb8lAv/vkpied6OKF0FtS6q0JFkpaAnFbsCAeLZZYOSMZVoO
+CsIQjkNtlfovLKHGNiGfTEZH9NhlNsqcItcGpDyPyyMzz3V/o4JPTxNBW+Gy
+n2GasXCb7dwPfcWCd+RB3IqeA5iXBzNJDl5R76qiYy/IXw6rCYHb+2BVK2dq
+koWCTv6wQKu9tAaWwXl6fpxwZM4bEu/W+dIkOYwaoGYcbP9dHY73P9AR7zMd
+UYahmnHfFn5fTQ25UaDs+4DYzFJucNKjSjdch/ZUsVNaP0x4O7FES+SR9w93
+NZCgx4Yu8yprMUZhE4G0zRCpigYfqlHigZhSFog2R/iph+51pEbX3qbnhMZN
+8AtR4YoT0wCvk2rZ5sCC3xS+33va4SXgkVIidXjag2tQQ2r8DCUB0+q2cKOf
+ODJ36rejo/VBdrBg6zFhQrdz9emy6gifbN2SrB3Be2VMCH0XRRZYS3veD6Ye
+/mUu7V7IZ131sGkPMdW5FK03tbp51F8caGo1OisGNZj5T1DiW4lBKZoyH/5u
+rWkkppxsNXSQiOVoKjxPHzDlV8M5xA+KNzSRPV81FlZwFB/QM5nLP1pUEPyo
+tq9lXSoEP1wx8hisl3uq6cPuC+cZsnCQlfpOL1BCrFxVf05Banp5Ro0i0W3v
+V6+PpZfFev5/RKhiFY2SRkXR5cCJOf6OPBnQz6zLSjZWm75I4JzdFZX6Zdmu
+iOabIjOb2jKj8FHCrEZkkWb58mPyhH9kUxZRP7YhY7cxN5Ko3jKRABKdBBJG
+Ft/FAN15F0R3r5S9+jcQCdmveqYI6/7tFSp1gMnoUvwZV/jrpnGPeI3kZUdy
+xVdRt8c1cA1UsA9ktThBZYJ9oIfqDH9C4zm6oY9wzGW6XFPUGxFtVsih8PHP
+4sQDtgRNYrY6ZIzk0ISVwukcAgCmIJQJriegXniOXY1x58l9/tCC+3pgRKCD
+Er/7OZCKX9hjbK3xPUAb6ZZBH53U+v/LW5HfxkFWdFI9CZ/k2FUEsRKsbnl4
+Dsfs59x8YcB4aP/HtwIqHOw1+imbzk7wyMraawVqo80e+j5rgGa3W7wyx7Ju
+N2DRyA4VDgxM6ftVvCUz5pUIi0PjHo1SaaIyii9zZw5QA37h7C3E7B0vPInM
+KsZAxalI8r25wRcRXuUKxql1zzl8EPBT0O5Q9QFKzYpm0zpF8VdqvauMk+ug
+vk6GJ4szVBUnEFK3cVo/EoOgYWDQIWJPQumqM6WPO5pEFvhh1f6ocM3JvslT
+TZs5LUEnJdpg+z0BJ5HoHQfCIHP+HSxehFP/wspJ/nqFSp4loJoQ3xBDDwUa
+IeEclS1PrhbjH7qwZCAnWWb6Acbxz26PTx94sNmmoNIFvJ4T6dXkdpV0vB7u
+pOem2GLN1CIK4WA6Kp/cmjLkgTrV3HauBYZgLi2Wil0V+wCYCBhf0EbLXU+k
+YLma1h41pucFL+fhg6mTFrcTpDBP9JANvzkgFPXePZ03BeHhSXkMP8AfYM8y
+RsNS0g4+zTRpUd7q3MsFU7XAwuS+s5273/WQCPo+Grm27t4Gft4NPgtngbpB
+1TSCqiMrYEoRXUvj7DsrAnVwX9akPUPflt216WUDLm1mupijucKL3BpUfFq3
++AwneAE/hMZzhfIz0QveiyOSYacK6tPaYp9OvQLFzYehpgWOVbCnQJfvGyUs
+KF37CX0=

data/gooddata.gemspec

@@ -31,7 +31,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'bundler', "~> 1.14"
   s.add_development_dependency 'license_finder', '~> 2.0'
   s.add_development_dependency 'rake', '~> 11.1'
-  s.add_development_dependency 'rake-notes', '~> 0.2'
   s.add_development_dependency 'redcarpet', '~> 3.1' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'rspec', '~> 3.5'
   s.add_development_dependency 'rspec-expectations', '~> 3.5'
@@ -39,16 +38,17 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rubocop', '< 0.48' # TODO: remove it after dealing with new rules introduced in 0.48 version
   s.add_development_dependency 'simplecov', '~> 0.12'
   s.add_development_dependency 'webmock', '~> 1.21'
-  s.add_development_dependency 'yard', '~> 0.8'
+  s.add_development_dependency 'yard', '~> 0.9.11'
   s.add_development_dependency 'yard-rspec', '~> 0.1'
   s.add_development_dependency 'ZenTest', '~> 4.11'
   s.add_development_dependency 'pry'
-  s.add_development_dependency 'activesupport', '~> 4.2.9'
   s.add_development_dependency 'pronto', '~> 0.9.5' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'pronto-rubocop', '~> 0.9.0' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'pronto-reek', '~> 0.9.0' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'pronto-flay', '~> 0.9.0' if RUBY_PLATFORM != 'java'
+  s.add_development_dependency 'vcr'
 
+  s.add_dependency 'activesupport', '~> 4.2.9'
   s.add_dependency 'aws-sdk', '~> 2.9', '>= 2.9.42'
   s.add_dependency 'docile', '~> 1.1'
   s.add_dependency 'erubis', '~> 2.7'

data/lib/gooddata/connection.rb

@@ -66,7 +66,7 @@ module GoodData
     # @param [Hash] opts Additional options
     # @option opts [Fixnum] :validity Validity in seconds from 'now'
     # @return [String] URL which can be used for SSO logging in
-    def sso_url(login, provider, opts = DEFAULT_SSO_OPTIONS)
+    def sso_url(login, provider, url, opts = DEFAULT_SSO_OPTIONS)
       opts = DEFAULT_SSO_OPTIONS.merge(opts)
 
       ts = DateTime.now.strftime('%s').to_i + opts[:valid]
@@ -83,21 +83,27 @@ module GoodData
       file_json.rewind
       file_signed = Tempfile.new('gooddata-sso-signed')
 
-      cmd = "gpg --no-tty --armor --yes -u #{login} --output #{file_signed.path} --sign #{file_json.path}"
+      cmd = "gpg --yes --no-tty --armor -u #{login} --output #{file_signed.path} --sign #{file_json.path}"
       res = system(cmd)
       fail 'Unable to sign json' unless res
 
       file_signed.rewind
       file_final = Tempfile.new('gooddata-sso-final')
 
-      cmd = "gpg --yes --no-tty --trust-model always --armor --output #{file_final.path} --encrypt --recipient security@gooddata.com #{file_signed.path}"
+      recipient = url == GoodData::Rest::Connection::DEFAULT_URL ? 'secure@gooddata.com' : 'test@gooddata.com'
+      cmd = "gpg --yes --no-tty --trust-model always --armor --output #{file_final.path} --encrypt --recipient #{recipient} #{file_signed.path}"
       res = system(cmd)
       fail 'Unable to encrypt json' unless res
 
       file_final.rewind
       final = file_final.read
 
-      "#{GoodData::Helpers::AuthHelper.read_server}/gdc/account/customerlogin?sessionId=#{CGI.escape(final)}&serverURL=#{CGI.escape(provider)}&targetURL=#{CGI.escape(opts[:url])}"
+      params = {
+        targetUrl: opts[:url],
+        ssoProvider: provider,
+        encryptedClaims: final
+      }
+      [url + '/gdc/account/customerlogin', params]
     end
 
     # Connect to GoodData using SSO
@@ -112,15 +118,19 @@ module GoodData
     # @param [String] login Email address used for logging into gooddata
     # @param [String] provider Name of SSO provider
     # @return [GoodData::Rest::Client] Instance of REST client
-    def connect_sso(login, provider)
-      url = sso_url(login, provider)
-
-      params = {
-        :x_gdc_request => "#{GoodData::Rest::Connection.generate_string}:#{GoodData::Rest::Connection.generate_string}"
-      }
-
-      RestClient.get url, params do |response, _request, _result|
-        Rest::Client.connect_sso(:sst_token => URI.decode(response.cookies['GDCAuthSST']))
+    def connect_sso(login, provider, url = GoodData::Rest::Connection::DEFAULT_URL, opts = {})
+      url, params = sso_url(login, provider, url)
+
+      RestClient::Request.execute(opts.merge(method: :post, url: url, payload: params)) do |response, _request, _result|
+        return Rest::Client.connect_sso(
+          opts.merge(
+            headers:
+               {
+                 x_gdc_authsst: response.cookies['GDCAuthSST'],
+                 x_gdc_authtt: response.cookies['GDCAuthTT']
+               }
+          )
+        )
       end
     end
   end

data/lib/gooddata/helpers/data_helper.rb

@@ -102,7 +102,6 @@ module GoodData
       end
 
       def realize_s3(params)
-        params = GoodData::Helpers.stringify_keys(params)
         s3_client = params['aws_client'] && params['aws_client']['s3_client']
         raise 'AWS client not present. Perhaps S3Middleware is missing in the brick definition?' if !s3_client || !s3_client.respond_to?(:bucket)
         bucket_name = @options[:bucket]

data/lib/gooddata/lcm/actions/apply_custom_maql.rb

@@ -21,13 +21,19 @@ module GoodData
         param :gdc_gd_client, instance_of(Type::GdClientType), required: true
 
         description 'Organization Name'
-        param :organization, instance_of(Type::StringType), required: true
+        param :organization, instance_of(Type::StringType), required: false
 
         description 'Segments to manage'
         param :segments, array_of(instance_of(Type::SegmentType)), required: true
 
         description 'Should be custom MAQL DDL Applied'
         param :apply_maql_ddl, instance_of(Type::BooleanType), required: false, default: false
+
+        description 'Domain'
+        param :domain, instance_of(Type::StringType), required: false
+
+        description 'DataProduct to manage'
+        param :data_product, instance_of(Type::GDDataProductType), required: false
       end
 
       RESULT_HEADER = [
@@ -43,6 +49,7 @@ module GoodData
           client = params.gdc_gd_client
 
           domain_name = params.organization || params.domain
+          fail "Either organisation or domain has to be specified in params" unless domain_name
           domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
           data_product = params.data_product
 

data/lib/gooddata/lcm/actions/associate_clients.rb

@@ -16,7 +16,10 @@ module GoodData
         param :gdc_gd_client, instance_of(Type::GdClientType), required: true
 
         description 'Organization Name'
-        param :organization, instance_of(Type::StringType), required: true
+        param :organization, instance_of(Type::StringType), required: false
+
+        description 'Domain'
+        param :domain, instance_of(Type::StringType), required: false
 
         description 'Delete Extra Clients'
         param :delete_extra, instance_of(Type::BooleanType), required: false, default: false
@@ -29,6 +32,9 @@ module GoodData
 
         description 'Segments to provision'
         param :segments_filter, array_of(instance_of(Type::StringType)), required: false
+
+        description 'DataProduct'
+        param :data_product, instance_of(Type::GDDataProductType), required: false
       end
 
       RESULT_HEADER = [
@@ -44,6 +50,7 @@ module GoodData
           client = params.gdc_gd_client
 
           domain_name = params.organization || params.domain
+          fail "Either organisation or domain has to be specified in params" unless domain_name
           domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
           data_product = params.data_product
 

data/lib/gooddata/lcm/actions/base_action.rb

@@ -17,6 +17,16 @@ module GoodData
         def check_params(specification, params)
           Helpers.check_params(specification, params)
         end
+
+        # This method is used to enable the possibility to read keys of params object
+        # which are not specified in the specification constant
+        # typically in case when method access params dynamically based on user input
+        def without_check(specification, params)
+          params.clear_filters # disables params validation
+          result = yield
+          params.setup_filters(specification) # enables params validation
+          result
+        end
       end
     end
   end

data/lib/gooddata/lcm/actions/collect_ca_metrics.rb

@@ -13,7 +13,13 @@ module GoodData
 
       PARAMS = define_params(self) do
         description 'Client Used for Connecting to GD'
-        param :gdc_gd_client, instance_of(Type::GdClientType), required: true
+        param :gdc_gd_client, instance_of(Type::GdClientType), required: false
+
+        description 'Client used to connecting to development domain'
+        param :development_client, instance_of(Type::GdClientType), required: true
+
+        description 'Synchronization Info'
+        param :synchronize, array_of(instance_of(Type::AnyType)), required: true, generated: true
       end
 
       class << self

data/lib/gooddata/lcm/actions/collect_client_projects.rb

@@ -21,6 +21,9 @@ module GoodData
 
         description 'Segments to manage'
         param :segments, array_of(instance_of(Type::SegmentType)), required: true
+
+        description 'DataProduct to manage'
+        param :data_product, instance_of(Type::GDDataProductType), required: false
       end
 
       RESULT_HEADER = [

data/lib/gooddata/lcm/actions/collect_clients.rb

@@ -77,7 +77,9 @@ module GoodData
           clients = []
           errors = []
           data_source = GoodData::Helpers::DataSource.new(params.input_source)
-          input_data = File.open(data_source.realize(params), 'r:UTF-8')
+          input_data = without_check(PARAMS, params) do
+            File.open(data_source.realize(params), 'r:UTF-8')
+          end
           GoodData.logger.debug("Input data: #{input_data.read}")
           GoodData.logger.debug("Segment names: #{segment_names}")
           CSV.foreach(input_data, :headers => true, :return_headers => false, encoding: 'utf-8') do |row|

data/lib/gooddata/lcm/actions/collect_data_product.rb

@@ -3,7 +3,6 @@
 # Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
-
 require_relative 'base_action'
 
 module GoodData
@@ -17,6 +16,15 @@ module GoodData
 
         description 'DataProduct to manage'
         param :data_product, instance_of(Type::StringType), required: false
+
+        description 'Organization Name'
+        param :organization, instance_of(Type::StringType), required: false
+
+        description 'Domain'
+        param :domain, instance_of(Type::StringType), required: false
+
+        description 'Logger'
+        param :gdc_logger, instance_of(Type::GdLogger), required: true
       end
 
       RESULT_HEADER = [
@@ -28,6 +36,7 @@ module GoodData
           params = params.to_hash
           client = params.gdc_gd_client
           domain_name = params.organization || params.domain
+          fail "Either organisation or domain has to be specified in params" unless domain_name
           domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
 
           if params.key?(:data_product)
@@ -36,7 +45,6 @@ module GoodData
             params.gdc_logger.info "Using data product 'default' since none was specified in brick parameters"
             data_product_id = 'default'
           end
-
           data_product = domain.data_products(data_product_id)
           results = [
             {

data/lib/gooddata/lcm/actions/collect_dynamic_schedule_params.rb

@@ -17,6 +17,15 @@ module GoodData
 
         description 'Dynamic Params'
         param :dynamic_params, instance_of(Type::HashType), required: false
+
+        description 'Client Id Column'
+        param :client_id_column, instance_of(Type::StringType), required: false
+
+        description 'Name Column'
+        param :param_name_column, instance_of(Type::StringType), required: false
+
+        description 'Value Column'
+        param :param_value_column, instance_of(Type::StringType), required: false
       end
 
       class << self
@@ -31,7 +40,9 @@ module GoodData
 
           input_source = params.dynamic_params.input_source
           data_source = GoodData::Helpers::DataSource.new(input_source)
-          input_data = File.open(data_source.realize(params), 'r:UTF-8')
+          input_data = without_check(PARAMS, params) do
+            File.open(data_source.realize(params), 'r:UTF-8')
+          end
           GoodData.logger.debug("Input data: #{input_data.read}")
 
           schedule_params = {}

data/lib/gooddata/lcm/actions/collect_ldm_objects.rb

@@ -12,7 +12,7 @@ module GoodData
       DESCRIPTION = "Collect all objects in LDM: attributes (include CAs), facts, datasets"
 
       PARAMS = define_params(self) do
-        description 'Development Client Used for Connecting to GD'
+        description 'Client used to connecting to development domain'
         param :development_client, instance_of(Type::GdClientType), required: true
 
         description 'Synchronization Info'
@@ -28,7 +28,11 @@ module GoodData
           synchronize = params.synchronize.pmap do |info|
             from = info.from
             from_project = development_client.projects(from) || fail("Invalid 'from' project specified - '#{from}'")
-            objects = (from_project.attributes.to_a + from_project.labels.to_a + from_project.datasets.to_a + from_project.facts.to_a).map(&:uri)
+            datasets = from_project.datasets.to_a
+            # TMA-836 - reading objects from datasets includes deprecated ones
+            attributes = datasets.map(&:attribute_uris).flatten
+            facts = datasets.map(&:fact_uris).flatten
+            objects = (from_project.labels.to_a + datasets).map(&:uri) + attributes + facts
 
             info[:transfer_uris] ||= []
             info[:transfer_uris] += objects

data/lib/gooddata/lcm/actions/collect_meta.rb

@@ -19,7 +19,7 @@ module GoodData
         description 'Production Tag Names'
         param :production_tag, instance_of(Type::StringType), required: false, deprecated: true, replacement: :production_tags
 
-        description 'Development Client Used for Connecting to GD'
+        description 'Client used to connecting to development domain'
         param :development_client, instance_of(Type::GdClientType), required: true
 
         description 'Synchronization Info'

data/lib/gooddata/lcm/actions/collect_segment_clients.rb

@@ -16,7 +16,10 @@ module GoodData
         param :gdc_gd_client, instance_of(Type::GdClientType), required: true
 
         description 'Organization Name'
-        param :organization, instance_of(Type::StringType), required: true
+        param :organization, instance_of(Type::StringType), required: false
+
+        description 'Domain'
+        param :domain, instance_of(Type::StringType), required: false
 
         description 'ADS Client'
         param :ads_client, instance_of(Type::AdsClientType), required: true
@@ -26,6 +29,9 @@ module GoodData
 
         description 'Table Name'
         param :release_table_name, instance_of(Type::StringType), required: false
+
+        description 'DataProduct'
+        param :data_product, instance_of(Type::GDDataProductType), required: false
       end
 
       RESULT_HEADER = [
@@ -42,6 +48,7 @@ module GoodData
           client = params.gdc_gd_client
 
           domain_name = params.organization || params.domain
+          fail "Either organisation or domain has to be specified in params" unless domain_name
           domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
           data_product = params.data_product
           domain_segments = domain.segments(:all, data_product)