gooddata 0.6.50 → 0.6.51

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba2ae6d7826f6eb42b8f24eb7774313adebfcda7
-  data.tar.gz: e7589c5893af0dcc78fcb16f8b9bd1a8562b2f00
+  metadata.gz: d1715a4ba9d7203654418b0a275dd7eaf7e5e1dc
+  data.tar.gz: 42547b8e7ccbef65b3a0c6b0cb276886c55adcd8
 SHA512:
-  metadata.gz: 7910edb7b3f5e2dc18f669034e983e5dee218dc9cf193017cfaf3f23b0a4fe9ddf3b3e5a4efdd1913aa95294e06edf30e1ee5feb38274deb29efc49471388484
-  data.tar.gz: eb863dfe3ead470750f8b0fab9b402989c07a51aeaadfeefa08219a7975f9795a60d58dd441789112ee51263cb3db24539ca626442612267f8cc543da9bb412f
+  metadata.gz: d8120afa7ca7037fbd372960fe2ad02e9d2dc92d2d9dd17ce614b3f8d2a9d4e12412fe6ee8c3c2bd9f1c67ffdbf7962c099f612ec10a625188e2dfe0b5f8f2c8
+  data.tar.gz: a8485d9b645c943c91386111a4f4b6d12c66162d141bb747e4865761d2ca15ebdad92900d8ed6f3596ebdd55048af6c1ad3cf651049ccf04fb0e7b9edc2acfad

data/.editorconfig

@@ -0,0 +1,12 @@
+root = true
+
+[*]
+indent_style = space
+indent_size = 2
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+
+[*.{sh,markdown}]
+indent_size = 4

data/.gitignore

@@ -12,6 +12,7 @@ tmtags
 
 ## VIM
 *.swp
+.tags*
 
 ## IDEA
 .idea/

data/CHANGELOG.md

@@ -1,5 +1,7 @@
 # GoodData Ruby SDK Changelog
 
+## 0.6.52
+
 ## 0.6.50
 - Add support for Email Notification Rules on Process
 - Add support for exclude_schedules option in Project#export_clone
@@ -10,6 +12,7 @@
 - Support for custom color palette
 - Support for trasfering attribute drill paths
 - Implemented basic version of LCM2 
+- Add more logging for user, user filter management
 
 ## 0.6.49
 - Implement Helpers::GD_MAX_RETRY to allow max retries override

data/gooddata.gemspec

@@ -34,12 +34,13 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'redcarpet', '~> 3.1' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'rspec', '~> 3.5'
   s.add_development_dependency 'rspec-expectations', '~> 3.5'
-  s.add_development_dependency 'rubocop', '~> 0.47'
+  s.add_development_dependency 'rubocop', '< 0.48' # TODO: remove it after dealing with new rules introduced in 0.48 version
   s.add_development_dependency 'simplecov', '~> 0.12'
   s.add_development_dependency 'webmock', '~> 1.21'
   s.add_development_dependency 'yard', '~> 0.8'
   s.add_development_dependency 'yard-rspec', '~> 0.1'
   s.add_development_dependency 'ZenTest', '~> 4.11'
+  s.add_development_dependency 'pry'
 
   s.add_dependency 'aws-sdk', '~> 2.7'
   s.add_dependency 'nokogiri', '~> 1.6.8'

data/lib/gooddata/bricks/middleware/aws_middleware.rb

@@ -17,6 +17,10 @@ module GoodData
           raise 'Unable to connect to AWS. Parameter "aws_client" seems to be empty' unless params['aws_client']
           raise 'Unable to connect to AWS. Parameter "access_key_id" is missing' if params['aws_client']['access_key_id'].blank?
           raise 'Unable to connect to AWS. Parameter "secret_access_key" is missing' if params['aws_client']['secret_access_key'].blank?
+          if params['aws_client'].key?('use_ssl')
+            params['aws_client']['use_ssl'] =
+              params['aws_client']['use_ssl'].to_b
+          end
           s3 = AWS::S3.new(params['aws_client'])
           params['aws_client']['s3_client'] = s3
         end

data/lib/gooddata/bricks/middleware/decode_params_middleware.rb

@@ -14,7 +14,7 @@ module GoodData
         params = params.to_hash
 
         # Decode and resolve reference parameters in gd_encoded_params
-        @app.call(GoodData::Helpers.decode_params(params, :resolve_reference_params => true))
+        @app.call(GoodData::Helpers.decode_params(params, resolve_reference_params: true, convert_pipe_delimited_params: true))
       end
     end
   end

data/lib/gooddata/bricks/middleware/dwh_middleware.rb

@@ -10,6 +10,7 @@ require 'gooddata_datawarehouse' if RUBY_PLATFORM == 'java'
 
 module GoodData
   module Bricks
+    # Connects to the warehouse (ADS) and enriches parameters with GoodData::Datawarehouse
     class WarehouseMiddleware < Bricks::Middleware
       def call(params)
         if params.key?('ads_client') && (RUBY_PLATFORM == 'java')

data/lib/gooddata/bricks/middleware/gooddata_middleware.rb

@@ -8,6 +8,7 @@ require_relative 'base_middleware'
 
 module GoodData
   module Bricks
+    # Connects to platform and enriches parameters with GoodData::Client
     class GoodDataMiddleware < Bricks::Middleware
       DEFAULT_PROTOCOL = 'https'
       DEFAULT_HOSTNAME = 'secure.gooddata.com'

data/lib/gooddata/bricks/middleware/logger_middleware.rb

@@ -17,9 +17,10 @@ module GoodData
         if params['GDC_LOGGING_OFF']
           logger = NilLogger.new
         else
-          logger = params['GDC_LOGGER'] = params[:GDC_LOGGER_FILE].nil? ? Logger.new(STDOUT) : Logger.new(params[:GDC_LOGGER_FILE])
+          logger = params[:GDC_LOGGER_FILE].nil? ? Logger.new(STDOUT) : Logger.new(params[:GDC_LOGGER_FILE])
           logger.info('Pipeline starts')
         end
+        params['GDC_LOGGER'] = logger
         returning(@app.call(params)) do |_result|
           logger.info('Pipeline ending')
         end

data/lib/gooddata/core/nil_logger.rb

@@ -19,5 +19,14 @@ module GoodData
     alias_method :info, :debug
     alias_method :warn, :debug
     alias_method :error, :debug
+
+    def debug?
+      false
+    end
+
+    alias_method :info?, :debug?
+    alias_method :warn?, :debug?
+    alias_method :error?, :debug?
+    alias_method :fatal?, :debug?
   end
 end

data/lib/gooddata/goodzilla/goodzilla.rb

@@ -11,7 +11,7 @@ module GoodData
       # @param maql Input MAQL string
       # @return [Array<Array>] Pairs [attribute, attribute_element]
       def extract_element_uri_pairs(maql)
-        arr = maql.scan(%r{\[([^\[\]]*)\/elements\?id=(\d+)\]}).flatten
+        arr = maql.scan(%r{(\/gdc\/(?:projects|md)\/[a-zA-Z\d]+\/obj\/\d+)\/elements\?id=(\d+)}).flatten
         evens = arr.select.each_with_index { |_, i| i.even? }
         odds = arr.select.each_with_index { |_, i| i.odd? }.map(&:to_i)
         evens.zip(odds)

data/lib/gooddata/helpers/data_helper.rb

@@ -102,6 +102,7 @@ module GoodData
       end
 
       def realize_s3(params)
+        params = GoodData::Helpers.stringify_keys(params)
         s3_client = params['aws_client'] && params['aws_client']['s3_client']
         raise 'AWS client not present. Perhaps S3Middleware is missing in the brick definition?' if !s3_client || !s3_client.respond_to?(:buckets)
         bucket_name = @options[:bucket]

data/lib/gooddata/helpers/global_helpers_params.rb

@@ -57,26 +57,6 @@ module GoodData
       # @option options [Boolean] :resolve_reference_params Resolve reference parameters in gd_encoded_params or not
       # @return [Hash] Decoded parameters
       def decode_params(params, options = {})
-        convert_secure_params = lambda do |args|
-          args = args.select { |k, _| k.include? "|" }
-          lines = args.keys.map do |key|
-            hash = {}
-            last_a = nil
-            last_e = nil
-            key.split("|").reduce(hash) do |a, e|
-              last_a = a
-              last_e = e
-              a[e] = {}
-            end
-            last_a[last_e] = args[key]
-            hash
-          end
-
-          lines.reduce({}) do |a, e|
-            a.deep_merge(e)
-          end
-        end
-
         key = ENCODED_PARAMS_KEY.to_s
         hidden_key = ENCODED_HIDDEN_PARAMS_KEY.to_s
         data_params = params[key] || '{}'
@@ -103,6 +83,8 @@ module GoodData
               v.map do |v2|
                 resolve_reference.call(v2)
               end
+            elsif !v.is_a?(String)
+              v
             else
               v.gsub(regexps) do |match|
                 if match =~ /\\\\/
@@ -130,21 +112,47 @@ module GoodData
         begin
           parsed_data_params = data_params.is_a?(Hash) ? data_params : JSON.parse(data_params)
           parsed_hidden_data_params = hidden_data_params.is_a?(Hash) ? hidden_data_params : JSON.parse(hidden_data_params)
-        rescue JSON::ParserError => e
-          raise e.class, "Error reading json from '#{key}' or '#{hidden_key}', reason: #{e.message}"
+        rescue JSON::ParserError => exception
+          raise exception.class, "Error reading json from '#{key}' or '#{hidden_key}', reason: #{exception.message}"
         end
 
         # Add the nil on ENCODED_HIDDEN_PARAMS_KEY
         # if the data was retrieved from API You will not have the actual values so encode -> decode is not losless. The nil on the key prevents the server from deleting the key
         parsed_hidden_data_params[ENCODED_HIDDEN_PARAMS_KEY] = nil unless parsed_hidden_data_params.empty?
-        secure_params = convert_secure_params.call(params)
-        params.delete_if do |k, _|
-          k.include?('|')
-        end
 
         params.delete(key)
         params.delete(hidden_key)
-        params.deep_merge(parsed_data_params).deep_merge(parsed_hidden_data_params).deep_merge(secure_params)
+        params = params.deep_merge(parsed_data_params).deep_merge(parsed_hidden_data_params)
+
+        if options[:convert_pipe_delimited_params]
+          convert_pipe_delimited_params = lambda do |args|
+            args = args.select { |k, _| k.include? "|" }
+            lines = args.keys.map do |k|
+              hash = {}
+              last_a = nil
+              last_e = nil
+              k.split("|").reduce(hash) do |a, e|
+                last_a = a
+                last_e = e
+                a[e] = {}
+              end
+              last_a[last_e] = args[k]
+              hash
+            end
+
+            lines.reduce({}) do |a, e|
+              a.deep_merge(e)
+            end
+          end
+
+          pipe_delimited_params = convert_pipe_delimited_params.call(params)
+          params.delete_if do |k, _|
+            k.include?('|')
+          end
+          params = params.deep_merge(pipe_delimited_params)
+        end
+
+        params
       end
 
       # A helper which allows you to diff two lists of objects. The objects
@@ -233,6 +241,25 @@ module GoodData
         end
         lookup
       end
+
+      def stringify_values(value)
+        case value
+        when nil
+          value
+        when Hash
+          Hash[
+            value.map do |k, v|
+              [k, stringify_values(v)]
+            end
+          ]
+        when Array
+          value.map do |v|
+            stringify_values(v)
+          end
+        else
+          value.to_s
+        end
+      end
     end
   end
 end

data/lib/gooddata/lcm/actions/apply_custom_maql.rb

@@ -0,0 +1,70 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require_relative 'base_action'
+
+module GoodData
+  module LCM2
+    # Applies custom MAQL DDL to all client projects so customized
+    # labels and fiscal calendars are not deleted.
+    # To ease up further automation, the MAQL DDL may be
+    # stored in separate field in lcm_release
+    # table as we will need custom Release brick action which will populate it.
+    class ApplyCustomMaql < BaseAction
+      DESCRIPTION = 'Apply Custom MAQL DDL'
+
+      PARAMS = define_params(self) do
+        description 'Should be custom MAQL DDL Applied'
+        param :apply_maql_ddl, instance_of(Type::BooleanType), required: false, default: false
+      end
+
+      RESULT_HEADER = [
+        :segment,
+        :maql,
+        :status
+      ]
+
+      class << self
+        def call(params)
+          return [] unless params.apply_maql_ddl.to_b
+
+          client = params.gdc_gd_client
+
+          domain_name = params.organization || params.domain
+          domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
+
+          segment_ids = params.segments.map(&:segment_id)
+          domain_segments = domain.segments.select do |ds|
+            segment_ids.include?(ds.segment_id)
+          end
+
+          res = []
+          domain_segments.peach do |ds|
+            maql = 'CREATE DATASET {dataset.quotes} VISUAL (TITLE "Stock Quotes Data");'
+
+            unless maql.empty?
+              ds.clients.peach do |dc|
+                project = dc.project
+
+                r = project.execute_maql(maql)
+
+                item = {
+                  segment: ds.segment_id,
+                  maql: maql,
+                  status: r
+                }
+
+                res.push(item)
+              end
+            end
+          end
+
+          res
+        end
+      end
+    end
+  end
+end

data/lib/gooddata/lcm/actions/associate_clients.rb

@@ -31,14 +31,27 @@ module GoodData
 
           client = params.gdc_gd_client
 
-          delete_projects = GoodData::Helpers.to_boolean(params.delete_projects)
-          delete_extra = GoodData::Helpers.to_boolean(params.delete_extra)
-
           domain_name = params.organization || params.domain
           domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
 
           domain.update_clients_settings(params.clients)
-          domain.update_clients(params.clients, delete_extra: delete_extra, delete_projects: delete_projects)
+
+          delete_projects = GoodData::Helpers.to_boolean(params.delete_projects)
+          delete_extra = GoodData::Helpers.to_boolean(params.delete_extra)
+          options = { delete_projects: delete_projects }
+          options.merge!(delete_extra_option(params)) if delete_extra
+
+          domain.update_clients(params.clients, options)
+        end
+
+        private
+
+        def delete_extra_option(params)
+          if params.segments_filter && params.segments_filter.any?
+            { delete_extra_in_segments: params.segments_filter }
+          else
+            { delete_extra: delete_extra }
+          end
         end
       end
     end

data/lib/gooddata/lcm/actions/collect_clients.rb

@@ -65,11 +65,14 @@ module GoodData
                 id: row[client_id_column],
                 segment: segment_name,
                 project: row[project_id_column],
-                project_title: row[project_title_column],
                 settings: [
                   {
                     name: 'lcm.token',
                     value: row[project_token_column]
+                  },
+                  {
+                    name: 'lcm.title',
+                    value: row[project_title_column]
                   }
                 ]
               }.compact

data/lib/gooddata/lcm/actions/collect_segment_clients.rb

@@ -66,6 +66,7 @@ module GoodData
             master_name = master.title
 
             sync_info = {
+              segment_id: segment.segment_id,
               from: master_pid,
               to: segment.clients.map do |segment_client|
                 client_project = segment_client.project

data/lib/gooddata/lcm/actions/collect_segments.rb

@@ -30,10 +30,23 @@ module GoodData
           domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
           domain_segments = domain.segments
 
+          if params.segments_filter
+            domain_segments.select! do |segment|
+              params.segments_filter.include?(segment.segment_id)
+            end
+          end
+
           segments = domain_segments.map do |segment|
-            project = segment.master_project
+            project = nil
+
+            begin
+              project = segment.master_project
+            rescue RestClient::BadRequest => e
+              params.gdc_logger.error "Failed to retrieve master project for segment #{segment.id}. Error: #{e}"
+              raise
+            end
 
-            # TODO: Check if project exists!
+            raise "Master project for segment #{segment.id} doesn't exist." unless project
 
             {
               segment_id: segment.segment_id,

data/lib/gooddata/lcm/actions/create_segment_masters.rb

@@ -21,8 +21,8 @@ module GoodData
         description 'ADS Client'
         param :ads_client, instance_of(Type::AdsClientType), required: true
 
-        description 'Queries Used'
-        param :query, instance_of(Type::ReleaseQueryType), required: false
+        # description 'Queries Used'
+        # param :query, instance_of(Type::ReleaseQueryType), required: false
 
         description 'Segments to manage'
         param :segments, array_of(instance_of(Type::SegmentType)), required: true

data/lib/gooddata/lcm/actions/provision_clients.rb

@@ -39,7 +39,6 @@ module GoodData
 
           domain_name = params.organization || params.domain
           domain = client.domain(domain_name) || fail("Invalid domain name specified - #{domain_name}")
-          domain_segments = domain.segments
 
           synchronize_projects = []
           results = params.segments.map do |segment|
@@ -47,11 +46,10 @@ module GoodData
               Hash[m.each_pair.to_a].merge(type: :provision_result)
             end
 
-            segment_master = domain_segments.find(segment.segment_id).first.master_project.pid
-
             unless tmp.empty?
               synchronize_projects << {
-                from: segment_master,
+                segment_id: segment.segment_id,
+                from: segment.development_pid,
                 to: tmp.map do |entry|
                   {
                     pid: entry[:project_uri].split('/').last,