gooddata 0.6.18 → 0.6.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f683852cdcca1c3ac58923b66d2875199f4941ca
-  data.tar.gz: c439059752871aa8edaaae9578ebb5d8070d055a
+  metadata.gz: a4de3a73d002c9131adae8968162b567827d1f67
+  data.tar.gz: 3e62ac57287eeafe59581fb23d898eea5bdefc12
 SHA512:
-  metadata.gz: 7645abe267313b36bcc9f5d9ae076be9a7b608860db6a7bd27a91919dab47af0e31d3a48a921521d546f28fe822312ff69007826886447ea0dd165b170f7e5bb
-  data.tar.gz: 319d48cffc079ce239e78ff4b8ab4d2c3911a5fb381a13d47fb8d91f58e7947dab7d7bbed9fbfa44a97d87689f6b1f3340612246a59c8ffcec581109e69c1765
+  metadata.gz: 7af60ede0582d91dbdb136e95a530f7a43fe61a721ed08bd78a09705c0d0dac6db2e80d0adfdc70366c6504f869dd8ab7b52e1c6148334a3f8753a7d2745f05f
+  data.tar.gz: b5f8f8c12e55ff4a4ca484a8d5b076d317940e8ea9776427366af06a80a90bc81d0ddcf4d3e58103be5314defb1968428137af81df153fa5fe7dac9e2c1b35a5

data/.gitignore

@@ -19,7 +19,8 @@ tmtags
 ## PROJECT::GENERAL
 .bundle
 coverage
-rdoc
+/rdoc
+/doc
 pkg
 
 ## PROJECT::SPECIFIC

data/.travis.yml

@@ -1,33 +1,22 @@
 language: ruby
-
 cache: bundler
-
 sudo: false
-
 branches:
   except:
   - gh-pages
   - next_doc_release
 env:
   global:
-  - secure: d/fE2Iuyrf5mfvQPe2nl++a06hpy82mEM5jbmXmS1ttQgMpf955GWTmZ+16VBZa9MU2pJLBXoBXy53tp8P9ADysE4R7YCeI68yE0CZ/OuU+FVADZ9/F6i4nlUESjNNQnlC0mTIjDMO5WI9HbVQiS07HqDHzr6bcS51ZvBzItcn4=
   - TRAVIS_BUILD=true
-
+  - secure: XIcBVui9577vRAtz23JoM9ZDSol4sY3XC0GP3kH4/fRnmf/zoYS3OmkfFUZ484RS2YmLPuSQvSfwaobRkYCnuc6iFNCEZD1Bxr7f1BT1rc5Sb9PZTdNBIHORnWimFcanGsTERWJiocCShL8miuTF3l1P0JAsjXoeVWI82oMz7xE=
 rvm:
-  - 1.9.3
-  - jruby-19mode
-  - 2.1
-  - 2.2
-
+- 1.9.3
+- jruby-19mode
+- 2.1
+- 2.2
 before_install:
-  - gem update --system
-  - gem update bundler
-
+- gem update --system
+- gem update bundler
 before_script:
-  - cp spec/data/.gooddata ~/
-
+- cp spec/data/.gooddata ~/
 script: bundle exec rake ci
-
-notifications:
-  slack:
-    secure: VIiymls7MDsR+3TeICWA41+uK4WAfe+CaNZhMvC/9Z/uWrPD9EsH7sX/GT2GoPJdjj7wCzTjWMy5fQOwY243cXu17umkTRHKYYhZYPjhGi4X0Diqjdx7A/eKieIUMS2xGb12a40HTPIB5Owc2+8C+sOPRk5AXRR/YrOB5xG61y8=

data/Guardfile

@@ -0,0 +1,5 @@
+clearing :on
+
+guard :rspec, cmd: 'bundle exec rspec' do
+  watch(%r{^spec/.+_spec\.rb$})
+end

data/README.md

@@ -5,12 +5,10 @@ It has a CLI client and it is a library which you can integrate into your applic
 
 The best documentation for the GoodData API can be found using these resources:
 
- * http://sdk.gooddata.com/gooddata-ruby/
- * http://docs.gooddata.apiary.io/
+ * http://sdk.gooddata.com/gooddata-ruby-examples/
  * http://developer.gooddata.com/api
  * https://secure.gooddata.com/gdc
  * http://rubydoc.info/gems/gooddata/frames
- * http://developer.gooddata.com/ruby-cookbook
 
 ## Status
 

data/bin/gooddata

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-require "gooddata/cli/cli"
+require_relative '../lib/gooddata/cli/cli'
 
 res = GoodData::CLI.main(ARGV)
 

data/gooddata.gemspec

@@ -29,13 +29,15 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake-notes', '~> 0.2', '>= 0.2.0'
   s.add_development_dependency 'redcarpet', '~> 3.1', '>= 3.1.1' if RUBY_PLATFORM != 'java'
   s.add_development_dependency 'rspec', '~> 2.14', '>= 2.14.1'
-  s.add_development_dependency 'rubocop', '~> 0.27', '>= 0.27.0'
+  s.add_development_dependency 'rubocop', '~> 0.32.1', '>= 0.32.1'
   s.add_development_dependency 'simplecov', '~> 0.9', '>= 0.9.1'
   s.add_development_dependency 'yard', '~> 0.8.7.3'
   s.add_development_dependency 'yard-rspec', '~> 0.1'
   s.add_development_dependency 'ZenTest', '~> 4.10', '>= 4.11.0'
   s.add_development_dependency 'coveralls', '~> 0.7', '>= 0.7.0'
-
+  s.add_development_dependency 'guard', '~> 2'
+  s.add_development_dependency 'guard-rspec', '~> 4'
+  s.add_development_dependency 'webmock', '~> 1.21.0'
   s.add_development_dependency 'debase' if !ENV['TRAVIS_BUILD'] && RUBY_VERSION >= '2.0.0'
   s.add_development_dependency 'ruby-debug-ide' if !ENV['TRAVIS_BUILD'] && RUBY_VERSION >= '2.0.0'
 
@@ -52,9 +54,9 @@ Gem::Specification.new do |s|
   s.add_dependency 'pmap', '~> 1.0', '>= 1.0.1'
   s.add_dependency 'pry', '~> 0.9.12.6' # '~> 0.10', '>= 0.10.1'
   s.add_dependency 'restforce', '~> 1.5', '>= 1.5.0'
-  s.add_dependency 'rest-client', '~> 1.7', '>= 1.7.2'
+  s.add_dependency 'rest-client', '~> 1.7.2', '>= 1.7.2'
   s.add_dependency 'rubyzip', '~> 1.1', '>= 1.1.0'
-  s.add_dependency 'terminal-table', '~> 1.4', '>= 1.4.5'
+  s.add_dependency 'terminal-table', '~> 1.5', '>= 1.5.1'
   s.add_dependency 'salesforce_bulk_query', '~> 0.0'
   s.add_dependency 'aws-sdk', '~> 1.45'
 end

data/lib/gooddata.rb

@@ -1,7 +1,7 @@
 # encoding: UTF-8
 
 require 'pmap'
-$pmap_default_thread_count = 100 # rubocop:disable GlobalVars
+$pmap_default_thread_count = 20 # rubocop:disable GlobalVars
 
 # GoodData Module
 module GoodData

data/lib/gooddata/bricks/middleware/aws_middleware.rb

@@ -0,0 +1,24 @@
+# encoding: UTF-8
+
+require 'aws-sdk'
+require_relative 'base_middleware'
+
+module GoodData
+  module Bricks
+    class AWSMiddleware < Bricks::Middleware
+      def call(params)
+        if params.key?('aws_client')
+          puts 'Setting up AWS-S3 connection'
+          fail "Unable to connect to AWS. Parameter \"aws_client\" seems to be empty" unless params['aws_client']
+          fail "Unable to connect to AWS. Parameter \"access_key_id\" is missing" if params['aws_client']['access_key_id'].blank?
+          fail "Unable to connect to AWS. Parameter \"secret_access_key\" is missing" if params['aws_client']['secret_access_key'].blank?
+          s3 = AWS::S3.new(params['aws_client'])
+          params['aws_client']['s3_client'] = s3
+          @app.call(params)
+        else
+          @app.call(params)
+        end
+      end
+    end
+  end
+end

data/lib/gooddata/cli/commands/console_cmd.rb

@@ -25,7 +25,7 @@ GoodData::CLI.module_eval do
         fail ArgumentError, 'Wrong project specified' if project.nil?
 
         puts "Use 'exit' to quit the live session. Use 'q' to jump out of displaying a large output."
-        binding.pry(:quiet => true,
+        binding.pry(:quiet => true, # rubocop:disable Lint/Debugger
                     :prompt => [proc do |_target_self, _nest_level, _pry|
                       'sdk_live_session: '
                     end])

data/lib/gooddata/cli/commands/project_cmd.rb

@@ -21,22 +21,42 @@ GoodData::CLI.module_eval do
     # TODO: Move away the ask methods. Provide params
     c.desc 'Create a gooddata project'
     c.command :create do |create|
+      create.default_value nil
+      create.arg_name :driver
+      create.flag [:driver]
+
+      create.default_value nil
+      create.arg_name :template
+      create.flag [:template]
+
+      create.default_value nil
+      create.arg_name :summary
+      create.flag [:summary]
+
       create.action do |global_options, options, args|
         opts = options.merge(global_options)
 
         title = args[0] || ask('Project name')
-        summary = args[1] || ask('Project summary') { |q| q.default = '' }
-        template = args[2] || ask('Project template')
-        token = opts[:token] || ask('token')
+        summary = opts[:summary] || args[1] || ask('Project summary') { |q| q.default = '' }
+        template = opts[:template] || args[2] || ask('Project template')
+        token = opts['token'] || ask('Token')
+        driver = opts[:driver] || ask('Driver') { |q| q.default = 'Pg' }
 
         opts = options.merge(global_options)
         client = GoodData.connect(opts)
-        project = GoodData::Command::Project.create(
-          :title => title,
-          :summary => summary,
-          :template => template,
-          :token => token,
-          client: client)
+        begin
+          project = GoodData::Command::Project.create(
+            :title => title,
+            :summary => summary,
+            :template => template,
+            :token => token,
+            :driver => driver,
+            client: client)
+        rescue => e
+          puts "Error creating project, reason: #{e.inspect}"
+          raise e
+        end
+
         puts "Project '#{project.title}' with id #{project.pid} created successfully!"
       end
     end

data/lib/gooddata/cli/hooks.rb

@@ -17,11 +17,17 @@ GoodData::CLI.module_eval do
 
     username = creds[:username] if username.nil?
     password = creds[:password] if password.nil?
-    token = creds[:auth_token] if token.nil?
+    token = creds[:auth_token] || creds[:token] if token.nil?
 
     global[:token] = token if global[:token].nil?
-    global[:login] = username if global[:login].nil?
-    global[:password] = password if global[:password].nil?
+    if global[:login].nil?
+      global[:login] = username
+      global['login'] = username
+    end
+    if global[:password].nil?
+      global[:password] = password
+      global['password'] = password
+    end
     # Pre logic here
     # Return true to proceed; false to abort and not call the
     # chosen command

data/lib/gooddata/commands/datawarehouse.rb

@@ -7,14 +7,8 @@ module GoodData
       class << self
         # Create new project based on options supplied
         def create(options = { client: GoodData.connection })
-          title = options[:title]
           description = options[:summary] || options[:description]
-          token = options[:token] || options[:auth_token]
-          client = options[:client]
-          GoodData::DataWarehouse.create(:title => title,
-                                         :description => description,
-                                         :auth_token => token,
-                                         :client => client)
+          GoodData::DataWarehouse.create(options.merge(:description => description))
         end
       end
     end

data/lib/gooddata/commands/project.rb

@@ -13,7 +13,8 @@ module GoodData
           template = options[:template]
           token = options[:token]
           client = options[:client]
-          GoodData::Project.create(:title => title, :summary => summary, :template => template, :auth_token => token, :client => client)
+          driver = options[:driver] || 'Pg'
+          GoodData::Project.create(:title => title, :summary => summary, :template => template, :auth_token => token, :client => client, :driver => driver)
         end
 
         # Show existing project
@@ -91,7 +92,7 @@ module GoodData
           client = opts[:client]
           fail ArgumentError, 'No :client specified' if client.nil?
 
-          GoodData::Model::ProjectCreator.migrate(:spec => opts[:spec], :token => opts[:token], :client => client)
+          GoodData::Model::ProjectCreator.migrate(opts.merge(:client => client))
         end
 
         # Performs project validation
@@ -124,7 +125,7 @@ module GoodData
                 fail ArgumentError, 'Wrong project specified' if project.nil?
 
                 puts "Use 'exit' to quit the live session. Use 'q' to jump out of displaying a large output."
-                binding.pry(:quiet => true,
+                binding.pry(:quiet => true, # rubocop:disable Lint/Debugger
                             :prompt => [proc do |_target_self, _nest_level, _pry|
                               'project_live_session: '
                             end])

data/lib/gooddata/core/logging.rb

@@ -13,8 +13,20 @@ module GoodData
     #
     #     GoodData.logging_on
     #
-    def logging_on
+    def logging_on(level = nil)
       @logger = default_logger if logger.is_a? NilLogger
+      @logger.level = level if level
+      @logger
+    end
+
+    # Turn logging on with HTTP included
+    #
+    # ### Example
+    #
+    #     GoodData.logging_http_on
+    #
+    def logging_http_on
+      logging_on(Logger::DEBUG)
     end
 
     # Turn logging on
@@ -49,7 +61,7 @@ module GoodData
       @stats = true
     end
 
-    def stats_on? # rubocop:disable Style/TrivialAccessors
+    def stats_on?
       @stats
     end
 

data/lib/gooddata/exceptions/execution_limit_exceeded.rb

@@ -0,0 +1,9 @@
+# encoding: UTF-8
+
+module GoodData
+  class ExecutionLimitExceeded < RuntimeError
+    def initialize(msg = 'The time limit #{time_limit} secs for polling on #{link} is over')
+      super(msg)
+    end
+  end
+end

data/lib/gooddata/exceptions/uncomputable_report.rb

@@ -0,0 +1,8 @@
+# encoding: UTF-8
+require 'restclient/exceptions'
+
+module GoodData
+  # Project Not Found
+  class UncomputableReport < RuntimeError
+  end
+end

data/lib/gooddata/exceptions/validation_error.rb

@@ -3,7 +3,7 @@
 module GoodData
   # Project Not Found
   class ValidationError < RuntimeError
-    DEFAULT_MSG = 'Validation has failed'
+    DEFAULT_MSG = 'Validation has failed. Run validate method on blueprint to learn more about the errors.'
 
     def initialize(msg = DEFAULT_MSG)
       super(msg)

data/lib/gooddata/goodzilla/goodzilla.rb

@@ -40,7 +40,11 @@ module GoodData
       pairs = expression.scan(PARSE_MAQL_OBJECT_REGEXP).pmap do |uri|
         uri = uri.first
         if uri =~ /elements/
-          [uri, Attribute.find_element_value(uri, opts)]
+          begin
+            [uri, Attribute.find_element_value(uri, opts)]
+          rescue AttributeElementNotFound
+            [uri, '(empty value)']
+          end
         else
           [uri, GoodData::MdObject[uri, opts].title]
         end

data/lib/gooddata/helpers/data_helper.rb

@@ -17,6 +17,29 @@ module GoodData
         @realized = false
       end
 
+      def realize(params = {})
+        @realized = true
+        source = @source && @source.to_s
+        case source
+        when 'ads'
+          realize_query(params)
+        when 'staging'
+          realize_staging(params)
+        when 'web'
+          realize_link
+        when 's3'
+          realize_s3(params)
+        else
+          fail "DataSource does not support type \"#{source}\""
+        end
+      end
+
+      def realized?
+        @realized == true
+      end
+
+      private
+
       def realize_query(params)
         query = @options[:query]
         dwh = params['ads_client']
@@ -65,16 +88,24 @@ module GoodData
         filename
       end
 
-      def realize(params = {})
-        @realized = true
-        case @source.to_s
-        when 'ads'
-          realize_query(params)
-        when 'staging'
-          realize_staging(params)
-        when 'web'
-          realize_link
+      def realize_s3(params)
+        s3_client = params['aws_client'] && params['aws_client']['s3_client']
+        fail 'AWS client not present. Perhaps S3Middleware is missing in the brick definition?' if !s3_client || !s3_client.respond_to?(:buckets)
+        bucket_name = @options[:bucket]
+        key = @options[:key]
+        fail "Key \"bucket\" is missing in S3 datasource" if bucket_name.blank?
+        fail "Key \"key\" is missing in S3 datasource" if key.blank?
+        puts "Realizing download from S3. Bucket #{bucket_name}, object with key #{key}."
+        filename = Digest::SHA256.new.hexdigest(@options.to_json)
+        bucket = s3_client.buckets[bucket_name]
+        obj = bucket.objects[key]
+        File.open(filename, 'wb') do |file|
+          obj.read do |chunk|
+            file.write(chunk)
+          end
         end
+        puts 'Done downloading file.'
+        filename
       end
     end
   end

data/lib/gooddata/mixins/md_finders.rb

@@ -3,6 +3,36 @@
 module GoodData
   module Mixin
     module MdFinders
+      # Finds a specific type of the object by identifier. Returns first match. Returns full object.
+      #
+      # @param title [String] identifier that has to match exactly
+      # @param title [Regexp] regular expression that has to match
+      # @return [Array<GoodData::MdObject>] Array of MdObject
+      def find_first_by_identifier(identifier, options = { :client => GoodData.connection, :project => GoodData.project })
+        all = self[:all, options.merge(full: false)]
+        item = if identifier.is_a?(Regexp)
+                 all.find { |r| r['identifier'] =~ identifier }
+               else
+                 all.find { |r| r['identifier'] == identifier }
+               end
+        self[item['link'], options] unless item.nil?
+      end
+
+      # Finds a specific type of the object by identifier. Returns all matches. Returns full object.
+      #
+      # @param title [String] identifier that has to match exactly
+      # @param title [Regexp] regular expression that has to match
+      # @return [Array<GoodData::MdObject>] Array of MdObject
+      def find_by_identifier(identifier, options = { :client => GoodData.connection, :project => GoodData.project })
+        all = self[:all, options.merge(full: false)]
+        items = if identifier.is_a?(Regexp)
+                  all.select { |r| r['title'] =~ identifier }
+                else
+                  all.select { |r| r['title'] == identifier }
+                end
+        items.pmap { |item| self[item['link'], options] unless item.nil? }
+      end
+
       def find_by_tag(tag, opts = { :client => GoodData.connection, :project => GoodData.project })
         c = client || opts[:client]
 
@@ -15,6 +45,11 @@ module GoodData
         self[:all, client: c, project: project].select { |r| r.tags.split(',').include?(tag) }
       end
 
+      # Finds a specific type of the object by title. Returns first match. Returns full object.
+      #
+      # @param title [String] title that has to match exactly
+      # @param title [Regexp] regular expression that has to match
+      # @return [Array<GoodData::MdObject>] Array of MdObject
       def find_first_by_title(title, options = { :client => GoodData.connection, :project => GoodData.project })
         all = self[:all, options.merge(full: false)]
         item = if title.is_a?(Regexp)