goodcheck 3.0.2 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0c8afdfe31520eabbb82eeaa32910c656e6447d4f3e13dcfd0ff6f09eb9854c
-  data.tar.gz: 361efc3d3596749d09d1c6abca0bea722e1523f55b6d0a01c9750b7a7b2608e3
+  metadata.gz: b382336bf78153607e3951bdafe7d819ebac80b080df118fcf3c2b15a25040db
+  data.tar.gz: b17ec056b4d49b70d777a90142b40dd4d17dcb50d9e5861f88cdb37c0eaeff0e
 SHA512:
-  metadata.gz: 51d137db095bc967e0bd2add64b94fccb2d3684bff282dd4f32efd749d39f52669a3e8b7acd58fbf428c83ef274130607a6a457a94415ce8bb58e4213d79d121
-  data.tar.gz: de13aa4b155e7fe583f48a49da717c80455132d8dde0691fd9ca2cf075d84c2edb6b228cb9aa8ce3eb7afc2b726e5d93e6a448fb7f7fec36255f84e02a07c832
+  metadata.gz: 5eaa08336a26a7adb83a0100dd48937395b11a3ee0da758a869940d0e741fa515c5eabc9bef9bf6f6eb1d39d69141014e5c64b0868594fb2bf983ccec7f203c9
+  data.tar.gz: 52a89b2342b9d6785d7ecfb847174d36cccba6bbd33c073520dcc4f65569a2579fb0879e59048aa41de8cd5cd00bc1b07c95784fe53f4b2ed2e1cb05417b4ff8

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## HEAD
 
+## 3.0.3 (2021-06-25)
+
+* Fix HTTP GET retrying [#203](https://github.com/sider/goodcheck/pull/203)
+
 ## 3.0.2 (2021-06-23)
 
 * Retry importing on Net::OpenTimeout [#202](https://github.com/sider/goodcheck/pull/202)

data/lib/goodcheck/import_loader.rb

@@ -25,10 +25,6 @@ module Goodcheck
         super("HTTP GET #{res.uri} => #{res.code} #{res.message}")
         @response = res
       end
-
-      def error_response?
-        response.is_a?(Net::HTTPClientError) || response.is_a?(Net::HTTPServerError)
-      end
     end
 
     attr_reader :cache_path
@@ -145,13 +141,15 @@ module Goodcheck
         when Net::HTTPRedirection
           location = res['Location']
           http_get location, limit - 1
-        else
+        when Net::HTTPClientError, Net::HTTPServerError
           raise HTTPGetError.new(res)
+        else
+          raise Error, "HTTP GET failed due to #{res.inspect}"
         end
       rescue Net::OpenTimeout, HTTPGetError => exn
-        if retry_count < max_retry_count && exn.error_response?
+        if retry_count < max_retry_count
           retry_count += 1
-          Goodcheck.logger.info "#{retry_count} retry HTTP GET #{exn.response.uri} due to '#{exn.response.code} #{exn.response.message}'..."
+          Goodcheck.logger.info "Retry ##{retry_count} - HTTP GET #{uri} due to #{exn.inspect}..."
           sleep 1
           retry
         else

data/lib/goodcheck/version.rb

@@ -1,3 +1,3 @@
 module Goodcheck
-  VERSION = "3.0.2".freeze
+  VERSION = "3.0.3".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: goodcheck
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
 platform: ruby
 authors:
 - Sider Corporation
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-06-23 00:00:00.000000000 Z
+date: 2021-06-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -209,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.20
+rubygems_version: 3.2.21
 signing_key:
 specification_version: 4
 summary: Regexp based customizable linter.