good_job 3.15.6 → 3.15.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a7428e5e751cae734ce33eecb6a9fc9a4e05bfd3c1774e6d0b6755785b1e33e7
-  data.tar.gz: d753e31cb938aa8fcd5bd1e6a0737022b883b76d734796d4212989f6de987bfe
+  metadata.gz: 304066b93c2dc8d6960e51727ee9f9453e79b00793721ffe97d1df02b79eda44
+  data.tar.gz: '02598cf6b47e27a1d568bb0680d7d4af205fac6bc817953bd26b938a79db25eb'
 SHA512:
-  metadata.gz: a0bb1f2322318db6be15c5a47ca88b063eb6f1f4a4981a9f78799c531d0f47beb888628e8216f22a7ca51873684cff93062a3d9e7e7da52cac186cca10da841a
-  data.tar.gz: 9e9b91b4e904115033d0daf2aaf7583ba757f318a9f9eb36a005d2ae692e2796abfecea45b2ed4754ecdff218dd86854b6b9ddd8ebb21762a8786621b0d554ae
+  metadata.gz: d3107c75571854f143429417d9fe23227da47fdafbb025ea037a6b31094266cfec62da1bbe78525aa29472704568ad5f71f23bf031794fe2cbe6d214f0dea16a
+  data.tar.gz: '09743b81235c7795f217165f5a64a41132dcd8b0ccf969835dadd143ebb2992b88c3f8650677f089d152e53591e28a09634cb8f4a9e668fc78fc63ee0563cf4a'

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## [v3.15.7](https://github.com/bensheldon/good_job/tree/v3.15.7) (2023-04-30)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.15.6...v3.15.7)
+
+**Fixed bugs:**
+
+- Fix Lockable's `SELECT 1 AS one` queries missing `LIMIT 1` [\#946](https://github.com/bensheldon/good_job/pull/946) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- Issue with performing jobs that use ActionMailer::Parameterized [\#944](https://github.com/bensheldon/good_job/issues/944)
+- Deprecation warning on the deprecation warning [\#943](https://github.com/bensheldon/good_job/issues/943)
+
+**Merged pull requests:**
+
+- Replace class usage of ActiveSupport::Deprecator with gem-specific instance [\#945](https://github.com/bensheldon/good_job/pull/945) ([bensheldon](https://github.com/bensheldon))
+
 ## [v3.15.6](https://github.com/bensheldon/good_job/tree/v3.15.6) (2023-04-24)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.15.5...v3.15.6)

data/app/models/good_job/base_record.rb

@@ -8,7 +8,7 @@ module GoodJob
     self.abstract_class = true
 
     def self.migration_pending_warning!
-      ActiveSupport::Deprecation.warn(<<~DEPRECATION)
+      GoodJob.deprecator.warn(<<~DEPRECATION)
         GoodJob has pending database migrations. To create the migration files, run:
             rails generate good_job:update
         To apply the migration files, run:

data/app/models/good_job/execution.rb

@@ -212,7 +212,7 @@ module GoodJob
     # Construct arguments for GoodJob::Execution from an ActiveJob instance.
     def self.enqueue_args(active_job, overrides = {})
       if active_job.priority && GoodJob.configuration.smaller_number_is_higher_priority.nil?
-        ActiveSupport::Deprecation.warn(<<~DEPRECATION)
+        GoodJob.deprecator.warn(<<~DEPRECATION)
           The next major version of GoodJob (v4.0) will change job `priority` to give smaller numbers higher priority (default: `0`), in accordance with Active Job's definition of priority.
             To opt-in to this behavior now, set `config.good_job.smaller_number_is_higher_priority = true` in your GoodJob initializer or application.rb.
             To not opt-in yet, but silence this deprecation warning, set `config.good_job.smaller_number_is_higher_priority = false`.

data/app/models/good_job/lockable.rb

@@ -324,6 +324,7 @@ module GoodJob
           AND pg_locks.objsubid = 1
           AND pg_locks.classid = ('x' || substr(md5($1::text), 1, 16))::bit(32)::int
           AND pg_locks.objid = (('x' || substr(md5($2::text), 1, 16))::bit(64) << 32)::bit(32)::int
+        LIMIT 1
       SQL
       binds = [
         ActiveRecord::Relation::QueryAttribute.new('key', key, ActiveRecord::Type::String.new),
@@ -351,6 +352,7 @@ module GoodJob
           AND pg_locks.classid = ('x' || substr(md5($1::text), 1, 16))::bit(32)::int
           AND pg_locks.objid = (('x' || substr(md5($2::text), 1, 16))::bit(64) << 32)::bit(32)::int
           AND pg_locks.pid = pg_backend_pid()
+        LIMIT 1
       SQL
       binds = [
         ActiveRecord::Relation::QueryAttribute.new('key', key, ActiveRecord::Type::String.new),

data/lib/good_job/configuration.rb

@@ -250,12 +250,12 @@ module GoodJob
       if rails_config.key?(:cleanup_interval_jobs)
         value = rails_config[:cleanup_interval_jobs]
         if value.nil?
-          ActiveSupport::Deprecation.warn(
+          GoodJob.deprecator.warn(
             %(Setting `config.good_job.cleanup_interval_jobs` to `nil` will no longer disable count-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
           )
           value = false
         elsif value == 0 # rubocop:disable Style/NumericPredicate
-          ActiveSupport::Deprecation.warn(
+          GoodJob.deprecator.warn(
             %(Setting `config.good_job.cleanup_interval_jobs` to `0` will disable count-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
           )
           value = -1
@@ -263,7 +263,7 @@ module GoodJob
       elsif env.key?('GOOD_JOB_CLEANUP_INTERVAL_JOBS')
         value = env['GOOD_JOB_CLEANUP_INTERVAL_JOBS']
         if value.blank?
-          ActiveSupport::Deprecation.warn(
+          GoodJob.deprecator.warn(
             %(Setting `GOOD_JOB_CLEANUP_INTERVAL_JOBS` to `""` will no longer disable count-based cleanups in GoodJob v4. Set to `0` to disable, or `-1` to run every time.)
           )
           value = false
@@ -285,12 +285,12 @@ module GoodJob
         value = rails_config[:cleanup_interval_seconds]
 
         if value.nil?
-          ActiveSupport::Deprecation.warn(
+          GoodJob.deprecator.warn(
             %(Setting `config.good_job.cleanup_interval_seconds` to `nil` will no longer disable time-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
           )
           value = false
         elsif value == 0 # rubocop:disable Style/NumericPredicate
-          ActiveSupport::Deprecation.warn(
+          GoodJob.deprecator.warn(
             %(Setting `config.good_job.cleanup_interval_seconds` to `0` will disable time-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
           )
           value = -1
@@ -298,7 +298,7 @@ module GoodJob
       elsif env.key?('GOOD_JOB_CLEANUP_INTERVAL_SECONDS')
         value = env['GOOD_JOB_CLEANUP_INTERVAL_SECONDS']
         if value.blank?
-          ActiveSupport::Deprecation.warn(
+          GoodJob.deprecator.warn(
             %(Setting `GOOD_JOB_CLEANUP_INTERVAL_SECONDS` to `""` will no longer disable time-based cleanups in GoodJob v4. Set to `0` to disable, or `-1` to run every time.)
           )
           value = false

data/lib/good_job/version.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.15.6'
+  VERSION = '3.15.7'
+
+  # GoodJob version as Gem::Version object
+  GEM_VERSION = Gem::Version.new(VERSION)
 end

data/lib/good_job.rb

@@ -223,5 +223,14 @@ module GoodJob
     end
   end
 
+  # Deprecator for providing deprecation warnings.
+  # @return [ActiveSupport::Deprecation]
+  def self.deprecator
+    @_deprecator ||= begin
+      next_major_version = GEM_VERSION.segments[0] + 1
+      ActiveSupport::Deprecation.new("#{next_major_version}.0", "GoodJob")
+    end
+  end
+
   ActiveSupport.run_load_hooks(:good_job, self)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.15.6
+  version: 3.15.7
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-04-24 00:00:00.000000000 Z
+date: 2023-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob